From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 6A902428F8 for ; Sun, 9 Apr 2023 17:33:35 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 653FC40EDE; Sun, 9 Apr 2023 17:33:35 +0200 (CEST) Received: from NAM02-DM3-obe.outbound.protection.outlook.com (mail-dm3nam02on2081.outbound.protection.outlook.com [40.107.95.81]) by mails.dpdk.org (Postfix) with ESMTP id 104FD40EDE for ; Sun, 9 Apr 2023 17:33:34 +0200 (CEST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=CK308OYT0cOt+7xdSacESK3dgm3JcWd9fF2g0SuAKj7Bp0/wJ89OitY9r8CKn+j2hw9lczZIO8qU8mzVYj7Qr9yrPq4JKmKYF2e9hnZlXD83X6dY+WgjZLfpsEVM9Qp0I03jSXDv0vvzdwmTTFHXaPiQVJBtIRUIvfWrDdoV+aG/I6TzoE7+7w5UjvEfBKuFTRKvV9Pg+NU9RclGQbMNy+rZXnk7SZ9BdyHM+eT/z28P8cugGH5YM8d+WOFDzNP2khw95k9LKta7tjVNQsSVEWVnRB0fxF1lIA++cxbRQoWs1rIU8YyNgnqc6aJZvSLRCf4KlyFPcragSApkHOgMFw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=9BdC27KqRFw7ZmCcj39EpvQj2XpFCngR3e6bM0sfjQ4=; b=JmJxf/ZyhulHRc+x60p1FMI4YAUFBz5DBUXPi80xFiWJlQmpVHha1jdN9ft+yGy7rh4NgcTx2rXg/zkyzvitx1qFnMJXsr/jawd4VI3LtgklOyhkBIU1rLL6Z1zIVF1FbwZ/57pXO0WJM02KPb5F+n34pfkfNzvf27PDkykVKgs0ss0EKPlsg6j1TjURNEkoGIxt0lBaTa8lob+gqAOzHd38iIH5tw7aIB57Bpmzd+3D2fRHIzOdO8GXHo94w+DUWsmTWshLkAlpluAh6bgJZAMdj26P26/BxzF68whFj/HNXZO022DP5RenxFPTsJPuDnLx6q7OZt2lDckKRGGtnw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 216.228.117.160) smtp.rcpttodomain=intel.com smtp.mailfrom=nvidia.com; dmarc=pass (p=reject sp=reject pct=100) action=none header.from=nvidia.com; dkim=none (message not signed); arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=9BdC27KqRFw7ZmCcj39EpvQj2XpFCngR3e6bM0sfjQ4=; b=PRXDq6q3+ugO7dN6fVpkcVBcb5l2+WPFg3aKpO3coqvAXhqJP7rhzpl0TiO1Jzamc/MNtKw2mF6kZZExTal+qz6hoHdC44Lh2ShYxryUOillRuMmWZ17jJ8uXHD3DIg3F0O2cKH2vemptExF1sMsBBicJGuOA47FB32oS8nAMoJaylun1tBpSjVDKu7c4zX9Rqdc2aykeJk2kUv5AJH26XMJ9N7Q7RYl1hMMJPcAPn2oaVxpuixWUYAl1G4fgUBP2BIrSDnb3J79EB/sfSHzuB6Kh6x41GjSj0X3X9etsvLhZ9Wm/4kjRNwLIAV+AYEfmM26xLgqX6xs09i6kyIqew== Received: from MW4PR03CA0089.namprd03.prod.outlook.com (2603:10b6:303:b6::34) by MW4PR12MB7465.namprd12.prod.outlook.com (2603:10b6:303:212::18) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6277.38; Sun, 9 Apr 2023 15:33:31 +0000 Received: from CO1NAM11FT040.eop-nam11.prod.protection.outlook.com (2603:10b6:303:b6:cafe::56) by MW4PR03CA0089.outlook.office365.com (2603:10b6:303:b6::34) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6277.39 via Frontend Transport; Sun, 9 Apr 2023 15:33:31 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 216.228.117.160) smtp.mailfrom=nvidia.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=nvidia.com; Received-SPF: Pass (protection.outlook.com: domain of nvidia.com designates 216.228.117.160 as permitted sender) receiver=protection.outlook.com; client-ip=216.228.117.160; helo=mail.nvidia.com; pr=C Received: from mail.nvidia.com (216.228.117.160) by CO1NAM11FT040.mail.protection.outlook.com (10.13.174.140) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6298.25 via Frontend Transport; Sun, 9 Apr 2023 15:33:31 +0000 Received: from rnnvmail201.nvidia.com (10.129.68.8) by mail.nvidia.com (10.129.200.66) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.986.5; Sun, 9 Apr 2023 08:33:28 -0700 Received: from nvidia.com (10.126.230.37) by rnnvmail201.nvidia.com (10.129.68.8) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.986.37; Sun, 9 Apr 2023 08:33:27 -0700 From: Xueming Li To: Ciara Power CC: Akhil Goyal , dpdk stable Subject: patch 'app/crypto-perf: fix test file memory leak' has been queued to stable release 22.11.2 Date: Sun, 9 Apr 2023 23:24:40 +0800 Message-ID: <20230409152529.5308-93-xuemingl@nvidia.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20230409152529.5308-1-xuemingl@nvidia.com> References: <20230227062349.13764-1-xuemingl@nvidia.com> <20230409152529.5308-1-xuemingl@nvidia.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Type: text/plain X-Originating-IP: [10.126.230.37] X-ClientProxiedBy: rnnvmail203.nvidia.com (10.129.68.9) To rnnvmail201.nvidia.com (10.129.68.8) X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: CO1NAM11FT040:EE_|MW4PR12MB7465:EE_ X-MS-Office365-Filtering-Correlation-Id: b5f12494-487c-4a84-db16-08db390fc651 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: vmMQyBf+ROJAGvK8c/0HvJpjhbzBH1FlPv1XAPHSTOE3wTy/0ugw6zl8Nmg+Cg92alXpQ9qTnY4+Bai4Plh08OVzjNyL2D8+Ue9+KoYGyqxBjpWd9LDU2ZUYyPpP9xOe22IiqgROpCBdhtKPD1GmYrEZaIFKnyUs5tIKBcC2CUIUnURFTWrEy4LDK1IARcXs8kcV0SGwmrFpuwBne5DG8MmodYChG1s1QvjdGmMgE8VUzMilErbnYlDZPmOf2yT9aF5R4dzLuvF0ImaTgNUof6dPwbvRJNlv6vOF459Majv2NpRTTns8MJxLKnGUaakzaLqNZbpHUlrz6ukpTHAkJinldBCLdepa915pTbmUsf7ECWm7pp0nURoWMqRChqO0VIKQULWwl8Pgv0cCCIXdKaHDkeW25/dPng6iG29SkJQn6le1leUE/wS9Yh02KbORcZLXc4GE/nQ5HhpnjwvRISAjZ4jcMf3DsPBpvDCwl7ug4CIZFo62jAdfSHnqFFruAZ6bxXR5y7gtHa8bTdlUc9/A9oMZ6cdMMrGlcxYL1Scy0QWqEmSugE8JuPmhb6DY+Do4cz7Um4F8xgfjOs6kqRpf7lvUkxWTMlIA38QdVQu6hKFCFJ6WdR3RegpSVg06TJlypzTQ6jdFkDwgV/qUKJVGU0C2IU1TF2JYHnZauHrJHCZnWIbLWGXklol6t9f51ZkP990OVW19oJTMJHVs1BYD8rsrTMYHoPz60IIp4vLs5pgBpcRzWgRjq7Tm9IfZ+5hfD5v7FKr52swQRi1BBIqBimhoBVjWtTS/Of4yE+gX3Nbz/6cervgQHvuz2NJETdCCjxnRYcpm0Alm5nN4KQ== X-Forefront-Antispam-Report: CIP:216.228.117.160; CTRY:US; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:mail.nvidia.com; PTR:dc6edge1.nvidia.com; CAT:NONE; SFS:(13230028)(4636009)(346002)(136003)(396003)(39860400002)(376002)(451199021)(40470700004)(36840700001)(46966006)(478600001)(7696005)(54906003)(316002)(53546011)(1076003)(26005)(16526019)(6286002)(186003)(6666004)(966005)(2906002)(4326008)(70586007)(70206006)(5660300002)(8676002)(6916009)(41300700001)(8936002)(82310400005)(7636003)(356005)(82740400003)(55016003)(86362001)(40480700001)(36756003)(40460700003)(47076005)(83380400001)(2616005)(426003)(336012)(36860700001); DIR:OUT; SFP:1101; X-OriginatorOrg: Nvidia.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 09 Apr 2023 15:33:31.6821 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: b5f12494-487c-4a84-db16-08db390fc651 X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=43083d15-7273-40c1-b7db-39efd9ccc17a; Ip=[216.228.117.160]; Helo=[mail.nvidia.com] X-MS-Exchange-CrossTenant-AuthSource: CO1NAM11FT040.eop-nam11.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: MW4PR12MB7465 X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org Hi, FYI, your patch has been queued to stable release 22.11.2 Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet. It will be pushed if I get no objections before 04/11/23. So please shout if anyone has objections. Also note that after the patch there's a diff of the upstream commit vs the patch applied to the branch. This will indicate if there was any rebasing needed to apply to the stable branch. If there were code changes for rebasing (ie: not only metadata diffs), please double check that the rebase was correctly done. Queued patches are on a temporary branch at: https://git.dpdk.org/dpdk-stable/log/?h=22.11-staging This queued commit can be viewed at: https://git.dpdk.org/dpdk-stable/log/?h=22.11-staging/commit/161ef7c943bc84814a5de8c66bc5e3e163847a38 Thanks. Xueming Li --- >From 161ef7c943bc84814a5de8c66bc5e3e163847a38 Mon Sep 17 00:00:00 2001 From: Ciara Power Date: Fri, 10 Mar 2023 13:20:17 +0000 Subject: [PATCH] app/crypto-perf: fix test file memory leak Cc: Xueming Li [ upstream commit 430c35730e09dea162b7830b4719285eb6f36364 ] A memory leak was detected using the AddressSanitizer tool, when running the crypto-perf application with a test vector file. The strdup function used returns a pointer to a null-terminated byte string, which must be freed after use. This patch frees the pointer in an error case, and also after a successful run. Fixes: f8be1786b1b8 ("app/crypto-perf: introduce performance test application") Signed-off-by: Ciara Power Acked-by: Akhil Goyal --- app/test-crypto-perf/cperf_options_parsing.c | 1 + app/test-crypto-perf/cperf_test_vector_parsing.c | 1 + 2 files changed, 2 insertions(+) diff --git a/app/test-crypto-perf/cperf_options_parsing.c b/app/test-crypto-perf/cperf_options_parsing.c index cb91bcc3c5..1f06e15d10 100644 --- a/app/test-crypto-perf/cperf_options_parsing.c +++ b/app/test-crypto-perf/cperf_options_parsing.c @@ -519,6 +519,7 @@ parse_test_file(struct cperf_options *opts, if (access(opts->test_file, F_OK) != -1) return 0; RTE_LOG(ERR, USER1, "Test vector file doesn't exist\n"); + free(opts->test_file); return -1; } diff --git a/app/test-crypto-perf/cperf_test_vector_parsing.c b/app/test-crypto-perf/cperf_test_vector_parsing.c index 98e46c3381..737d61d4af 100644 --- a/app/test-crypto-perf/cperf_test_vector_parsing.c +++ b/app/test-crypto-perf/cperf_test_vector_parsing.c @@ -30,6 +30,7 @@ free_test_vector(struct cperf_test_vector *vector, struct cperf_options *opts) rte_free(vector->cipher_key.data); rte_free(vector->auth_key.data); rte_free(vector->ciphertext.data); + free(opts->test_file); } rte_free(vector); -- 2.25.1 --- Diff of the applied patch vs upstream commit (please double-check if non-empty: --- --- - 2023-04-09 21:45:41.120527300 +0800 +++ 0092-app-crypto-perf-fix-test-file-memory-leak.patch 2023-04-09 21:45:38.709042200 +0800 @@ -1 +1 @@ -From 430c35730e09dea162b7830b4719285eb6f36364 Mon Sep 17 00:00:00 2001 +From 161ef7c943bc84814a5de8c66bc5e3e163847a38 Mon Sep 17 00:00:00 2001 @@ -4,0 +5,3 @@ +Cc: Xueming Li + +[ upstream commit 430c35730e09dea162b7830b4719285eb6f36364 ] @@ -14 +16,0 @@ -Cc: stable@dpdk.org @@ -24 +26 @@ -index 8c9f632590..26136a52ae 100644 +index cb91bcc3c5..1f06e15d10 100644