From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 18839428F8 for ; Sun, 9 Apr 2023 17:33:40 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 100E442B8E; Sun, 9 Apr 2023 17:33:40 +0200 (CEST) Received: from NAM10-BN7-obe.outbound.protection.outlook.com (mail-bn7nam10on2088.outbound.protection.outlook.com [40.107.92.88]) by mails.dpdk.org (Postfix) with ESMTP id 1F6C04067E for ; Sun, 9 Apr 2023 17:33:39 +0200 (CEST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=e2w6uQ7ewHJ+5nnA8LPRT5Moy42bNRKZoyEIMTX7VPlsp4EwpROQPHmV/cyDzMekWbv4iGswTCyabfmNjQ8SGshHeD+oujq8ccBK40sN7slIO1TwWKEmwVzE1jSDUQ7WCfySritGQsLDvdZR8LIsS/jH/WBEGaYR633rUDXHba9pC9nMiABhEABfXLih42Bf3z1WM2nk/fW0/S+q8u1b7gC1OL1OWY5Pgp2LIEDkrjP7sfALV74aJSFoVvMvOGcwPOC1NBHDFrr+hwcZgyA0pvThyOmHWr0LytY6di4tBxW0GlFoWhy+VBynom0fpxyIxNc7XlI42Zl3100PuNE07A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=LyPq1bNpPbLbLKahJRzsNOkkM7+/xgQ/ehB0FwoJnBY=; b=UpZSvaDpG8ZElZmNCObu/N7OzJPKw20je7Ho2BsSqOeOKf65/Ed3Ry6G37IstRtyjaqVf1oLMvun9rYMH22qH5WKlCY223BxlcHrTp40F58W4EU+9BeVGUZ5UDUX93moVXteFg9MVb1YXrc3nw1shsL5kKfLQxvID/USKGtRdKMp8wkMhkBIqSsfa20a/PlMIRVnOAaQ2QpfJd4+Ye3iaLOnEU5JJ2r2b0IqK6tZZV4m4UwYj/P7Sm1rqpRk4egapYgu4DtGSdfIVriUz/PKyM+zDyaS/ujlBOzH9zczy21nJDJM/EJ8ZfXq/jAqQE4h8pI0uKeYZZP84OEjNwxz2w== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 216.228.117.161) smtp.rcpttodomain=marvell.com smtp.mailfrom=nvidia.com; dmarc=pass (p=reject sp=reject pct=100) action=none header.from=nvidia.com; dkim=none (message not signed); arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=LyPq1bNpPbLbLKahJRzsNOkkM7+/xgQ/ehB0FwoJnBY=; b=AqnlVZJgqcqEBrAGf8YZY9lKsx2IB0+fbDJ5ltsdT5iIX0ArVzxOxHDnd7k6idLiiXo66J6tJdDMEkZtKSzEev+OkuIrvp8U8aKoZomSCYEAgqeUmdVtjNrmr65y7mxgE/uT476m8yarAPxjHZDB/uZMdYxYmEgQm8yN4IUCX0nhofvTPmquhCk85BGsUOJXQ7mZb3TOwIweLAxILCEMCm9o29YcgTXBAncuB6HbPr/sSAsfGzl52l2ehY9UfHI7D86T/aIYu7GXbrjNUmIqghlUpS511NEW96V2qr8tKgFjz82hqsThiGGfXFYwx3j+1Vn4+/VIoarakibhwpOUkg== Received: from BN0PR04CA0106.namprd04.prod.outlook.com (2603:10b6:408:ec::21) by SA1PR12MB8860.namprd12.prod.outlook.com (2603:10b6:806:38b::15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6277.38; Sun, 9 Apr 2023 15:33:36 +0000 Received: from BN8NAM11FT048.eop-nam11.prod.protection.outlook.com (2603:10b6:408:ec:cafe::ac) by BN0PR04CA0106.outlook.office365.com (2603:10b6:408:ec::21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6277.38 via Frontend Transport; Sun, 9 Apr 2023 15:33:36 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 216.228.117.161) smtp.mailfrom=nvidia.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=nvidia.com; Received-SPF: Pass (protection.outlook.com: domain of nvidia.com designates 216.228.117.161 as permitted sender) receiver=protection.outlook.com; client-ip=216.228.117.161; helo=mail.nvidia.com; pr=C Received: from mail.nvidia.com (216.228.117.161) by BN8NAM11FT048.mail.protection.outlook.com (10.13.177.117) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6298.25 via Frontend Transport; Sun, 9 Apr 2023 15:33:35 +0000 Received: from rnnvmail201.nvidia.com (10.129.68.8) by mail.nvidia.com (10.129.200.67) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.986.5; Sun, 9 Apr 2023 08:33:30 -0700 Received: from nvidia.com (10.126.230.37) by rnnvmail201.nvidia.com (10.129.68.8) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.986.37; Sun, 9 Apr 2023 08:33:28 -0700 From: Xueming Li To: Mohammad Iqbal Ahmad CC: Wisam Jaddo , dpdk stable Subject: patch 'app/flow-perf: fix division or module by zero' has been queued to stable release 22.11.2 Date: Sun, 9 Apr 2023 23:24:41 +0800 Message-ID: <20230409152529.5308-94-xuemingl@nvidia.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20230409152529.5308-1-xuemingl@nvidia.com> References: <20230227062349.13764-1-xuemingl@nvidia.com> <20230409152529.5308-1-xuemingl@nvidia.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Type: text/plain X-Originating-IP: [10.126.230.37] X-ClientProxiedBy: rnnvmail203.nvidia.com (10.129.68.9) To rnnvmail201.nvidia.com (10.129.68.8) X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: BN8NAM11FT048:EE_|SA1PR12MB8860:EE_ X-MS-Office365-Filtering-Correlation-Id: 5a6c8a83-1ead-46d3-16bb-08db390fc8cd X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: hFSLcBrvNvjRyOXuPpDeImuLIEZokcxM1UCs0L/D5h+kWY+A1WocBzakdWIy05jKCrCr5usfDUxhBssCH4dKTcp/ppv+J3/uQSGmtf/uDVqGxoLoxGCyv/rXZd/gKrp3VYEeGAMG22NLL6ndymM6343TrhTB2/H+R+b2eIo7YdgaGFl4LTk8i3WaMqPS2oBrqNk0S+CzQrcAGbc3gZV8KmVQv90Y3IotX4srBo4ydDD1dsAPvch41p9qko0eAzNKTyLmNeimjE1V1NjGFP7UhGtmidiJb17HjP8bvav7PAJo39H//sFT3JzOQt8AGy8dNBPtOlDTTvYJ+UOfN3jhoMKy+bkuH5sOG27BP+7wXk8BkZPuihy6kY47Imh7srKUxhQeTRSpiLkmRKDQf/DFs+OlCH3RJMQgvhYUnEdKt/92iImadKOT9BorOjirHlGwBhIS4txkQuXjPSevv56dacAbLmsNY4MIk/FkTfT1QhJ1sbspaDntXxSRyUJlCtRDadoW3Ir4fyWloL62l2p0ltcXiremAP6ekVlFin1ecZo5OshqSbBPdPjdw7zPQWSK6K9AdtO7zz6jiftNNT4QvvPKcrQvxQr+pMs39Cu5D0989GoqhEGbLolGRLylaVxDAxi1yChO2vz0CrdOqV6oHqaX+a36yfciV6+6XDo9iYPuhOMnPJ7p8PLYQn9pSsiHp3ZOAvRncHwEDJikoD1TM8xzF+Xgm+gZBz9TI8CZgOgZD90DooOKSyIlLd9PGT83V+7mB2OXAvhji7wp5sr36LCdhLTa8fRvd/e6Gfs3npFwBxOX2BzboYgm+XMChRNc/rvnacAe8tujrOkMrRgeJQ== X-Forefront-Antispam-Report: CIP:216.228.117.161; CTRY:US; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:mail.nvidia.com; PTR:dc6edge2.nvidia.com; CAT:NONE; SFS:(13230028)(4636009)(39860400002)(376002)(396003)(346002)(136003)(451199021)(40470700004)(46966006)(36840700001)(83380400001)(316002)(54906003)(478600001)(186003)(1076003)(36756003)(53546011)(16526019)(6286002)(55016003)(26005)(40480700001)(36860700001)(40460700003)(2616005)(47076005)(426003)(966005)(336012)(6666004)(7696005)(82740400003)(2906002)(70206006)(70586007)(4326008)(6916009)(8676002)(8936002)(86362001)(41300700001)(5660300002)(356005)(82310400005)(7636003); DIR:OUT; SFP:1101; X-OriginatorOrg: Nvidia.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 09 Apr 2023 15:33:35.7202 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 5a6c8a83-1ead-46d3-16bb-08db390fc8cd X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=43083d15-7273-40c1-b7db-39efd9ccc17a; Ip=[216.228.117.161]; Helo=[mail.nvidia.com] X-MS-Exchange-CrossTenant-AuthSource: BN8NAM11FT048.eop-nam11.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: SA1PR12MB8860 X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org Hi, FYI, your patch has been queued to stable release 22.11.2 Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet. It will be pushed if I get no objections before 04/11/23. So please shout if anyone has objections. Also note that after the patch there's a diff of the upstream commit vs the patch applied to the branch. This will indicate if there was any rebasing needed to apply to the stable branch. If there were code changes for rebasing (ie: not only metadata diffs), please double check that the rebase was correctly done. Queued patches are on a temporary branch at: https://git.dpdk.org/dpdk-stable/log/?h=22.11-staging This queued commit can be viewed at: https://git.dpdk.org/dpdk-stable/log/?h=22.11-staging/commit/55f236de5c17c0bc591c9c647829197aa78cc61e Thanks. Xueming Li --- >From 55f236de5c17c0bc591c9c647829197aa78cc61e Mon Sep 17 00:00:00 2001 From: Mohammad Iqbal Ahmad Date: Tue, 24 Jan 2023 16:08:03 +0530 Subject: [PATCH] app/flow-perf: fix division or module by zero Cc: Xueming Li [ upstream commit 132d39dcab370b2112e0a24ab1c94036b40b9557 ] Fix division or module by zero reported by coverity scan. Coverity issue: 373870 Fixes: bf3688f1e816 ("app/flow-perf: add insertion rate calculation") Signed-off-by: Mohammad Iqbal Ahmad Acked-by: Wisam Jaddo --- .mailmap | 1 + app/test-flow-perf/main.c | 7 ++++++- 2 files changed, 7 insertions(+), 1 deletion(-) diff --git a/.mailmap b/.mailmap index e9ecebafc1..89fdbe2542 100644 --- a/.mailmap +++ b/.mailmap @@ -917,6 +917,7 @@ Mitch Williams Mit Matelske Mohamad Noor Alim Hussin Mohammad Abdul Awal +Mohammad Iqbal Ahmad Mohammed Gamal Mohsin Kazmi Mohsin Mazhar Shaikh diff --git a/app/test-flow-perf/main.c b/app/test-flow-perf/main.c index 4a9206803a..e0ef78a840 100644 --- a/app/test-flow-perf/main.c +++ b/app/test-flow-perf/main.c @@ -848,7 +848,12 @@ args_parse(int argc, char **argv) /* Control */ if (strcmp(lgopts[opt_idx].name, "rules-batch") == 0) { - rules_batch = atoi(optarg); + n = atoi(optarg); + if (n > 0) + rules_batch = n; + else + rte_exit(EXIT_FAILURE, + "flow rules-batch should be > 0\n"); } if (strcmp(lgopts[opt_idx].name, "rules-count") == 0) { -- 2.25.1 --- Diff of the applied patch vs upstream commit (please double-check if non-empty: --- --- - 2023-04-09 21:45:41.146423000 +0800 +++ 0093-app-flow-perf-fix-division-or-module-by-zero.patch 2023-04-09 21:45:38.709042200 +0800 @@ -1 +1 @@ -From 132d39dcab370b2112e0a24ab1c94036b40b9557 Mon Sep 17 00:00:00 2001 +From 55f236de5c17c0bc591c9c647829197aa78cc61e Mon Sep 17 00:00:00 2001 @@ -4,0 +5,3 @@ +Cc: Xueming Li + +[ upstream commit 132d39dcab370b2112e0a24ab1c94036b40b9557 ] @@ -10 +12,0 @@ -Cc: stable@dpdk.org @@ -20 +22 @@ -index aaa15deff9..4018f0fc47 100644 +index e9ecebafc1..89fdbe2542 100644 @@ -23 +25 @@ -@@ -924,6 +924,7 @@ Mitch Williams +@@ -917,6 +917,7 @@ Mitch Williams