* [PATCH] net/ice: fix dcf init rss blocked
@ 2023-05-06 6:48 Kaiwen Deng
2023-05-08 15:14 ` Tyler Retzlaff
2023-05-09 1:22 ` [PATCH v2] " Kaiwen Deng
0 siblings, 2 replies; 5+ messages in thread
From: Kaiwen Deng @ 2023-05-06 6:48 UTC (permalink / raw)
To: dev; +Cc: stable, qiming.yang, yidingx.zhou, Kaiwen Deng, Qi Zhang, Ting Xu
The i variable type is uint8_t which causes a dead loop,
changing it to uint32_t will solve this issue.
Fixes: 3220d865382c ("net/ice: init RSS during DCF start")
Cc: stable@dpdk.org
Signed-off-by: Kaiwen Deng <kaiwenx.deng@intel.com>
---
drivers/net/ice/ice_dcf.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/drivers/net/ice/ice_dcf.c b/drivers/net/ice/ice_dcf.c
index 1c3d22ae0f..2cf5de0380 100644
--- a/drivers/net/ice/ice_dcf.c
+++ b/drivers/net/ice/ice_dcf.c
@@ -854,7 +854,8 @@ ice_dcf_init_rss(struct ice_dcf_hw *hw)
{
struct rte_eth_dev *dev = hw->eth_dev;
struct rte_eth_rss_conf *rss_conf;
- uint8_t i, j, nb_q;
+ uint8_t j, nb_q;
+ uint32_t i;
int ret;
rss_conf = &dev->data->dev_conf.rx_adv_conf.rss_conf;
--
2.34.1
^ permalink raw reply [flat|nested] 5+ messages in thread* Re: [PATCH] net/ice: fix dcf init rss blocked
2023-05-06 6:48 [PATCH] net/ice: fix dcf init rss blocked Kaiwen Deng
@ 2023-05-08 15:14 ` Tyler Retzlaff
2023-05-09 1:22 ` [PATCH v2] " Kaiwen Deng
1 sibling, 0 replies; 5+ messages in thread
From: Tyler Retzlaff @ 2023-05-08 15:14 UTC (permalink / raw)
To: Kaiwen Deng; +Cc: dev, stable, qiming.yang, yidingx.zhou, Qi Zhang, Ting Xu
On Sat, May 06, 2023 at 02:48:22PM +0800, Kaiwen Deng wrote:
> The i variable type is uint8_t which causes a dead loop,
> changing it to uint32_t will solve this issue.
>
> Fixes: 3220d865382c ("net/ice: init RSS during DCF start")
> Cc: stable@dpdk.org
>
> Signed-off-by: Kaiwen Deng <kaiwenx.deng@intel.com>
> ---
> drivers/net/ice/ice_dcf.c | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/net/ice/ice_dcf.c b/drivers/net/ice/ice_dcf.c
> index 1c3d22ae0f..2cf5de0380 100644
> --- a/drivers/net/ice/ice_dcf.c
> +++ b/drivers/net/ice/ice_dcf.c
> @@ -854,7 +854,8 @@ ice_dcf_init_rss(struct ice_dcf_hw *hw)
> {
> struct rte_eth_dev *dev = hw->eth_dev;
> struct rte_eth_rss_conf *rss_conf;
> - uint8_t i, j, nb_q;
> + uint8_t j, nb_q;
> + uint32_t i;
should be size_t
> int ret;
>
> rss_conf = &dev->data->dev_conf.rx_adv_conf.rss_conf;
with or without suggested change, also isn't there a warning on gcc or
clang that can be enabled to detect this?
Acked-by: Tyler Retzlaff <roretzla@linux.microsoft.com>
^ permalink raw reply [flat|nested] 5+ messages in thread* [PATCH v2] net/ice: fix dcf init rss blocked
2023-05-06 6:48 [PATCH] net/ice: fix dcf init rss blocked Kaiwen Deng
2023-05-08 15:14 ` Tyler Retzlaff
@ 2023-05-09 1:22 ` Kaiwen Deng
2023-05-15 1:44 ` Zhang, Qi Z
1 sibling, 1 reply; 5+ messages in thread
From: Kaiwen Deng @ 2023-05-09 1:22 UTC (permalink / raw)
To: dev; +Cc: stable, qiming.yang, yidingx.zhou, Kaiwen Deng, Qi Zhang
The i variable type is uint8_t which causes a dead loop,
changing it to size_t will solve this issue.
Signed-off-by: Kaiwen Deng <kaiwenx.deng@intel.com>
---
drivers/net/ice/ice_dcf.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/drivers/net/ice/ice_dcf.c b/drivers/net/ice/ice_dcf.c
index 1c3d22ae0f..3e3004f51b 100644
--- a/drivers/net/ice/ice_dcf.c
+++ b/drivers/net/ice/ice_dcf.c
@@ -854,7 +854,8 @@ ice_dcf_init_rss(struct ice_dcf_hw *hw)
{
struct rte_eth_dev *dev = hw->eth_dev;
struct rte_eth_rss_conf *rss_conf;
- uint8_t i, j, nb_q;
+ uint8_t j, nb_q;
+ size_t i;
int ret;
rss_conf = &dev->data->dev_conf.rx_adv_conf.rss_conf;
--
2.34.1
^ permalink raw reply [flat|nested] 5+ messages in thread* RE: [PATCH v2] net/ice: fix dcf init rss blocked
2023-05-09 1:22 ` [PATCH v2] " Kaiwen Deng
@ 2023-05-15 1:44 ` Zhang, Qi Z
0 siblings, 0 replies; 5+ messages in thread
From: Zhang, Qi Z @ 2023-05-15 1:44 UTC (permalink / raw)
To: Deng, KaiwenX, dev; +Cc: stable, Yang, Qiming, Zhou, YidingX
> -----Original Message-----
> From: Deng, KaiwenX <kaiwenx.deng@intel.com>
> Sent: Tuesday, May 9, 2023 9:22 AM
> To: dev@dpdk.org
> Cc: stable@dpdk.org; Yang, Qiming <qiming.yang@intel.com>; Zhou, YidingX
> <yidingx.zhou@intel.com>; Deng, KaiwenX <kaiwenx.deng@intel.com>;
> Zhang, Qi Z <qi.z.zhang@intel.com>
> Subject: [PATCH v2] net/ice: fix dcf init rss blocked
>
> The i variable type is uint8_t which causes a dead loop, changing it to size_t
> will solve this issue.
Fixes: 3220d865382c ("net/ice: init RSS during DCF start")
Cc: stable@dpdk.org
>
> Signed-off-by: Kaiwen Deng <kaiwenx.deng@intel.com>
Acked-by: Qi Zhang <qi.z.zhang@intel.com>
Applied to dpdk-next-net-intel.
Thanks
Qi
^ permalink raw reply [flat|nested] 5+ messages in thread
* RE: [PATCH v2] net/ice: fix dcf init rss blocked
@ 2023-05-12 8:57 Liao, TingtingX
0 siblings, 0 replies; 5+ messages in thread
From: Liao, TingtingX @ 2023-05-12 8:57 UTC (permalink / raw)
To: Deng, KaiwenX, dev
Cc: stable, Yang, Qiming, Zhou, YidingX, Deng, KaiwenX, Zhang, Qi Z
[-- Attachment #1: Type: text/plain, Size: 870 bytes --]
> -----Original Message-----
> From: Kaiwen Deng <kaiwenx.deng@intel.com<mailto:kaiwenx.deng@intel.com>>
> Sent: Tuesday, May 9, 2023 9:22 AM
> To: dev@dpdk.org<mailto:dev@dpdk.org>
> Cc: stable@dpdk.org<mailto:stable@dpdk.org>; Yang, Qiming <qiming.yang@intel.com<mailto:qiming.yang@intel.com>>; Zhou, YidingX <yidingx.zhou@intel.com<mailto:yidingx.zhou@intel.com>>; Deng, KaiwenX <kaiwenx.deng@intel.com<mailto:kaiwenx.deng@intel.com>>; Zhang, Qi Z <qi.z.zhang@intel.com<mailto:qi.z.zhang@intel.com>>
> Subject: [PATCH v2] net/ice: fix dcf init rss blocked
>
> The i variable type is uint8_t which causes a dead loop, changing it to size_t will solve this issue.
>
> Signed-off-by: Kaiwen Deng <kaiwenx.deng@intel.com<mailto:kaiwenx.deng@intel.com>>
Tested-by: Tingting Liao <tingtingx.liao@intel.com<mailto:tingtingx.liao@intel.com>>
[-- Attachment #2: Type: text/html, Size: 4579 bytes --]
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2023-05-15 1:44 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2023-05-06 6:48 [PATCH] net/ice: fix dcf init rss blocked Kaiwen Deng
2023-05-08 15:14 ` Tyler Retzlaff
2023-05-09 1:22 ` [PATCH v2] " Kaiwen Deng
2023-05-15 1:44 ` Zhang, Qi Z
2023-05-12 8:57 Liao, TingtingX
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).