From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <stable-bounces@dpdk.org>
Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124])
	by inbox.dpdk.org (Postfix) with ESMTP id E2AD542B70
	for <public@inbox.dpdk.org>; Mon, 22 May 2023 11:23:05 +0200 (CEST)
Received: from mails.dpdk.org (localhost [127.0.0.1])
	by mails.dpdk.org (Postfix) with ESMTP id DA16842D31;
	Mon, 22 May 2023 11:23:05 +0200 (CEST)
Received: from mga18.intel.com (mga18.intel.com [134.134.136.126])
 by mails.dpdk.org (Postfix) with ESMTP id E8D87410D1;
 Mon, 22 May 2023 11:23:02 +0200 (CEST)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple;
 d=intel.com; i=@intel.com; q=dns/txt; s=Intel;
 t=1684747383; x=1716283383;
 h=from:to:cc:subject:date:message-id:mime-version:
 content-transfer-encoding;
 bh=x9ZPBOzQoGa/U0eZ3LRC9qQUbiCMsJUvtwnH01pgxTI=;
 b=W6IGHpexiFwOQSvCLQd/xzJHbrUVoF2VFRWZpd0CY7iTcQUZqxHYrH5J
 h/Qo4d7JQp/oV1J2320c9iTIm3aHWzkr/EA5mB2gO7uZCUSLvx2/AUi7D
 kCRbrTZl5i+TAeOLyDupQff0anTzGiDZKRBFDpmyeGX5nwmHGTshWWChi
 oNkfs98segSRwmoQhx+TKZOEiNOAQmbPqyjZCf/menRJj21NmeZmZ9ZXX
 8eg7qA4ySvEgvuLQMXVZDbYMyB3lY64dpCLBmGJtIMMemz+bwM1BNPOeP
 3HwLh7VqDQ3c0fXFRVsgPRI4V4eZ4o59LgfMFdyjw/tbPzHzhKk7NobzW g==;
X-IronPort-AV: E=McAfee;i="6600,9927,10717"; a="337462407"
X-IronPort-AV: E=Sophos;i="6.00,184,1681196400"; d="scan'208";a="337462407"
Received: from orsmga007.jf.intel.com ([10.7.209.58])
 by orsmga106.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384;
 22 May 2023 02:23:01 -0700
X-ExtLoop1: 1
X-IronPort-AV: E=McAfee;i="6600,9927,10717"; a="697583628"
X-IronPort-AV: E=Sophos;i="6.00,184,1681196400"; d="scan'208";a="697583628"
Received: from silpixa00401385.ir.intel.com ([10.237.214.40])
 by orsmga007.jf.intel.com with ESMTP; 22 May 2023 02:23:00 -0700
From: Bruce Richardson <bruce.richardson@intel.com>
To: dev@dpdk.org
Cc: Bruce Richardson <bruce.richardson@intel.com>, stable@dpdk.org,
 John Baldwin <jhb@FreeBSD.org>
Subject: [PATCH] freebsd/contigmem: fix function parameter list
Date: Mon, 22 May 2023 10:22:41 +0100
Message-Id: <20230522092241.20773-1-bruce.richardson@intel.com>
X-Mailer: git-send-email 2.39.2
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit
X-BeenThere: stable@dpdk.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: patches for DPDK stable branches <stable.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/stable>,
 <mailto:stable-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/stable/>
List-Post: <mailto:stable@dpdk.org>
List-Help: <mailto:stable-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/stable>,
 <mailto:stable-request@dpdk.org?subject=subscribe>
Errors-To: stable-bounces@dpdk.org

Functions which take no parameters should explicitly have "(void)" as
the parameter list, rather than "()".

Reported upstream on FreeBSD ports collection [1].

[1] https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=271524

Fixes: 764bf26873b9 ("add FreeBSD support")
Cc: stable@dpdk.org

Reported-by: John Baldwin <jhb@FreeBSD.org>
Signed-off-by: Bruce Richardson <bruce.richardson@intel.com>
---
 kernel/freebsd/contigmem/contigmem.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/kernel/freebsd/contigmem/contigmem.c b/kernel/freebsd/contigmem/contigmem.c
index bd72f4d620..7dd87599d9 100644
--- a/kernel/freebsd/contigmem/contigmem.c
+++ b/kernel/freebsd/contigmem/contigmem.c
@@ -111,7 +111,7 @@ static struct cdevsw contigmem_ops = {
 };
 
 static int
-contigmem_load()
+contigmem_load(void)
 {
 	char index_string[8], description[32];
 	int  i, error = 0;
@@ -178,7 +178,7 @@ contigmem_load()
 }
 
 static int
-contigmem_unload()
+contigmem_unload(void)
 {
 	int i;
 
-- 
2.39.2