From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 4F90742B7B for ; Tue, 23 May 2023 05:07:32 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 47AE142BB1; Tue, 23 May 2023 05:07:32 +0200 (CEST) Received: from mga06.intel.com (mga06b.intel.com [134.134.136.31]) by mails.dpdk.org (Postfix) with ESMTP id D827840A80; Tue, 23 May 2023 05:07:29 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1684811250; x=1716347250; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=uceCB7pjAANGjCZ5ibTG6Wi8GGcTtCcu4xB3qyLWgHw=; b=kQPNP9S0N3vmBhYgpN1+LY8FJByuH5RiwUnIjlTNz7NmxJgv12DrCZ6g /VBaeCGsT9G5ZpjFV2CmxU6XHopA08nSO3oH1MwmN6ZRYfite/ck3G4Mc BjZ9FWXHtPgURuwXYKLM1Eyom0uD9ke8HAxXLU8MgdFnwPx7O+XoxfbG1 zMJ2A0dnyHxW6Kq4sVSQ2KaYXB9dlGWrx4QdVjdLdzFZihCKmTJkuKQ8H cwPpmA4AdLrVVDTwf5s3sAiUj1kg5Z+Ek8MDtAh8W5LT5iTbcaSrLBIs1 W2XpqNqF1eqhqrENKRFs6YMJgJPz9jPnC3Tvuexn3pOoqqgMDHVpEwl5Q A==; X-IronPort-AV: E=McAfee;i="6600,9927,10718"; a="416577126" X-IronPort-AV: E=Sophos;i="6.00,185,1681196400"; d="scan'208";a="416577126" Received: from orsmga003.jf.intel.com ([10.7.209.27]) by orsmga104.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 22 May 2023 20:07:28 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10718"; a="654191968" X-IronPort-AV: E=Sophos;i="6.00,185,1681196400"; d="scan'208";a="654191968" Received: from unknown (HELO localhost.localdomain) ([10.239.252.104]) by orsmga003-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 22 May 2023 20:07:25 -0700 From: Kaisen You To: dev@dpdk.org Cc: yidingx.zhou@intel.com, thomas@monjalon.net, david.marchand@redhat.com, olivier.matz@6wind.com, ferruh.yigit@amd.com, kaisenx.you@intel.com, zhoumin@loongson.cn, anatoly.burakov@intel.com, stable@dpdk.org Subject: [PATCH v7] enhance NUMA affinity heuristic Date: Tue, 23 May 2023 10:50:04 +0800 Message-Id: <20230523025004.192071-1-kaisenx.you@intel.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20230425051649.1109428-1-kaisenx.you@intel.com> References: <20230425051649.1109428-1-kaisenx.you@intel.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org When a DPDK application is started on only one numa node, memory is allocated for only one socket. When interrupt threads use memory, memory may not be found on the socket where the interrupt thread is currently located, and memory has to be reallocated on the hugepage, this operation will lead to performance degradation. Fixes: 705356f0811f ("eal: simplify control thread creation") Fixes: 770d41bf3309 ("malloc: fix allocation with unknown socket ID") Cc: stable@dpdk.org Signed-off-by: Kaisen You --- Changes since v6: - New explanation for easy understanding, Changes since v5: - Add comments to the code, Changes since v4: - mod the patch title, Changes since v3: - add the assignment of socket_id in thread initialization, Changes since v2: - add uncommitted local change and fix compilation, Changes since v1: - accomodate for configurations with main lcore running on multiples physical cores belonging to different numa, --- lib/eal/common/eal_common_thread.c | 6 ++++++ lib/eal/common/malloc_heap.c | 9 +++++++++ 2 files changed, 15 insertions(+) diff --git a/lib/eal/common/eal_common_thread.c b/lib/eal/common/eal_common_thread.c index 079a385630..6479b66da1 100644 --- a/lib/eal/common/eal_common_thread.c +++ b/lib/eal/common/eal_common_thread.c @@ -252,6 +252,12 @@ static int ctrl_thread_init(void *arg) struct rte_thread_ctrl_params *params = arg; __rte_thread_init(rte_lcore_id(), cpuset); + /* set the value of the per-core variable _socket_id to SOCKET_ID_ANY. + * Satisfy the judgment condition when threads find memory. + * If SOCKET_ID_ANY is not specified, the thread may go to a node with + * unallocated memory in a subsequent memory search. + */ + RTE_PER_LCORE(_socket_id) = SOCKET_ID_ANY; params->ret = rte_thread_set_affinity_by_id(rte_thread_self(), cpuset); if (params->ret != 0) { __atomic_store_n(¶ms->ctrl_thread_status, diff --git a/lib/eal/common/malloc_heap.c b/lib/eal/common/malloc_heap.c index d25bdc98f9..6d37f8afee 100644 --- a/lib/eal/common/malloc_heap.c +++ b/lib/eal/common/malloc_heap.c @@ -716,6 +716,15 @@ malloc_get_numa_socket(void) if (conf->socket_mem[socket_id] != 0) return socket_id; } + /* Trying to allocate memory on the main lcore numa node. + * especially when the DPDK application is started only on one numa node. + */ + socket_id = rte_lcore_to_socket_id(rte_get_main_lcore()); + /* When the socket_id obtained in the main lcore numa is SOCKET_ID_ANY, + * The probability of finding memory on rte_socket_id_by_idx(0) is higher. + */ + if (socket_id != (unsigned int)SOCKET_ID_ANY) + return socket_id; return rte_socket_id_by_idx(0); } -- 2.25.1