* [PATCH v2 03/32] common/cnxk: fix CPT backpressure disable on LBK [not found] ` <20230524100407.3796139-1-ndabilpuram@marvell.com> @ 2023-05-24 10:03 ` Nithin Dabilpuram 2023-05-24 10:03 ` [PATCH v2 12/32] common/cnxk: fix null pointer dereference Nithin Dabilpuram ` (3 subsequent siblings) 4 siblings, 0 replies; 10+ messages in thread From: Nithin Dabilpuram @ 2023-05-24 10:03 UTC (permalink / raw) To: Nithin Kumar Dabilpuram, Kiran Kumar K, Sunil Kumar Kori, Satha Rao Cc: jerinj, dev, Rahul Bhansali, stable From: Rahul Bhansali <rbhansali@marvell.com> For LBK interfaces, roc_nix_inl_inb_is_enabled() is false, hence backpressure on CPT is disabled and causing CQ full interrupt. NIXX_AF_RX_CHAN[0x800]_CFG is global config for all PF, VF of RPM/LBK, hence backpressure disable on CPT is not required. Fixes: 0663a84524e ("common/cnxk: enable backpressure on CPT with inline inbound") cc: stable@dpdk.org Signed-off-by: Rahul Bhansali <rbhansali@marvell.com> --- drivers/common/cnxk/roc_nix_fc.c | 18 ++---------------- 1 file changed, 2 insertions(+), 16 deletions(-) diff --git a/drivers/common/cnxk/roc_nix_fc.c b/drivers/common/cnxk/roc_nix_fc.c index 8b7659fb9a..19334b1eb0 100644 --- a/drivers/common/cnxk/roc_nix_fc.c +++ b/drivers/common/cnxk/roc_nix_fc.c @@ -87,25 +87,11 @@ nix_fc_rxchan_bpid_set(struct roc_nix *roc_nix, bool enable) if (rc) goto exit; nix->cpt_lbpid = rsp->chan_bpid[0] & 0x1FF; - } else { - req = mbox_alloc_msg_nix_cpt_bp_disable(mbox); - if (req == NULL) - goto exit; - req->chan_base = 0; - if (roc_nix_is_lbk(roc_nix) || roc_nix_is_sdp(roc_nix)) - req->chan_cnt = NIX_LBK_MAX_CHAN; - else - req->chan_cnt = NIX_CGX_MAX_CHAN; - req->bpid_per_chan = 0; - - rc = mbox_process_msg(mbox, (void *)&rsp); - if (rc) - goto exit; - nix->cpt_lbpid = 0; } /* CPT to NIX BP on all channels */ - if (!roc_feature_nix_has_rxchan_multi_bpid() || !nix->cpt_nixbpid) + if (!roc_feature_nix_has_rxchan_multi_bpid() || !nix->cpt_nixbpid || + !roc_nix_inl_inb_is_enabled(roc_nix)) goto exit; mbox_put(mbox); -- 2.25.1 ^ permalink raw reply [flat|nested] 10+ messages in thread
* [PATCH v2 12/32] common/cnxk: fix null pointer dereference [not found] ` <20230524100407.3796139-1-ndabilpuram@marvell.com> 2023-05-24 10:03 ` [PATCH v2 03/32] common/cnxk: fix CPT backpressure disable on LBK Nithin Dabilpuram @ 2023-05-24 10:03 ` Nithin Dabilpuram 2023-05-24 10:03 ` [PATCH v2 13/32] common/cnxk: fix parameter in NIX dump Nithin Dabilpuram ` (2 subsequent siblings) 4 siblings, 0 replies; 10+ messages in thread From: Nithin Dabilpuram @ 2023-05-24 10:03 UTC (permalink / raw) To: Nithin Kumar Dabilpuram, Kiran Kumar K, Sunil Kumar Kori, Satha Rao Cc: jerinj, dev, Gowrishankar Muthukrishnan, stable From: Gowrishankar Muthukrishnan <gmuthukrishn@marvell.com> Fix null pointer dereferences reported by klocwork. Fixes: 4398c4092f3d ("common/cnxk: dump inline device RQ context") Fixes: 79dc6f324e82 ("common/cnxk: add inline function for statistics") cc: stable@dpdk.org Signed-off-by: Gowrishankar Muthukrishnan <gmuthukrishn@marvell.com> --- drivers/common/cnxk/roc_nix_debug.c | 8 +++++++- drivers/common/cnxk/roc_nix_inl_dev.c | 2 +- 2 files changed, 8 insertions(+), 2 deletions(-) diff --git a/drivers/common/cnxk/roc_nix_debug.c b/drivers/common/cnxk/roc_nix_debug.c index 399d0d7eae..a1c3db284b 100644 --- a/drivers/common/cnxk/roc_nix_debug.c +++ b/drivers/common/cnxk/roc_nix_debug.c @@ -733,7 +733,13 @@ roc_nix_queues_ctx_dump(struct roc_nix *roc_nix, FILE *file) inl_rq = roc_nix_inl_dev_rq(roc_nix); if (inl_rq) { struct idev_cfg *idev = idev_get_cfg(); - struct nix_inl_dev *inl_dev = idev->nix_inl_dev; + struct nix_inl_dev *inl_dev = NULL; + + if (idev && idev->nix_inl_dev) + inl_dev = idev->nix_inl_dev; + + if (!inl_dev) + return -EINVAL; rc = nix_q_ctx_get(&inl_dev->dev, NIX_AQ_CTYPE_RQ, inl_rq->qid, &ctx); if (rc) { diff --git a/drivers/common/cnxk/roc_nix_inl_dev.c b/drivers/common/cnxk/roc_nix_inl_dev.c index 0df148c3ed..ca948d3bc7 100644 --- a/drivers/common/cnxk/roc_nix_inl_dev.c +++ b/drivers/common/cnxk/roc_nix_inl_dev.c @@ -843,7 +843,7 @@ roc_nix_inl_dev_stats_get(struct roc_nix_stats *stats) if (stats == NULL) return NIX_ERR_PARAM; - if (!idev && idev->nix_inl_dev) + if (idev && idev->nix_inl_dev) inl_dev = idev->nix_inl_dev; if (!inl_dev) -- 2.25.1 ^ permalink raw reply [flat|nested] 10+ messages in thread
* [PATCH v2 13/32] common/cnxk: fix parameter in NIX dump [not found] ` <20230524100407.3796139-1-ndabilpuram@marvell.com> 2023-05-24 10:03 ` [PATCH v2 03/32] common/cnxk: fix CPT backpressure disable on LBK Nithin Dabilpuram 2023-05-24 10:03 ` [PATCH v2 12/32] common/cnxk: fix null pointer dereference Nithin Dabilpuram @ 2023-05-24 10:03 ` Nithin Dabilpuram 2023-05-24 10:03 ` [PATCH v2 24/32] common/cnxk: fix inline device VF identification Nithin Dabilpuram 2023-05-24 10:04 ` [PATCH v2 29/32] common/cnxk: fix receive queue with multiple mask Nithin Dabilpuram 4 siblings, 0 replies; 10+ messages in thread From: Nithin Dabilpuram @ 2023-05-24 10:03 UTC (permalink / raw) To: Nithin Kumar Dabilpuram, Kiran Kumar K, Sunil Kumar Kori, Satha Rao Cc: jerinj, dev, Gowrishankar Muthukrishnan, stable From: Gowrishankar Muthukrishnan <gmuthukrishn@marvell.com> Fix parameter passed to nix_dump to what expected in format specifier. Fixes: d2f168dfa5de ("common/cnxk: support 10K B0 for inline IPsec") cc: stable@dpdk.org Signed-off-by: Gowrishankar Muthukrishnan <gmuthukrishn@marvell.com> --- drivers/common/cnxk/roc_nix_debug.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/common/cnxk/roc_nix_debug.c b/drivers/common/cnxk/roc_nix_debug.c index a1c3db284b..8c7d902f1e 100644 --- a/drivers/common/cnxk/roc_nix_debug.c +++ b/drivers/common/cnxk/roc_nix_debug.c @@ -664,8 +664,8 @@ nix_lf_cq_dump(__io struct nix_cq_ctx_s *ctx, FILE *file) nix_dump(file, "W1: lbpid_high \t\t\t0x%03x\nW1: lbpid_med \t\t\t0x%03x\n" "W1: lbpid_low \t\t\t0x%03x\n(W1: lbpid) \t\t\t0x%03x\n", - ctx->lbpid_high, ctx->lbpid_med, ctx->lbpid_low, - ctx->lbpid_high << 6 | ctx->lbpid_med << 3 | ctx->lbpid_low); + ctx->lbpid_high, ctx->lbpid_med, ctx->lbpid_low, (unsigned int) + (ctx->lbpid_high << 6 | ctx->lbpid_med << 3 | ctx->lbpid_low)); nix_dump(file, "W1: lbp_ena \t\t\t\t%d\n", ctx->lbp_ena); nix_dump(file, "W2: update_time \t\t%d\nW2: avg_level \t\t\t%d", -- 2.25.1 ^ permalink raw reply [flat|nested] 10+ messages in thread
* [PATCH v2 24/32] common/cnxk: fix inline device VF identification [not found] ` <20230524100407.3796139-1-ndabilpuram@marvell.com> ` (2 preceding siblings ...) 2023-05-24 10:03 ` [PATCH v2 13/32] common/cnxk: fix parameter in NIX dump Nithin Dabilpuram @ 2023-05-24 10:03 ` Nithin Dabilpuram 2023-05-24 10:04 ` [PATCH v2 29/32] common/cnxk: fix receive queue with multiple mask Nithin Dabilpuram 4 siblings, 0 replies; 10+ messages in thread From: Nithin Dabilpuram @ 2023-05-24 10:03 UTC (permalink / raw) To: Nithin Kumar Dabilpuram, Kiran Kumar K, Sunil Kumar Kori, Satha Rao Cc: jerinj, dev, stable Fix inline device VF identification so that the right mbox region is used. Fixes: ee48f711f3b0 ("common/cnxk: support NIX inline inbound and outbound setup") cc: stable@dpdk.org Signed-off-by: Nithin Dabilpuram <ndabilpuram@marvell.com> --- drivers/common/cnxk/roc_dev.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/common/cnxk/roc_dev.c b/drivers/common/cnxk/roc_dev.c index 3125f9dda2..d87b00e7e8 100644 --- a/drivers/common/cnxk/roc_dev.c +++ b/drivers/common/cnxk/roc_dev.c @@ -1001,6 +1001,7 @@ dev_vf_hwcap_update(struct plt_pci_device *pci_dev, struct dev *dev) case PCI_DEVID_CNXK_RVU_AF_VF: case PCI_DEVID_CNXK_RVU_VF: case PCI_DEVID_CNXK_RVU_SDP_VF: + case PCI_DEVID_CNXK_RVU_NIX_INL_VF: dev->hwcap |= DEV_HWCAP_F_VF; break; } -- 2.25.1 ^ permalink raw reply [flat|nested] 10+ messages in thread
* [PATCH v2 29/32] common/cnxk: fix receive queue with multiple mask [not found] ` <20230524100407.3796139-1-ndabilpuram@marvell.com> ` (3 preceding siblings ...) 2023-05-24 10:03 ` [PATCH v2 24/32] common/cnxk: fix inline device VF identification Nithin Dabilpuram @ 2023-05-24 10:04 ` Nithin Dabilpuram 4 siblings, 0 replies; 10+ messages in thread From: Nithin Dabilpuram @ 2023-05-24 10:04 UTC (permalink / raw) To: Nithin Kumar Dabilpuram, Kiran Kumar K, Sunil Kumar Kori, Satha Rao Cc: jerinj, dev, Rakesh Kudurumalla, stable From: Rakesh Kudurumalla <rkudurumalla@marvell.com> enable or disable RQ mask based on function parameter.This fix allocates different profile for different rq masks Fixes: ddf955d3917e ("common/cnxk: support CPT second pass") cc: stable@dpdk.org Signed-off-by: Rakesh Kudurumalla <rkudurumalla@marvell.com> --- drivers/common/cnxk/roc_nix_inl.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/common/cnxk/roc_nix_inl.c b/drivers/common/cnxk/roc_nix_inl.c index 69f658ba87..16f858f561 100644 --- a/drivers/common/cnxk/roc_nix_inl.c +++ b/drivers/common/cnxk/roc_nix_inl.c @@ -1382,7 +1382,7 @@ roc_nix_inl_rq_ena_dis(struct roc_nix *roc_nix, bool enable) return -EFAULT; if (roc_feature_nix_has_inl_rq_mask()) { - rc = nix_inl_rq_mask_cfg(roc_nix, true); + rc = nix_inl_rq_mask_cfg(roc_nix, enable); if (rc) { plt_err("Failed to get rq mask rc=%d", rc); return rc; -- 2.25.1 ^ permalink raw reply [flat|nested] 10+ messages in thread
[parent not found: <20230525095904.3967080-1-ndabilpuram@marvell.com>]
* [PATCH v3 03/32] common/cnxk: fix CPT backpressure disable on LBK [not found] ` <20230525095904.3967080-1-ndabilpuram@marvell.com> @ 2023-05-25 9:58 ` Nithin Dabilpuram 2023-05-25 9:58 ` [PATCH v3 12/32] common/cnxk: fix null pointer dereference Nithin Dabilpuram ` (3 subsequent siblings) 4 siblings, 0 replies; 10+ messages in thread From: Nithin Dabilpuram @ 2023-05-25 9:58 UTC (permalink / raw) To: Nithin Kumar Dabilpuram, Kiran Kumar K, Sunil Kumar Kori, Satha Rao Cc: jerinj, dev, Rahul Bhansali, stable From: Rahul Bhansali <rbhansali@marvell.com> For LBK interfaces, roc_nix_inl_inb_is_enabled() is false, hence backpressure on CPT is disabled and causing CQ full interrupt. NIXX_AF_RX_CHAN[0x800]_CFG is global config for all PF, VF of RPM/LBK, hence backpressure disable on CPT is not required. Fixes: 0663a84524e5 ("common/cnxk: enable backpressure on CPT with inline inbound") cc: stable@dpdk.org Signed-off-by: Rahul Bhansali <rbhansali@marvell.com> --- drivers/common/cnxk/roc_nix_fc.c | 18 ++---------------- 1 file changed, 2 insertions(+), 16 deletions(-) diff --git a/drivers/common/cnxk/roc_nix_fc.c b/drivers/common/cnxk/roc_nix_fc.c index 8feb773e1d..6d6997ed82 100644 --- a/drivers/common/cnxk/roc_nix_fc.c +++ b/drivers/common/cnxk/roc_nix_fc.c @@ -87,25 +87,11 @@ nix_fc_rxchan_bpid_set(struct roc_nix *roc_nix, bool enable) if (rc) goto exit; nix->cpt_lbpid = rsp->chan_bpid[0] & 0x1FF; - } else { - req = mbox_alloc_msg_nix_cpt_bp_disable(mbox); - if (req == NULL) - goto exit; - req->chan_base = 0; - if (roc_nix_is_lbk(roc_nix) || roc_nix_is_sdp(roc_nix)) - req->chan_cnt = NIX_LBK_MAX_CHAN; - else - req->chan_cnt = NIX_CGX_MAX_CHAN; - req->bpid_per_chan = 0; - - rc = mbox_process_msg(mbox, (void *)&rsp); - if (rc) - goto exit; - nix->cpt_lbpid = 0; } /* CPT to NIX BP on all channels */ - if (!roc_feature_nix_has_rxchan_multi_bpid() || !nix->cpt_nixbpid) + if (!roc_feature_nix_has_rxchan_multi_bpid() || !nix->cpt_nixbpid || + !roc_nix_inl_inb_is_enabled(roc_nix)) goto exit; mbox_put(mbox); -- 2.25.1 ^ permalink raw reply [flat|nested] 10+ messages in thread
* [PATCH v3 12/32] common/cnxk: fix null pointer dereference [not found] ` <20230525095904.3967080-1-ndabilpuram@marvell.com> 2023-05-25 9:58 ` [PATCH v3 03/32] common/cnxk: fix CPT backpressure disable on LBK Nithin Dabilpuram @ 2023-05-25 9:58 ` Nithin Dabilpuram 2023-05-25 9:58 ` [PATCH v3 13/32] common/cnxk: fix parameter in NIX dump Nithin Dabilpuram ` (2 subsequent siblings) 4 siblings, 0 replies; 10+ messages in thread From: Nithin Dabilpuram @ 2023-05-25 9:58 UTC (permalink / raw) To: Nithin Kumar Dabilpuram, Kiran Kumar K, Sunil Kumar Kori, Satha Rao Cc: jerinj, dev, Gowrishankar Muthukrishnan, stable From: Gowrishankar Muthukrishnan <gmuthukrishn@marvell.com> Fix null pointer dereferences reported by klocwork. Fixes: 4398c4092f3d ("common/cnxk: dump inline device RQ context") Fixes: 79dc6f324e82 ("common/cnxk: add inline function for statistics") cc: stable@dpdk.org Signed-off-by: Gowrishankar Muthukrishnan <gmuthukrishn@marvell.com> --- drivers/common/cnxk/roc_nix_debug.c | 8 +++++++- drivers/common/cnxk/roc_nix_inl_dev.c | 2 +- 2 files changed, 8 insertions(+), 2 deletions(-) diff --git a/drivers/common/cnxk/roc_nix_debug.c b/drivers/common/cnxk/roc_nix_debug.c index 399d0d7eae..a1c3db284b 100644 --- a/drivers/common/cnxk/roc_nix_debug.c +++ b/drivers/common/cnxk/roc_nix_debug.c @@ -733,7 +733,13 @@ roc_nix_queues_ctx_dump(struct roc_nix *roc_nix, FILE *file) inl_rq = roc_nix_inl_dev_rq(roc_nix); if (inl_rq) { struct idev_cfg *idev = idev_get_cfg(); - struct nix_inl_dev *inl_dev = idev->nix_inl_dev; + struct nix_inl_dev *inl_dev = NULL; + + if (idev && idev->nix_inl_dev) + inl_dev = idev->nix_inl_dev; + + if (!inl_dev) + return -EINVAL; rc = nix_q_ctx_get(&inl_dev->dev, NIX_AQ_CTYPE_RQ, inl_rq->qid, &ctx); if (rc) { diff --git a/drivers/common/cnxk/roc_nix_inl_dev.c b/drivers/common/cnxk/roc_nix_inl_dev.c index 0df148c3ed..ca948d3bc7 100644 --- a/drivers/common/cnxk/roc_nix_inl_dev.c +++ b/drivers/common/cnxk/roc_nix_inl_dev.c @@ -843,7 +843,7 @@ roc_nix_inl_dev_stats_get(struct roc_nix_stats *stats) if (stats == NULL) return NIX_ERR_PARAM; - if (!idev && idev->nix_inl_dev) + if (idev && idev->nix_inl_dev) inl_dev = idev->nix_inl_dev; if (!inl_dev) -- 2.25.1 ^ permalink raw reply [flat|nested] 10+ messages in thread
* [PATCH v3 13/32] common/cnxk: fix parameter in NIX dump [not found] ` <20230525095904.3967080-1-ndabilpuram@marvell.com> 2023-05-25 9:58 ` [PATCH v3 03/32] common/cnxk: fix CPT backpressure disable on LBK Nithin Dabilpuram 2023-05-25 9:58 ` [PATCH v3 12/32] common/cnxk: fix null pointer dereference Nithin Dabilpuram @ 2023-05-25 9:58 ` Nithin Dabilpuram 2023-05-25 9:58 ` [PATCH v3 24/32] common/cnxk: fix inline device VF identification Nithin Dabilpuram 2023-05-25 9:59 ` [PATCH v3 29/32] common/cnxk: fix receive queue with multiple mask Nithin Dabilpuram 4 siblings, 0 replies; 10+ messages in thread From: Nithin Dabilpuram @ 2023-05-25 9:58 UTC (permalink / raw) To: Nithin Kumar Dabilpuram, Kiran Kumar K, Sunil Kumar Kori, Satha Rao Cc: jerinj, dev, Gowrishankar Muthukrishnan, stable From: Gowrishankar Muthukrishnan <gmuthukrishn@marvell.com> Fix parameter passed to nix_dump to what expected in format specifier. Fixes: d2f168dfa5de ("common/cnxk: support 10K B0 for inline IPsec") cc: stable@dpdk.org Signed-off-by: Gowrishankar Muthukrishnan <gmuthukrishn@marvell.com> --- drivers/common/cnxk/roc_nix_debug.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/common/cnxk/roc_nix_debug.c b/drivers/common/cnxk/roc_nix_debug.c index a1c3db284b..8c7d902f1e 100644 --- a/drivers/common/cnxk/roc_nix_debug.c +++ b/drivers/common/cnxk/roc_nix_debug.c @@ -664,8 +664,8 @@ nix_lf_cq_dump(__io struct nix_cq_ctx_s *ctx, FILE *file) nix_dump(file, "W1: lbpid_high \t\t\t0x%03x\nW1: lbpid_med \t\t\t0x%03x\n" "W1: lbpid_low \t\t\t0x%03x\n(W1: lbpid) \t\t\t0x%03x\n", - ctx->lbpid_high, ctx->lbpid_med, ctx->lbpid_low, - ctx->lbpid_high << 6 | ctx->lbpid_med << 3 | ctx->lbpid_low); + ctx->lbpid_high, ctx->lbpid_med, ctx->lbpid_low, (unsigned int) + (ctx->lbpid_high << 6 | ctx->lbpid_med << 3 | ctx->lbpid_low)); nix_dump(file, "W1: lbp_ena \t\t\t\t%d\n", ctx->lbp_ena); nix_dump(file, "W2: update_time \t\t%d\nW2: avg_level \t\t\t%d", -- 2.25.1 ^ permalink raw reply [flat|nested] 10+ messages in thread
* [PATCH v3 24/32] common/cnxk: fix inline device VF identification [not found] ` <20230525095904.3967080-1-ndabilpuram@marvell.com> ` (2 preceding siblings ...) 2023-05-25 9:58 ` [PATCH v3 13/32] common/cnxk: fix parameter in NIX dump Nithin Dabilpuram @ 2023-05-25 9:58 ` Nithin Dabilpuram 2023-05-25 9:59 ` [PATCH v3 29/32] common/cnxk: fix receive queue with multiple mask Nithin Dabilpuram 4 siblings, 0 replies; 10+ messages in thread From: Nithin Dabilpuram @ 2023-05-25 9:58 UTC (permalink / raw) To: Nithin Kumar Dabilpuram, Kiran Kumar K, Sunil Kumar Kori, Satha Rao Cc: jerinj, dev, stable Fix inline device VF identification so that the right mbox region is used. Fixes: ee48f711f3b0 ("common/cnxk: support NIX inline inbound and outbound setup") cc: stable@dpdk.org Signed-off-by: Nithin Dabilpuram <ndabilpuram@marvell.com> --- drivers/common/cnxk/roc_dev.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/common/cnxk/roc_dev.c b/drivers/common/cnxk/roc_dev.c index 3125f9dda2..d87b00e7e8 100644 --- a/drivers/common/cnxk/roc_dev.c +++ b/drivers/common/cnxk/roc_dev.c @@ -1001,6 +1001,7 @@ dev_vf_hwcap_update(struct plt_pci_device *pci_dev, struct dev *dev) case PCI_DEVID_CNXK_RVU_AF_VF: case PCI_DEVID_CNXK_RVU_VF: case PCI_DEVID_CNXK_RVU_SDP_VF: + case PCI_DEVID_CNXK_RVU_NIX_INL_VF: dev->hwcap |= DEV_HWCAP_F_VF; break; } -- 2.25.1 ^ permalink raw reply [flat|nested] 10+ messages in thread
* [PATCH v3 29/32] common/cnxk: fix receive queue with multiple mask [not found] ` <20230525095904.3967080-1-ndabilpuram@marvell.com> ` (3 preceding siblings ...) 2023-05-25 9:58 ` [PATCH v3 24/32] common/cnxk: fix inline device VF identification Nithin Dabilpuram @ 2023-05-25 9:59 ` Nithin Dabilpuram 4 siblings, 0 replies; 10+ messages in thread From: Nithin Dabilpuram @ 2023-05-25 9:59 UTC (permalink / raw) To: Nithin Kumar Dabilpuram, Kiran Kumar K, Sunil Kumar Kori, Satha Rao Cc: jerinj, dev, Rakesh Kudurumalla, stable From: Rakesh Kudurumalla <rkudurumalla@marvell.com> enable or disable RQ mask based on function parameter.This fix allocates different profile for different rq masks Fixes: ddf955d3917e ("common/cnxk: support CPT second pass") cc: stable@dpdk.org Signed-off-by: Rakesh Kudurumalla <rkudurumalla@marvell.com> --- drivers/common/cnxk/roc_nix_inl.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/common/cnxk/roc_nix_inl.c b/drivers/common/cnxk/roc_nix_inl.c index 69f658ba87..16f858f561 100644 --- a/drivers/common/cnxk/roc_nix_inl.c +++ b/drivers/common/cnxk/roc_nix_inl.c @@ -1382,7 +1382,7 @@ roc_nix_inl_rq_ena_dis(struct roc_nix *roc_nix, bool enable) return -EFAULT; if (roc_feature_nix_has_inl_rq_mask()) { - rc = nix_inl_rq_mask_cfg(roc_nix, true); + rc = nix_inl_rq_mask_cfg(roc_nix, enable); if (rc) { plt_err("Failed to get rq mask rc=%d", rc); return rc; -- 2.25.1 ^ permalink raw reply [flat|nested] 10+ messages in thread
end of thread, other threads:[~2023-05-25 10:37 UTC | newest]
Thread overview: 10+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
[not found] <20230411091144.1087887-1-ndabilpuram@marvell.com>
[not found] ` <20230524100407.3796139-1-ndabilpuram@marvell.com>
2023-05-24 10:03 ` [PATCH v2 03/32] common/cnxk: fix CPT backpressure disable on LBK Nithin Dabilpuram
2023-05-24 10:03 ` [PATCH v2 12/32] common/cnxk: fix null pointer dereference Nithin Dabilpuram
2023-05-24 10:03 ` [PATCH v2 13/32] common/cnxk: fix parameter in NIX dump Nithin Dabilpuram
2023-05-24 10:03 ` [PATCH v2 24/32] common/cnxk: fix inline device VF identification Nithin Dabilpuram
2023-05-24 10:04 ` [PATCH v2 29/32] common/cnxk: fix receive queue with multiple mask Nithin Dabilpuram
[not found] ` <20230525095904.3967080-1-ndabilpuram@marvell.com>
2023-05-25 9:58 ` [PATCH v3 03/32] common/cnxk: fix CPT backpressure disable on LBK Nithin Dabilpuram
2023-05-25 9:58 ` [PATCH v3 12/32] common/cnxk: fix null pointer dereference Nithin Dabilpuram
2023-05-25 9:58 ` [PATCH v3 13/32] common/cnxk: fix parameter in NIX dump Nithin Dabilpuram
2023-05-25 9:58 ` [PATCH v3 24/32] common/cnxk: fix inline device VF identification Nithin Dabilpuram
2023-05-25 9:59 ` [PATCH v3 29/32] common/cnxk: fix receive queue with multiple mask Nithin Dabilpuram
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).