From: Stephen Hemminger <stephen@networkplumber.org>
To: Kaijun Zeng <corezeng@gmail.com>
Cc: dev@dpdk.org, Ferruh Yigit <ferruh.yigit@amd.com>,
stable@dpdk.org, Jochen Behrens <jbehrens@vmware.com>,
Bruce Richardson <bruce.richardson@intel.com>
Subject: Re: [PATCH v2] net/vmxnet3: fix return code in initializing
Date: Tue, 6 Jun 2023 08:36:12 -0700 [thread overview]
Message-ID: <20230606083612.6ee181d4@hermes.local> (raw)
In-Reply-To: <20230602164438.45939-1-corezeng@gmail.com>
On Fri, 2 Jun 2023 12:44:38 -0400
Kaijun Zeng <corezeng@gmail.com> wrote:
> + PMD_INIT_LOG(ERR,
> + "ERROR: Zero descriptor requirement in Rx queue: %d,"
> + "buffers ring: %d\n",
> + i, j);
Please don't split messages across source lines, it makes harder for developers
to use tools to scan source for message.
Often, when message is long, it means that there is redundant information or poor wording.
For example, in your message "ERROR:" is redundant.
next prev parent reply other threads:[~2023-06-06 15:36 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20230528143734.145326-1-user@sklga>
2023-06-02 16:44 ` Kaijun Zeng
2023-06-06 9:08 ` Ferruh Yigit
2023-06-06 15:36 ` Stephen Hemminger [this message]
2023-06-07 15:49 ` Ferruh Yigit
2023-06-07 17:57 ` [PATCH v3] " Kaijun Zeng
2023-06-09 18:08 ` Ferruh Yigit
2023-06-07 16:54 ` [PATCH] " Kaijun Zeng
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230606083612.6ee181d4@hermes.local \
--to=stephen@networkplumber.org \
--cc=bruce.richardson@intel.com \
--cc=corezeng@gmail.com \
--cc=dev@dpdk.org \
--cc=ferruh.yigit@amd.com \
--cc=jbehrens@vmware.com \
--cc=stable@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).