From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 653AC42CC2 for ; Thu, 15 Jun 2023 08:52:03 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 5BE0042D0B; Thu, 15 Jun 2023 08:52:03 +0200 (CEST) Received: from NAM11-DM6-obe.outbound.protection.outlook.com (mail-dm6nam11on2133.outbound.protection.outlook.com [40.107.223.133]) by mails.dpdk.org (Postfix) with ESMTP id C3BDB40DDA; Thu, 15 Jun 2023 08:51:59 +0200 (CEST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=hxaxDe6gxP19Qeb8M5so0t3nGan3uTOIbZGN89UogiXjOaH7sSyoCkioyIxgkTtTMyooT2yc2T+d4/nQmdAAn+wPcg5ruIHxpjpwbu3Ikrt8vUWaSlJsWO5DQMF6Lha1dHtihbTSRE5PZsJ2pCdTJ0zI30Ahg3gWTvQUQi2ap33GQbkI8AsTSAK+tL2ARkBt8tE0zvl2mLa+wjb9qOMGNUTEeTpGHTkI9XYUP+gaS1NqOIdW0Fo5xLa8EZbj3IMBMUe2w5Afa9KNR5o0Cv+8sSwmBdAdOYialSWtSa5JJ2/GFjqpSFU794P7Aupd3FRA3bJHnYV2PFullaMaxDyjew== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=g/+5FfXkkR0RK2KFiQbqJvEllWO6AmFT2dhUghE948c=; b=BPl8tZPaU1esKd3NniK5b8fVqo+JmBbVW8BRtjpHVLHr4FCVmiXIFNgLjSTYJuQO7wi2vnmBkHbAKy3lXx4frwgTHdyMSeD2zG3n4bm3VJFksEeS3Vs4aTvijAJOU+EXdvxiNdR/40K4Ru8+ElSlNOo6n4y/kfUnIkwYhEcnXT06j7G3p0xfisXWpI7R+NQJL6046dyii/GArwt2+9bi3d2sR3DEsBhnzLK3w5W6npqG5PhOd5Fbm4zCAiKjafX2CUh8foDUqENhrZaw5hnrQNa5zGd7hGMlAbu1MdmQLBObVeRWTCmE/Uz8lN4us/MLLxnZxxBPXuHwjuAarlJlbA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=corigine.com; dmarc=pass action=none header.from=corigine.com; dkim=pass header.d=corigine.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=corigine.onmicrosoft.com; s=selector2-corigine-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=g/+5FfXkkR0RK2KFiQbqJvEllWO6AmFT2dhUghE948c=; b=N6lmD/S0xPQ4oTWOc8Fu0WzlikkFmyNOGmE/fO4nJoGDrzYMk+B9Kqm6vGH11kfpqeWJ91xrS084ytexqrmyseZlAthxv6qxf9zssEzTtgp6yJ29PVGTC8Ez6j41T8s+C+3//CqkULJi/hCwwo0WlN9lo0h0D/LxFmw6Te0Ajk0= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=corigine.com; Received: from SJ0PR13MB5545.namprd13.prod.outlook.com (2603:10b6:a03:424::5) by PH0PR13MB5422.namprd13.prod.outlook.com (2603:10b6:510:128::22) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6477.29; Thu, 15 Jun 2023 06:51:58 +0000 Received: from SJ0PR13MB5545.namprd13.prod.outlook.com ([fe80::d2cb:a650:e1ce:2174]) by SJ0PR13MB5545.namprd13.prod.outlook.com ([fe80::d2cb:a650:e1ce:2174%3]) with mapi id 15.20.6455.045; Thu, 15 Jun 2023 06:51:58 +0000 From: Chaoyong He To: dev@dpdk.org Cc: oss-drivers@corigine.com, niklas.soderlund@corigine.com, Long Wu , stable@dpdk.org, Chaoyong He Subject: [PATCH 1/2] net/nfp: fix representor name too long Date: Thu, 15 Jun 2023 14:51:30 +0800 Message-Id: <20230615065131.1267711-2-chaoyong.he@corigine.com> X-Mailer: git-send-email 2.39.1 In-Reply-To: <20230615065131.1267711-1-chaoyong.he@corigine.com> References: <20230615065131.1267711-1-chaoyong.he@corigine.com> Content-Transfer-Encoding: 8bit Content-Type: text/plain X-ClientProxiedBy: SG2PR01CA0145.apcprd01.prod.exchangelabs.com (2603:1096:4:8f::25) To SJ0PR13MB5545.namprd13.prod.outlook.com (2603:10b6:a03:424::5) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: SJ0PR13MB5545:EE_|PH0PR13MB5422:EE_ X-MS-Office365-Filtering-Correlation-Id: b1f4d943-5b8e-4ca7-456e-08db6d6d03c3 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: uIvyV2Kv9ok+UDfHyZ53x/RogbKhUn107//GEqvYRDU7DBafL+ayTPKSrCdnUK9tyactPnA/KS/pnmTlfntOzRgZI9VBVU8Ff0dWVmr3k/lom8rPOs9tAptrySjS4TCUn6VxIwFRn+/zHaM1+xcUsjJRV7dv+i9jHg3u/QNUH4rfxTJiS3C9aYN1E4b8qEEueb4g+ICIahLZo0/USMHOfRBVSho1K0eI5ypaaMHs1l4NGwQD6Gq2x3LdvrjLL8AkWN8IPUp+CvUKPEUkD32kGA7AgEDrfe+SoTdhZt5MCb4fVxpcZsCWgjbFG2SlOOn3KkxkklU6nvLBdXETnHjTGRGwX9rO8ZJVpdEuRHirl1e+hn8IV/5+i7nG+Xy9xR+3067YmcPPFcpVuLWoTePKFhVKAZ8IU4oLfRuU0bktqm69bdDA4NGeeiMmlIqmG2yDVaKnesgxr508VqE55CSjm9qevnnl/5loSPiqc7oKi2Tphbt61O9trjIuXp3/UZZBcZFkF+wCOlqFjGtD8VkGZBRkooyVrQE3H7w/B3ps1PRnPX+sFCaAZqdMOUgRpxUsNoE/RNLV4cPg8+3lPu0yp915xkGsLqcfORsq9xIgI+B2Tpp+5/uQrgFxcwGMJS55 X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:SJ0PR13MB5545.namprd13.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230028)(4636009)(396003)(376002)(366004)(39840400004)(346002)(136003)(451199021)(66476007)(316002)(38100700002)(66556008)(2616005)(66946007)(26005)(6916009)(6512007)(6506007)(6486002)(478600001)(52116002)(36756003)(6666004)(86362001)(54906003)(1076003)(107886003)(4326008)(38350700002)(450100002)(186003)(41300700001)(8936002)(2906002)(5660300002)(44832011)(83380400001)(8676002); DIR:OUT; SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?C7gRo2r1iRGvUo0zrXXGPmHeDjD06S79N6nw4UPPwhUq0UgHonZf+NoGatxk?= =?us-ascii?Q?64ZT/RYDWwW4na0JgaBuX7PFXtQvYALe9DazAPOd9JDEmg6xzaLx5LdnYgSe?= =?us-ascii?Q?2EIdwODZx/hQogs/zUJ/JHLbg7nSJu5QDBiUuVO9CPVwPHFreegx2+e2ZjN5?= =?us-ascii?Q?7iuNjk2c5H+G+ynoTBswUwAU99P1TzQJUufcnEmbVDHOe8fEF9DTKDtlhnqz?= =?us-ascii?Q?7qLcQPqxqjQnk14HquK/z2VCx/IYG2br2czH4AjVEdxP1GSTEG2qXfNriAnH?= =?us-ascii?Q?TNT8py0w8jSTaxrEmUklt/c1esIYBdIA2RsZTOwBS6VUqzoo9Jtle0M+37N2?= =?us-ascii?Q?e3fgE7qX4ageoakyw29G6gfKVs57QTlUMri0w2+QTlVNcUBJ3YIuS8M8uLFh?= =?us-ascii?Q?B+oEJUOj/V2HAXcDV/V+RPl9VFexyXhYqeCCknjL4j8/g8DRtYcgpi3jOXsI?= =?us-ascii?Q?JPbbxfI1jtH7nZ2yh8u/0CuLDKjAT9rJbMOGYrH0AKU2RvkMqT7sx+atsQUW?= =?us-ascii?Q?jQR2hoGLxpLLd2DIwTM7aYwIJipSnn1G+VjLM0VajUoyvIpKeQApIVarmzNA?= =?us-ascii?Q?aReoqfaZyg+ToeUOKlpo2iujnrOqPNPG/9yAVg/6FFe2mO0Qv36zeH3H8veq?= =?us-ascii?Q?PPKc3SXgmKRuXx9vge9vuQbXPjirylqQ+7LeAqnmYeDNS+/3QNHo6ei8LGdk?= =?us-ascii?Q?c/PKhz+UYa7pOX26m6L1VDLQowvwAlTj9QUYSN483+uxmsKyd0aYF2Ui4ZDA?= =?us-ascii?Q?LwzQcfj5lhJ8UJaWWNV+k0uIJ6FowekBFKxlL77j6ps3ng/hsg1DY40Y7NZ8?= =?us-ascii?Q?AfU3U6x7fQhOhAWt+uSBcOYwwjUoeo5xhmfrNKEy+Ih4v+ac3lylKHB6s3Pc?= =?us-ascii?Q?HVz4Ha3n9WYtYTa6G6K/bm9jlxdSFxH6bg1HZ2R5RUgBzWDmaqpJMA0dz0/g?= =?us-ascii?Q?q8ZDPaFlqYBEQ8/TZewIR+7ETgncb1rAdTfKbe+UmD1Vi5+msePb7BRItmmz?= =?us-ascii?Q?P4lZLnnFCoDzsgqF06QTl1a2uyH/kvwNhPESOmbXOpCCau4SkET29TLxHaCL?= =?us-ascii?Q?P5I9fw+qBUz+lbo8eiHkCzo3BkNiT8HHRXwMAp54nK8hOd5SlaHEKe/4SNAT?= =?us-ascii?Q?kgQaVIfpv3FBMaV6zcr/2j5RN1OgX7/5HPXtU9+wrfSKGmg/iakd/U+vIy4F?= =?us-ascii?Q?o87SAS1PzV0ajqOPG+CHf46bJKohOViDZqmgOEuI3kd7JTjlIFlKyKMCsKVL?= =?us-ascii?Q?x8F8pC5k6J718nZ6CURZbLZ0FLKhsWcIFpaZ6Tsquy382YM/ayBtt5tJj3ke?= =?us-ascii?Q?6JX8zIA9x9qmsC914OKBzHnxMkTHliJQNmB7NYfR4pSBLgtsECZ6ZjtWuwvO?= =?us-ascii?Q?YC21TiMZ/+w2yjka0RLxC4W35+LzAT3kNafZO4KITt2oOqljPRT18ECSt18J?= =?us-ascii?Q?ob60dXLgJlLfIvD+4PESwh4tdsb5sLoJ9DqBB5DrdPVDRc86O/uWqNY00MMR?= =?us-ascii?Q?VLrl6gtY2QJYPW0lstghozWwpKgMjuVwgsHH5iIPI7BuQkRF7Jao+yJlAMEW?= =?us-ascii?Q?Du0FSRYHw6eM0APAGD8smDGXYzF4Fl0vePY4rf7BklIaMijBiZ3+K4A6EYBw?= =?us-ascii?Q?+w=3D=3D?= X-OriginatorOrg: corigine.com X-MS-Exchange-CrossTenant-Network-Message-Id: b1f4d943-5b8e-4ca7-456e-08db6d6d03c3 X-MS-Exchange-CrossTenant-AuthSource: SJ0PR13MB5545.namprd13.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 15 Jun 2023 06:51:58.7656 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: fe128f2c-073b-4c20-818e-7246a585940c X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: 1MR7lRBSK9c6BTe9SQPULQ5mkME2pCEFSk08fsrNQT0Fc2kakij05vfABmzdTvPPqQja1eyXltM+2dEUc9BDBFNvrwXNfIhBGXBeRWCMV64= X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH0PR13MB5422 X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org From: Long Wu The length of representor name may exceed the limit when we use it to create rte_ring, so we reduce the length of its name. For example: old: 0000:af:00.0_fl_repr_p1 new: af:00.0_repr_p1 Fixes: 2003cb447aa5 ("net/nfp: fix representor creation") Cc: stable@dpdk.org Signed-off-by: Long Wu Reviewed-by: Chaoyong He --- drivers/net/nfp/flower/nfp_flower_representor.c | 13 ++++++++----- 1 file changed, 8 insertions(+), 5 deletions(-) diff --git a/drivers/net/nfp/flower/nfp_flower_representor.c b/drivers/net/nfp/flower/nfp_flower_representor.c index 5118c9c57c..5585e1ed9e 100644 --- a/drivers/net/nfp/flower/nfp_flower_representor.c +++ b/drivers/net/nfp/flower/nfp_flower_representor.c @@ -723,8 +723,9 @@ nfp_flower_repr_alloc(struct nfp_app_fw_flower *app_fw_flower) { int i; int ret; - struct rte_device *device; + const char *pci_name; struct rte_eth_dev *eth_dev; + struct rte_pci_device *pci_dev; struct nfp_eth_table *nfp_eth_table; struct nfp_eth_table_port *eth_port; struct nfp_flower_representor flower_repr = { @@ -748,10 +749,12 @@ nfp_flower_repr_alloc(struct nfp_app_fw_flower *app_fw_flower) /* PF vNIC reprs get a random MAC address */ rte_eth_random_addr(flower_repr.mac_addr.addr_bytes); - device = &app_fw_flower->pf_hw->pf_dev->pci_dev->device; + pci_dev = app_fw_flower->pf_hw->pf_dev->pci_dev; + + pci_name = strchr(pci_dev->name, ':') + 1; snprintf(flower_repr.name, sizeof(flower_repr.name), - "%s_flower_repr_pf", device->name); + "%s_repr_pf", pci_name); /* Create a eth_dev for this representor */ ret = rte_eth_dev_create(eth_dev->device, flower_repr.name, @@ -773,7 +776,7 @@ nfp_flower_repr_alloc(struct nfp_app_fw_flower *app_fw_flower) /* Copy the real mac of the interface to the representor struct */ rte_ether_addr_copy(ð_port->mac_addr, &flower_repr.mac_addr); snprintf(flower_repr.name, sizeof(flower_repr.name), - "%s_fl_repr_p%d", device->name, i); + "%s_repr_p%d", pci_name, i); /* * Create a eth_dev for this representor @@ -805,7 +808,7 @@ nfp_flower_repr_alloc(struct nfp_app_fw_flower *app_fw_flower) /* VF reprs get a random MAC address */ rte_eth_random_addr(flower_repr.mac_addr.addr_bytes); snprintf(flower_repr.name, sizeof(flower_repr.name), - "%s_fl_repr_vf%d", device->name, i); + "%s_repr_vf%d", pci_name, i); /* This will also allocate private memory for the device*/ ret = rte_eth_dev_create(eth_dev->device, flower_repr.name, -- 2.39.1