From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 703D942D46 for ; Sun, 25 Jun 2023 08:37:50 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 678ED42BDA; Sun, 25 Jun 2023 08:37:50 +0200 (CEST) Received: from NAM11-BN8-obe.outbound.protection.outlook.com (mail-bn8nam11on2041.outbound.protection.outlook.com [40.107.236.41]) by mails.dpdk.org (Postfix) with ESMTP id 5E6CB40A7F for ; Sun, 25 Jun 2023 08:37:49 +0200 (CEST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=HNnHJuvnqu7mLWQ7fTH4tHzis7+jWk+n+BnOrtneEttNXQ+6by5u2GMVJIMLmaReIpQ7V6bQT7GDnDbpHIj+MqFgfE5Crt9OhqAa87vtZu8Amgnv0QInJmY5GgdQ94OfeU3oLIyNY1EvEj0v8+5WABZAAcOui25ZQgc/5JggxNRM9TTaruBs2jRr5QRtifUWfsvNmMlpd3L1ify0WT6UH+bzELOGnEq6y+pEo/aKEWLh6bhLhPAvnoz7b6c40qbGfrhhi2Anhba5ofnlbUgFx53vKLavBKcvGk2iZxyYHB3h1Kh7eBya2fHVmNw9MLiUEYhTOXivNsI1H0QyO6AXug== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=W8aHJekhGbW2Dc/spCJEqBIrB5rYcnCM6iLkjeWtVl0=; b=n9lGwUd2CaRzIx3IN8egXZowzNIVNsjoYKQY2PFz108iX8hkZbilbpZnLw78PcpRgbXI8BHvh6z4wqf8vmvctGy8FeHxn4SZ1LqOipGCA4ttRgflyR3xYWH18golJCmYQSEodDJ8c7isKk0kzRs9vFHVO7ca5BSWAc6KCe7fM+rj7Oj6HUIeCn7Ndqat+jElr2i41dBQfYa4kP9DqAPTYij8VWjqH4yBTh5g9+WI4DjcEvlKtlgNIJ3n0v6f30xpHtK4DZzyIosGkAHNu67tzZMzePzeR1LczEYbbxnVKuTQVVU85G4T7YoVMeuwyrHR6XxOrPiYgjoCH0rrx3iwEA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 216.228.117.160) smtp.rcpttodomain=intel.com smtp.mailfrom=nvidia.com; dmarc=pass (p=reject sp=reject pct=100) action=none header.from=nvidia.com; dkim=none (message not signed); arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=W8aHJekhGbW2Dc/spCJEqBIrB5rYcnCM6iLkjeWtVl0=; b=Ad0CDfqkQrZ3cwAM+RXN4Bp0K6BSuAaltLkjO7TFckewb3go6yjZPKFYkxTGkS2cUQb8O96cm3G2ZQLzCmWvIlmwqUX+znoBE5TdE/1cRYkJ9a+ltIHAoOMq99MOeVyCSJWjlY8UjeBe+rjNcLCjD+1cJwyH2mQ8VvfBS/1MExE0Y83fCkSr0Ka7qGAInEXU3yuqyl+InU9XqrgqOCcG8L1mB5ozqRKO9/vw8ZDdOJ+Nt+KTg3Z4zLGo6mFh0vO2eE6m0o6YYgfezYCvHbmnqO8DglDGvkmfr86/30LJaNLdc0jlPaXT+RqqxhvF61oPjGHIp3qo0jkdZ9gLVtPhIQ== Received: from BN9P222CA0011.NAMP222.PROD.OUTLOOK.COM (2603:10b6:408:10c::16) by PH7PR12MB5806.namprd12.prod.outlook.com (2603:10b6:510:1d2::10) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6521.23; Sun, 25 Jun 2023 06:37:47 +0000 Received: from BN8NAM11FT042.eop-nam11.prod.protection.outlook.com (2603:10b6:408:10c:cafe::46) by BN9P222CA0011.outlook.office365.com (2603:10b6:408:10c::16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6521.33 via Frontend Transport; Sun, 25 Jun 2023 06:37:47 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 216.228.117.160) smtp.mailfrom=nvidia.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=nvidia.com; Received-SPF: Pass (protection.outlook.com: domain of nvidia.com designates 216.228.117.160 as permitted sender) receiver=protection.outlook.com; client-ip=216.228.117.160; helo=mail.nvidia.com; pr=C Received: from mail.nvidia.com (216.228.117.160) by BN8NAM11FT042.mail.protection.outlook.com (10.13.177.85) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6500.47 via Frontend Transport; Sun, 25 Jun 2023 06:37:46 +0000 Received: from rnnvmail201.nvidia.com (10.129.68.8) by mail.nvidia.com (10.129.200.66) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.986.5; Sat, 24 Jun 2023 23:37:29 -0700 Received: from nvidia.com (10.126.230.35) by rnnvmail201.nvidia.com (10.129.68.8) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.986.37; Sat, 24 Jun 2023 23:37:27 -0700 From: Xueming Li To: Leyi Rong CC: =?UTF-8?q?Morten=20Br=C3=B8rup?= , "Bruce Richardson" , David Marchand , dpdk stable Subject: patch 'eal/x86: improve multiple of 64 bytes memcpy performance' has been queued to stable release 22.11.3 Date: Sun, 25 Jun 2023 14:33:55 +0800 Message-ID: <20230625063544.11183-18-xuemingl@nvidia.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20230625063544.11183-1-xuemingl@nvidia.com> References: <20230625063544.11183-1-xuemingl@nvidia.com> MIME-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit X-Originating-IP: [10.126.230.35] X-ClientProxiedBy: rnnvmail202.nvidia.com (10.129.68.7) To rnnvmail201.nvidia.com (10.129.68.8) X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: BN8NAM11FT042:EE_|PH7PR12MB5806:EE_ X-MS-Office365-Filtering-Correlation-Id: 7adcde6d-4b61-40f4-fabe-08db7546b00b X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: 0Ipts2KRZlIVG5CvvZHFOqcqVn93XdNgY/dT+ck8/nnVd0eBviYzgNzF3rOyWhjwBHb1HIaGz9w0qi9Bh9krYLFPXoFVtIZ9DbmNBourmh4MkXEaJJnxpnr7XQaIDikvj2RBqONTKeu4KUdlDk+dXZgyGt1+Zn1NzcCi4wYKxLkCcj2liwqUTTSXnWkeU6xy1f2+Yr1EYduLQWZA1hDWIHWEyUwN931FGCcQevt8dl8xIlqrwtEqjWKt35Wpmilbxputzw3q03YCoH3j0VFHp8JTesyyMYAi6ecJV1HoN+WsDo4u3F69h8COnalXwrw0tMb9zhKigpewicQPoH8p4M/4VzeTYX/wmLURZ9NLTtxMgMC9Ow10mAU7wYOshlXi8ZfgSvVZK3qYqi8tbMvGvXN0JlXGZ3Lq5TWQTWCEJz60iAgjcg37MB7HZ/pAamNmWqMCJoUhwKef7YfCfubNFCbfoH56oumz0wqKkw9fcm7wdbZPxdh7X2zh6bwtYG7j1Vtx3KRFyP4KnYndOytgwXToUL7RsJU+ULDISJd8zN3Px6RutIxEcPMPZkKHCHlOHyh7otYfIIiUmLo8vlhsWFvRWC82s4xbLculwwe/2UsELHTF81LYAX0eMrMtu6R1qVMRA/68xw0KKgWVv9W2VGtgLtkBY8lcKEjov1BOY57VbgRfuSjwpULucdjCEqv9VfxcFWOOSCW0TzPbpc+zpaJfDoZsrPq2eLu8shdL5BfrvxrA8ARHI0Y1sgvVwqzaSTDj9bTG99e4gnfGpOkEUw== X-Forefront-Antispam-Report: CIP:216.228.117.160; CTRY:US; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:mail.nvidia.com; PTR:dc6edge1.nvidia.com; CAT:NONE; SFS:(13230028)(4636009)(376002)(136003)(396003)(39860400002)(346002)(451199021)(40470700004)(46966006)(36840700001)(8936002)(8676002)(55016003)(4326008)(6916009)(70206006)(70586007)(41300700001)(316002)(53546011)(1076003)(16526019)(26005)(186003)(6286002)(336012)(426003)(2616005)(478600001)(54906003)(6666004)(40460700003)(966005)(7696005)(82310400005)(2906002)(5660300002)(40480700001)(82740400003)(356005)(7636003)(36756003)(86362001)(36860700001)(47076005)(66574015)(83380400001); DIR:OUT; SFP:1101; X-OriginatorOrg: Nvidia.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 25 Jun 2023 06:37:46.2761 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 7adcde6d-4b61-40f4-fabe-08db7546b00b X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=43083d15-7273-40c1-b7db-39efd9ccc17a; Ip=[216.228.117.160]; Helo=[mail.nvidia.com] X-MS-Exchange-CrossTenant-AuthSource: BN8NAM11FT042.eop-nam11.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH7PR12MB5806 X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org Hi, FYI, your patch has been queued to stable release 22.11.3 Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet. It will be pushed if I get no objections before 06/27/23. So please shout if anyone has objections. Also note that after the patch there's a diff of the upstream commit vs the patch applied to the branch. This will indicate if there was any rebasing needed to apply to the stable branch. If there were code changes for rebasing (ie: not only metadata diffs), please double check that the rebase was correctly done. Queued patches are on a temporary branch at: https://git.dpdk.org/dpdk-stable/log/?h=22.11-staging This queued commit can be viewed at: https://git.dpdk.org/dpdk-stable/commit/?h=22.11-staging&id=5ecf2e459d480631a3dbe7b77157ace8cef76b33 Thanks. Xueming Li --- >From 5ecf2e459d480631a3dbe7b77157ace8cef76b33 Mon Sep 17 00:00:00 2001 From: Leyi Rong Date: Wed, 29 Mar 2023 17:16:58 +0800 Subject: [PATCH] eal/x86: improve multiple of 64 bytes memcpy performance MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Cc: Xueming Li [ upstream commit 2ef17be88e8b26f871cfb0265227341e36f486ea ] In rte_memcpy_aligned(), one redundant round is taken in the 64 bytes block copy loops if the size is a multiple of 64. So, let the catch-up copy the last 64 bytes in this case. Fixes: f5472703c0bd ("eal: optimize aligned memcpy on x86") Suggested-by: Morten Brørup Signed-off-by: Leyi Rong Reviewed-by: Morten Brørup Acked-by: Bruce Richardson Reviewed-by: David Marchand --- lib/eal/x86/include/rte_memcpy.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/lib/eal/x86/include/rte_memcpy.h b/lib/eal/x86/include/rte_memcpy.h index d4d7a5cfc8..fd151be708 100644 --- a/lib/eal/x86/include/rte_memcpy.h +++ b/lib/eal/x86/include/rte_memcpy.h @@ -846,7 +846,7 @@ rte_memcpy_aligned(void *dst, const void *src, size_t n) } /* Copy 64 bytes blocks */ - for (; n >= 64; n -= 64) { + for (; n > 64; n -= 64) { rte_mov64((uint8_t *)dst, (const uint8_t *)src); dst = (uint8_t *)dst + 64; src = (const uint8_t *)src + 64; -- 2.25.1 --- Diff of the applied patch vs upstream commit (please double-check if non-empty: --- --- - 2023-06-25 14:31:59.018237100 +0800 +++ 0017-eal-x86-improve-multiple-of-64-bytes-memcpy-performa.patch 2023-06-25 14:31:58.295773900 +0800 @@ -1 +1 @@ -From 2ef17be88e8b26f871cfb0265227341e36f486ea Mon Sep 17 00:00:00 2001 +From 5ecf2e459d480631a3dbe7b77157ace8cef76b33 Mon Sep 17 00:00:00 2001 @@ -7,0 +8,3 @@ +Cc: Xueming Li + +[ upstream commit 2ef17be88e8b26f871cfb0265227341e36f486ea ]