From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id C192542D46 for ; Sun, 25 Jun 2023 08:38:51 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id BC19040ED8; Sun, 25 Jun 2023 08:38:51 +0200 (CEST) Received: from NAM10-BN7-obe.outbound.protection.outlook.com (mail-bn7nam10on2041.outbound.protection.outlook.com [40.107.92.41]) by mails.dpdk.org (Postfix) with ESMTP id 10BFE40A7F for ; Sun, 25 Jun 2023 08:38:50 +0200 (CEST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Ls2Pren0jFWb1IUyvkz3h0Rfvev8IlwSZL0njv9Gtfx8yCiedPPN/f3cP+WXnUn6X4lbzngYxC56alEgC+u85sC2rUU11u+MbV13iBRtioxSOa5h0mSuJY26AJ9KSZjH0J/VS0g3ggdUdpndAhKeg9hFUpVWX7B3DPPR6LCRqlivxEWz3GBbss7IgkImsuG49Rau9ixkjQPyoC+fKXcjAo+Zi9uxfiK8L0lW4i/nnAlJQHDkS86BHCTk+CAIoGaKBAoBp9mLbH/dqnOwm+h7CoM2mjNvUbFwGjhqZZKpRvfLkWWdrvYZyjj62Mae9/VDFA/2NcVW8BT+BMGqUGwJGQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=f/3UQAGXpsfhdsT8YSWX3mhtHGoooM/KrfFGMO4Qcnw=; b=OVGoHnV7FSh0AvbRuIg+wT5dcJd/90ka8B3J1zukkPFLaXz2FPUqwjpyC6/DrIXo8STkZF+WveD/A3EoMvbtXJ0tFt1qyc4dNdho5C9EMzNs1wxW4hZSqYrUvWojeOTgURcTpYp0COGTwQQ7IBdNtCX4Yp7eQOSt3zeSXBY6dsV8Tfg5ld05pbuU4Vd0bO2Vh6cl/3GRlpk49Ts4agSRGUPvooh4jVQ726xaUYYclKJeEDc/sz6Sf/TxGt+tGHLjipivjbcpVjb0XFppE8e/2O9fXHXRjwG5gsUzouCblgBwjZQjzsRWsdTZc97XX9o1TtZQ/9zFVqI561ytSvg5tg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 216.228.117.160) smtp.rcpttodomain=microsoft.com smtp.mailfrom=nvidia.com; dmarc=pass (p=reject sp=reject pct=100) action=none header.from=nvidia.com; dkim=none (message not signed); arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=f/3UQAGXpsfhdsT8YSWX3mhtHGoooM/KrfFGMO4Qcnw=; b=UssVog/BVQcRdd/eOsX3RHDIornpAySTlgqya6jw78OBU8EVsUAHd/v6Dyb1Z0QrKw3ZWiH36RWtbbTirUIUpp6I3KWiwDHcFcJHh4DAPWcJ8IF+efICJDtVJNj+CUF4+7waEsbgNrtQqbzN6MumCm1RtN30F2N/aduMqM1GumiY1I68+P59TIZfkIe3IE0wz7gMYfCpgUejqWB6tbZN4vFm13AETxjRQ4k9K4QPNbdYXu8QP4kUIU5QfmazSaO+xoBtEGmZjYRPRB21rHYqS39bYHE+Fs6rz6QWnhxAZEJvd4pSiIEq2ukHMdrzdHzs4uUjrKASUPywGbLqtkvfmQ== Received: from BN0PR03CA0015.namprd03.prod.outlook.com (2603:10b6:408:e6::20) by DS7PR12MB5864.namprd12.prod.outlook.com (2603:10b6:8:7b::18) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6521.23; Sun, 25 Jun 2023 06:38:48 +0000 Received: from BN8NAM11FT036.eop-nam11.prod.protection.outlook.com (2603:10b6:408:e6:cafe::2e) by BN0PR03CA0015.outlook.office365.com (2603:10b6:408:e6::20) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6521.33 via Frontend Transport; Sun, 25 Jun 2023 06:38:48 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 216.228.117.160) smtp.mailfrom=nvidia.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=nvidia.com; Received-SPF: Pass (protection.outlook.com: domain of nvidia.com designates 216.228.117.160 as permitted sender) receiver=protection.outlook.com; client-ip=216.228.117.160; helo=mail.nvidia.com; pr=C Received: from mail.nvidia.com (216.228.117.160) by BN8NAM11FT036.mail.protection.outlook.com (10.13.177.168) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6500.47 via Frontend Transport; Sun, 25 Jun 2023 06:38:47 +0000 Received: from rnnvmail201.nvidia.com (10.129.68.8) by mail.nvidia.com (10.129.200.66) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.986.5; Sat, 24 Jun 2023 23:38:42 -0700 Received: from nvidia.com (10.126.230.35) by rnnvmail201.nvidia.com (10.129.68.8) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.986.37; Sat, 24 Jun 2023 23:38:41 -0700 From: Xueming Li To: Long Li CC: dpdk stable Subject: patch 'net/mana: avoid unnecessary assignments in data path' has been queued to stable release 22.11.3 Date: Sun, 25 Jun 2023 14:34:08 +0800 Message-ID: <20230625063544.11183-31-xuemingl@nvidia.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20230625063544.11183-1-xuemingl@nvidia.com> References: <20230625063544.11183-1-xuemingl@nvidia.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Type: text/plain X-Originating-IP: [10.126.230.35] X-ClientProxiedBy: rnnvmail202.nvidia.com (10.129.68.7) To rnnvmail201.nvidia.com (10.129.68.8) X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: BN8NAM11FT036:EE_|DS7PR12MB5864:EE_ X-MS-Office365-Filtering-Correlation-Id: dd3007b6-44d7-4769-0799-08db7546d4ce X-LD-Processed: 43083d15-7273-40c1-b7db-39efd9ccc17a,ExtAddr X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: DhBO0pPjYzhqPmHITkBKpDhz+zBueuQFKb2uA3S8QJC6+EwHHrI6MFSMpadkMsd9cG0/RaNMSlFDvb+K9ZKtWJM6Q6/TI+917cjzPoi+PXdCbthg31mZu/PQ+k9JC4A2Xa8QBsv8MUZIS29LLiTs1Sr+5/ItmflCtEV2odWSsd+NrmZmUStt/pvnl2eBzuuV4I0QQN1arjRSfF6JOK8jofNKR1wdcbYF4Lh71JVR8x9834ufexRhjxI6Iy9pv8iQgYOVxQTLsqZUDtKfNVAQhkryJeY9GNObyuMP+FSh45pLWVukgHpg9oouCR404ybEOyH4mrbobXoRvZrG19lhqTIQzryZaUlA3fQrZCRyQgZIZGgS10DfFJ0qD/ApJh+EMDqhdA4PA4IHDj7F9THsgoMfSbK22Uy2ZSYY4Rp32GoNlcCWhbAjuTE4UYHXkb9XgRcgNYKED63uQkc6BFcg+Sag11MVMIiOy2GfaWZ2Ucs0T2dhEcRBsIpcY4IasdNKof+Uxp3Bqj94DDi15jt3pWjYSOlu90j+KY+8YJqq4JCJWPxmSkwZeRTaLUD59WfPa8RcGzcqOBgQImpzxz9wv53jiIc4Vy3PxGzdIb4Uu52Zntou8/qjKa/pZF5zGdiUu0DsDg+SZKQq2TXlWrO3w56Qwv4KQvvBxOsQceNkeTiDxkOPcY/u+q5ixHtEiAveoWbo8q1BwtfP2CzAktxi4c1eI9/La6CcIdkh3MMKtrsE4UsV+qXehVVFVXpgwC/XbLLNGvG5sZbc6exEJMBgbA== X-Forefront-Antispam-Report: CIP:216.228.117.160; CTRY:US; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:mail.nvidia.com; PTR:dc6edge1.nvidia.com; CAT:NONE; SFS:(13230028)(4636009)(39860400002)(346002)(376002)(136003)(396003)(451199021)(36840700001)(40470700004)(46966006)(40480700001)(82310400005)(186003)(16526019)(6286002)(26005)(45080400002)(2616005)(1076003)(336012)(426003)(83380400001)(53546011)(41300700001)(40460700003)(8676002)(8936002)(5660300002)(2906002)(55016003)(82740400003)(7636003)(6916009)(478600001)(316002)(36756003)(86362001)(356005)(70586007)(47076005)(70206006)(6666004)(966005)(4326008)(7696005)(36860700001); DIR:OUT; SFP:1101; X-OriginatorOrg: Nvidia.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 25 Jun 2023 06:38:47.9458 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: dd3007b6-44d7-4769-0799-08db7546d4ce X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=43083d15-7273-40c1-b7db-39efd9ccc17a; Ip=[216.228.117.160]; Helo=[mail.nvidia.com] X-MS-Exchange-CrossTenant-AuthSource: BN8NAM11FT036.eop-nam11.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: DS7PR12MB5864 X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org Hi, FYI, your patch has been queued to stable release 22.11.3 Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet. It will be pushed if I get no objections before 06/27/23. So please shout if anyone has objections. Also note that after the patch there's a diff of the upstream commit vs the patch applied to the branch. This will indicate if there was any rebasing needed to apply to the stable branch. If there were code changes for rebasing (ie: not only metadata diffs), please double check that the rebase was correctly done. Queued patches are on a temporary branch at: https://git.dpdk.org/dpdk-stable/log/?h=22.11-staging This queued commit can be viewed at: https://git.dpdk.org/dpdk-stable/commit/?h=22.11-staging&id=5b1a78987f11be0d44d658feac20e72d5b517869 Thanks. Xueming Li --- >From 5b1a78987f11be0d44d658feac20e72d5b517869 Mon Sep 17 00:00:00 2001 From: Long Li Date: Fri, 17 Mar 2023 16:32:43 -0700 Subject: [PATCH] net/mana: avoid unnecessary assignments in data path Cc: Xueming Li [ upstream commit b5dfcaece13add5d874d805197856c8b8aa643ab ] Unnecessary assignments involve memset and waste CPU cycles. Removing them to reduce CPU usage. Fixes: 517ed6e2d590 ("net/mana: add basic driver with build environment") Signed-off-by: Long Li --- drivers/net/mana/gdma.c | 11 ++--------- drivers/net/mana/mana.h | 2 +- drivers/net/mana/rx.c | 9 ++++----- drivers/net/mana/tx.c | 17 ++++++++++------- 4 files changed, 17 insertions(+), 22 deletions(-) diff --git a/drivers/net/mana/gdma.c b/drivers/net/mana/gdma.c index f637084137..7d5bb08927 100644 --- a/drivers/net/mana/gdma.c +++ b/drivers/net/mana/gdma.c @@ -123,7 +123,7 @@ write_scatter_gather_list(uint8_t *work_queue_head_pointer, int gdma_post_work_request(struct mana_gdma_queue *queue, struct gdma_work_request *work_req, - struct gdma_posted_wqe_info *wqe_info) + uint32_t *wqe_size_in_bu) { uint32_t client_oob_size = work_req->inline_oob_size_in_bytes > @@ -149,14 +149,7 @@ gdma_post_work_request(struct mana_gdma_queue *queue, DP_LOG(DEBUG, "client_oob_size %u sgl_data_size %u wqe_size %u", client_oob_size, sgl_data_size, wqe_size); - if (wqe_info) { - wqe_info->wqe_index = - ((queue->head * GDMA_WQE_ALIGNMENT_UNIT_SIZE) & - (queue->size - 1)) / GDMA_WQE_ALIGNMENT_UNIT_SIZE; - wqe_info->unmasked_queue_offset = queue->head; - wqe_info->wqe_size_in_bu = - wqe_size / GDMA_WQE_ALIGNMENT_UNIT_SIZE; - } + *wqe_size_in_bu = wqe_size / GDMA_WQE_ALIGNMENT_UNIT_SIZE; wq_buffer_pointer = gdma_get_wqe_pointer(queue); wq_buffer_pointer += write_dma_client_oob(wq_buffer_pointer, work_req, diff --git a/drivers/net/mana/mana.h b/drivers/net/mana/mana.h index 7b8c27df2a..ce16e7efff 100644 --- a/drivers/net/mana/mana.h +++ b/drivers/net/mana/mana.h @@ -462,7 +462,7 @@ int mana_rq_ring_doorbell(struct mana_rxq *rxq, uint8_t arm); int gdma_post_work_request(struct mana_gdma_queue *queue, struct gdma_work_request *work_req, - struct gdma_posted_wqe_info *wqe_info); + uint32_t *wqe_size_in_bu); uint8_t *gdma_get_wqe_pointer(struct mana_gdma_queue *queue); uint16_t mana_rx_burst(void *dpdk_rxq, struct rte_mbuf **rx_pkts, diff --git a/drivers/net/mana/rx.c b/drivers/net/mana/rx.c index 10392ae292..afd153424b 100644 --- a/drivers/net/mana/rx.c +++ b/drivers/net/mana/rx.c @@ -52,8 +52,8 @@ mana_alloc_and_post_rx_wqe(struct mana_rxq *rxq) { struct rte_mbuf *mbuf = NULL; struct gdma_sgl_element sgl[1]; - struct gdma_work_request request = {0}; - struct gdma_posted_wqe_info wqe_info = {0}; + struct gdma_work_request request; + uint32_t wqe_size_in_bu; struct mana_priv *priv = rxq->priv; int ret; struct mana_mr_cache *mr; @@ -72,7 +72,6 @@ mana_alloc_and_post_rx_wqe(struct mana_rxq *rxq) } request.gdma_header.struct_size = sizeof(request); - wqe_info.gdma_header.struct_size = sizeof(wqe_info); sgl[0].address = rte_cpu_to_le_64(rte_pktmbuf_mtod(mbuf, uint64_t)); sgl[0].memory_key = mr->lkey; @@ -87,14 +86,14 @@ mana_alloc_and_post_rx_wqe(struct mana_rxq *rxq) request.flags = 0; request.client_data_unit = NOT_USING_CLIENT_DATA_UNIT; - ret = gdma_post_work_request(&rxq->gdma_rq, &request, &wqe_info); + ret = gdma_post_work_request(&rxq->gdma_rq, &request, &wqe_size_in_bu); if (!ret) { struct mana_rxq_desc *desc = &rxq->desc_ring[rxq->desc_ring_head]; /* update queue for tracking pending packets */ desc->pkt = mbuf; - desc->wqe_size_in_bu = wqe_info.wqe_size_in_bu; + desc->wqe_size_in_bu = wqe_size_in_bu; rxq->desc_ring_head = (rxq->desc_ring_head + 1) % rxq->num_desc; } else { DP_LOG(DEBUG, "failed to post recv ret %d", ret); diff --git a/drivers/net/mana/tx.c b/drivers/net/mana/tx.c index a45b5e289c..b593f98bb1 100644 --- a/drivers/net/mana/tx.c +++ b/drivers/net/mana/tx.c @@ -208,8 +208,8 @@ mana_tx_burst(void *dpdk_txq, struct rte_mbuf **tx_pkts, uint16_t nb_pkts) for (uint16_t pkt_idx = 0; pkt_idx < nb_pkts; pkt_idx++) { struct rte_mbuf *m_pkt = tx_pkts[pkt_idx]; struct rte_mbuf *m_seg = m_pkt; - struct transmit_oob_v2 tx_oob = {0}; - struct one_sgl sgl = {0}; + struct transmit_oob_v2 tx_oob; + struct one_sgl sgl; uint16_t seg_idx; /* Drop the packet if it exceeds max segments */ @@ -263,6 +263,8 @@ mana_tx_burst(void *dpdk_txq, struct rte_mbuf **tx_pkts, uint16_t nb_pkts) tx_oob.short_oob.tx_compute_TCP_checksum = 1; tx_oob.short_oob.tx_transport_header_offset = m_pkt->l2_len + m_pkt->l3_len; + } else { + tx_oob.short_oob.tx_compute_TCP_checksum = 0; } if ((m_pkt->ol_flags & RTE_MBUF_F_TX_L4_MASK) == @@ -301,6 +303,8 @@ mana_tx_burst(void *dpdk_txq, struct rte_mbuf **tx_pkts, uint16_t nb_pkts) } tx_oob.short_oob.tx_compute_UDP_checksum = 1; + } else { + tx_oob.short_oob.tx_compute_UDP_checksum = 0; } tx_oob.short_oob.suppress_tx_CQE_generation = 0; @@ -355,11 +359,10 @@ mana_tx_burst(void *dpdk_txq, struct rte_mbuf **tx_pkts, uint16_t nb_pkts) if (seg_idx != m_pkt->nb_segs) continue; - struct gdma_work_request work_req = {0}; - struct gdma_posted_wqe_info wqe_info = {0}; + struct gdma_work_request work_req; + uint32_t wqe_size_in_bu; work_req.gdma_header.struct_size = sizeof(work_req); - wqe_info.gdma_header.struct_size = sizeof(wqe_info); work_req.sgl = sgl.gdma_sgl; work_req.num_sgl_elements = m_pkt->nb_segs; @@ -370,14 +373,14 @@ mana_tx_burst(void *dpdk_txq, struct rte_mbuf **tx_pkts, uint16_t nb_pkts) work_req.client_data_unit = NOT_USING_CLIENT_DATA_UNIT; ret = gdma_post_work_request(&txq->gdma_sq, &work_req, - &wqe_info); + &wqe_size_in_bu); if (!ret) { struct mana_txq_desc *desc = &txq->desc_ring[txq->desc_ring_head]; /* Update queue for tracking pending requests */ desc->pkt = m_pkt; - desc->wqe_size_in_bu = wqe_info.wqe_size_in_bu; + desc->wqe_size_in_bu = wqe_size_in_bu; txq->desc_ring_head = (txq->desc_ring_head + 1) % txq->num_desc; -- 2.25.1 --- Diff of the applied patch vs upstream commit (please double-check if non-empty: --- --- - 2023-06-25 14:31:59.337143500 +0800 +++ 0030-net-mana-avoid-unnecessary-assignments-in-data-path.patch 2023-06-25 14:31:58.315773900 +0800 @@ -1 +1 @@ -From b5dfcaece13add5d874d805197856c8b8aa643ab Mon Sep 17 00:00:00 2001 +From 5b1a78987f11be0d44d658feac20e72d5b517869 Mon Sep 17 00:00:00 2001 @@ -4,0 +5,3 @@ +Cc: Xueming Li + +[ upstream commit b5dfcaece13add5d874d805197856c8b8aa643ab ] @@ -10 +12,0 @@ -Cc: stable@dpdk.org