From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 10E1642D46 for ; Sun, 25 Jun 2023 08:39:53 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 0CAFB410ED; Sun, 25 Jun 2023 08:39:53 +0200 (CEST) Received: from NAM02-SN1-obe.outbound.protection.outlook.com (mail-sn1nam02on2080.outbound.protection.outlook.com [40.107.96.80]) by mails.dpdk.org (Postfix) with ESMTP id BF37140A7F for ; Sun, 25 Jun 2023 08:39:51 +0200 (CEST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Wc0sExRTLJpgKh9Vbm55030VC3DRtCTttA1c5GXmI+5x+AwaGnAxjzj84241ElFU3HAq+EJyf1b5QW0VMM1TquNwENDu+m5PLJMf+BiPUfc8Z1kLtbNthgtIi0Jh/vxX66eQSgdR7TKdnYAEMqEKm5xQOdKZK1fiFU1C4gLtsJggKp/Jq888244zWvedTnQdBOiI/Cd6u6k9R6cZ0MVxmMPmJ6oOkgf9Ku6gjFhrAPREbG7BcV6JJ4guYA3hGQw+uPaPRWOozonRqOSl7goJi2wKTseh6YifQQFOS3dK1T8zAQXMIg98Kj9n/9r2AWun6/2hj+YQkYe85FsNUBeNjg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=iq9+eUZ+StTSdkTptb/U5bycGGrfFBA58w83haeXm1M=; b=gXRa/HcMatVbFqYyVMRCAKVJRSy79ukXuOmWvnQqHvbgItlG0Emyc1Wc4xf73YY0V5d2gLseMjdS1z4gWzR2iF7ZL+z42EJgED6OykdbsMbYtmHCy6qR1adjUy+osru7SaPujirORaupWihpO5oLfmHOIlJFWOzBRNCwzRkZhYuEyZlxbi9A7W8UlyCYC7uoxl2bIHSyBSjMYd0LGiv4z2iZLNz/DlWThOFCbhpur2kASSops9au/kEhMrN5F8v8EaMt5HRSSc44addsLqrbaVcCprmzTct/G4NT+FfJ3OjwEpPAOqwgoODfLJXzDkt1kDLyx9YLqdXqRVvP1LUsOQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 216.228.117.160) smtp.rcpttodomain=huawei.com smtp.mailfrom=nvidia.com; dmarc=pass (p=reject sp=reject pct=100) action=none header.from=nvidia.com; dkim=none (message not signed); arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=iq9+eUZ+StTSdkTptb/U5bycGGrfFBA58w83haeXm1M=; b=CSiaABbbEKlmgLVZxMW9aFhAT1wy3fq01TNutXsT4s3EE/AEOLwm1WN3nutd6cIodJBs3+4OaHb7UANl+Wt3gWLLGlVrM5kyqzQhVwLAJbCDsdS7m5HV5HgKqmwf2ivIKQOuvXFe/7qfE6hBAk51DyxwNnvde/+xKTQjs7CS4dBH/Kc1KTnPEFQnikrMKiOAtqbnmfEQvXTO8/cH+5/vrMC/nSOJGtU7UDS2sapMvxERAoLfodbO0zA66+doA2bWbDCnlQ4/JRP8zvZPCYdOpreF1zPNNWvr2UcUlaB1dowHvuHlDnsAVNTmZl/twRHvCKmc18ESlXwwVxPsmXrOvw== Received: from BN7PR02CA0003.namprd02.prod.outlook.com (2603:10b6:408:20::16) by DM6PR12MB4530.namprd12.prod.outlook.com (2603:10b6:5:2aa::19) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6521.24; Sun, 25 Jun 2023 06:39:50 +0000 Received: from BN8NAM11FT031.eop-nam11.prod.protection.outlook.com (2603:10b6:408:20:cafe::7a) by BN7PR02CA0003.outlook.office365.com (2603:10b6:408:20::16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6521.32 via Frontend Transport; Sun, 25 Jun 2023 06:39:50 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 216.228.117.160) smtp.mailfrom=nvidia.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=nvidia.com; Received-SPF: Pass (protection.outlook.com: domain of nvidia.com designates 216.228.117.160 as permitted sender) receiver=protection.outlook.com; client-ip=216.228.117.160; helo=mail.nvidia.com; pr=C Received: from mail.nvidia.com (216.228.117.160) by BN8NAM11FT031.mail.protection.outlook.com (10.13.177.25) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6500.47 via Frontend Transport; Sun, 25 Jun 2023 06:39:47 +0000 Received: from rnnvmail201.nvidia.com (10.129.68.8) by mail.nvidia.com (10.129.200.66) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.986.5; Sat, 24 Jun 2023 23:39:34 -0700 Received: from nvidia.com (10.126.230.35) by rnnvmail201.nvidia.com (10.129.68.8) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.986.37; Sat, 24 Jun 2023 23:39:33 -0700 From: Xueming Li To: Huisong Li CC: Dongdong Liu , dpdk stable Subject: patch 'net/hns3: fix never set MAC flow control' has been queued to stable release 22.11.3 Date: Sun, 25 Jun 2023 14:34:18 +0800 Message-ID: <20230625063544.11183-41-xuemingl@nvidia.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20230625063544.11183-1-xuemingl@nvidia.com> References: <20230625063544.11183-1-xuemingl@nvidia.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Type: text/plain X-Originating-IP: [10.126.230.35] X-ClientProxiedBy: rnnvmail202.nvidia.com (10.129.68.7) To rnnvmail201.nvidia.com (10.129.68.8) X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: BN8NAM11FT031:EE_|DM6PR12MB4530:EE_ X-MS-Office365-Filtering-Correlation-Id: 91d4b011-7b4e-40a9-cc5c-08db7546f885 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: utQMw2X4jUA8gN2De/xSNPxmikQSS2cliYFqHs2fF+EkY8tCRZIgBlbuN/TBHQagmILw2rovm0asY88MDWsV+MQUQMDokVBHhWN21IThKcmDHiYbPHWIBLUdzXkLIIo3VtNYPAAmR3hXDN4cQQcs9Q843G9Yx+2DJD9BB8L64oRSC6y49VqOjsd5D6CEj55lKlrfIAMKApNyMWCtmPG1h07+Q/yVcmUm2FYxZr6765kyvSEVrZoQa6nhq4hBN8G9MUf1FvJoTFOt0DQTB3um69OsROV1DovGpwLkYKHMaoCiZdNBDQhYh5HbpM2608aNptE6NrA+EWnItHJGvh7hG+iWFZcbRe74Wk1l9igDkHa++4PGVTHOw6S7JwJJczKDDYjQIdVmNuz2gJOPonEfDh4lxcWPqMRlkZK/OhkmfzJEiEnr7dZT4Ie+ffcsMV2rl4hl3vk2M2Xcb2ddkObNvR/TGubpWIdvfjt1qcLSS9vNt5njyuPjUsWySb1dSIzSNSOlbo4Z+S1PzqFVALbxdSlOhpxndW+Mz6RWQot4+5iWdddsZwlNfs3jlC/J/bGdM2tHBKyP8uh0YE93q/e2imgFqeyxWEcBSh2TsFTsZjlnTO/SEI1WB/VkF2zvlKraOFOzpcPvPWBox24h7anPzX7zdm2/1+h8i1E5qqKjX+98HlQ3TF0Gi4HOsaHXRZOtCLAKvI/ujYbRscyNYzTBL5vOiE9tNiUvx/NIiaaQ0M5zDEodEaZwtU7Ch60kFazj4lV7k4vSj4by/P2b2Mi2nw== X-Forefront-Antispam-Report: CIP:216.228.117.160; CTRY:US; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:mail.nvidia.com; PTR:dc6edge1.nvidia.com; CAT:NONE; SFS:(13230028)(4636009)(376002)(136003)(396003)(39860400002)(346002)(451199021)(40470700004)(36840700001)(46966006)(82310400005)(36860700001)(40460700003)(47076005)(966005)(478600001)(7696005)(2616005)(54906003)(426003)(6666004)(83380400001)(336012)(53546011)(1076003)(26005)(16526019)(6286002)(186003)(2906002)(5660300002)(36756003)(70206006)(356005)(4326008)(70586007)(82740400003)(7636003)(40480700001)(8936002)(8676002)(41300700001)(316002)(86362001)(6916009)(55016003); DIR:OUT; SFP:1101; X-OriginatorOrg: Nvidia.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 25 Jun 2023 06:39:47.8860 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 91d4b011-7b4e-40a9-cc5c-08db7546f885 X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=43083d15-7273-40c1-b7db-39efd9ccc17a; Ip=[216.228.117.160]; Helo=[mail.nvidia.com] X-MS-Exchange-CrossTenant-AuthSource: BN8NAM11FT031.eop-nam11.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM6PR12MB4530 X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org Hi, FYI, your patch has been queued to stable release 22.11.3 Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet. It will be pushed if I get no objections before 06/27/23. So please shout if anyone has objections. Also note that after the patch there's a diff of the upstream commit vs the patch applied to the branch. This will indicate if there was any rebasing needed to apply to the stable branch. If there were code changes for rebasing (ie: not only metadata diffs), please double check that the rebase was correctly done. Queued patches are on a temporary branch at: https://git.dpdk.org/dpdk-stable/log/?h=22.11-staging This queued commit can be viewed at: https://git.dpdk.org/dpdk-stable/commit/?h=22.11-staging&id=2a7aef1dd0c51b04b7f36fea94ece654ba6893a0 Thanks. Xueming Li --- >From 2a7aef1dd0c51b04b7f36fea94ece654ba6893a0 Mon Sep 17 00:00:00 2001 From: Huisong Li Date: Mon, 22 May 2023 21:17:36 +0800 Subject: [PATCH] net/hns3: fix never set MAC flow control Cc: Xueming Li [ upstream commit 2350eb39f337f9e8d798f8dd1d658834e3981e9e ] When some hardware and firmware support speed auto-negotiation but do not support flow control auto-negotiation, driver can never successfully set MAC flow control by flow_ctrl_set() API. So only tell user driver doesn't support flow control autoneg when user enable it. Fixes: 1f411e31a826 ("net/hns3: support flow control autoneg for copper port") Signed-off-by: Huisong Li Signed-off-by: Dongdong Liu --- drivers/net/hns3/hns3_ethdev.c | 11 +---------- 1 file changed, 1 insertion(+), 10 deletions(-) diff --git a/drivers/net/hns3/hns3_ethdev.c b/drivers/net/hns3/hns3_ethdev.c index 0fe6223561..c31c6979c3 100644 --- a/drivers/net/hns3/hns3_ethdev.c +++ b/drivers/net/hns3/hns3_ethdev.c @@ -5304,16 +5304,7 @@ hns3_check_fc_autoneg_valid(struct hns3_hw *hw, uint8_t autoneg) if (!pf->support_fc_autoneg) { if (autoneg != 0) { - hns3_err(hw, "unsupported fc auto-negotiation setting."); - return -EOPNOTSUPP; - } - - /* - * Flow control auto-negotiation of the NIC is not supported, - * but other auto-negotiation features may be supported. - */ - if (autoneg != hw->mac.link_autoneg) { - hns3_err(hw, "please use 'link_speeds' in struct rte_eth_conf to disable autoneg!"); + hns3_err(hw, "unsupported fc auto-negotiation."); return -EOPNOTSUPP; } -- 2.25.1 --- Diff of the applied patch vs upstream commit (please double-check if non-empty: --- --- - 2023-06-25 14:31:59.602601600 +0800 +++ 0040-net-hns3-fix-never-set-MAC-flow-control.patch 2023-06-25 14:31:58.345773900 +0800 @@ -1 +1 @@ -From 2350eb39f337f9e8d798f8dd1d658834e3981e9e Mon Sep 17 00:00:00 2001 +From 2a7aef1dd0c51b04b7f36fea94ece654ba6893a0 Mon Sep 17 00:00:00 2001 @@ -4,0 +5,3 @@ +Cc: Xueming Li + +[ upstream commit 2350eb39f337f9e8d798f8dd1d658834e3981e9e ] @@ -13 +15,0 @@ -Cc: stable@dpdk.org @@ -22 +24 @@ -index d97280e647..8f819d5f23 100644 +index 0fe6223561..c31c6979c3 100644