From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 0F7F042D46 for ; Sun, 25 Jun 2023 08:36:33 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 0BC6440ED8; Sun, 25 Jun 2023 08:36:33 +0200 (CEST) Received: from NAM11-CO1-obe.outbound.protection.outlook.com (mail-co1nam11on2084.outbound.protection.outlook.com [40.107.220.84]) by mails.dpdk.org (Postfix) with ESMTP id A104840A7F for ; Sun, 25 Jun 2023 08:36:31 +0200 (CEST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=ke8+Tr9NSCp2DsYXNVgKR0hZqQSwhmo7NNiyXtpMOwoZnmNXzPiU6cVib45XHJTG/upCJNOj4QkpWbMtlu539e5tfBgBoroYfhG19xeFill67SplNTy2u4m7Uu2w+pXfNTu3+h0IigigSLSivGLhWxxWF6ve0rQoH5GRYcgDnazpO6BWwVu8MV3habYfUP9zhm0CzoT9VKXf1Rsh4a1NRzlf4TAEjcA/n9lLRPh4103u2m/AB3PuMKzUtodDgHTLVgR2knSZPc9I9Sa3oGx6XjQbGeniYFpysfO31GeUsiNNQbuU6o7ZNzt4UgyN/vsTRyblAVFtU5jWFsHYHMBeOQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=6C+S8mbY2vaahWVi4A4vkkxbPmFRbulndJ+L1UaGHg4=; b=nUSLqY/INfBcsiDiyY3aX9dxRJ7J2vdQai9sMSlNme7Im4h55KKJUl0cDdN7B+VZY4HQPfu4RMLVI/BaJmScuGopnQskrAbdYmE7VzOWPO2MqAZcLxzfdEQXBRqTcg2UhB/wr7yNIBnsIyoUfgKPRJx3l+dArVgqBZRsiN0jPmsNSRsTPsPk5OoXXtWnhA3BxePNU1N1apvKFlMW+91HQKTUgih+keVzmDlDDqZ1vP211qh+Z0kUVLSrT3Wc/3+zNVvCAyiFGSIskzJrYiOa8BDNCvVYNDs0FiBM/046LX7dhDLWsJezoW09UJJJS/agEOhDvDBskERd7Tlh7tJqxQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 216.228.117.160) smtp.rcpttodomain=marvell.com smtp.mailfrom=nvidia.com; dmarc=pass (p=reject sp=reject pct=100) action=none header.from=nvidia.com; dkim=none (message not signed); arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=6C+S8mbY2vaahWVi4A4vkkxbPmFRbulndJ+L1UaGHg4=; b=OVn4mO4hK79hIKDvol37nfsl5uRWAPsiaY25PySjU5b6P9mJXgFtwk6syX7WuZcV/dZayKljewFudPXiBYbNI8pf1cXNXiS2mMO9sLg3ojFsinpyAwD75zjx2sWI0zI6NuUSWUn3B9l4KaaZwW+M1AEkXqMl4eDYFk3WngqnFurGk+BGFfhK9ViYPSlIoNP6LSEbKraAh+jTAf4X7TJnfFmj43enGvaUMgj4oM1mJFdshe81Dl6VDrnYoS4SlkKK6YSHMlMEcPaUGtMgbWA/WdrcxTqwZTXpw8h2Lnj0j3A3MMVFqPxQMpoTYH4gsryuhNEctO/fCSpXnncggEMf+Q== Received: from BN6PR17CA0037.namprd17.prod.outlook.com (2603:10b6:405:75::26) by DM6PR12MB4121.namprd12.prod.outlook.com (2603:10b6:5:220::14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6521.24; Sun, 25 Jun 2023 06:36:29 +0000 Received: from BN8NAM11FT085.eop-nam11.prod.protection.outlook.com (2603:10b6:405:75:cafe::fa) by BN6PR17CA0037.outlook.office365.com (2603:10b6:405:75::26) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6521.32 via Frontend Transport; Sun, 25 Jun 2023 06:36:29 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 216.228.117.160) smtp.mailfrom=nvidia.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=nvidia.com; Received-SPF: Pass (protection.outlook.com: domain of nvidia.com designates 216.228.117.160 as permitted sender) receiver=protection.outlook.com; client-ip=216.228.117.160; helo=mail.nvidia.com; pr=C Received: from mail.nvidia.com (216.228.117.160) by BN8NAM11FT085.mail.protection.outlook.com (10.13.176.100) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6500.47 via Frontend Transport; Sun, 25 Jun 2023 06:36:28 +0000 Received: from rnnvmail201.nvidia.com (10.129.68.8) by mail.nvidia.com (10.129.200.66) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.986.5; Sat, 24 Jun 2023 23:36:15 -0700 Received: from nvidia.com (10.126.230.35) by rnnvmail201.nvidia.com (10.129.68.8) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.986.37; Sat, 24 Jun 2023 23:36:13 -0700 From: Xueming Li To: Jerin Jacob CC: Ali Alnubani , Junfeng Guo , Daxue Gao , dpdk stable Subject: patch 'examples/ntb: fix build with GCC 13' has been queued to stable release 22.11.3 Date: Sun, 25 Jun 2023 14:33:42 +0800 Message-ID: <20230625063544.11183-5-xuemingl@nvidia.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20230625063544.11183-1-xuemingl@nvidia.com> References: <20230625063544.11183-1-xuemingl@nvidia.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Type: text/plain X-Originating-IP: [10.126.230.35] X-ClientProxiedBy: rnnvmail202.nvidia.com (10.129.68.7) To rnnvmail201.nvidia.com (10.129.68.8) X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: BN8NAM11FT085:EE_|DM6PR12MB4121:EE_ X-MS-Office365-Filtering-Correlation-Id: 5cb5bc92-5b74-467b-5527-08db754681ea X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: bCx6j6CmzwmIqn5RvmW9mAzbEaC8npZPN1cGBlAZJGqman5L4osPRj7LLumo4fpfJqCv4iHeR1/RDWRrpEAOuol6G6l7D6Fr4gZB843Ui/x763Nu8cjutE4iRoLufcsFes5X/T7PnaswvvzZx8OB4219uk4i0zTgviv9nuIbzOu8TxccJWgLJyRe/AGpivnQ27ibTdlEV9lhhNIJEDoXqdL6nImWwmj+6fZ7xZApGSjfUwP1SM/u3nGGgjvIGbqeOZ7L4B44/GhaF0MC4UQB1HOyRrVK0HSMzgHOWvCL5uZj0tJcufBPdN8aNkHVK2HOOwyhxqpDtoCid5ugJxb7iRu5WeE1HzR+kQGsPpCz7GQ+qfuz57XK9SIx5kFyLMrf9CAHVq2ofM5AKo8udZhxNAzMt7SB508eJwKcvuVgcXv5kRxaFVdlKGai47al7WVvNzpepiLt6+/wi7wn58VjIipMFvauV1fL2L+82/jeCQTFTzKmK9OTtZ1kaZ6Kn0pegGDXsoKRznphrJ3C1gDBy5jUrT0WEVPfPNKmPCRCU92JMoEp1GEGahx0qWkB2mNvaUBerFXN+HckM7ngElPFPEBQ66UNOVhN+0pSTVPYZxJqH5sPlyG0cp8R8IUIJ32Pr9d0oBV9IOxxTcDdnyBlRQmtwmomW4VtHGI1IBcLcXGxYyzAncnDIjvskf0xGlFGrAg3Lrp3WCyqU8s48w1SBMKVQ01Gxl5Y6+nM+TFKSvtRbZlRsrkA4hOF3po1tW0dc0ugDHvDVUI/ShRg91YqMA== X-Forefront-Antispam-Report: CIP:216.228.117.160; CTRY:US; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:mail.nvidia.com; PTR:dc6edge1.nvidia.com; CAT:NONE; SFS:(13230028)(4636009)(39860400002)(376002)(136003)(346002)(396003)(451199021)(46966006)(40470700004)(36840700001)(316002)(70586007)(70206006)(4326008)(6916009)(478600001)(8936002)(36756003)(8676002)(5660300002)(2906002)(40460700003)(55016003)(966005)(36860700001)(40480700001)(86362001)(54906003)(41300700001)(7696005)(82310400005)(6286002)(16526019)(53546011)(186003)(336012)(426003)(1076003)(26005)(47076005)(7636003)(6666004)(82740400003)(356005)(83380400001)(2616005); DIR:OUT; SFP:1101; X-OriginatorOrg: Nvidia.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 25 Jun 2023 06:36:28.8804 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 5cb5bc92-5b74-467b-5527-08db754681ea X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=43083d15-7273-40c1-b7db-39efd9ccc17a; Ip=[216.228.117.160]; Helo=[mail.nvidia.com] X-MS-Exchange-CrossTenant-AuthSource: BN8NAM11FT085.eop-nam11.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM6PR12MB4121 X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org Hi, FYI, your patch has been queued to stable release 22.11.3 Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet. It will be pushed if I get no objections before 06/27/23. So please shout if anyone has objections. Also note that after the patch there's a diff of the upstream commit vs the patch applied to the branch. This will indicate if there was any rebasing needed to apply to the stable branch. If there were code changes for rebasing (ie: not only metadata diffs), please double check that the rebase was correctly done. Queued patches are on a temporary branch at: https://git.dpdk.org/dpdk-stable/log/?h=22.11-staging This queued commit can be viewed at: https://git.dpdk.org/dpdk-stable/commit/?h=22.11-staging&id=f9a20a28ecdc83ee76d696170a5ccb69afcb0518 Thanks. Xueming Li --- >From f9a20a28ecdc83ee76d696170a5ccb69afcb0518 Mon Sep 17 00:00:00 2001 From: Jerin Jacob Date: Thu, 4 May 2023 14:23:37 +0530 Subject: [PATCH] examples/ntb: fix build with GCC 13 Cc: Xueming Li [ upstream commit dbff181d62c997f128b75db2bbac9f42e8dd0f8f ] Fix the following build issue by not allowing nb_ids to be zero. nb_ids can be zero based on rte_rawdev_xstats_get() API documentation but it is not valid for the case when second argument is NULL. examples/ntb/ntb_fwd.c: In function 'ntb_stats_display': examples/ntb/ntb_fwd.c:945:23: error: 'rte_rawdev_xstats_get' accessing 8 bytes in a region of size 0 [-Werror=stringop-overflow=] 945 | if (nb_ids != rte_rawdev_xstats_get(dev_id, ids, values, nb_ids)) { | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ examples/ntb/ntb_fwd.c:945:23: note: referencing argument 3 of type 'uint64_t[0]' {aka 'long unsigned int[]'} In file included from ../examples/ntb/ntb_fwd.c:17: lib/rawdev/rte_rawdev.h:504:1: note: in a call to function 'rte_rawdev_xstats_get' 504 | rte_rawdev_xstats_get(uint16_t dev_id, Fixes: 5194299d6ef5 ("examples/ntb: support more functions") Signed-off-by: Jerin Jacob Tested-by: Ali Alnubani Acked-by: Junfeng Guo Tested-by: Daxue Gao --- examples/ntb/ntb_fwd.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/examples/ntb/ntb_fwd.c b/examples/ntb/ntb_fwd.c index f9abed28e4..585aad9d70 100644 --- a/examples/ntb/ntb_fwd.c +++ b/examples/ntb/ntb_fwd.c @@ -865,7 +865,7 @@ ntb_stats_clear(void) /* Clear NTB dev stats */ nb_ids = rte_rawdev_xstats_names_get(dev_id, NULL, 0); - if (nb_ids < 0) { + if (nb_ids <= 0) { printf("Error: Cannot get count of xstats\n"); return; } @@ -923,7 +923,7 @@ ntb_stats_display(void) /* Get NTB dev stats and stats names */ nb_ids = rte_rawdev_xstats_names_get(dev_id, NULL, 0); - if (nb_ids < 0) { + if (nb_ids <= 0) { printf("Error: Cannot get count of xstats\n"); return; } -- 2.25.1 --- Diff of the applied patch vs upstream commit (please double-check if non-empty: --- --- - 2023-06-25 14:31:58.705277700 +0800 +++ 0004-examples-ntb-fix-build-with-GCC-13.patch 2023-06-25 14:31:58.285773900 +0800 @@ -1 +1 @@ -From dbff181d62c997f128b75db2bbac9f42e8dd0f8f Mon Sep 17 00:00:00 2001 +From f9a20a28ecdc83ee76d696170a5ccb69afcb0518 Mon Sep 17 00:00:00 2001 @@ -4,0 +5,3 @@ +Cc: Xueming Li + +[ upstream commit dbff181d62c997f128b75db2bbac9f42e8dd0f8f ] @@ -25 +27,0 @@ -Cc: stable@dpdk.org