From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id DF44A42D46 for ; Sun, 25 Jun 2023 08:42:25 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id DAD7640ED8; Sun, 25 Jun 2023 08:42:25 +0200 (CEST) Received: from NAM11-BN8-obe.outbound.protection.outlook.com (mail-bn8nam11on2041.outbound.protection.outlook.com [40.107.236.41]) by mails.dpdk.org (Postfix) with ESMTP id 8674E40A7F for ; Sun, 25 Jun 2023 08:42:24 +0200 (CEST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=E6XlGZIVAyB52dmQ5PK0DCt7c68LWMhV2FNJRYHvEvzohN1OtWTxUWsLQIPhkvHb2h75bPeradhiUcrtW7tdwo6AGjIMES2X9ESp7RPtYqDpkEKMbDKi59JUV4V3cEG8ItM4UCfReepUaCGyQ0LdNxqr1ajXoEnm5L8LlINepyn03pEZhnFcPzHoWWDyhNCbbAUwFE+FwgMJUDeSCHtC0H9mUlj3fxvZz8v2UUwVHKc/mPs05Vh4zoKAsNyl5/tLE9+mpn7oXAvVhzYEXoOXVVb3chvwbBr2r1ZBOb52b4iSkin6Za6CZtrYsbJNPko1fhvBKPRXslHCJCKLlsBQvQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=BJ9qKcAefpCgUg3TIzCCaK70zZL7y6aMmlsFjI4Zhcg=; b=JzC7XeygAAwe6SPx30ULIUXYaMbXqXhtEnhRw5nLVaEvI4FSt2pTXaHoU93j4XP/hiJ1cWU/wWrVTlvYiwFFwPzrFur6L43lw1BSSp4magvmoDDwuUo1x0/Mln5tFBbzNjh8YLC1TmeorK2RLsioD7nfhn+ZG5Y83mawK9BmI7KGGX/kloH3fpxds60zWtd/oi0/xSjieHfn5sIZli8ELSWEN2Fyg4cMB1e69DtNlIDsqgBu3gLqxFsSl4PoCo3GB4tnROdfvkD6jlaMoAsrtfMs7lawD/3JzUOEbhe8tO3dAJeBxVbkP3PTYzp57sNl+VAGeSKVExkzSbiWHZZc5g== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 216.228.117.160) smtp.rcpttodomain=intel.com smtp.mailfrom=nvidia.com; dmarc=pass (p=reject sp=reject pct=100) action=none header.from=nvidia.com; dkim=none (message not signed); arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=BJ9qKcAefpCgUg3TIzCCaK70zZL7y6aMmlsFjI4Zhcg=; b=CIbUH/am9ao9e3OzHkY0JGhg+zVo3sevZFmMwIenmU3V0eZOhlzHh4C2PjYgN3vVGs684Js14GwLZ3Yt214DGIrQohlJKzW3WQ+TAP+HNNWrmkfwxeDq0RkiNKChJlbKpQE+fclXD+iNXO3KCHr/z6X6y+80JTGMjK6jQ8T5iQOEkbEJSBkWZvk8N3H3LGMvR9GqOVij6iaYHDP3wE8iciHE9rMWAiXt6DtKkb29uUPEY2vsft+twufEUGanY8SZXITFNwBE5g6Gzq9OehDs90GdW8DcVDwIADo8cDo9g2OmjyvAnU8TsLNPF30rhGKsM97OF3/b71QeP13sBTlqZQ== Received: from MW4P223CA0016.NAMP223.PROD.OUTLOOK.COM (2603:10b6:303:80::21) by SN7PR12MB7911.namprd12.prod.outlook.com (2603:10b6:806:32a::19) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6521.24; Sun, 25 Jun 2023 06:42:22 +0000 Received: from CO1NAM11FT009.eop-nam11.prod.protection.outlook.com (2603:10b6:303:80:cafe::32) by MW4P223CA0016.outlook.office365.com (2603:10b6:303:80::21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6521.33 via Frontend Transport; Sun, 25 Jun 2023 06:42:22 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 216.228.117.160) smtp.mailfrom=nvidia.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=nvidia.com; Received-SPF: Pass (protection.outlook.com: domain of nvidia.com designates 216.228.117.160 as permitted sender) receiver=protection.outlook.com; client-ip=216.228.117.160; helo=mail.nvidia.com; pr=C Received: from mail.nvidia.com (216.228.117.160) by CO1NAM11FT009.mail.protection.outlook.com (10.13.175.61) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6500.47 via Frontend Transport; Sun, 25 Jun 2023 06:42:22 +0000 Received: from rnnvmail201.nvidia.com (10.129.68.8) by mail.nvidia.com (10.129.200.66) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.986.5; Sat, 24 Jun 2023 23:42:07 -0700 Received: from nvidia.com (10.126.230.35) by rnnvmail201.nvidia.com (10.129.68.8) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.986.37; Sat, 24 Jun 2023 23:42:06 -0700 From: Xueming Li To: Ciara Power CC: Kai Ji , Brian Dooley , "dpdk stable" Subject: patch 'crypto/qat: fix stack buffer overflow in SGL loop' has been queued to stable release 22.11.3 Date: Sun, 25 Jun 2023 14:34:49 +0800 Message-ID: <20230625063544.11183-72-xuemingl@nvidia.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20230625063544.11183-1-xuemingl@nvidia.com> References: <20230625063544.11183-1-xuemingl@nvidia.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Type: text/plain X-Originating-IP: [10.126.230.35] X-ClientProxiedBy: rnnvmail202.nvidia.com (10.129.68.7) To rnnvmail201.nvidia.com (10.129.68.8) X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: CO1NAM11FT009:EE_|SN7PR12MB7911:EE_ X-MS-Office365-Filtering-Correlation-Id: 52e04243-6c60-4b2b-a942-08db75475456 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: Lzc3xMYUNzsyV4DJyITQyGbGkWQScBjpY8eN3QmhSvwJs7siD9XMvYBF/5q77jdmb5xx5AxxrSxDSANT3aJPUmMYOvWMJ3jED1Eg0S0rhZZedR4wR5W79jqmrzBHVAEtyBB3odLqwcjBTD50sLI8Dg7WyRMZgFz7bBW6Q7voVY4sc9h3Y+nhh190n1BahxBh6kzq4Z6dGt/6fDj6e9bCDfOoFyuSySPrTypOgbvybo+V5mL4Am0CnanQYAW+Umsp7/lFWryQy0KkZ8Xq1wC2IcHAnRZqSzFMhWKZWlQb0U9ff6aGDvMkjYa7IbdYP8ARLV4OxGa5i/A3xCXFD/MWkICYiIVlXAWlXxZCtVc9Aukhnr/9v9Jfc7lQOk2o8ZS0ghoJo+rf+b/NFGUs9lQEmpxqwSYudkvS6fsRcv242GNpPIoUqgmohww+5GVkBbDQQ89aNpKnOVfJUl/QxcacsqOf2GHp4HjoQ5vh+xtuiq65F45zTmjUN6HycP+A7N6Megd4sR/O0FZQ6jWxmohEtBmzjV6Lke7W46lOjcjEidHShM+e1XJO6XE6Q3FL+tpzpTDZi28M5VDFJ79ovCf/I97/6VzOJocXqvD3J/isqAoNDBZLFPoZAGucWChFIJRBdZBpW5PwAw7H7I4ArX2+ypS24wF3puNJ7zKL/ZC32WHp/uEeyWjQDtTw+z3tssXAdtNkI6M/vXw8PJnC2IOHB2QuMErO3vR/2u7xdJQh5jdoP+J7MhaeS7vhDKHwTzDmfwQ/D4UY105Op9oz0nprrA== X-Forefront-Antispam-Report: CIP:216.228.117.160; CTRY:US; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:mail.nvidia.com; PTR:dc6edge1.nvidia.com; CAT:NONE; SFS:(13230028)(4636009)(396003)(136003)(376002)(39860400002)(346002)(451199021)(36840700001)(40470700004)(46966006)(36860700001)(82310400005)(47076005)(966005)(478600001)(7696005)(6666004)(2616005)(54906003)(426003)(83380400001)(336012)(26005)(53546011)(1076003)(186003)(16526019)(6286002)(2906002)(5660300002)(40460700003)(36756003)(70206006)(356005)(4326008)(7636003)(70586007)(82740400003)(55016003)(40480700001)(316002)(86362001)(8936002)(8676002)(41300700001)(6916009); DIR:OUT; SFP:1101; X-OriginatorOrg: Nvidia.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 25 Jun 2023 06:42:22.0056 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 52e04243-6c60-4b2b-a942-08db75475456 X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=43083d15-7273-40c1-b7db-39efd9ccc17a; Ip=[216.228.117.160]; Helo=[mail.nvidia.com] X-MS-Exchange-CrossTenant-AuthSource: CO1NAM11FT009.eop-nam11.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: SN7PR12MB7911 X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org Hi, FYI, your patch has been queued to stable release 22.11.3 Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet. It will be pushed if I get no objections before 06/27/23. So please shout if anyone has objections. Also note that after the patch there's a diff of the upstream commit vs the patch applied to the branch. This will indicate if there was any rebasing needed to apply to the stable branch. If there were code changes for rebasing (ie: not only metadata diffs), please double check that the rebase was correctly done. Queued patches are on a temporary branch at: https://git.dpdk.org/dpdk-stable/log/?h=22.11-staging This queued commit can be viewed at: https://git.dpdk.org/dpdk-stable/commit/?h=22.11-staging&id=44137441387c0d04698e0b1083c0b90cff131d42 Thanks. Xueming Li --- >From 44137441387c0d04698e0b1083c0b90cff131d42 Mon Sep 17 00:00:00 2001 From: Ciara Power Date: Fri, 14 Apr 2023 12:31:31 +0000 Subject: [PATCH] crypto/qat: fix stack buffer overflow in SGL loop Cc: Xueming Li [ upstream commit ff6e69e935ddc460bffdcfe7431dcf914fdfdb3f ] The cvec pointer was incremented incorrectly in the case where the length of remaining_off equals cvec len, and there is no next cvec. This led to cvec->iova being invalid memory to access. Instead, only increment the cvec pointer when we know there is a next cvec to point to, by checking the i value, which represents the number of cvecs available. If i is 0, then no need to increment as the current cvec is the last one. Fixes: a815a04cea05 ("crypto/qat: support symmetric build op request") Signed-off-by: Ciara Power Acked-by: Kai Ji Acked-by: Brian Dooley --- drivers/crypto/qat/dev/qat_crypto_pmd_gens.h | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/crypto/qat/dev/qat_crypto_pmd_gens.h b/drivers/crypto/qat/dev/qat_crypto_pmd_gens.h index 524c291340..092265631b 100644 --- a/drivers/crypto/qat/dev/qat_crypto_pmd_gens.h +++ b/drivers/crypto/qat/dev/qat_crypto_pmd_gens.h @@ -682,7 +682,8 @@ enqueue_one_chain_job_gen1(struct qat_sym_session *ctx, while (remaining_off >= cvec->len && i >= 1) { i--; remaining_off -= cvec->len; - cvec++; + if (i) + cvec++; } auth_iova_end = cvec->iova + remaining_off; -- 2.25.1 --- Diff of the applied patch vs upstream commit (please double-check if non-empty: --- --- - 2023-06-25 14:32:00.420530400 +0800 +++ 0071-crypto-qat-fix-stack-buffer-overflow-in-SGL-loop.patch 2023-06-25 14:31:58.435773900 +0800 @@ -1 +1 @@ -From ff6e69e935ddc460bffdcfe7431dcf914fdfdb3f Mon Sep 17 00:00:00 2001 +From 44137441387c0d04698e0b1083c0b90cff131d42 Mon Sep 17 00:00:00 2001 @@ -4,0 +5,3 @@ +Cc: Xueming Li + +[ upstream commit ff6e69e935ddc460bffdcfe7431dcf914fdfdb3f ] @@ -16 +18,0 @@ -Cc: stable@dpdk.org