From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id D6D1A42D46 for ; Sun, 25 Jun 2023 08:42:51 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id D2E3F42C4D; Sun, 25 Jun 2023 08:42:51 +0200 (CEST) Received: from NAM12-MW2-obe.outbound.protection.outlook.com (mail-mw2nam12on2088.outbound.protection.outlook.com [40.107.244.88]) by mails.dpdk.org (Postfix) with ESMTP id A6B4542D2F for ; Sun, 25 Jun 2023 08:42:49 +0200 (CEST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=RuOv93On0CNNSg+5XIUOSkVpPLaiuKMOsqZdsHAQy6VaZFSsOW7jqmOukcjHdDkL+HoA6PhNiCqpoIRl++JgNgS1SAeZzE9uuuZxCos+ElDHoL2c9eIPhJ24k0JX+5F/+rfFYAWq4qaaGbGyjzN58/SR16IB71KCz+mRt8cqzUdBxvqtXYlwPaX5HPNHFurr/P7evkxfNoUNFspBxlTOGUJUYyXwS+tDxhldXAK+flypYviXffdfQhAWLNojq/KyorEIbeVc5gFNnSgKlNcOgMcPOP3Z3l/YAAzKybLAexoF9dSiY862o78E5OPAJ5xtKu8Dqay7o/pZPaVVrVnAMA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=xWJaNhX+TKHJsIb/wcHHWubZInq53wZU1kpJ9YumwvI=; b=ZF3vEwWvudkAvj7zlyHhanAfz7fKUh+JSjOTQOJ6HpIi6gmblsXI5ayOTeYPfgoF4AnxLRKmG3y5LCUxF+kDRdFgkNhunAQTr91YMA/TDMp6pD0yW/fWJcol/VM0+YeaeJD5h2jJR3WIbGfnfGxNmrtV1e4KQGUTPYtzRpKphSZ2SSCfRZU8nNdF0XECHOn+k1bR9CK4j2uzxQZvWrztXSJlnlzpMYokLVmZRdsbnHDmp7tIawKaC6GuSZYm8Pyuo7QizVMmxqKZkDP1FcVcwH6GsNWWQTbHfYDVEWMfSY0IOnWqVsKajK6R8NGNG9ZsQcW6bFwMNGNIxAVq7qz0ww== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 216.228.117.161) smtp.rcpttodomain=intel.com smtp.mailfrom=nvidia.com; dmarc=pass (p=reject sp=reject pct=100) action=none header.from=nvidia.com; dkim=none (message not signed); arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=xWJaNhX+TKHJsIb/wcHHWubZInq53wZU1kpJ9YumwvI=; b=gW6M3dSrwr7TM/eFVIGlJP+FEf+JRl7awv2kQl1n2Y0tRvPcMoKtG1T+O3u58+Xz1Yw37eZCvB2Tv+sI+KiXPSvnJKYWPetTpO/YesmtPm6cfm47cZfANX8EocqIDGElkbOfUhSb6UosR7Og1xSizJE5nyL9ozR43pKusWg79XkfNTBaRv5jUSjnISrjPdxnEcQ8Ox8lV1YIhshjdR5UNg3c7feGmrn430NZ4Odd+EKSk6Jl4Y4lJBOvoE4U9uns3r1IMWtes9P2gsrX22eClHfumohyO//4Yy6iYAQB2tdytqcIlWy0+mRFD3AR7nFqj8C/txHKBGxKp7TqpO3LQw== Received: from BN9PR03CA0906.namprd03.prod.outlook.com (2603:10b6:408:107::11) by CYYPR12MB8732.namprd12.prod.outlook.com (2603:10b6:930:c8::9) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6521.23; Sun, 25 Jun 2023 06:42:47 +0000 Received: from BN8NAM11FT068.eop-nam11.prod.protection.outlook.com (2603:10b6:408:107:cafe::2c) by BN9PR03CA0906.outlook.office365.com (2603:10b6:408:107::11) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6521.32 via Frontend Transport; Sun, 25 Jun 2023 06:42:47 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 216.228.117.161) smtp.mailfrom=nvidia.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=nvidia.com; Received-SPF: Pass (protection.outlook.com: domain of nvidia.com designates 216.228.117.161 as permitted sender) receiver=protection.outlook.com; client-ip=216.228.117.161; helo=mail.nvidia.com; pr=C Received: from mail.nvidia.com (216.228.117.161) by BN8NAM11FT068.mail.protection.outlook.com (10.13.177.69) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6500.47 via Frontend Transport; Sun, 25 Jun 2023 06:42:46 +0000 Received: from rnnvmail201.nvidia.com (10.129.68.8) by mail.nvidia.com (10.129.200.67) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.986.5; Sat, 24 Jun 2023 23:42:33 -0700 Received: from nvidia.com (10.126.230.35) by rnnvmail201.nvidia.com (10.129.68.8) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.986.37; Sat, 24 Jun 2023 23:42:31 -0700 From: Xueming Li To: Saoirse O'Donovan CC: Ciara Power , Kai Ji , "dpdk stable" Subject: patch 'crypto/openssl: fix memory free' has been queued to stable release 22.11.3 Date: Sun, 25 Jun 2023 14:34:54 +0800 Message-ID: <20230625063544.11183-77-xuemingl@nvidia.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20230625063544.11183-1-xuemingl@nvidia.com> References: <20230625063544.11183-1-xuemingl@nvidia.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Type: text/plain X-Originating-IP: [10.126.230.35] X-ClientProxiedBy: rnnvmail202.nvidia.com (10.129.68.7) To rnnvmail201.nvidia.com (10.129.68.8) X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: BN8NAM11FT068:EE_|CYYPR12MB8732:EE_ X-MS-Office365-Filtering-Correlation-Id: 48726c02-d1d4-46c4-88fa-08db7547631b X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: +ZOy7Agi9HopEgoM8E0bE1L/51RhNgg8n95Q0/ATqc2d8m3p2dDDgt3lrDcKd195u9jqdURilQR1WwdJ+s5WcRlZXI+2Klm6oGeiG35lc32MJE507Jy4IoA1E2i9/QCzkxjPfYH5DVSzSHfCkJFJ0Xa+fSXloArQZV2dcGZzMBpIqfuZmibB5EV0PFyqdzz29U4QRazlfcjcS8YBoXZM2KvoS6c+0CDlvbBtgOCPk0bIu9U4Or3up1hA/ycS0AuWSCLsiRn1qvG8P7ZKXWv/zhd3BNueFwvH7akrJ5Z6WuZMsYjfMhC/57kmmBEHdDxpCtqTQyYoclgYZRDaGnxU9SiigAVvKMvww63Da1vgugCRuvMFPZzvG2GfPhaZ8MqcRKTOTsEflhPyP8LGz7LXzzrMDhxPp7GgAF96vRnneWNGR9RQ1yTd74/yYcNIY+0WdONMVX5K46UvnZGkCMNA08z3D42Um7zx+6kXgH4iH1YQ/rMze0JNoGnpIH/hwsmAHHK4P6ujkkNGLeZPeoQZC5UeGJ1Xq398P2UQHogRDldGnVsJG6zKvGfsHWG9H81ZB3lFKKezyFcqMzVt0ILzgdH+nHt6B+9WicvvxPZ6iBhqR9hNt2GpEN0PSEDr0dQnGv8/Mzz7VtZ732jQgvFpX0RLzgJ4fDWfNdsquuqDt+y8AlyufpsobheQnnMxSyrl3ZODJIdr2qQuBrKsryJU30+3KkA43lj5rkmzJ+M4AyW5rGQ9Pb0dH3rgKnAFqYJMkqEaKE6pGRFHfIOMB741lA== X-Forefront-Antispam-Report: CIP:216.228.117.161; CTRY:US; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:mail.nvidia.com; PTR:dc6edge2.nvidia.com; CAT:NONE; SFS:(13230028)(4636009)(346002)(396003)(376002)(39860400002)(136003)(451199021)(46966006)(36840700001)(40470700004)(478600001)(7696005)(6666004)(70586007)(70206006)(54906003)(53546011)(26005)(1076003)(16526019)(6286002)(186003)(966005)(2906002)(82310400005)(41300700001)(6916009)(4326008)(316002)(5660300002)(8936002)(8676002)(7636003)(356005)(82740400003)(40460700003)(86362001)(36756003)(47076005)(40480700001)(36860700001)(83380400001)(2616005)(426003)(336012)(55016003); DIR:OUT; SFP:1101; X-OriginatorOrg: Nvidia.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 25 Jun 2023 06:42:46.6902 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 48726c02-d1d4-46c4-88fa-08db7547631b X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=43083d15-7273-40c1-b7db-39efd9ccc17a; Ip=[216.228.117.161]; Helo=[mail.nvidia.com] X-MS-Exchange-CrossTenant-AuthSource: BN8NAM11FT068.eop-nam11.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: CYYPR12MB8732 X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org Hi, FYI, your patch has been queued to stable release 22.11.3 Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet. It will be pushed if I get no objections before 06/27/23. So please shout if anyone has objections. Also note that after the patch there's a diff of the upstream commit vs the patch applied to the branch. This will indicate if there was any rebasing needed to apply to the stable branch. If there were code changes for rebasing (ie: not only metadata diffs), please double check that the rebase was correctly done. Queued patches are on a temporary branch at: https://git.dpdk.org/dpdk-stable/log/?h=22.11-staging This queued commit can be viewed at: https://git.dpdk.org/dpdk-stable/commit/?h=22.11-staging&id=e3456f2478537de03017d34f18eb1fa54b694074 Thanks. Xueming Li --- >From e3456f2478537de03017d34f18eb1fa54b694074 Mon Sep 17 00:00:00 2001 From: Saoirse O'Donovan Date: Thu, 11 May 2023 13:59:44 +0000 Subject: [PATCH] crypto/openssl: fix memory free Cc: Xueming Li [ upstream commit 26c7b4fe2e2c26dca0a6c8ee3f8b66c1898c6a59 ] Allocated memory was being freed using 'free' when it should have been freed using 'OPENSSL_free'. This has now been modified so that the correct method is used to free allocated memory. Coverity issue: 384415 Fixes: 4c7ae22f1f83 ("crypto/openssl: update DSA routine with 3.0 EVP API") Signed-off-by: Saoirse O'Donovan Signed-off-by: Ciara Power Acked-by: Kai Ji --- drivers/crypto/openssl/rte_openssl_pmd.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/crypto/openssl/rte_openssl_pmd.c b/drivers/crypto/openssl/rte_openssl_pmd.c index 384d262621..f65fbca300 100644 --- a/drivers/crypto/openssl/rte_openssl_pmd.c +++ b/drivers/crypto/openssl/rte_openssl_pmd.c @@ -1927,7 +1927,7 @@ process_openssl_dsa_sign_op_evp(struct rte_crypto_op *cop, if (EVP_PKEY_sign(dsa_ctx, dsa_sign_data, &outlen, op->message.data, op->message.length) <= 0) { - free(dsa_sign_data); + OPENSSL_free(dsa_sign_data); goto err_dsa_sign; } @@ -1935,7 +1935,7 @@ process_openssl_dsa_sign_op_evp(struct rte_crypto_op *cop, DSA_SIG *sign = d2i_DSA_SIG(NULL, &dsa_sign_data_p, outlen); if (!sign) { OPENSSL_LOG(ERR, "%s:%d\n", __func__, __LINE__); - free(dsa_sign_data); + OPENSSL_free(dsa_sign_data); goto err_dsa_sign; } else { const BIGNUM *r = NULL, *s = NULL; @@ -1947,7 +1947,7 @@ process_openssl_dsa_sign_op_evp(struct rte_crypto_op *cop, } DSA_SIG_free(sign); - free(dsa_sign_data); + OPENSSL_free(dsa_sign_data); return 0; err_dsa_sign: -- 2.25.1 --- Diff of the applied patch vs upstream commit (please double-check if non-empty: --- --- - 2023-06-25 14:32:00.544251600 +0800 +++ 0076-crypto-openssl-fix-memory-free.patch 2023-06-25 14:31:58.445773900 +0800 @@ -1 +1 @@ -From 26c7b4fe2e2c26dca0a6c8ee3f8b66c1898c6a59 Mon Sep 17 00:00:00 2001 +From e3456f2478537de03017d34f18eb1fa54b694074 Mon Sep 17 00:00:00 2001 @@ -4,0 +5,3 @@ +Cc: Xueming Li + +[ upstream commit 26c7b4fe2e2c26dca0a6c8ee3f8b66c1898c6a59 ] @@ -12 +14,0 @@ -Cc: stable@dpdk.org