* [PATCH 22.11] common/cnxk: fix CPT backpressure disable on LBK
@ 2023-07-03 13:28 Rahul Bhansali
2023-08-09 12:54 ` Xueming(Steven) Li
0 siblings, 1 reply; 2+ messages in thread
From: Rahul Bhansali @ 2023-07-03 13:28 UTC (permalink / raw)
To: stable; +Cc: Rahul Bhansali
[ upstream commit 772e30281a1d686096b27e5926e2f369caa05cff ]
For LBK interfaces, roc_nix_inl_inb_is_enabled() is false, hence
backpressure on CPT is disabled and causing CQ full interrupt.
NIXX_AF_RX_CHAN[0x800]_CFG is global config for all PF, VF
of RPM/LBK, hence backpressure disable on CPT is not required.
Fixes: 0663a84524e5 ("common/cnxk: enable backpressure on CPT with inline inbound")
Signed-off-by: Rahul Bhansali <rbhansali@marvell.com>
---
drivers/common/cnxk/roc_nix_fc.c | 11 -----------
1 file changed, 11 deletions(-)
diff --git a/drivers/common/cnxk/roc_nix_fc.c b/drivers/common/cnxk/roc_nix_fc.c
index 033e17a4bf..5e8a01c775 100644
--- a/drivers/common/cnxk/roc_nix_fc.c
+++ b/drivers/common/cnxk/roc_nix_fc.c
@@ -88,17 +88,6 @@ nix_fc_rxchan_bpid_set(struct roc_nix *roc_nix, bool enable)
req->chan_cnt = 1;
req->bpid_per_chan = 0;
- rc = mbox_process_msg(mbox, (void *)&rsp);
- if (rc)
- goto exit;
- } else {
- req = mbox_alloc_msg_nix_cpt_bp_disable(mbox);
- if (req == NULL)
- return rc;
- req->chan_base = 0;
- req->chan_cnt = 1;
- req->bpid_per_chan = 0;
-
rc = mbox_process_msg(mbox, (void *)&rsp);
if (rc)
goto exit;
--
2.25.1
^ permalink raw reply [flat|nested] 2+ messages in thread
* RE: [PATCH 22.11] common/cnxk: fix CPT backpressure disable on LBK
2023-07-03 13:28 [PATCH 22.11] common/cnxk: fix CPT backpressure disable on LBK Rahul Bhansali
@ 2023-08-09 12:54 ` Xueming(Steven) Li
0 siblings, 0 replies; 2+ messages in thread
From: Xueming(Steven) Li @ 2023-08-09 12:54 UTC (permalink / raw)
To: Rahul Bhansali, stable
Hi Rahul,
Thanks for the backport! Patch queued to 22.11.3 stable list.
> -----Original Message-----
> From: Rahul Bhansali <rbhansali@marvell.com>
> Sent: 7/3/2023 21:28
> To: stable@dpdk.org
> Cc: Rahul Bhansali <rbhansali@marvell.com>
> Subject: [PATCH 22.11] common/cnxk: fix CPT backpressure disable on LBK
>
> [ upstream commit 772e30281a1d686096b27e5926e2f369caa05cff ]
>
> For LBK interfaces, roc_nix_inl_inb_is_enabled() is false, hence backpressure
> on CPT is disabled and causing CQ full interrupt.
>
> NIXX_AF_RX_CHAN[0x800]_CFG is global config for all PF, VF of RPM/LBK,
> hence backpressure disable on CPT is not required.
>
> Fixes: 0663a84524e5 ("common/cnxk: enable backpressure on CPT with inline
> inbound")
>
> Signed-off-by: Rahul Bhansali <rbhansali@marvell.com>
> ---
> drivers/common/cnxk/roc_nix_fc.c | 11 -----------
> 1 file changed, 11 deletions(-)
>
> diff --git a/drivers/common/cnxk/roc_nix_fc.c
> b/drivers/common/cnxk/roc_nix_fc.c
> index 033e17a4bf..5e8a01c775 100644
> --- a/drivers/common/cnxk/roc_nix_fc.c
> +++ b/drivers/common/cnxk/roc_nix_fc.c
> @@ -88,17 +88,6 @@ nix_fc_rxchan_bpid_set(struct roc_nix *roc_nix, bool
> enable)
> req->chan_cnt = 1;
> req->bpid_per_chan = 0;
>
> - rc = mbox_process_msg(mbox, (void *)&rsp);
> - if (rc)
> - goto exit;
> - } else {
> - req = mbox_alloc_msg_nix_cpt_bp_disable(mbox);
> - if (req == NULL)
> - return rc;
> - req->chan_base = 0;
> - req->chan_cnt = 1;
> - req->bpid_per_chan = 0;
> -
> rc = mbox_process_msg(mbox, (void *)&rsp);
> if (rc)
> goto exit;
> --
> 2.25.1
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2023-08-09 12:54 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2023-07-03 13:28 [PATCH 22.11] common/cnxk: fix CPT backpressure disable on LBK Rahul Bhansali
2023-08-09 12:54 ` Xueming(Steven) Li
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).