From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 95C5E42DFC for ; Sat, 8 Jul 2023 03:54:40 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 7E63441143; Sat, 8 Jul 2023 03:54:40 +0200 (CEST) Received: from mail-pl1-f171.google.com (mail-pl1-f171.google.com [209.85.214.171]) by mails.dpdk.org (Postfix) with ESMTP id EF8ED40A8A for ; Sat, 8 Jul 2023 03:54:38 +0200 (CEST) Received: by mail-pl1-f171.google.com with SMTP id d9443c01a7336-1b8a8154f9cso17289625ad.1 for ; Fri, 07 Jul 2023 18:54:38 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20221208.gappssmtp.com; s=20221208; t=1688781277; x=1691373277; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:subject:cc:to:from:date:from:to:cc:subject:date :message-id:reply-to; bh=GV4gi3YYmzQEkij2HXAt8pfMnMX76JmAzNavFxGEhw0=; b=HTmvOl7CWdztGwHsE4KEsJYon1FoKrsm5NwTDWTiqLDu13ZbbWjWJAw6IZ+mruYOov DkcgjZSVY33UmuIjVHqIuJ1lDiWxgX+rGAfXegWbhGp04yyvPWdoNSc61FYJqwJquaKU fu6Wtq5kxyYb9W+yccDFJXUrhz86BjKll/c2uB0ObLf7ABYxfQsKRo9JERmcb4Ix6ZCh XTSrrqoXaw8Xi9PXC/TWE9koqmsdYMUi7W+cHQmxsMF24p4I2flJzMYSTwF3bcZd/5Ai /+Px6ksZTm6dlyiy5BR4BJlpnftXgsV+hGlyIAKIT+51hA41tpXUeM+UrMWYBFNgew1B 6QrQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1688781277; x=1691373277; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:subject:cc:to:from:date:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=GV4gi3YYmzQEkij2HXAt8pfMnMX76JmAzNavFxGEhw0=; b=edKkaqbL9aqgvNyY9HS7sP7IHX131YsBikbr3eI+YykmPWo348laYna488BdwD2Hyc RKLuJjWI9T+FZQzVtmFU0I3CYt7jdRtkHPIca0bV6FfFiTNjGtaPxhS1BItL5WQYfd9G MtPUpsBF1ur3znYXPv3YwfUT6tGDiV5ahCCI54oubRygP39aF5IZU9jAerJHOLW0pJMb b0QaEgq9jCMDLKhROLClpzcwS9RV9GFnripBBqlz2bEpDWQSf7cXrThGvohbFXTo2VOd nKv1iwJYEefUyQy/nwvIjLU6G7KxCUaV6JR9Kvh/3KKld4/6CjwsfrNqSQJmcZrCeLx7 LY6Q== X-Gm-Message-State: ABy/qLaWN3iWOaVxWpvF0OoyWqUKk9xX5YgEEgVmiWjSHOUnmdMd6SGu 0Qgv1jZB86R9ZaXBe1/Luh+Siw== X-Google-Smtp-Source: APBJJlFW6+qE+mYch6m9hcDx/mdMFQoBfRBmbKEMRkiu4mleip8rIi8isb1gBH+c8D0ZasLWIpBVfQ== X-Received: by 2002:a17:902:a514:b0:1b1:99c9:8ce5 with SMTP id s20-20020a170902a51400b001b199c98ce5mr12230477plq.16.1688781276930; Fri, 07 Jul 2023 18:54:36 -0700 (PDT) Received: from hermes.local (204-195-120-218.wavecable.com. [204.195.120.218]) by smtp.gmail.com with ESMTPSA id ba10-20020a170902720a00b001b83e624eecsm3854867plb.81.2023.07.07.18.54.36 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 07 Jul 2023 18:54:36 -0700 (PDT) Date: Fri, 7 Jul 2023 18:54:34 -0700 From: Stephen Hemminger To: Dmitry Kozlyuk Cc: "dev@dpdk.org" , "stable@dpdk.org" , Matan Azrad , Xiaoyun Li , Aman Singh , Yuying Zhang Subject: Re: [PATCH v3 1/2] app/testpmd: do not poll stopped queues Message-ID: <20230707185434.022934d7@hermes.local> In-Reply-To: References: <20220306232310.613552-1-dkozlyuk@nvidia.com> <20220307125351.697936-1-dkozlyuk@nvidia.com> <20220307125351.697936-2-dkozlyuk@nvidia.com> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org On Wed, 9 Mar 2022 10:36:15 +0000 Dmitry Kozlyuk wrote: > > Calling Rx/Tx functions on a stopped queue is not supported. > > Do not run packet forwarding for streams that use stopped queues. > > > > Each stream has a read-only "disabled" field, > > so that lcore function can skip such streams. > > Forwarding engines can set this field > > using a new "stream_init" callback function > > by checking relevant queue states, > > which are stored along with queue configurations > > (not all PMDs implement rte_eth_rx/tx_queue_info_get() > > to query the state from there). > > > > Fixes: 5f4ec54f1d16 ("testpmd: queue start and stop") > > Cc: stable@dpdk.org > > > > Signed-off-by: Dmitry Kozlyuk > > Acked-by: Matan Azrad > > --- > > Pinging testpmd maintainers for this bugfix. > The sibling ethdev patch will have to wait until the next release cycle. So you broke a bunch of drivers now that is merged??? Sound like it needs to be reverted. Certainly not something that should go into stable tree if you expect all drivers to correctly set queue state.