From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 09ABC42ECF for ; Thu, 20 Jul 2023 17:23:46 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 0657B40685; Thu, 20 Jul 2023 17:23:46 +0200 (CEST) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by mails.dpdk.org (Postfix) with ESMTP id 30FB5400D6 for ; Thu, 20 Jul 2023 17:23:44 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1689866623; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=MDCvtHg8BofkUjusWJzVPszJquLWwt9r8+C+9Egfw24=; b=Hsy9aabB/Wi34xKvsk0RpH2mve4aTm4sPs2BJYG+SzedzC2WwVSQUgI/moYJhbvk+sOsAT bHmQeCPVA4WgYlnb00AVdT2TZkfQLQsd1P3TLoVKT16okw4E3+65MKNyMRakUe5mBBjT1O 0rSzzBZtPj0K05dFY/vT9rugnJ1grvo= Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-312-WbT2OvthPWmD94h6NS7jJw-1; Thu, 20 Jul 2023 11:21:04 -0400 X-MC-Unique: WbT2OvthPWmD94h6NS7jJw-1 Received: from smtp.corp.redhat.com (int-mx10.intmail.prod.int.rdu2.redhat.com [10.11.54.10]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 2A3EB8F1845; Thu, 20 Jul 2023 15:20:35 +0000 (UTC) Received: from rh.redhat.com (unknown [10.39.192.15]) by smtp.corp.redhat.com (Postfix) with ESMTP id 33AC3492C13; Thu, 20 Jul 2023 15:20:34 +0000 (UTC) From: Kevin Traynor To: Raslan Darawsheh Cc: Aman Singh , dpdk stable Subject: patch 'app/testpmd: fix GTP L2 length in checksum engine' has been queued to stable release 21.11.5 Date: Thu, 20 Jul 2023 16:17:37 +0100 Message-ID: <20230720151942.262154-26-ktraynor@redhat.com> In-Reply-To: <20230720151942.262154-1-ktraynor@redhat.com> References: <20230720151942.262154-1-ktraynor@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 3.1 on 10.11.54.10 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: 8bit Content-Type: text/plain; charset="US-ASCII"; x-default=true X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org Hi, FYI, your patch has been queued to stable release 21.11.5 Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet. It will be pushed if I get no objections before 07/25/23. So please shout if anyone has objections. Also note that after the patch there's a diff of the upstream commit vs the patch applied to the branch. This will indicate if there was any rebasing needed to apply to the stable branch. If there were code changes for rebasing (ie: not only metadata diffs), please double check that the rebase was correctly done. Queued patches are on a temporary branch at: https://github.com/kevintraynor/dpdk-stable This queued commit can be viewed at: https://github.com/kevintraynor/dpdk-stable/commit/b23b2580e3afba41f43b4fb5aed04cebb44869f2 Thanks. Kevin --- >From b23b2580e3afba41f43b4fb5aed04cebb44869f2 Mon Sep 17 00:00:00 2001 From: Raslan Darawsheh Date: Sun, 2 Apr 2023 15:26:19 +0300 Subject: [PATCH] app/testpmd: fix GTP L2 length in checksum engine [ upstream commit dd827fa42a30a9b0aa87a1d5614af83ea32b19e0 ] GTP header can be followed by an optional 32 bits extension. But, l2_len value statically set to RTE_ETHER_GTP_HLEN which is defined to be (sizeof(struct rte_udp_hdr) + sizeof(struct rte_gtp_hdr)) This fixes the l2_len to take into consideration the extension size. Fixes: d8e5e69f3a9b ("app/testpmd: add GTP parsing and Tx checksum offload") Signed-off-by: Raslan Darawsheh Acked-by: Aman Singh --- app/test-pmd/csumonly.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/app/test-pmd/csumonly.c b/app/test-pmd/csumonly.c index 80d4d415bd..16c05b3527 100644 --- a/app/test-pmd/csumonly.c +++ b/app/test-pmd/csumonly.c @@ -251,5 +251,5 @@ parse_gtp(struct rte_udp_hdr *udp_hdr, } - info->l2_len += RTE_ETHER_GTP_HLEN; + info->l2_len += gtp_len + sizeof(udp_hdr); } -- 2.41.0 --- Diff of the applied patch vs upstream commit (please double-check if non-empty: --- --- - 2023-07-20 16:17:58.211196267 +0100 +++ 0026-app-testpmd-fix-GTP-L2-length-in-checksum-engine.patch 2023-07-20 16:17:54.502749858 +0100 @@ -1 +1 @@ -From dd827fa42a30a9b0aa87a1d5614af83ea32b19e0 Mon Sep 17 00:00:00 2001 +From b23b2580e3afba41f43b4fb5aed04cebb44869f2 Mon Sep 17 00:00:00 2001 @@ -5,0 +6,2 @@ +[ upstream commit dd827fa42a30a9b0aa87a1d5614af83ea32b19e0 ] + @@ -15 +16,0 @@ -Cc: stable@dpdk.org @@ -24 +25 @@ -index fc85c22a77..b50b89367a 100644 +index 80d4d415bd..16c05b3527 100644