From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 4748242ECF for ; Thu, 20 Jul 2023 17:24:30 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 435EA42D48; Thu, 20 Jul 2023 17:24:30 +0200 (CEST) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by mails.dpdk.org (Postfix) with ESMTP id 3177F400D6 for ; Thu, 20 Jul 2023 17:24:29 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1689866668; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=wUOCWnYSFrMyvOXa1iGG8mZcjtSqBadsJTt6RK+nHi8=; b=a9nJGNZcraxQSkHWnlSfdE4pEz1FMi4vUufE68Ax+EdOGvm9sanO4bPH7f07W+qBlTGFNH W9Moyex2SpP8uC8wcI3xUU38h1EI7lyY18Sv7n80VyEXCNeN+sZrPsQ7SNcr8YUC6qevzx aTNQl/HPjnhr3gOl76aKsYHaWzLl0do= Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-208-9SMqG9buNiS-rQu5r6s4uQ-1; Thu, 20 Jul 2023 11:22:21 -0400 X-MC-Unique: 9SMqG9buNiS-rQu5r6s4uQ-1 Received: from smtp.corp.redhat.com (int-mx10.intmail.prod.int.rdu2.redhat.com [10.11.54.10]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 90A8B887157; Thu, 20 Jul 2023 15:21:32 +0000 (UTC) Received: from rh.redhat.com (unknown [10.39.192.15]) by smtp.corp.redhat.com (Postfix) with ESMTP id 5ACD04A9004; Thu, 20 Jul 2023 15:21:31 +0000 (UTC) From: Kevin Traynor To: David Marchand Cc: Gregory Etelson , Raslan Darawsheh , dpdk stable Subject: patch 'net/mlx5: enhance error log for tunnel offloading' has been queued to stable release 21.11.5 Date: Thu, 20 Jul 2023 16:18:10 +0100 Message-ID: <20230720151942.262154-59-ktraynor@redhat.com> In-Reply-To: <20230720151942.262154-1-ktraynor@redhat.com> References: <20230720151942.262154-1-ktraynor@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 3.1 on 10.11.54.10 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: 8bit Content-Type: text/plain; charset="US-ASCII"; x-default=true X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org Hi, FYI, your patch has been queued to stable release 21.11.5 Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet. It will be pushed if I get no objections before 07/25/23. So please shout if anyone has objections. Also note that after the patch there's a diff of the upstream commit vs the patch applied to the branch. This will indicate if there was any rebasing needed to apply to the stable branch. If there were code changes for rebasing (ie: not only metadata diffs), please double check that the rebase was correctly done. Queued patches are on a temporary branch at: https://github.com/kevintraynor/dpdk-stable This queued commit can be viewed at: https://github.com/kevintraynor/dpdk-stable/commit/2681bfff6d10c06d0086b128872576266ea8f58f Thanks. Kevin --- >From 2681bfff6d10c06d0086b128872576266ea8f58f Mon Sep 17 00:00:00 2001 From: David Marchand Date: Thu, 27 Apr 2023 13:55:34 +0200 Subject: [PATCH] net/mlx5: enhance error log for tunnel offloading [ upstream commit c9fecc1cc2886bcd626a656a5493841363dec6dd ] Tunnel offloading is linked to running a port with the non-obvious dv_xmeta_en=3 devargs. Hint at it for "normal" users. Fixes: 4ec6360de37d ("net/mlx5: implement tunnel offload") Signed-off-by: David Marchand Reviewed-by: Gregory Etelson Acked-by: Raslan Darawsheh --- drivers/net/mlx5/mlx5_flow.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/mlx5/mlx5_flow.c b/drivers/net/mlx5/mlx5_flow.c index 79b4847f39..1e147c2e0d 100644 --- a/drivers/net/mlx5/mlx5_flow.c +++ b/drivers/net/mlx5/mlx5_flow.c @@ -9698,5 +9698,5 @@ mlx5_flow_tunnel_validate(struct rte_eth_dev *dev, return rte_flow_error_set(error, ENOTSUP, RTE_FLOW_ERROR_TYPE_ACTION_CONF, NULL, - "tunnel offload was not activated"); + "tunnel offload was not activated, consider setting dv_xmeta_en=3"); if (!tunnel) return rte_flow_error_set(error, EINVAL, -- 2.41.0 --- Diff of the applied patch vs upstream commit (please double-check if non-empty: --- --- - 2023-07-20 16:18:02.138025977 +0100 +++ 0059-net-mlx5-enhance-error-log-for-tunnel-offloading.patch 2023-07-20 16:17:54.799751071 +0100 @@ -1 +1 @@ -From c9fecc1cc2886bcd626a656a5493841363dec6dd Mon Sep 17 00:00:00 2001 +From 2681bfff6d10c06d0086b128872576266ea8f58f Mon Sep 17 00:00:00 2001 @@ -5,0 +6,2 @@ +[ upstream commit c9fecc1cc2886bcd626a656a5493841363dec6dd ] + @@ -10 +11,0 @@ -Cc: stable@dpdk.org @@ -20 +21 @@ -index 156f826b8a..c32783efb2 100644 +index 79b4847f39..1e147c2e0d 100644 @@ -23 +24 @@ -@@ -11330,5 +11330,5 @@ mlx5_flow_tunnel_validate(struct rte_eth_dev *dev, +@@ -9698,5 +9698,5 @@ mlx5_flow_tunnel_validate(struct rte_eth_dev *dev,