From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 2A00C42ECF for ; Thu, 20 Jul 2023 17:21:04 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 2635040685; Thu, 20 Jul 2023 17:21:04 +0200 (CEST) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by mails.dpdk.org (Postfix) with ESMTP id 9E8F4400D6 for ; Thu, 20 Jul 2023 17:21:02 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1689866462; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=AoNyWGBaqo7hn7EVipkNBm9MDISWN2Caw/LOYHIdIxY=; b=i+ASzg9gy4Ve3hSkE3Bo344pOyvtA81d8ZEejNpNKiAUElzDVpiEkUJm4uLlroG9RcQv51 JDBzx3BoHcUE3++WZhwnKkuTwDASh5TsYI92j0R5o2Sz6Oz4Dw6a3WSVFP9fUVgQNSPxSu DSUViC8WUbRmYmpXEeSqBq5ky0C/aDU= Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-595-htxgoTTYNb61uRYmaAi08A-1; Thu, 20 Jul 2023 11:20:09 -0400 X-MC-Unique: htxgoTTYNb61uRYmaAi08A-1 Received: from smtp.corp.redhat.com (int-mx10.intmail.prod.int.rdu2.redhat.com [10.11.54.10]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id ADBF088D070; Thu, 20 Jul 2023 15:20:03 +0000 (UTC) Received: from rh.redhat.com (unknown [10.39.192.15]) by smtp.corp.redhat.com (Postfix) with ESMTP id 58B384A9004; Thu, 20 Jul 2023 15:20:02 +0000 (UTC) From: Kevin Traynor To: Bruce Richardson Cc: John Baldwin , Tyler Retzlaff , dpdk stable Subject: patch 'kernel/freebsd: fix function parameter list' has been queued to stable release 21.11.5 Date: Thu, 20 Jul 2023 16:17:17 +0100 Message-ID: <20230720151942.262154-6-ktraynor@redhat.com> In-Reply-To: <20230720151942.262154-1-ktraynor@redhat.com> References: <20230720151942.262154-1-ktraynor@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 3.1 on 10.11.54.10 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: 8bit Content-Type: text/plain; charset="US-ASCII"; x-default=true X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org Hi, FYI, your patch has been queued to stable release 21.11.5 Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet. It will be pushed if I get no objections before 07/25/23. So please shout if anyone has objections. Also note that after the patch there's a diff of the upstream commit vs the patch applied to the branch. This will indicate if there was any rebasing needed to apply to the stable branch. If there were code changes for rebasing (ie: not only metadata diffs), please double check that the rebase was correctly done. Queued patches are on a temporary branch at: https://github.com/kevintraynor/dpdk-stable This queued commit can be viewed at: https://github.com/kevintraynor/dpdk-stable/commit/e8393bfd7bb3b9798f31baa9cc89fae6b933ab50 Thanks. Kevin --- >From e8393bfd7bb3b9798f31baa9cc89fae6b933ab50 Mon Sep 17 00:00:00 2001 From: Bruce Richardson Date: Mon, 22 May 2023 10:22:41 +0100 Subject: [PATCH] kernel/freebsd: fix function parameter list [ upstream commit 12b7ef3c4a6262e1c0f747bd0037a3a8df38ab4c ] Functions which take no parameters should explicitly have "(void)" as the parameter list, rather than "()". Reported upstream on FreeBSD ports collection [1]. [1] https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=271524 Fixes: 764bf26873b9 ("add FreeBSD support") Reported-by: John Baldwin Signed-off-by: Bruce Richardson Acked-by: Tyler Retzlaff --- kernel/freebsd/contigmem/contigmem.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/kernel/freebsd/contigmem/contigmem.c b/kernel/freebsd/contigmem/contigmem.c index bd72f4d620..7dd87599d9 100644 --- a/kernel/freebsd/contigmem/contigmem.c +++ b/kernel/freebsd/contigmem/contigmem.c @@ -112,5 +112,5 @@ static struct cdevsw contigmem_ops = { static int -contigmem_load() +contigmem_load(void) { char index_string[8], description[32]; @@ -179,5 +179,5 @@ error: static int -contigmem_unload() +contigmem_unload(void) { int i; -- 2.41.0 --- Diff of the applied patch vs upstream commit (please double-check if non-empty: --- --- - 2023-07-20 16:17:55.972662181 +0100 +++ 0006-kernel-freebsd-fix-function-parameter-list.patch 2023-07-20 16:17:54.428749556 +0100 @@ -1 +1 @@ -From 12b7ef3c4a6262e1c0f747bd0037a3a8df38ab4c Mon Sep 17 00:00:00 2001 +From e8393bfd7bb3b9798f31baa9cc89fae6b933ab50 Mon Sep 17 00:00:00 2001 @@ -5,0 +6,2 @@ +[ upstream commit 12b7ef3c4a6262e1c0f747bd0037a3a8df38ab4c ] + @@ -14 +15,0 @@ -Cc: stable@dpdk.org