* [PATCH] app/test: fix include of standard header
@ 2023-07-21 10:57 Bruce Richardson
2023-07-21 11:24 ` Morten Brørup
0 siblings, 1 reply; 3+ messages in thread
From: Bruce Richardson @ 2023-07-21 10:57 UTC (permalink / raw)
To: dev; +Cc: Bruce Richardson, stable
Standard headers, or headers not in the current directory generally,
should be wrapped in "<>" rather than in regular quotes "". Fix one
instance of unistd.h being included using quotes
Fixes: df468c4937bb ("app/test: refactor bonding checks with macros")
Cc: stable@dpdk.org
Signed-off-by: Bruce Richardson <bruce.richardson@intel.com>
---
app/test/test_link_bonding.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/app/test/test_link_bonding.c b/app/test/test_link_bonding.c
index 5c496352c2..2f46e4c6ee 100644
--- a/app/test/test_link_bonding.c
+++ b/app/test/test_link_bonding.c
@@ -2,7 +2,7 @@
* Copyright(c) 2010-2014 Intel Corporation
*/
-#include "unistd.h"
+#include <unistd.h>
#include <string.h>
#include <stdarg.h>
#include <stdio.h>
--
2.39.2
^ permalink raw reply [flat|nested] 3+ messages in thread
* RE: [PATCH] app/test: fix include of standard header
2023-07-21 10:57 [PATCH] app/test: fix include of standard header Bruce Richardson
@ 2023-07-21 11:24 ` Morten Brørup
2023-07-21 17:24 ` Ferruh Yigit
0 siblings, 1 reply; 3+ messages in thread
From: Morten Brørup @ 2023-07-21 11:24 UTC (permalink / raw)
To: Bruce Richardson, dev; +Cc: stable
> From: Bruce Richardson [mailto:bruce.richardson@intel.com]
> Sent: Friday, 21 July 2023 12.57
>
> Standard headers, or headers not in the current directory generally,
> should be wrapped in "<>" rather than in regular quotes "". Fix one
> instance of unistd.h being included using quotes
>
> Fixes: df468c4937bb ("app/test: refactor bonding checks with macros")
> Cc: stable@dpdk.org
>
> Signed-off-by: Bruce Richardson <bruce.richardson@intel.com>
> ---
Acked-by: Morten Brørup <mb@smartsharesystems.com>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] app/test: fix include of standard header
2023-07-21 11:24 ` Morten Brørup
@ 2023-07-21 17:24 ` Ferruh Yigit
0 siblings, 0 replies; 3+ messages in thread
From: Ferruh Yigit @ 2023-07-21 17:24 UTC (permalink / raw)
To: Morten Brørup, Bruce Richardson, dev; +Cc: stable
On 7/21/2023 12:24 PM, Morten Brørup wrote:
>> From: Bruce Richardson [mailto:bruce.richardson@intel.com]
>> Sent: Friday, 21 July 2023 12.57
>>
>> Standard headers, or headers not in the current directory generally,
>> should be wrapped in "<>" rather than in regular quotes "". Fix one
>> instance of unistd.h being included using quotes
>>
>> Fixes: df468c4937bb ("app/test: refactor bonding checks with macros")
>> Cc: stable@dpdk.org
>>
>> Signed-off-by: Bruce Richardson <bruce.richardson@intel.com>
>> ---
>
> Acked-by: Morten Brørup <mb@smartsharesystems.com>
>
Acked-by: Ferruh Yigit <ferruh.yigit@amd.com>
Applied to dpdk-next-net/main, thanks.
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2023-07-21 17:25 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2023-07-21 10:57 [PATCH] app/test: fix include of standard header Bruce Richardson
2023-07-21 11:24 ` Morten Brørup
2023-07-21 17:24 ` Ferruh Yigit
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).