patches for DPDK stable branches
 help / color / mirror / Atom feed
* patch 'doc: fix typos and wording in flow API guide' has been queued to stable release 21.11.5
@ 2023-07-21 13:34 Kevin Traynor
  2023-07-21 13:34 ` patch 'net/i40e: fix comments' " Kevin Traynor
                   ` (9 more replies)
  0 siblings, 10 replies; 11+ messages in thread
From: Kevin Traynor @ 2023-07-21 13:34 UTC (permalink / raw)
  To: Ali Alnubani; +Cc: John McNamara, dpdk stable

Hi,

FYI, your patch has been queued to stable release 21.11.5

Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet.
It will be pushed if I get no objections before 07/25/23. So please
shout if anyone has objections.

Also note that after the patch there's a diff of the upstream commit vs the
patch applied to the branch. This will indicate if there was any rebasing
needed to apply to the stable branch. If there were code changes for rebasing
(ie: not only metadata diffs), please double check that the rebase was
correctly done.

Queued patches are on a temporary branch at:
https://github.com/kevintraynor/dpdk-stable

This queued commit can be viewed at:
https://github.com/kevintraynor/dpdk-stable/commit/dd28326d46529442343ce831beacd6e83640855c

Thanks.

Kevin

---
From dd28326d46529442343ce831beacd6e83640855c Mon Sep 17 00:00:00 2001
From: Ali Alnubani <alialnu@nvidia.com>
Date: Sun, 16 Jul 2023 09:58:26 +0300
Subject: [PATCH] doc: fix typos and wording in flow API guide

[ upstream commit d9f1751090ce1055a64f1d9a5f43758acae2c5ac ]

This fixes typos, punctuation and wording in the rte flow API guide.

Fixes: 2f82d143fb31 ("ethdev: add group jump action")

Signed-off-by: Ali Alnubani <alialnu@nvidia.com>
Acked-by: John McNamara <john.mcnamara@intel.com>
---
 doc/guides/prog_guide/rte_flow.rst | 17 +++++++++--------
 1 file changed, 9 insertions(+), 8 deletions(-)

diff --git a/doc/guides/prog_guide/rte_flow.rst b/doc/guides/prog_guide/rte_flow.rst
index 61d0d0899a..91ace7ae7a 100644
--- a/doc/guides/prog_guide/rte_flow.rst
+++ b/doc/guides/prog_guide/rte_flow.rst
@@ -149,12 +149,13 @@ Flow rules can be grouped by assigning them a common group number. Groups
 allow a logical hierarchy of flow rule groups (tables) to be defined. These
 groups can be supported virtually in the PMD or in the physical device.
-Group 0 is the default group and this is the only group which flows are
-guarantee to matched against, all subsequent groups can only be reached by
-way of the JUMP action from a matched flow rule.
+Group 0 is the default group and is the only group that
+flows are guaranteed to be matched against.
+All subsequent groups can only be reached by using a JUMP action
+from a matched flow rule.
 
 Although optional, applications are encouraged to group similar rules as
 much as possible to fully take advantage of hardware capabilities
 (e.g. optimized matching) and work around limitations (e.g. a single pattern
-type possibly allowed in a given group), while being aware that the groups
+type possibly allowed in a given group), while being aware that the groups'
 hierarchies must be programmed explicitly.
 
@@ -171,5 +172,5 @@ not need to be contiguous nor start from 0, however the maximum number
 varies between devices and may be affected by existing flow rules.
 
-A flow which matches multiple rules in the same group will always matched by
+A flow which matches multiple rules in the same group will always be matched by
 the rule with the highest priority in that group.
 
@@ -1832,10 +1833,10 @@ the specified group on that device.
 
 If a matched flow is redirected to a table which doesn't contain a matching
-rule for that flow then the behavior is undefined and the resulting behavior
-is up to the specific device. Best practice when using groups would be define
+rule for that flow, then the behavior is undefined and the resulting behavior
+is up to the specific device. Best practice when using groups would be to define
 a default flow rule for each group which a defines the default actions in that
 group so a consistent behavior is defined.
 
-Defining an action for matched flow in a group to jump to a group which is
+Defining an action for a matched flow in a group to jump to a group which is
 higher in the group hierarchy may not be supported by physical devices,
 depending on how groups are mapped to the physical devices. In the
-- 
2.41.0

---
  Diff of the applied patch vs upstream commit (please double-check if non-empty:
---
--- -	2023-07-21 14:33:59.046079280 +0100
+++ 0001-doc-fix-typos-and-wording-in-flow-API-guide.patch	2023-07-21 14:33:58.986253149 +0100
@@ -1 +1 @@
-From d9f1751090ce1055a64f1d9a5f43758acae2c5ac Mon Sep 17 00:00:00 2001
+From dd28326d46529442343ce831beacd6e83640855c Mon Sep 17 00:00:00 2001
@@ -5,0 +6,2 @@
+[ upstream commit d9f1751090ce1055a64f1d9a5f43758acae2c5ac ]
+
@@ -9 +10,0 @@
-Cc: stable@dpdk.org
@@ -18 +19 @@
-index 28d09c58d5..5bc998a433 100644
+index 61d0d0899a..91ace7ae7a 100644
@@ -46 +47 @@
-@@ -1770,10 +1771,10 @@ the specified group on that device.
+@@ -1832,10 +1833,10 @@ the specified group on that device.


^ permalink raw reply	[flat|nested] 11+ messages in thread
end of thread, other threads:[~2023-07-21 13:35 UTC | newest]

Thread overview: 11+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2023-07-21 13:34 patch 'doc: fix typos and wording in flow API guide' has been queued to stable release 21.11.5 Kevin Traynor
2023-07-21 13:34 ` patch 'net/i40e: fix comments' " Kevin Traynor
2023-07-21 13:34 ` patch 'net/iavf: fix stop ordering' " Kevin Traynor
2023-07-21 13:34 ` patch 'common/iavf: fix MAC type for 710 NIC' " Kevin Traynor
2023-07-21 13:35 ` patch 'net/ixgbe: fix Rx and Tx queue status' " Kevin Traynor
2023-07-21 13:35 ` patch 'net/igc: " Kevin Traynor
2023-07-21 13:35 ` patch 'net/e1000: " Kevin Traynor
2023-07-21 13:35 ` patch 'net/mlx5: fix drop action memory leak' " Kevin Traynor
2023-07-21 13:35 ` patch 'net/mlx5: fix LRO TCP checksum' " Kevin Traynor
2023-07-21 13:35 ` patch 'net/mlx5: fix validation for conntrack indirect action' " Kevin Traynor
2023-07-21 13:35 ` patch 'doc: update BIOS settings and supported HW for NTB' " Kevin Traynor

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).