patches for DPDK stable branches
 help / color / mirror / Atom feed
From: Kevin Traynor <ktraynor@redhat.com>
To: Qiming Yang <qiming.yang@intel.com>
Cc: Jie Hai <haijie1@huawei.com>, Qi Zhang <qi.z.zhang@intel.com>,
	dpdk stable <stable@dpdk.org>
Subject: patch 'net/ixgbe: fix Rx and Tx queue status' has been queued to stable release 21.11.5
Date: Fri, 21 Jul 2023 14:35:00 +0100	[thread overview]
Message-ID: <20230721133509.348959-5-ktraynor@redhat.com> (raw)
In-Reply-To: <20230721133509.348959-1-ktraynor@redhat.com>

Hi,

FYI, your patch has been queued to stable release 21.11.5

Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet.
It will be pushed if I get no objections before 07/25/23. So please
shout if anyone has objections.

Also note that after the patch there's a diff of the upstream commit vs the
patch applied to the branch. This will indicate if there was any rebasing
needed to apply to the stable branch. If there were code changes for rebasing
(ie: not only metadata diffs), please double check that the rebase was
correctly done.

Queued patches are on a temporary branch at:
https://github.com/kevintraynor/dpdk-stable

This queued commit can be viewed at:
https://github.com/kevintraynor/dpdk-stable/commit/a821b0298b6131989a1025269650b07c7dcb2fbe

Thanks.

Kevin

---
From a821b0298b6131989a1025269650b07c7dcb2fbe Mon Sep 17 00:00:00 2001
From: Qiming Yang <qiming.yang@intel.com>
Date: Wed, 12 Jul 2023 08:31:51 +0000
Subject: [PATCH] net/ixgbe: fix Rx and Tx queue status

[ upstream commit 4a8490075692c32797be4280aea33772a5865038 ]

Ixgbevf driver don't enable queue start/stop functions, queue status is not
updated when the HW queue enabled or disabled. It caused application can't
get correct queue status.
This patch fixes the issue by updating the queue states when the queue is
disabled or enabled.

Fixes: 429c6d86b371 ("ixgbe: prepare for vector pmd")
Fixes: f0c50e5f56fa ("ixgbe: move PMD specific fields out of base driver")

Signed-off-by: Qiming Yang <qiming.yang@intel.com>
Signed-off-by: Jie Hai <haijie1@huawei.com>
Acked-by: Qi Zhang <qi.z.zhang@intel.com>
---
 drivers/net/ixgbe/ixgbe_rxtx.c | 6 ++++++
 1 file changed, 6 insertions(+)

diff --git a/drivers/net/ixgbe/ixgbe_rxtx.c b/drivers/net/ixgbe/ixgbe_rxtx.c
index 12e8abcbef..c137707869 100644
--- a/drivers/net/ixgbe/ixgbe_rxtx.c
+++ b/drivers/net/ixgbe/ixgbe_rxtx.c
@@ -3381,4 +3381,5 @@ ixgbe_dev_clear_queues(struct rte_eth_dev *dev)
 			txq->ops->release_mbufs(txq);
 			txq->ops->reset(txq);
+			dev->data->tx_queue_state[i] = RTE_ETH_QUEUE_STATE_STOPPED;
 		}
 	}
@@ -3390,4 +3391,5 @@ ixgbe_dev_clear_queues(struct rte_eth_dev *dev)
 			ixgbe_rx_queue_release_mbufs(rxq);
 			ixgbe_reset_rx_queue(adapter, rxq);
+			dev->data->rx_queue_state[i] = RTE_ETH_QUEUE_STATE_STOPPED;
 		}
 	}
@@ -5827,4 +5829,6 @@ ixgbevf_dev_rxtx_start(struct rte_eth_dev *dev)
 		if (!poll_ms)
 			PMD_INIT_LOG(ERR, "Could not enable Tx Queue %d", i);
+		else
+			dev->data->tx_queue_state[i] = RTE_ETH_QUEUE_STATE_STARTED;
 	}
 	for (i = 0; i < dev->data->nb_rx_queues; i++) {
@@ -5844,4 +5848,6 @@ ixgbevf_dev_rxtx_start(struct rte_eth_dev *dev)
 		if (!poll_ms)
 			PMD_INIT_LOG(ERR, "Could not enable Rx Queue %d", i);
+		else
+			dev->data->rx_queue_state[i] = RTE_ETH_QUEUE_STATE_STARTED;
 		rte_wmb();
 		IXGBE_WRITE_REG(hw, IXGBE_VFRDT(i), rxq->nb_rx_desc - 1);
-- 
2.41.0

---
  Diff of the applied patch vs upstream commit (please double-check if non-empty:
---
--- -	2023-07-21 14:33:59.137776022 +0100
+++ 0005-net-ixgbe-fix-Rx-and-Tx-queue-status.patch	2023-07-21 14:33:59.010253237 +0100
@@ -1 +1 @@
-From 4a8490075692c32797be4280aea33772a5865038 Mon Sep 17 00:00:00 2001
+From a821b0298b6131989a1025269650b07c7dcb2fbe Mon Sep 17 00:00:00 2001
@@ -5,0 +6,2 @@
+[ upstream commit 4a8490075692c32797be4280aea33772a5865038 ]
+
@@ -14 +15,0 @@
-Cc: stable@dpdk.org
@@ -24 +25 @@
-index 61f17cd90b..954ef241a0 100644
+index 12e8abcbef..c137707869 100644
@@ -27 +28 @@
-@@ -3379,4 +3379,5 @@ ixgbe_dev_clear_queues(struct rte_eth_dev *dev)
+@@ -3381,4 +3381,5 @@ ixgbe_dev_clear_queues(struct rte_eth_dev *dev)
@@ -33 +34 @@
-@@ -3388,4 +3389,5 @@ ixgbe_dev_clear_queues(struct rte_eth_dev *dev)
+@@ -3390,4 +3391,5 @@ ixgbe_dev_clear_queues(struct rte_eth_dev *dev)
@@ -39 +40 @@
-@@ -5897,4 +5899,6 @@ ixgbevf_dev_rxtx_start(struct rte_eth_dev *dev)
+@@ -5827,4 +5829,6 @@ ixgbevf_dev_rxtx_start(struct rte_eth_dev *dev)
@@ -46 +47 @@
-@@ -5914,4 +5918,6 @@ ixgbevf_dev_rxtx_start(struct rte_eth_dev *dev)
+@@ -5844,4 +5848,6 @@ ixgbevf_dev_rxtx_start(struct rte_eth_dev *dev)


  parent reply	other threads:[~2023-07-21 13:35 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-07-21 13:34 patch 'doc: fix typos and wording in flow API guide' " Kevin Traynor
2023-07-21 13:34 ` patch 'net/i40e: fix comments' " Kevin Traynor
2023-07-21 13:34 ` patch 'net/iavf: fix stop ordering' " Kevin Traynor
2023-07-21 13:34 ` patch 'common/iavf: fix MAC type for 710 NIC' " Kevin Traynor
2023-07-21 13:35 ` Kevin Traynor [this message]
2023-07-21 13:35 ` patch 'net/igc: fix Rx and Tx queue status' " Kevin Traynor
2023-07-21 13:35 ` patch 'net/e1000: " Kevin Traynor
2023-07-21 13:35 ` patch 'net/mlx5: fix drop action memory leak' " Kevin Traynor
2023-07-21 13:35 ` patch 'net/mlx5: fix LRO TCP checksum' " Kevin Traynor
2023-07-21 13:35 ` patch 'net/mlx5: fix validation for conntrack indirect action' " Kevin Traynor
2023-07-21 13:35 ` patch 'doc: update BIOS settings and supported HW for NTB' " Kevin Traynor

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20230721133509.348959-5-ktraynor@redhat.com \
    --to=ktraynor@redhat.com \
    --cc=haijie1@huawei.com \
    --cc=qi.z.zhang@intel.com \
    --cc=qiming.yang@intel.com \
    --cc=stable@dpdk.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).