From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 19AB842EDA for ; Fri, 21 Jul 2023 15:35:30 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 15ED842D30; Fri, 21 Jul 2023 15:35:30 +0200 (CEST) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by mails.dpdk.org (Postfix) with ESMTP id 3CE9940DDC for ; Fri, 21 Jul 2023 15:35:28 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1689946527; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=gU6eQosyPFxPafzam8VzABQbduWRUVyFaNQpvQD3ZRk=; b=QqIijDfDpMqfOzJqe1uezxXHGsUJXv7UjABlGsbvgneIwop8kwdR2a3adKGjm2p98xRwIE MwVr8v+aeawxI77AajK2HYh5jLmPvJQl31q1yOQEUkWvBV8AShaOzQq8KcawI2F3PVRYdR n2NjLKLzT7oIAoTHIqaSfq0R3PjHGI4= Received: from mimecast-mx02.redhat.com (66.187.233.73 [66.187.233.73]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-185-0XTxuzL4NNakyOV-iSfLlQ-1; Fri, 21 Jul 2023 09:35:26 -0400 X-MC-Unique: 0XTxuzL4NNakyOV-iSfLlQ-1 Received: from smtp.corp.redhat.com (int-mx07.intmail.prod.int.rdu2.redhat.com [10.11.54.7]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 09FD81C04191; Fri, 21 Jul 2023 13:35:26 +0000 (UTC) Received: from rh.redhat.com (unknown [10.39.192.15]) by smtp.corp.redhat.com (Postfix) with ESMTP id CA221140E949; Fri, 21 Jul 2023 13:35:24 +0000 (UTC) From: Kevin Traynor To: Qiming Yang Cc: Jie Hai , Qi Zhang , dpdk stable Subject: patch 'net/ixgbe: fix Rx and Tx queue status' has been queued to stable release 21.11.5 Date: Fri, 21 Jul 2023 14:35:00 +0100 Message-ID: <20230721133509.348959-5-ktraynor@redhat.com> In-Reply-To: <20230721133509.348959-1-ktraynor@redhat.com> References: <20230721133509.348959-1-ktraynor@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 3.1 on 10.11.54.7 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: 8bit Content-Type: text/plain; charset="US-ASCII"; x-default=true X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org Hi, FYI, your patch has been queued to stable release 21.11.5 Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet. It will be pushed if I get no objections before 07/25/23. So please shout if anyone has objections. Also note that after the patch there's a diff of the upstream commit vs the patch applied to the branch. This will indicate if there was any rebasing needed to apply to the stable branch. If there were code changes for rebasing (ie: not only metadata diffs), please double check that the rebase was correctly done. Queued patches are on a temporary branch at: https://github.com/kevintraynor/dpdk-stable This queued commit can be viewed at: https://github.com/kevintraynor/dpdk-stable/commit/a821b0298b6131989a1025269650b07c7dcb2fbe Thanks. Kevin --- >From a821b0298b6131989a1025269650b07c7dcb2fbe Mon Sep 17 00:00:00 2001 From: Qiming Yang Date: Wed, 12 Jul 2023 08:31:51 +0000 Subject: [PATCH] net/ixgbe: fix Rx and Tx queue status [ upstream commit 4a8490075692c32797be4280aea33772a5865038 ] Ixgbevf driver don't enable queue start/stop functions, queue status is not updated when the HW queue enabled or disabled. It caused application can't get correct queue status. This patch fixes the issue by updating the queue states when the queue is disabled or enabled. Fixes: 429c6d86b371 ("ixgbe: prepare for vector pmd") Fixes: f0c50e5f56fa ("ixgbe: move PMD specific fields out of base driver") Signed-off-by: Qiming Yang Signed-off-by: Jie Hai Acked-by: Qi Zhang --- drivers/net/ixgbe/ixgbe_rxtx.c | 6 ++++++ 1 file changed, 6 insertions(+) diff --git a/drivers/net/ixgbe/ixgbe_rxtx.c b/drivers/net/ixgbe/ixgbe_rxtx.c index 12e8abcbef..c137707869 100644 --- a/drivers/net/ixgbe/ixgbe_rxtx.c +++ b/drivers/net/ixgbe/ixgbe_rxtx.c @@ -3381,4 +3381,5 @@ ixgbe_dev_clear_queues(struct rte_eth_dev *dev) txq->ops->release_mbufs(txq); txq->ops->reset(txq); + dev->data->tx_queue_state[i] = RTE_ETH_QUEUE_STATE_STOPPED; } } @@ -3390,4 +3391,5 @@ ixgbe_dev_clear_queues(struct rte_eth_dev *dev) ixgbe_rx_queue_release_mbufs(rxq); ixgbe_reset_rx_queue(adapter, rxq); + dev->data->rx_queue_state[i] = RTE_ETH_QUEUE_STATE_STOPPED; } } @@ -5827,4 +5829,6 @@ ixgbevf_dev_rxtx_start(struct rte_eth_dev *dev) if (!poll_ms) PMD_INIT_LOG(ERR, "Could not enable Tx Queue %d", i); + else + dev->data->tx_queue_state[i] = RTE_ETH_QUEUE_STATE_STARTED; } for (i = 0; i < dev->data->nb_rx_queues; i++) { @@ -5844,4 +5848,6 @@ ixgbevf_dev_rxtx_start(struct rte_eth_dev *dev) if (!poll_ms) PMD_INIT_LOG(ERR, "Could not enable Rx Queue %d", i); + else + dev->data->rx_queue_state[i] = RTE_ETH_QUEUE_STATE_STARTED; rte_wmb(); IXGBE_WRITE_REG(hw, IXGBE_VFRDT(i), rxq->nb_rx_desc - 1); -- 2.41.0 --- Diff of the applied patch vs upstream commit (please double-check if non-empty: --- --- - 2023-07-21 14:33:59.137776022 +0100 +++ 0005-net-ixgbe-fix-Rx-and-Tx-queue-status.patch 2023-07-21 14:33:59.010253237 +0100 @@ -1 +1 @@ -From 4a8490075692c32797be4280aea33772a5865038 Mon Sep 17 00:00:00 2001 +From a821b0298b6131989a1025269650b07c7dcb2fbe Mon Sep 17 00:00:00 2001 @@ -5,0 +6,2 @@ +[ upstream commit 4a8490075692c32797be4280aea33772a5865038 ] + @@ -14 +15,0 @@ -Cc: stable@dpdk.org @@ -24 +25 @@ -index 61f17cd90b..954ef241a0 100644 +index 12e8abcbef..c137707869 100644 @@ -27 +28 @@ -@@ -3379,4 +3379,5 @@ ixgbe_dev_clear_queues(struct rte_eth_dev *dev) +@@ -3381,4 +3381,5 @@ ixgbe_dev_clear_queues(struct rte_eth_dev *dev) @@ -33 +34 @@ -@@ -3388,4 +3389,5 @@ ixgbe_dev_clear_queues(struct rte_eth_dev *dev) +@@ -3390,4 +3391,5 @@ ixgbe_dev_clear_queues(struct rte_eth_dev *dev) @@ -39 +40 @@ -@@ -5897,4 +5899,6 @@ ixgbevf_dev_rxtx_start(struct rte_eth_dev *dev) +@@ -5827,4 +5829,6 @@ ixgbevf_dev_rxtx_start(struct rte_eth_dev *dev) @@ -46 +47 @@ -@@ -5914,4 +5918,6 @@ ixgbevf_dev_rxtx_start(struct rte_eth_dev *dev) +@@ -5844,4 +5848,6 @@ ixgbevf_dev_rxtx_start(struct rte_eth_dev *dev)