From: Kevin Traynor <ktraynor@redhat.com>
To: Qiming Yang <qiming.yang@intel.com>
Cc: Mingjin Ye <mingjinx.ye@intel.com>,
Qi Zhang <qi.z.zhang@intel.com>, dpdk stable <stable@dpdk.org>
Subject: patch 'net/igc: fix Rx and Tx queue status' has been queued to stable release 21.11.5
Date: Fri, 21 Jul 2023 14:35:01 +0100 [thread overview]
Message-ID: <20230721133509.348959-6-ktraynor@redhat.com> (raw)
In-Reply-To: <20230721133509.348959-1-ktraynor@redhat.com>
Hi,
FYI, your patch has been queued to stable release 21.11.5
Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet.
It will be pushed if I get no objections before 07/25/23. So please
shout if anyone has objections.
Also note that after the patch there's a diff of the upstream commit vs the
patch applied to the branch. This will indicate if there was any rebasing
needed to apply to the stable branch. If there were code changes for rebasing
(ie: not only metadata diffs), please double check that the rebase was
correctly done.
Queued patches are on a temporary branch at:
https://github.com/kevintraynor/dpdk-stable
This queued commit can be viewed at:
https://github.com/kevintraynor/dpdk-stable/commit/831bf81980d4b3eace7eca621e2f7e9b427a9a80
Thanks.
Kevin
---
From 831bf81980d4b3eace7eca621e2f7e9b427a9a80 Mon Sep 17 00:00:00 2001
From: Qiming Yang <qiming.yang@intel.com>
Date: Wed, 12 Jul 2023 08:31:52 +0000
Subject: [PATCH] net/igc: fix Rx and Tx queue status
[ upstream commit 921ff14280ed8ba7b9d0a898046cf5eadf3d4c8e ]
Igc driver don't enable queue start/stop functions, queue status is not
updated when the HW queue enabled or disabled. It caused application can't
get correct queue status.
This patch fixes the issue by updating the queue states when the queue is
disabled or enabled.
Fixes: a5aeb2b9e225 ("net/igc: support Rx and Tx")
Signed-off-by: Qiming Yang <qiming.yang@intel.com>
Signed-off-by: Mingjin Ye <mingjinx.ye@intel.com>
Acked-by: Qi Zhang <qi.z.zhang@intel.com>
---
drivers/net/igc/igc_txrx.c | 4 ++++
1 file changed, 4 insertions(+)
diff --git a/drivers/net/igc/igc_txrx.c b/drivers/net/igc/igc_txrx.c
index ffd219b0df..160865e911 100644
--- a/drivers/net/igc/igc_txrx.c
+++ b/drivers/net/igc/igc_txrx.c
@@ -1292,4 +1292,5 @@ igc_rx_init(struct rte_eth_dev *dev)
IGC_WRITE_REG(hw, IGC_DVMOLR(rxq->reg_idx), dvmolr);
+ dev->data->rx_queue_state[i] = RTE_ETH_QUEUE_STATE_STARTED;
}
@@ -1935,4 +1936,5 @@ igc_dev_clear_queues(struct rte_eth_dev *dev)
igc_tx_queue_release_mbufs(txq);
igc_reset_tx_queue(txq);
+ dev->data->tx_queue_state[i] = RTE_ETH_QUEUE_STATE_STOPPED;
}
}
@@ -1943,4 +1945,5 @@ igc_dev_clear_queues(struct rte_eth_dev *dev)
igc_rx_queue_release_mbufs(rxq);
igc_reset_rx_queue(rxq);
+ dev->data->rx_queue_state[i] = RTE_ETH_QUEUE_STATE_STOPPED;
}
}
@@ -2188,4 +2191,5 @@ igc_tx_init(struct rte_eth_dev *dev)
txdctl |= IGC_TXDCTL_QUEUE_ENABLE;
IGC_WRITE_REG(hw, IGC_TXDCTL(txq->reg_idx), txdctl);
+ dev->data->tx_queue_state[i] = RTE_ETH_QUEUE_STATE_STARTED;
}
--
2.41.0
---
Diff of the applied patch vs upstream commit (please double-check if non-empty:
---
--- - 2023-07-21 14:33:59.162375541 +0100
+++ 0006-net-igc-fix-Rx-and-Tx-queue-status.patch 2023-07-21 14:33:59.012253244 +0100
@@ -1 +1 @@
-From 921ff14280ed8ba7b9d0a898046cf5eadf3d4c8e Mon Sep 17 00:00:00 2001
+From 831bf81980d4b3eace7eca621e2f7e9b427a9a80 Mon Sep 17 00:00:00 2001
@@ -5,0 +6,2 @@
+[ upstream commit 921ff14280ed8ba7b9d0a898046cf5eadf3d4c8e ]
+
@@ -13 +14,0 @@
-Cc: stable@dpdk.org
@@ -23 +24 @@
-index c11b6f7f25..5c60e3e997 100644
+index ffd219b0df..160865e911 100644
@@ -26 +27 @@
-@@ -1216,4 +1216,5 @@ igc_rx_init(struct rte_eth_dev *dev)
+@@ -1292,4 +1292,5 @@ igc_rx_init(struct rte_eth_dev *dev)
@@ -32 +33 @@
-@@ -1889,4 +1890,5 @@ igc_dev_clear_queues(struct rte_eth_dev *dev)
+@@ -1935,4 +1936,5 @@ igc_dev_clear_queues(struct rte_eth_dev *dev)
@@ -38 +39 @@
-@@ -1897,4 +1899,5 @@ igc_dev_clear_queues(struct rte_eth_dev *dev)
+@@ -1943,4 +1945,5 @@ igc_dev_clear_queues(struct rte_eth_dev *dev)
@@ -44 +45 @@
-@@ -2144,4 +2147,5 @@ igc_tx_init(struct rte_eth_dev *dev)
+@@ -2188,4 +2191,5 @@ igc_tx_init(struct rte_eth_dev *dev)
next prev parent reply other threads:[~2023-07-21 13:35 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-07-21 13:34 patch 'doc: fix typos and wording in flow API guide' " Kevin Traynor
2023-07-21 13:34 ` patch 'net/i40e: fix comments' " Kevin Traynor
2023-07-21 13:34 ` patch 'net/iavf: fix stop ordering' " Kevin Traynor
2023-07-21 13:34 ` patch 'common/iavf: fix MAC type for 710 NIC' " Kevin Traynor
2023-07-21 13:35 ` patch 'net/ixgbe: fix Rx and Tx queue status' " Kevin Traynor
2023-07-21 13:35 ` Kevin Traynor [this message]
2023-07-21 13:35 ` patch 'net/e1000: " Kevin Traynor
2023-07-21 13:35 ` patch 'net/mlx5: fix drop action memory leak' " Kevin Traynor
2023-07-21 13:35 ` patch 'net/mlx5: fix LRO TCP checksum' " Kevin Traynor
2023-07-21 13:35 ` patch 'net/mlx5: fix validation for conntrack indirect action' " Kevin Traynor
2023-07-21 13:35 ` patch 'doc: update BIOS settings and supported HW for NTB' " Kevin Traynor
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230721133509.348959-6-ktraynor@redhat.com \
--to=ktraynor@redhat.com \
--cc=mingjinx.ye@intel.com \
--cc=qi.z.zhang@intel.com \
--cc=qiming.yang@intel.com \
--cc=stable@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).