From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 4930542EDA for ; Fri, 21 Jul 2023 15:35:32 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 450B240E2D; Fri, 21 Jul 2023 15:35:32 +0200 (CEST) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by mails.dpdk.org (Postfix) with ESMTP id 4947542D36 for ; Fri, 21 Jul 2023 15:35:30 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1689946529; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=x5kM6qxwPNELl0F7ah5voHB558NRB45bMBw4xPy6H70=; b=EFM9Gg3fsr+RHPDUUPqjw4oKWTn9ktA1o+SLcbaEGTbDrny/JBsmYxwnHSh3rXIpXZnLVe NBUDhE8qgMBNuNWdaZ1SVJ5VanFk9K4XKhP462cCcQsATxdHExiishoJzVjvZ7RUKnqe/b xPKeM9qMNt4jYDRqBi0oxwMf8mejffU= Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-304-6tCSydPKMByqUXD4lNnumw-1; Fri, 21 Jul 2023 09:35:28 -0400 X-MC-Unique: 6tCSydPKMByqUXD4lNnumw-1 Received: from smtp.corp.redhat.com (int-mx07.intmail.prod.int.rdu2.redhat.com [10.11.54.7]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 8D29C8F1845; Fri, 21 Jul 2023 13:35:27 +0000 (UTC) Received: from rh.redhat.com (unknown [10.39.192.15]) by smtp.corp.redhat.com (Postfix) with ESMTP id 697ED1454142; Fri, 21 Jul 2023 13:35:26 +0000 (UTC) From: Kevin Traynor To: Qiming Yang Cc: Mingjin Ye , Qi Zhang , dpdk stable Subject: patch 'net/igc: fix Rx and Tx queue status' has been queued to stable release 21.11.5 Date: Fri, 21 Jul 2023 14:35:01 +0100 Message-ID: <20230721133509.348959-6-ktraynor@redhat.com> In-Reply-To: <20230721133509.348959-1-ktraynor@redhat.com> References: <20230721133509.348959-1-ktraynor@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 3.1 on 10.11.54.7 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: 8bit Content-Type: text/plain; charset="US-ASCII"; x-default=true X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org Hi, FYI, your patch has been queued to stable release 21.11.5 Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet. It will be pushed if I get no objections before 07/25/23. So please shout if anyone has objections. Also note that after the patch there's a diff of the upstream commit vs the patch applied to the branch. This will indicate if there was any rebasing needed to apply to the stable branch. If there were code changes for rebasing (ie: not only metadata diffs), please double check that the rebase was correctly done. Queued patches are on a temporary branch at: https://github.com/kevintraynor/dpdk-stable This queued commit can be viewed at: https://github.com/kevintraynor/dpdk-stable/commit/831bf81980d4b3eace7eca621e2f7e9b427a9a80 Thanks. Kevin --- >From 831bf81980d4b3eace7eca621e2f7e9b427a9a80 Mon Sep 17 00:00:00 2001 From: Qiming Yang Date: Wed, 12 Jul 2023 08:31:52 +0000 Subject: [PATCH] net/igc: fix Rx and Tx queue status [ upstream commit 921ff14280ed8ba7b9d0a898046cf5eadf3d4c8e ] Igc driver don't enable queue start/stop functions, queue status is not updated when the HW queue enabled or disabled. It caused application can't get correct queue status. This patch fixes the issue by updating the queue states when the queue is disabled or enabled. Fixes: a5aeb2b9e225 ("net/igc: support Rx and Tx") Signed-off-by: Qiming Yang Signed-off-by: Mingjin Ye Acked-by: Qi Zhang --- drivers/net/igc/igc_txrx.c | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/drivers/net/igc/igc_txrx.c b/drivers/net/igc/igc_txrx.c index ffd219b0df..160865e911 100644 --- a/drivers/net/igc/igc_txrx.c +++ b/drivers/net/igc/igc_txrx.c @@ -1292,4 +1292,5 @@ igc_rx_init(struct rte_eth_dev *dev) IGC_WRITE_REG(hw, IGC_DVMOLR(rxq->reg_idx), dvmolr); + dev->data->rx_queue_state[i] = RTE_ETH_QUEUE_STATE_STARTED; } @@ -1935,4 +1936,5 @@ igc_dev_clear_queues(struct rte_eth_dev *dev) igc_tx_queue_release_mbufs(txq); igc_reset_tx_queue(txq); + dev->data->tx_queue_state[i] = RTE_ETH_QUEUE_STATE_STOPPED; } } @@ -1943,4 +1945,5 @@ igc_dev_clear_queues(struct rte_eth_dev *dev) igc_rx_queue_release_mbufs(rxq); igc_reset_rx_queue(rxq); + dev->data->rx_queue_state[i] = RTE_ETH_QUEUE_STATE_STOPPED; } } @@ -2188,4 +2191,5 @@ igc_tx_init(struct rte_eth_dev *dev) txdctl |= IGC_TXDCTL_QUEUE_ENABLE; IGC_WRITE_REG(hw, IGC_TXDCTL(txq->reg_idx), txdctl); + dev->data->tx_queue_state[i] = RTE_ETH_QUEUE_STATE_STARTED; } -- 2.41.0 --- Diff of the applied patch vs upstream commit (please double-check if non-empty: --- --- - 2023-07-21 14:33:59.162375541 +0100 +++ 0006-net-igc-fix-Rx-and-Tx-queue-status.patch 2023-07-21 14:33:59.012253244 +0100 @@ -1 +1 @@ -From 921ff14280ed8ba7b9d0a898046cf5eadf3d4c8e Mon Sep 17 00:00:00 2001 +From 831bf81980d4b3eace7eca621e2f7e9b427a9a80 Mon Sep 17 00:00:00 2001 @@ -5,0 +6,2 @@ +[ upstream commit 921ff14280ed8ba7b9d0a898046cf5eadf3d4c8e ] + @@ -13 +14,0 @@ -Cc: stable@dpdk.org @@ -23 +24 @@ -index c11b6f7f25..5c60e3e997 100644 +index ffd219b0df..160865e911 100644 @@ -26 +27 @@ -@@ -1216,4 +1216,5 @@ igc_rx_init(struct rte_eth_dev *dev) +@@ -1292,4 +1292,5 @@ igc_rx_init(struct rte_eth_dev *dev) @@ -32 +33 @@ -@@ -1889,4 +1890,5 @@ igc_dev_clear_queues(struct rte_eth_dev *dev) +@@ -1935,4 +1936,5 @@ igc_dev_clear_queues(struct rte_eth_dev *dev) @@ -38 +39 @@ -@@ -1897,4 +1899,5 @@ igc_dev_clear_queues(struct rte_eth_dev *dev) +@@ -1943,4 +1945,5 @@ igc_dev_clear_queues(struct rte_eth_dev *dev) @@ -44 +45 @@ -@@ -2144,4 +2147,5 @@ igc_tx_init(struct rte_eth_dev *dev) +@@ -2188,4 +2191,5 @@ igc_tx_init(struct rte_eth_dev *dev)