patches for DPDK stable branches
 help / color / mirror / Atom feed
From: Kevin Traynor <ktraynor@redhat.com>
To: Qiming Yang <qiming.yang@intel.com>
Cc: Mingjin Ye <mingjinx.ye@intel.com>,
	Qi Zhang <qi.z.zhang@intel.com>, dpdk stable <stable@dpdk.org>
Subject: patch 'net/e1000: fix Rx and Tx queue status' has been queued to stable release 21.11.5
Date: Fri, 21 Jul 2023 14:35:02 +0100	[thread overview]
Message-ID: <20230721133509.348959-7-ktraynor@redhat.com> (raw)
In-Reply-To: <20230721133509.348959-1-ktraynor@redhat.com>

Hi,

FYI, your patch has been queued to stable release 21.11.5

Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet.
It will be pushed if I get no objections before 07/25/23. So please
shout if anyone has objections.

Also note that after the patch there's a diff of the upstream commit vs the
patch applied to the branch. This will indicate if there was any rebasing
needed to apply to the stable branch. If there were code changes for rebasing
(ie: not only metadata diffs), please double check that the rebase was
correctly done.

Queued patches are on a temporary branch at:
https://github.com/kevintraynor/dpdk-stable

This queued commit can be viewed at:
https://github.com/kevintraynor/dpdk-stable/commit/c7a2de80c152960684b5c7cc72b1967c0b036f6c

Thanks.

Kevin

---
From c7a2de80c152960684b5c7cc72b1967c0b036f6c Mon Sep 17 00:00:00 2001
From: Qiming Yang <qiming.yang@intel.com>
Date: Wed, 12 Jul 2023 08:31:53 +0000
Subject: [PATCH] net/e1000: fix Rx and Tx queue status

[ upstream commit b2a0271188f3428ad5dc1ea600e1e2254b9d6781 ]

Igb driver don't enable queue start/stop functions, queue status is not
updated when the HW queue enabled or disabled. It caused application can't
get correct queue status.
This patch fixes the issue by updating the queue states when the queue is
disabled or enabled.

Fixes: be2d648a2dd3 ("igb: add PF support")

Signed-off-by: Qiming Yang <qiming.yang@intel.com>
Signed-off-by: Mingjin Ye <mingjinx.ye@intel.com>
Acked-by: Qi Zhang <qi.z.zhang@intel.com>
---
 drivers/net/e1000/igb_rxtx.c | 4 ++++
 1 file changed, 4 insertions(+)

diff --git a/drivers/net/e1000/igb_rxtx.c b/drivers/net/e1000/igb_rxtx.c
index f32dee46df..1d23e081b6 100644
--- a/drivers/net/e1000/igb_rxtx.c
+++ b/drivers/net/e1000/igb_rxtx.c
@@ -1854,4 +1854,5 @@ igb_dev_clear_queues(struct rte_eth_dev *dev)
 			igb_tx_queue_release_mbufs(txq);
 			igb_reset_tx_queue(txq, dev);
+			dev->data->tx_queue_state[i] = RTE_ETH_QUEUE_STATE_STOPPED;
 		}
 	}
@@ -1862,4 +1863,5 @@ igb_dev_clear_queues(struct rte_eth_dev *dev)
 			igb_rx_queue_release_mbufs(rxq);
 			igb_reset_rx_queue(rxq);
+			dev->data->rx_queue_state[i] = RTE_ETH_QUEUE_STATE_STOPPED;
 		}
 	}
@@ -2442,4 +2444,5 @@ eth_igb_rx_init(struct rte_eth_dev *dev)
 		rxdctl |= ((rxq->wthresh & 0x1F) << 16);
 		E1000_WRITE_REG(hw, E1000_RXDCTL(rxq->reg_idx), rxdctl);
+		dev->data->rx_queue_state[i] = RTE_ETH_QUEUE_STATE_STARTED;
 	}
 
@@ -2606,4 +2609,5 @@ eth_igb_tx_init(struct rte_eth_dev *dev)
 		txdctl |= E1000_TXDCTL_QUEUE_ENABLE;
 		E1000_WRITE_REG(hw, E1000_TXDCTL(txq->reg_idx), txdctl);
+		dev->data->tx_queue_state[i] = RTE_ETH_QUEUE_STATE_STARTED;
 	}
 
-- 
2.41.0

---
  Diff of the applied patch vs upstream commit (please double-check if non-empty:
---
--- -	2023-07-21 14:33:59.184309758 +0100
+++ 0007-net-e1000-fix-Rx-and-Tx-queue-status.patch	2023-07-21 14:33:59.015253255 +0100
@@ -1 +1 @@
-From b2a0271188f3428ad5dc1ea600e1e2254b9d6781 Mon Sep 17 00:00:00 2001
+From c7a2de80c152960684b5c7cc72b1967c0b036f6c Mon Sep 17 00:00:00 2001
@@ -5,0 +6,2 @@
+[ upstream commit b2a0271188f3428ad5dc1ea600e1e2254b9d6781 ]
+
@@ -13 +14,0 @@
-Cc: stable@dpdk.org
@@ -23 +24 @@
-index 25ad9eb4e5..61c6394310 100644
+index f32dee46df..1d23e081b6 100644
@@ -26 +27 @@
-@@ -1855,4 +1855,5 @@ igb_dev_clear_queues(struct rte_eth_dev *dev)
+@@ -1854,4 +1854,5 @@ igb_dev_clear_queues(struct rte_eth_dev *dev)
@@ -32 +33 @@
-@@ -1863,4 +1864,5 @@ igb_dev_clear_queues(struct rte_eth_dev *dev)
+@@ -1862,4 +1863,5 @@ igb_dev_clear_queues(struct rte_eth_dev *dev)
@@ -38 +39 @@
-@@ -2443,4 +2445,5 @@ eth_igb_rx_init(struct rte_eth_dev *dev)
+@@ -2442,4 +2444,5 @@ eth_igb_rx_init(struct rte_eth_dev *dev)
@@ -44 +45 @@
-@@ -2607,4 +2610,5 @@ eth_igb_tx_init(struct rte_eth_dev *dev)
+@@ -2606,4 +2609,5 @@ eth_igb_tx_init(struct rte_eth_dev *dev)


  parent reply	other threads:[~2023-07-21 13:35 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-07-21 13:34 patch 'doc: fix typos and wording in flow API guide' " Kevin Traynor
2023-07-21 13:34 ` patch 'net/i40e: fix comments' " Kevin Traynor
2023-07-21 13:34 ` patch 'net/iavf: fix stop ordering' " Kevin Traynor
2023-07-21 13:34 ` patch 'common/iavf: fix MAC type for 710 NIC' " Kevin Traynor
2023-07-21 13:35 ` patch 'net/ixgbe: fix Rx and Tx queue status' " Kevin Traynor
2023-07-21 13:35 ` patch 'net/igc: " Kevin Traynor
2023-07-21 13:35 ` Kevin Traynor [this message]
2023-07-21 13:35 ` patch 'net/mlx5: fix drop action memory leak' " Kevin Traynor
2023-07-21 13:35 ` patch 'net/mlx5: fix LRO TCP checksum' " Kevin Traynor
2023-07-21 13:35 ` patch 'net/mlx5: fix validation for conntrack indirect action' " Kevin Traynor
2023-07-21 13:35 ` patch 'doc: update BIOS settings and supported HW for NTB' " Kevin Traynor

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20230721133509.348959-7-ktraynor@redhat.com \
    --to=ktraynor@redhat.com \
    --cc=mingjinx.ye@intel.com \
    --cc=qi.z.zhang@intel.com \
    --cc=qiming.yang@intel.com \
    --cc=stable@dpdk.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).