From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id D9BA84301E for ; Thu, 10 Aug 2023 01:53:09 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id D414340DD8; Thu, 10 Aug 2023 01:53:09 +0200 (CEST) Received: from NAM10-DM6-obe.outbound.protection.outlook.com (mail-dm6nam10on2060.outbound.protection.outlook.com [40.107.93.60]) by mails.dpdk.org (Postfix) with ESMTP id 7A508406B6 for ; Thu, 10 Aug 2023 01:53:08 +0200 (CEST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Ju2onVsVZbyq1w/j+9UsHGBFScULnQJsFocQR/P675YFwrWXJJuzJQ6O035ij7Meb03J5RUlMrGyxrWCJ79HwprkXvB91IsZubYLjoqK8CbYC4r/rPmiclLJgzlBmEmy5oq8weHlZ3ml5uU0CY5TeVXjefK2iUwA7u2FbTTU7jH6b9wv+8OxgukCTRXRwfo5SzgbBvaBGAefQlsPlt4RwUva+fcd421oBwYfHlOy/fGcs9nOwGJePBEe7rpOgGGfCYZuUsh4JKISqS9pY8xL9wuVyNOOZju9VHMQTa/Q0n3bu1yFhSf/Bo6uJmaioYpgUa5gfWwJhp9+PhiEXzbZ0g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=yVJ3wf+nc7T0qVqTd47Zp/a22qVWTTFsklFLXgG36nY=; b=TRZRARRcd0+/KbgCr83TyqDajQlT+SVhr8WhBOKJd860//uj+OeLFvSORSoR3D9LuvhfQgfOwtzWilkERQrFVNSvwqSlCHbg8WxOnboC9N35g1tbIZYiHwtgPCGlVdJp2xwI5LUlc9NwOxeWCDxNPHOP19o/NUfnbmRIDr5ezWK+30KPPEvKWaHWThDjT+ZjKkZZFK49RrguFuDvgO9OwGFwduQVyghA7VMzsuykeGSjWAkFsqc0BTNknScVa7CZB9VHNxk4JB3bvJZT2IvZchaWIsPGCOGeCFEzeeV+U/SLoGW6QyOCQYh0Gs33mha6HLUhLWu0ODcrbPpB4RPZ8Q== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 216.228.117.161) smtp.rcpttodomain=arknetworks.am smtp.mailfrom=nvidia.com; dmarc=pass (p=reject sp=reject pct=100) action=none header.from=nvidia.com; dkim=none (message not signed); arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=yVJ3wf+nc7T0qVqTd47Zp/a22qVWTTFsklFLXgG36nY=; b=IulgUEZUQMLbZCTSY+5FWM3FMekwYqqynB1VOtCjlcrkjMYHfOotFzYQ9KV8IG+ceVqlVaDWnVxhG9+WJp2K/c3jMJtRDjaNWvJoPDB2ZpZ9xN1W78FcCbZd9iVg/8MsaBQpVBC/pbPNMwB9XQXGo7qYV1DiOE3CRK0Pori2LqUg5T+uON+nQbSqPf5/gEfZsUl4SeAp0S3ZBYbqJH95mkbgiYYUUgOgX0MRlSVKlbRwz4XSG510AYv852aJSuTDYw4THmjxde1iQvEW/XBCigVWZStyQfkCJtGan2hIZ2Ofv7BkHzX5qNLmVgNECr3dxxujVXzg/5kA0DOOx5pezA== Received: from SN7PR04CA0191.namprd04.prod.outlook.com (2603:10b6:806:126::16) by DM6PR12MB4531.namprd12.prod.outlook.com (2603:10b6:5:2a4::9) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6652.30; Wed, 9 Aug 2023 23:53:05 +0000 Received: from SA2PEPF000015CA.namprd03.prod.outlook.com (2603:10b6:806:126:cafe::a0) by SN7PR04CA0191.outlook.office365.com (2603:10b6:806:126::16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6652.30 via Frontend Transport; Wed, 9 Aug 2023 23:53:05 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 216.228.117.161) smtp.mailfrom=nvidia.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=nvidia.com; Received-SPF: Pass (protection.outlook.com: domain of nvidia.com designates 216.228.117.161 as permitted sender) receiver=protection.outlook.com; client-ip=216.228.117.161; helo=mail.nvidia.com; pr=C Received: from mail.nvidia.com (216.228.117.161) by SA2PEPF000015CA.mail.protection.outlook.com (10.167.241.200) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6652.20 via Frontend Transport; Wed, 9 Aug 2023 23:53:04 +0000 Received: from rnnvmail201.nvidia.com (10.129.68.8) by mail.nvidia.com (10.129.200.67) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.986.5; Wed, 9 Aug 2023 16:52:52 -0700 Received: from nvidia.com (10.126.230.37) by rnnvmail201.nvidia.com (10.129.68.8) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.986.37; Wed, 9 Aug 2023 16:52:50 -0700 From: Xueming Li To: Artemii Morozov CC: Andy Moreton , Andrew Rybchenko , dpdk stable Subject: patch 'common/sfc_efx/base: fix Rx queue without RSS hash prefix' has been queued to stable release 22.11.3 Date: Thu, 10 Aug 2023 07:47:56 +0800 Message-ID: <20230809234930.32424-35-xuemingl@nvidia.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20230809234930.32424-1-xuemingl@nvidia.com> References: <20230625063544.11183-1-xuemingl@nvidia.com> <20230809234930.32424-1-xuemingl@nvidia.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Type: text/plain X-Originating-IP: [10.126.230.37] X-ClientProxiedBy: rnnvmail202.nvidia.com (10.129.68.7) To rnnvmail201.nvidia.com (10.129.68.8) X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: SA2PEPF000015CA:EE_|DM6PR12MB4531:EE_ X-MS-Office365-Filtering-Correlation-Id: c4bbf6a4-14b9-4c67-c481-08db9933c5f2 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: HI9aEpxgDqAEQ/At++w+uF8xmipjm0UsDLqmHBkdsiFBpq7el9RIqFW44fJugCf2663BJCeY2PKrvnosRcDIwxzBIRlopdf6+TlZvc7gVrxvuTro0f3CEgJVkW5hk51aPZs/9SZ3q5aMc1N1cQ9ZoshpWWjPbP33d0rhbH8ok7xu3PciAbMSyKdGZK12iasTu/TTxr1qLW3DXL3BlOF+mGbkVEFz06HrEv0oDUyMina/svvqjZ8nWiSLcFOaLP+CXnpFz6t5e9zlGm966F3OrXZILJuf7mSS9mOg99PylbrfgJndgu76nZFb22uM0LsPU/IV9YQtBf3flLNbXwL2doYx8I5LI2eD4rXszUH/bWg8QIITCuYWvzAyvVoyZoEy5NcvIWTv0VeeaY6+T+IcrAgX4yNv4yT3Cs8t2eUAEL+xM7DApcLJQhrwFMgqjFcd+wJAapn8tWG1T6Qxq65DPeoAuDIiwNZ772GB739yCFIg7Q3esA73Oe4p0Fn38Vbe7B9rfEOmCgYfntAf2keJY7qT+Fcpm3x0sy7WFoan7i/mA4CORhZutjQgjnPplINJKaPLIKqyyLpSAljy1ftQpsqmJKt6VlumN9jnRBrRRX9GKByInuAXgoTCHGbWoZg8lNBXT5ytidkYquxupJc/crAlL1HqDJvum3JkH+Tsab6WQtY+2AdUpwSSPP1sC8Hihbp6dsVvyREh/BVuxQsWHMN+WwJGIVzHZINQ7hAgdmU45ORI4f2wBNR6LNX4SYi1S10nB+/nDt0HzG9jjpU3BA== X-Forefront-Antispam-Report: CIP:216.228.117.161; CTRY:US; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:mail.nvidia.com; PTR:dc6edge2.nvidia.com; CAT:NONE; SFS:(13230028)(4636009)(376002)(396003)(39860400002)(346002)(136003)(451199021)(82310400008)(1800799006)(186006)(36840700001)(46966006)(40470700004)(966005)(2906002)(7696005)(53546011)(1076003)(26005)(40480700001)(83380400001)(55016003)(86362001)(40460700003)(426003)(47076005)(4326008)(82740400003)(6916009)(7636003)(16526019)(6286002)(2616005)(336012)(356005)(70586007)(70206006)(41300700001)(316002)(54906003)(478600001)(36756003)(5660300002)(8676002)(36860700001)(8936002); DIR:OUT; SFP:1101; X-OriginatorOrg: Nvidia.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 09 Aug 2023 23:53:04.5054 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: c4bbf6a4-14b9-4c67-c481-08db9933c5f2 X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=43083d15-7273-40c1-b7db-39efd9ccc17a; Ip=[216.228.117.161]; Helo=[mail.nvidia.com] X-MS-Exchange-CrossTenant-AuthSource: SA2PEPF000015CA.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM6PR12MB4531 X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org Hi, FYI, your patch has been queued to stable release 22.11.3 Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet. It will be pushed if I get no objections before 08/11/23. So please shout if anyone has objections. Also note that after the patch there's a diff of the upstream commit vs the patch applied to the branch. This will indicate if there was any rebasing needed to apply to the stable branch. If there were code changes for rebasing (ie: not only metadata diffs), please double check that the rebase was correctly done. Queued patches are on a temporary branch at: https://git.dpdk.org/dpdk-stable/log/?h=22.11-staging This queued commit can be viewed at: https://git.dpdk.org/dpdk-stable/commit/?h=22.11-staging&id=64c315b9e9f078d7cf183f2f31c03e7577f444dd Thanks. Xueming Li --- >From 64c315b9e9f078d7cf183f2f31c03e7577f444dd Mon Sep 17 00:00:00 2001 From: Artemii Morozov Date: Thu, 22 Jun 2023 16:31:36 +0400 Subject: [PATCH] common/sfc_efx/base: fix Rx queue without RSS hash prefix Cc: Xueming Li [ upstream commit 80d18a958e4f06e121327073439c391dbc870d80 ] If the prefix for the RSS hash was not chosen the ENOTSUP error should be returned. Before this patch success was returned for this case causing Rx queue creation to fail. Fixing return value to indicate failure. Fixes: f784cdc5cbb1 ("common/sfc_efx/base: provide control to deliver RSS hash") Signed-off-by: Artemii Morozov Reviewed-by: Andy Moreton Acked-by: Andrew Rybchenko --- drivers/common/sfc_efx/base/efx_rx.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/drivers/common/sfc_efx/base/efx_rx.c b/drivers/common/sfc_efx/base/efx_rx.c index 68f42f5cac..61726a9f0b 100644 --- a/drivers/common/sfc_efx/base/efx_rx.c +++ b/drivers/common/sfc_efx/base/efx_rx.c @@ -937,8 +937,10 @@ efx_rx_qcreate_internal( rss_hash_field = &erplp->erpl_fields[EFX_RX_PREFIX_FIELD_RSS_HASH]; - if (rss_hash_field->erpfi_width_bits == 0) + if (rss_hash_field->erpfi_width_bits == 0) { + rc = ENOTSUP; goto fail5; + } } enp->en_rx_qcount++; -- 2.25.1 --- Diff of the applied patch vs upstream commit (please double-check if non-empty: --- --- - 2023-08-09 21:51:19.128216000 +0800 +++ 0034-common-sfc_efx-base-fix-Rx-queue-without-RSS-hash-pr.patch 2023-08-09 21:51:18.164352000 +0800 @@ -1 +1 @@ -From 80d18a958e4f06e121327073439c391dbc870d80 Mon Sep 17 00:00:00 2001 +From 64c315b9e9f078d7cf183f2f31c03e7577f444dd Mon Sep 17 00:00:00 2001 @@ -4,0 +5,3 @@ +Cc: Xueming Li + +[ upstream commit 80d18a958e4f06e121327073439c391dbc870d80 ] @@ -15 +17,0 @@ -Cc: stable@dpdk.org