From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id D2DFE4301F for ; Thu, 10 Aug 2023 02:02:59 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id CA97140DD8; Thu, 10 Aug 2023 02:02:59 +0200 (CEST) Received: from NAM10-BN7-obe.outbound.protection.outlook.com (mail-bn7nam10on2083.outbound.protection.outlook.com [40.107.92.83]) by mails.dpdk.org (Postfix) with ESMTP id 0E82E406B6 for ; Thu, 10 Aug 2023 02:02:59 +0200 (CEST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=LgiEQUGmi/O8junyUL3wNn4wirrX8ix2YsAaCDBC5ERzHZHxIAOiUa76yDVNQFkGfsh2B9cmHWLolGK3JK6GHLF9AwJIw/eETFbMhJvdmqfb1Ndt6ZLKy5cB1uALZevLiBfPGdBzUJKEYab+wEesux2G01EV5g6CgUqcUXb4YIbhH4CCE9l9WoECvtDVhjnmx70Vou2JBVK+OlOMdElzrw7NqXPWzLVtzTCFE83gSbqMhf4Oog1XBaDY5+NgGdQ8AnVDQvA3Kxxz+BTOQzymgeWOzfWHS62lgaNu7opTybG2vJSaT4pYUArY7KksQOZbqge+4dtCLXq+ah/DVRevpw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=AX+Y4WlKuYuYry3znMeK85iqHUVC7qtMZSg+LMwqqtY=; b=R5ZulwO09BcCUPr7EE0Ti+bvP4PhdciB5/RDf+p4YquCM50FYxmvPoZ10dF0MIFF35o+qRvKFIqG65fxkdkDCiVml+Y/GJHn8H+3TTgd6LGZIzDr5g3f50AdD1rwEwS2zLZLd6uXgVhwR4/jqXfNGAjP+5g/YkJ0NPK1fXJl9v0ZJXPrMSTK+aVc7onnqD+ScFL6Vyx6W+spmqXP2B6ytsR0xlPs0xbPgQ2RHKvRAnelQBp0ASxh7JQEwL/FzRow2FVuYzL2wN6DfinsiuLzHN+RDP5szUuW2FgJAtMof0sYjoJyIVxYREz8ODdTaY+dqm3xsj23tTjuJ8Eb7qoGWw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 216.228.117.160) smtp.rcpttodomain=dpdk.org smtp.mailfrom=nvidia.com; dmarc=pass (p=reject sp=reject pct=100) action=none header.from=nvidia.com; dkim=none (message not signed); arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=AX+Y4WlKuYuYry3znMeK85iqHUVC7qtMZSg+LMwqqtY=; b=CTeel/8DWo4euYIEj/LhRa1Dntcr7DHtx0XfAhBQaFdUT/ezFTSs9o3S454l6cbCTzOFr9k5cNDcDo30FOBIHrDlWRHApbOILYdD69GNWPWUpkbllcAoawGlh1KlIBxUXTovRx8tEpMQt3WOWMItArgYS/wsYHMtjciL3IzoQ+mXP+GFbb2i/6nBHw1vHkd7p8WSskVzpfOyLV84WwoBOkiVdufpIWtt0V1Jg4PNz6zwbTgsOJLxV4pq6OIX9Vs7hOX9VX9PBDeVn5uhoOWAhCh8OEMs84PhH4z+xeT8Eyigc2YfFO6B66mIQIwkQfEBYVLMWNFtCOwU0TcC3ig9ig== Received: from CYZPR20CA0001.namprd20.prod.outlook.com (2603:10b6:930:a2::26) by PH0PR12MB8098.namprd12.prod.outlook.com (2603:10b6:510:29a::17) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6652.28; Thu, 10 Aug 2023 00:02:57 +0000 Received: from CY4PEPF0000E9D2.namprd03.prod.outlook.com (2603:10b6:930:a2:cafe::53) by CYZPR20CA0001.outlook.office365.com (2603:10b6:930:a2::26) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6652.28 via Frontend Transport; Thu, 10 Aug 2023 00:02:53 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 216.228.117.160) smtp.mailfrom=nvidia.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=nvidia.com; Received-SPF: Pass (protection.outlook.com: domain of nvidia.com designates 216.228.117.160 as permitted sender) receiver=protection.outlook.com; client-ip=216.228.117.160; helo=mail.nvidia.com; pr=C Received: from mail.nvidia.com (216.228.117.160) by CY4PEPF0000E9D2.mail.protection.outlook.com (10.167.241.145) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6652.19 via Frontend Transport; Thu, 10 Aug 2023 00:02:53 +0000 Received: from rnnvmail201.nvidia.com (10.129.68.8) by mail.nvidia.com (10.129.200.66) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.986.5; Wed, 9 Aug 2023 17:02:40 -0700 Received: from nvidia.com (10.126.230.37) by rnnvmail201.nvidia.com (10.129.68.8) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.986.37; Wed, 9 Aug 2023 17:02:38 -0700 From: Xueming Li To: Alexander Kozyrev CC: Viacheslav Ovsiienko , dpdk stable Subject: patch 'net/mlx5: forbid MPRQ restart' has been queued to stable release 22.11.3 Date: Thu, 10 Aug 2023 07:59:02 +0800 Message-ID: <20230809235947.1187-30-xuemingl@nvidia.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20230809235947.1187-1-xuemingl@nvidia.com> References: <20230625063544.11183-1-xuemingl@nvidia.com> <20230809235947.1187-1-xuemingl@nvidia.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Type: text/plain X-Originating-IP: [10.126.230.37] X-ClientProxiedBy: rnnvmail202.nvidia.com (10.129.68.7) To rnnvmail201.nvidia.com (10.129.68.8) X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: CY4PEPF0000E9D2:EE_|PH0PR12MB8098:EE_ X-MS-Office365-Filtering-Correlation-Id: 664435ef-0969-4d94-ae00-08db993524f9 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: Bca814iIjgLLORIOL9ylFwPISGuFlRMaETMmev8wO48cOq9kbFVVegyjmOwzW14q56JgxiugsPnjsqoqikRL/F7h631qJoJq/GL9pP7wwZ2ZB6R2zNl7I2vekGKNx4sXPCKzagPC+Ba/bNnPPIJFzLNPM2kxqC+bm9mGZWu9DW21XodOWeCYsYjjbsMccwZzaQsSLU1g859kdxi+L8IhG22L05PY38PmCByY5v1C1aWa2NYrPIHZzVb9gNxsSY8cVvpigJthA9i3hGMIUQxeQe/nwjMn8y89EkI2C73rpcm50jVpcNnTR0FEoefKVGYiKDrILHpSuI4b9N0WMAYwqRvglzWOCavoaE0zyYErOhybcTQ9/EL4OUNRaqvnyZpQGjY81YMOYlv7ly3hnu0PLSODkM3YJq9Z9xNmBKwWhtdYcGc0mgTw/R+4CXswWi8e7aS0gwkOQnq2YdvX3ppheiz20xHWVGLfOfU6DuVp2CtkIBhWtS2XKMuWNdWNApmg1fOpwd7GcDsSwxb2PFgeuqtyyCryu+uxXfdwdxANWVqy/iYIG0ZDZnyPs8iCGCGUqpzE7jOmw9InD/VMCgUYR9JCFOt/A0PblGsVfer88c0YeuWPSilseXACCH3g/U4NnCXEtV6Ap8OcndmT9XGaWhKNKecxzzSmUwWlZsXngwkG69+v3M2QbUqcPPDF0sGJ93eZ357iqk+kylECNlrL7dJRvzrzDnrJz5cRdOXOgcR+Unbg3SKtwHLztEy3YdKv0s/fVDWAICtgzUG9zL1J6w== X-Forefront-Antispam-Report: CIP:216.228.117.160; CTRY:US; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:mail.nvidia.com; PTR:dc6edge1.nvidia.com; CAT:NONE; SFS:(13230028)(4636009)(376002)(39860400002)(136003)(346002)(396003)(82310400008)(1800799006)(186006)(451199021)(36840700001)(46966006)(40470700004)(426003)(83380400001)(356005)(478600001)(82740400003)(7636003)(36860700001)(2616005)(6286002)(47076005)(336012)(16526019)(40460700003)(1076003)(966005)(26005)(53546011)(55016003)(40480700001)(8936002)(70586007)(70206006)(8676002)(4326008)(6636002)(2906002)(316002)(7696005)(6666004)(6862004)(36756003)(37006003)(54906003)(41300700001)(86362001)(5660300002); DIR:OUT; SFP:1101; X-OriginatorOrg: Nvidia.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 10 Aug 2023 00:02:53.4310 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 664435ef-0969-4d94-ae00-08db993524f9 X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=43083d15-7273-40c1-b7db-39efd9ccc17a; Ip=[216.228.117.160]; Helo=[mail.nvidia.com] X-MS-Exchange-CrossTenant-AuthSource: CY4PEPF0000E9D2.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH0PR12MB8098 X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org Hi, FYI, your patch has been queued to stable release 22.11.3 Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet. It will be pushed if I get no objections before 08/11/23. So please shout if anyone has objections. Also note that after the patch there's a diff of the upstream commit vs the patch applied to the branch. This will indicate if there was any rebasing needed to apply to the stable branch. If there were code changes for rebasing (ie: not only metadata diffs), please double check that the rebase was correctly done. Queued patches are on a temporary branch at: https://git.dpdk.org/dpdk-stable/log/?h=22.11-staging This queued commit can be viewed at: https://git.dpdk.org/dpdk-stable/commit/?h=22.11-staging&id=f32ecbd872d16cd514117761a03e9614b911f846 Thanks. Xueming Li --- >From f32ecbd872d16cd514117761a03e9614b911f846 Mon Sep 17 00:00:00 2001 From: Alexander Kozyrev Date: Tue, 4 Jul 2023 00:22:24 +0300 Subject: [PATCH] net/mlx5: forbid MPRQ restart Cc: Xueming Li [ upstream commit f0b2d50e2c6c02555b7fbe77f909bd7f1c6ac2e4 ] The queue restart is only supported by the non-vectorized single-packet receive queue today. Restarting MPRQ will result in corrupted packets because of CQE and WQE mismatch. Prevent this by not allowing the MPRQ Rx queue stop. Fixes: 161d103b231c ("net/mlx5: add queue start and stop") Signed-off-by: Alexander Kozyrev Acked-by: Viacheslav Ovsiienko --- drivers/net/mlx5/mlx5_rxq.c | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/drivers/net/mlx5/mlx5_rxq.c b/drivers/net/mlx5/mlx5_rxq.c index 81aa3f074a..a42c70f898 100644 --- a/drivers/net/mlx5/mlx5_rxq.c +++ b/drivers/net/mlx5/mlx5_rxq.c @@ -528,12 +528,12 @@ mlx5_rx_queue_stop(struct rte_eth_dev *dev, uint16_t idx) * synchronized, that might be broken on RQ restart * and cause Rx malfunction, so queue stopping is * not supported if vectorized Rx burst is engaged. - * The routine pointer depends on the process - * type, should perform check there. + * The routine pointer depends on the process type, + * should perform check there. MPRQ is not supported as well. */ - if (pkt_burst == mlx5_rx_burst_vec) { - DRV_LOG(ERR, "Rx queue stop is not supported " - "for vectorized Rx"); + if (pkt_burst != mlx5_rx_burst) { + DRV_LOG(ERR, "Rx queue stop is only supported " + "for non-vectorized single-packet Rx"); rte_errno = EINVAL; return -EINVAL; } -- 2.25.1 --- Diff of the applied patch vs upstream commit (please double-check if non-empty: --- --- - 2023-08-09 21:51:20.343295400 +0800 +++ 0083-net-mlx5-forbid-MPRQ-restart.patch 2023-08-09 21:51:18.244352000 +0800 @@ -1 +1 @@ -From f0b2d50e2c6c02555b7fbe77f909bd7f1c6ac2e4 Mon Sep 17 00:00:00 2001 +From f32ecbd872d16cd514117761a03e9614b911f846 Mon Sep 17 00:00:00 2001 @@ -4,0 +5,3 @@ +Cc: Xueming Li + +[ upstream commit f0b2d50e2c6c02555b7fbe77f909bd7f1c6ac2e4 ] @@ -12 +14,0 @@ -Cc: stable@dpdk.org @@ -21 +23 @@ -index ad8fd13cbe..b314c0482b 100644 +index 81aa3f074a..a42c70f898 100644 @@ -24 +26 @@ -@@ -531,12 +531,12 @@ mlx5_rx_queue_stop(struct rte_eth_dev *dev, uint16_t idx) +@@ -528,12 +528,12 @@ mlx5_rx_queue_stop(struct rte_eth_dev *dev, uint16_t idx)