From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id A02F34301F for ; Thu, 10 Aug 2023 02:03:52 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 97AC840DD8; Thu, 10 Aug 2023 02:03:52 +0200 (CEST) Received: from NAM10-BN7-obe.outbound.protection.outlook.com (mail-bn7nam10on2084.outbound.protection.outlook.com [40.107.92.84]) by mails.dpdk.org (Postfix) with ESMTP id 6BEFC406B6 for ; Thu, 10 Aug 2023 02:03:51 +0200 (CEST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=oT0MV19wj7+6jaZjMS1OlS337AoT2JbNorSxCjyRmsW7ZgIy8M/RXoMIkwn5Udkn0g3XzBZjV4TF51HeD+sx+c4WUwm0HTaR3MABWJkz8tYKOqxukQSzcvpTpF7ouUlhHOb58TZuj2f4M2ZLnCNY472JSsPqH90+4S9nBiFAdTbvpKUR5/ijMYsqI5XU8zg+De0cEfhL7PzUP/ff37ikXH6X5Bsqr/zjC2kDYb7jP4rsT0AQloL1G43CxZ3uBwHnKvYMgdVGWliu60k7g+CDrPz96ILClLj+duz3kYJ9166XSD4ISpEE9juZPTWSTr+ZTt5TmQMPi32aSmo6ZUctnQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=3NIAJtZO9shb8I4AHyOCK7ThtOKbSD6oXFlFTY4mZCI=; b=n6BPlpP5mLBe9DnRPj1qg+rXQlBTi6FTbuuQITZLeEvEXLB/ExOXVldAuIXX/rfnPozRuPPMOFxW+BBEGj1Ma/pR/btG6T3DR9JpXQpcTncE7Rvg/xzV15UUQCrL3D3EMW/OaHnAyAjBD+MSAUEsayfCxvH8NvosrPcAzFTSvftcuWMSRAb9825NDSe8XyQKJcuNtdWPR5hk32Z0xZp5jT7pIWR9uFd0UYcFdsYOZGPJAMHjbf6WbGip42Bz/0nVUbaal8lf4VHM1SbkSPqYey/hMTG6jjgPLL3PgYUFLaas4vv13H7vJ7kRVoRn3rL6TeS0PIfS4Bd3hYl1b9pYsg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 216.228.117.160) smtp.rcpttodomain=intel.com smtp.mailfrom=nvidia.com; dmarc=pass (p=reject sp=reject pct=100) action=none header.from=nvidia.com; dkim=none (message not signed); arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=3NIAJtZO9shb8I4AHyOCK7ThtOKbSD6oXFlFTY4mZCI=; b=OcSHOAlSRBmJnrBTX0hpZ6ebOeFAKpcu3kid851BOQ7VrcHA7+pmOYPz7ZFs12OasMWBw6kVgKCpbEDs4wUy+Q5l+f9yOaQicPwrEbb/pPWlyNTdFFKPMpdw8BfE9S32cLU3yREAe5A69X484V5zUDOebrafAM9CezOrVlzN7RNfJMuKCIdRIqhC14onra12EMVZAXF97OSAwraZEdU+rio19Dxpo4jgSwYxqcEfDwcGm5YO1NU98gxTmOGNWcWt3nSi31kk7QtOeLZLtoke8fQyxiQAngVDeHjf71+z3ZKDa1vr0dQ/YNFtb7lsHdrzx2cNHo5Vn5cDMd8RF3o59w== Received: from CYXPR02CA0045.namprd02.prod.outlook.com (2603:10b6:930:cc::29) by IA1PR12MB7760.namprd12.prod.outlook.com (2603:10b6:208:418::20) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6652.30; Thu, 10 Aug 2023 00:03:48 +0000 Received: from CY4PEPF0000E9D0.namprd03.prod.outlook.com (2603:10b6:930:cc:cafe::39) by CYXPR02CA0045.outlook.office365.com (2603:10b6:930:cc::29) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6652.28 via Frontend Transport; Thu, 10 Aug 2023 00:03:48 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 216.228.117.160) smtp.mailfrom=nvidia.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=nvidia.com; Received-SPF: Pass (protection.outlook.com: domain of nvidia.com designates 216.228.117.160 as permitted sender) receiver=protection.outlook.com; client-ip=216.228.117.160; helo=mail.nvidia.com; pr=C Received: from mail.nvidia.com (216.228.117.160) by CY4PEPF0000E9D0.mail.protection.outlook.com (10.167.241.143) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6652.19 via Frontend Transport; Thu, 10 Aug 2023 00:03:48 +0000 Received: from rnnvmail201.nvidia.com (10.129.68.8) by mail.nvidia.com (10.129.200.66) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.986.5; Wed, 9 Aug 2023 17:03:41 -0700 Received: from nvidia.com (10.126.230.37) by rnnvmail201.nvidia.com (10.129.68.8) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.986.37; Wed, 9 Aug 2023 17:03:39 -0700 From: Xueming Li To: Hernan Vargas CC: Maxime Coquelin , dpdk stable Subject: patch 'baseband/fpga_5gnr_fec: fix starting unconfigured queue' has been queued to stable release 22.11.3 Date: Thu, 10 Aug 2023 07:59:11 +0800 Message-ID: <20230809235947.1187-39-xuemingl@nvidia.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20230809235947.1187-1-xuemingl@nvidia.com> References: <20230625063544.11183-1-xuemingl@nvidia.com> <20230809235947.1187-1-xuemingl@nvidia.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Type: text/plain X-Originating-IP: [10.126.230.37] X-ClientProxiedBy: rnnvmail202.nvidia.com (10.129.68.7) To rnnvmail201.nvidia.com (10.129.68.8) X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: CY4PEPF0000E9D0:EE_|IA1PR12MB7760:EE_ X-MS-Office365-Filtering-Correlation-Id: 39d4be19-d0e8-417c-0743-08db993545d6 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: ZKOoOp1dgV2BSaHHirae5rF07CfkQwbwBmn/FvI91BmG9NTPz+c6OpYi48HJHZJFQc0sBKVXlUggA6D+Hf9mc565ze1FFgVjMA3bELCVQLI1UPRvM9RVjWCIfrufnlpcaRt6bl88RFIq4hO77YROsWU7mE+lUlg64Wg8wRlKwFc1Jo5bYywS25KTKdoWFmqQBqZcq4r5GbHGwsfceMhKn3Z08e7IUKnNGE2ybKHsU4xidKORaQCPSC3LjCkjKj0ZjUfzntJl+X4w4g1GI9g9Pmuf2wyWfBC3TDncW902+zIYDUhFK1+F6NpMa9U8pqeNa2YmEEZ/Pi+1I/IJFbWnNuZrQge5f4FinzoyqLzEQjFm2T/x3vrRkfVqcMzdmtQhCgLxzTJNqbra1Hi8hJ2GKB9nXjRLzkoYlyqPBSWsdeMOCuBRwrTm2LIiuOCUe/j2kMY7b5M38kix9nhSf8FaZvwv9Jxhk1ZSv0bornrFMGI/7iFUxbplhy3sv7QD5y8CiL7vyk03Au0ujCNs4PX7dXmyrJ1ydbWvmlFregmhwTb3v58XstbCIcyxX2cAHQTnKvomVregLGANCso7N/GfOx1gMSaCasKuaYg9Tsn2s0OJi7Tp1Ko0gIZtkA+cSq0L39Z9QfS9NxFI9dVJukrwe+Pl5Nax9QuAKt2L+ZhIYoUsVIhMbv8S/i0rfxrd/flgos2uXPZ3ECHFbMfGHafl0Gm+f+G6eTFbe1x33aZSwh4JYM07bZaYhejdsRRXLdAIbjm2DzwOWt71Ms1UhwlYdQ== X-Forefront-Antispam-Report: CIP:216.228.117.160; CTRY:US; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:mail.nvidia.com; PTR:dc6edge1.nvidia.com; CAT:NONE; SFS:(13230028)(4636009)(376002)(396003)(136003)(346002)(39860400002)(1800799006)(186006)(451199021)(82310400008)(40470700004)(36840700001)(46966006)(426003)(83380400001)(55016003)(40480700001)(2616005)(40460700003)(54906003)(478600001)(2906002)(86362001)(36860700001)(966005)(82740400003)(7636003)(356005)(7696005)(6666004)(4326008)(41300700001)(8676002)(8936002)(5660300002)(6916009)(70586007)(70206006)(316002)(336012)(47076005)(6286002)(16526019)(36756003)(53546011)(26005)(1076003); DIR:OUT; SFP:1101; X-OriginatorOrg: Nvidia.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 10 Aug 2023 00:03:48.5465 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 39d4be19-d0e8-417c-0743-08db993545d6 X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=43083d15-7273-40c1-b7db-39efd9ccc17a; Ip=[216.228.117.160]; Helo=[mail.nvidia.com] X-MS-Exchange-CrossTenant-AuthSource: CY4PEPF0000E9D0.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: IA1PR12MB7760 X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org Hi, FYI, your patch has been queued to stable release 22.11.3 Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet. It will be pushed if I get no objections before 08/11/23. So please shout if anyone has objections. Also note that after the patch there's a diff of the upstream commit vs the patch applied to the branch. This will indicate if there was any rebasing needed to apply to the stable branch. If there were code changes for rebasing (ie: not only metadata diffs), please double check that the rebase was correctly done. Queued patches are on a temporary branch at: https://git.dpdk.org/dpdk-stable/log/?h=22.11-staging This queued commit can be viewed at: https://git.dpdk.org/dpdk-stable/commit/?h=22.11-staging&id=be74d3fef7f2767b7bcd21f592d922571b75bc35 Thanks. Xueming Li --- >From be74d3fef7f2767b7bcd21f592d922571b75bc35 Mon Sep 17 00:00:00 2001 From: Hernan Vargas Date: Thu, 25 May 2023 11:28:08 -0700 Subject: [PATCH] baseband/fpga_5gnr_fec: fix starting unconfigured queue Cc: Xueming Li [ upstream commit 490501e6cbe48503aeadb20f89915a3949b70aa8 ] Adding exception to prevent segmentation fault in case a queue is started which was not configured earlier. Fixes: c58109a8871d ("baseband/fpga_5gnr_fec: add queue configuration") Signed-off-by: Hernan Vargas Reviewed-by: Maxime Coquelin --- drivers/baseband/fpga_5gnr_fec/rte_fpga_5gnr_fec.c | 14 +++++++++----- 1 file changed, 9 insertions(+), 5 deletions(-) diff --git a/drivers/baseband/fpga_5gnr_fec/rte_fpga_5gnr_fec.c b/drivers/baseband/fpga_5gnr_fec/rte_fpga_5gnr_fec.c index ffd4334541..0dfeba08e1 100644 --- a/drivers/baseband/fpga_5gnr_fec/rte_fpga_5gnr_fec.c +++ b/drivers/baseband/fpga_5gnr_fec/rte_fpga_5gnr_fec.c @@ -569,17 +569,21 @@ static int fpga_queue_start(struct rte_bbdev *dev, uint16_t queue_id) { struct fpga_5gnr_fec_device *d = dev->data->dev_private; + struct fpga_queue *q = dev->data->queues[queue_id].queue_private; + uint32_t offset = FPGA_5GNR_FEC_RING_CTRL_REGS + + (sizeof(struct fpga_ring_ctrl_reg) * q->q_idx); + uint8_t enable = 0x01; + uint16_t zero = 0x0000; #ifdef RTE_LIBRTE_BBDEV_DEBUG if (d == NULL) { rte_bbdev_log(ERR, "Invalid device pointer"); return -1; } #endif - struct fpga_queue *q = dev->data->queues[queue_id].queue_private; - uint32_t offset = FPGA_5GNR_FEC_RING_CTRL_REGS + - (sizeof(struct fpga_ring_ctrl_reg) * q->q_idx); - uint8_t enable = 0x01; - uint16_t zero = 0x0000; + if (dev->data->queues[queue_id].queue_private == NULL) { + rte_bbdev_log(ERR, "Cannot start invalid queue %d", queue_id); + return -1; + } /* Clear queue head and tail variables */ q->tail = q->head_free_desc = 0; -- 2.25.1 --- Diff of the applied patch vs upstream commit (please double-check if non-empty: --- --- - 2023-08-09 21:51:20.565968300 +0800 +++ 0092-baseband-fpga_5gnr_fec-fix-starting-unconfigured-que.patch 2023-08-09 21:51:18.264352000 +0800 @@ -1 +1 @@ -From 490501e6cbe48503aeadb20f89915a3949b70aa8 Mon Sep 17 00:00:00 2001 +From be74d3fef7f2767b7bcd21f592d922571b75bc35 Mon Sep 17 00:00:00 2001 @@ -4,0 +5,3 @@ +Cc: Xueming Li + +[ upstream commit 490501e6cbe48503aeadb20f89915a3949b70aa8 ] @@ -10 +12,0 @@ -Cc: stable@dpdk.org @@ -19 +21 @@ -index 99390c4816..6b0644ffc5 100644 +index ffd4334541..0dfeba08e1 100644 @@ -22 +24 @@ -@@ -567,17 +567,21 @@ static int +@@ -569,17 +569,21 @@ static int