From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 136504301F for ; Thu, 10 Aug 2023 02:00:50 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 0D0AF40DD8; Thu, 10 Aug 2023 02:00:50 +0200 (CEST) Received: from NAM02-DM3-obe.outbound.protection.outlook.com (mail-dm3nam02on2089.outbound.protection.outlook.com [40.107.95.89]) by mails.dpdk.org (Postfix) with ESMTP id CC51C406B6 for ; Thu, 10 Aug 2023 02:00:48 +0200 (CEST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=WAwY6m22sMxx2NyZ1zs0Mr6DGW/00xdsbL7bL4QzbRj7/v/SY2937OEbX9iuZN+r8HIuY/qHlUcrXOD1EoURj8rEf7ByX8gp/MbpwQehY21POXWcZ034aiD4C1ryDn845kGid0P4zm+SoC5Iz5O1f57OuooDIrrbY1BOiDX9vU0vXzBKwUP0OMNGmRLeGYtx+apUbmSxkWeDP29/6inkF9d2F3UXkna/yjZHEOemNB2RJrrFiQS4BOTa73BToBbN7DiJ4Vr/r4Ui9xtFAfVOtmAvR7E1wLFBoVv8e6GABQGpR5r4bfBrpAxBc13fYfSPjTiL1XqeyqOj5a0Mdbq/wA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=hWctI0akqC4ym2DSxGLUELXqLi1u5sKWfmMie2fcHAk=; b=ATu6lydPVxjHkuOksBFbSxvUuGwVU0eZulDFXldas9jDnGDgCAaXdUCSzZ5UcuhjsYa6QDdiILYzBNeGCIdfR27N0/jxqA2toXObCCKFQIXR7tXSBOMTAAhayviHGOBHsEvdYq/egIaTCBixbxc113xiQN1UKx6MvlZ7jol94zGO4hhs5GIUO0+omnOJuTqYFVKllHbkE2faK/vf0YWsUEM7Uptm5qZ2Kp9/WAXFjOjZ6Wb2YQ4PAoPIZx7LPbxPzIUd4DRggw00Ne3nTP3zCQ3+z5NeuA/RQxEbp/7rs1Z667E4csnJrV4VOejTXGFz9FlnSBZmXW26LbInpgnm5g== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 216.228.117.160) smtp.rcpttodomain=networkplumber.org smtp.mailfrom=nvidia.com; dmarc=pass (p=reject sp=reject pct=100) action=none header.from=nvidia.com; dkim=none (message not signed); arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=hWctI0akqC4ym2DSxGLUELXqLi1u5sKWfmMie2fcHAk=; b=r0HzHOqOZ7KscRjnzOApmKVImO91uej5vt7a7qUo/7XyFH1BgyjjiGfUmxW/nu4H4oc3HGoZPCG+gtf0MAQ4aQPVELDLkZo1WmKaGYbHGmq57OnUSScCoRpI+8HfWIlCCGlAwmmf0cBGiW1NAOO4IxQFbxVHcZRkmuf0tBI3gqQw/ny/QSo4Uzg9m+QeTAFnR93qHU6BB9PiUPr5lWepyemyuqNxOpMI724DMPxUof3rwgtHMsui/r3Ye1OAoSev5+z22m5K/KCZASfu/U7Qb/Dz6swx/RycJQULKgSRjKkO2XkAe4OYfpuoQN6TPsO8gdtvTY1zhdE9hMTWicsVrQ== Received: from CY8PR19CA0010.namprd19.prod.outlook.com (2603:10b6:930:44::16) by SJ0PR12MB7034.namprd12.prod.outlook.com (2603:10b6:a03:449::18) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6652.28; Thu, 10 Aug 2023 00:00:45 +0000 Received: from CY4PEPF0000E9CD.namprd03.prod.outlook.com (2603:10b6:930:44:cafe::f7) by CY8PR19CA0010.outlook.office365.com (2603:10b6:930:44::16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6652.28 via Frontend Transport; Thu, 10 Aug 2023 00:00:45 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 216.228.117.160) smtp.mailfrom=nvidia.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=nvidia.com; Received-SPF: Pass (protection.outlook.com: domain of nvidia.com designates 216.228.117.160 as permitted sender) receiver=protection.outlook.com; client-ip=216.228.117.160; helo=mail.nvidia.com; pr=C Received: from mail.nvidia.com (216.228.117.160) by CY4PEPF0000E9CD.mail.protection.outlook.com (10.167.241.140) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6652.19 via Frontend Transport; Thu, 10 Aug 2023 00:00:45 +0000 Received: from rnnvmail201.nvidia.com (10.129.68.8) by mail.nvidia.com (10.129.200.66) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.986.5; Wed, 9 Aug 2023 17:00:30 -0700 Received: from nvidia.com (10.126.230.37) by rnnvmail201.nvidia.com (10.129.68.8) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.986.37; Wed, 9 Aug 2023 17:00:28 -0700 From: Xueming Li To: Stephen Hemminger CC: Long Li , dpdk stable Subject: patch 'net/netvsc: fix sizeof calculation' has been queued to stable release 22.11.3 Date: Thu, 10 Aug 2023 07:58:38 +0800 Message-ID: <20230809235947.1187-6-xuemingl@nvidia.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20230809235947.1187-1-xuemingl@nvidia.com> References: <20230625063544.11183-1-xuemingl@nvidia.com> <20230809235947.1187-1-xuemingl@nvidia.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Type: text/plain X-Originating-IP: [10.126.230.37] X-ClientProxiedBy: rnnvmail202.nvidia.com (10.129.68.7) To rnnvmail201.nvidia.com (10.129.68.8) X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: CY4PEPF0000E9CD:EE_|SJ0PR12MB7034:EE_ X-MS-Office365-Filtering-Correlation-Id: 14f9a962-6e82-4ee7-4ded-08db9934d8b0 X-LD-Processed: 43083d15-7273-40c1-b7db-39efd9ccc17a,ExtAddr X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: 0LdtGNYzDlJxK7en/BjxpkMtX5Kz/032fID7rI0Xnxa+lYMj6AmDdrkGWRSsu4WigaYy5u1sCfOy+uUauCP2qgbUu9LIVqedhd2fs9ts+Ug/1LjvlSv0oxZcwyVLWCcJZEoPmW+EInDXarVaDsBK2Bb0zcFlqNj5o5WbLCPNuiIfDsY38qXa8RnWgspxzSbWviShBFeyr3n1lKKsGf5N6G6jk0PwAUEzrZfDWKpLBFmttrPm3f8B+El13yCUeDZ7fJ9YFjStFnI4JB9Zu//ooZKqic5+lhNbn6wbD4EH21IwPL/VpvmgqPf8Z3OJbhCnAiXinVu2AeQcv5I2XlqwfJAF5REjBPBE1NKQshLUtI7xQmPu1xAAgietGfCxdG9RejrqDnTb4b3GM4CCdEfl/RLQziN4dCZAu1HGM7Ciiftmj+SnKhuFXer2r1JlTZYolzlBQWRB9JFgoEdhePd8I8ds4oDCMDdY0wpukiIBq49GTPyKqYwaCukEj+px/YkhC9IQZ5Wye2yEAcKesum0k+mPSsEnTw7PJZMWjZMPubMscENyU7iIjJweaJqTOLuhGNk4X9FPBNayeZb3c6m35780freDDwWjhIuMveDYrs7hWUyVH0CgVb8UqmVVkev64sAWMNasqgMoH7vtAAXk1qMTAoKtJ3jPDEEAVKHAs6GLxcX9A53ephzmFVOBnV/9PyS2qesbcvToCmvBAX0BbVZzkxqIyIzfm//lVL6Dv2kCYkJexnkxoqvtvoQh5P2vHn2+uoqgSwRGbD1HlmsoKw== X-Forefront-Antispam-Report: CIP:216.228.117.160; CTRY:US; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:mail.nvidia.com; PTR:dc6edge1.nvidia.com; CAT:NONE; SFS:(13230028)(4636009)(396003)(39860400002)(376002)(346002)(136003)(451199021)(1800799006)(186006)(82310400008)(36840700001)(40470700004)(46966006)(966005)(40480700001)(26005)(55016003)(1076003)(53546011)(40460700003)(54906003)(36756003)(5660300002)(86362001)(2906002)(6916009)(41300700001)(70586007)(70206006)(8936002)(8676002)(4326008)(316002)(6666004)(7696005)(356005)(7636003)(82740400003)(45080400002)(478600001)(2616005)(426003)(47076005)(36860700001)(83380400001)(336012)(16526019)(6286002); DIR:OUT; SFP:1101; X-OriginatorOrg: Nvidia.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 10 Aug 2023 00:00:45.4433 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 14f9a962-6e82-4ee7-4ded-08db9934d8b0 X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=43083d15-7273-40c1-b7db-39efd9ccc17a; Ip=[216.228.117.160]; Helo=[mail.nvidia.com] X-MS-Exchange-CrossTenant-AuthSource: CY4PEPF0000E9CD.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: SJ0PR12MB7034 X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org Hi, FYI, your patch has been queued to stable release 22.11.3 Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet. It will be pushed if I get no objections before 08/11/23. So please shout if anyone has objections. Also note that after the patch there's a diff of the upstream commit vs the patch applied to the branch. This will indicate if there was any rebasing needed to apply to the stable branch. If there were code changes for rebasing (ie: not only metadata diffs), please double check that the rebase was correctly done. Queued patches are on a temporary branch at: https://git.dpdk.org/dpdk-stable/log/?h=22.11-staging This queued commit can be viewed at: https://git.dpdk.org/dpdk-stable/commit/?h=22.11-staging&id=67912c46f49c1b2617aac34e9c4e4fc05fbf7c3d Thanks. Xueming Li --- >From 67912c46f49c1b2617aac34e9c4e4fc05fbf7c3d Mon Sep 17 00:00:00 2001 From: Stephen Hemminger Date: Wed, 28 Jun 2023 17:29:57 -0700 Subject: [PATCH] net/netvsc: fix sizeof calculation Cc: Xueming Li [ upstream commit 86fb73f5bf401afc9d52144f27e6d1cf4f64348b ] Found by cppcheck. drivers/net/netvsc/hn_rndis.c:332:21: warning: Found calculation inside sizeof(). [sizeofCalculation] if (len < sizeof(3 * sizeof(uint32_t))) { Fixes: 4e9c73e96e83 ("net/netvsc: add Hyper-V network device") Signed-off-by: Stephen Hemminger Signed-off-by: Long Li --- drivers/net/netvsc/hn_rndis.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/net/netvsc/hn_rndis.c b/drivers/net/netvsc/hn_rndis.c index e6f1f28768..29c6009b2c 100644 --- a/drivers/net/netvsc/hn_rndis.c +++ b/drivers/net/netvsc/hn_rndis.c @@ -329,7 +329,8 @@ void hn_rndis_receive_response(struct hn_data *hv, hn_rndis_dump(data); - if (len < sizeof(3 * sizeof(uint32_t))) { + /* Check we can read first three data fields from RNDIS header */ + if (len < 3 * sizeof(uint32_t)) { PMD_DRV_LOG(ERR, "missing RNDIS header %u", len); return; -- 2.25.1 --- Diff of the applied patch vs upstream commit (please double-check if non-empty: --- --- - 2023-08-09 21:51:19.697626300 +0800 +++ 0059-net-netvsc-fix-sizeof-calculation.patch 2023-08-09 21:51:18.204352000 +0800 @@ -1 +1 @@ -From 86fb73f5bf401afc9d52144f27e6d1cf4f64348b Mon Sep 17 00:00:00 2001 +From 67912c46f49c1b2617aac34e9c4e4fc05fbf7c3d Mon Sep 17 00:00:00 2001 @@ -4,0 +5,3 @@ +Cc: Xueming Li + +[ upstream commit 86fb73f5bf401afc9d52144f27e6d1cf4f64348b ] @@ -13 +15,0 @@ -Cc: stable@dpdk.org