From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 391D24301F for ; Thu, 10 Aug 2023 02:13:06 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 3329C40DD8; Thu, 10 Aug 2023 02:13:06 +0200 (CEST) Received: from NAM10-MW2-obe.outbound.protection.outlook.com (mail-mw2nam10on2074.outbound.protection.outlook.com [40.107.94.74]) by mails.dpdk.org (Postfix) with ESMTP id E6B8A406B6 for ; Thu, 10 Aug 2023 02:13:04 +0200 (CEST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Lban5oIPpu4Xhhc1xQnt2ZF/hk++aI1WWOmSekm19xVme4XVlE7zicz5wK1ORUK/e8KOyamNN1nZDjUtpARGNOcdSCuD3nzJKjVZXt6HEsnaag9Nlzzq6kP3l7G21/w6cQMHuO1PQNPpK6sQ9UG6j9o6TKgnCirgAzsli5LCLkV9hfjnFAH8A1pNBp9bJkvSZF0ydkyMR2FtGZ2uVcfsMqv3VMSj5ZAbDgFXLSqlSa1+Dy5xCo9qH+2P8wI3uTPn4gsFRqYqclqHre3BSC14aUrQg09AVnzV5E683beT4FhmpMZ4gi/a3dMO3WO+x5UuQ/MsWwn7+z86JATq3AtSmA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=Go7CURtPpXtGhSEhF0zehDjcD8lMulbfJZ3JyLWVnUA=; b=daJuRFFASC/8WdspbB+Q7Jpj2UM+9La3arZ0+cw196NUHVU+IhgqmFedIU2U9rE5irauqLQIOj7qK+N/nyOI4/8WJXo8VUoEP8VDJRHg6LniDiOEP99l3R+lV9nm0AEOcclasaZdPkNLbYUxnyEqfBRWElWuf81PbXYbw7jf9nXvyt/tqLn7nXeRQoykqE3Dia6qvcvvIizDSGASZ0flwc5twFxuxgH/VCnHIbHC63xaWCA9fu6RSXfkG3KsZSQdy4+W7TC5OQ+Q001peRprZqpn7xf6ZCPW0gjA1aErGrUo6ptRYjHPrfdEXB+NZFjmGc0zc9u7dTnTtwf3l0r4Qw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 216.228.117.161) smtp.rcpttodomain=marvell.com smtp.mailfrom=nvidia.com; dmarc=pass (p=reject sp=reject pct=100) action=none header.from=nvidia.com; dkim=none (message not signed); arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=Go7CURtPpXtGhSEhF0zehDjcD8lMulbfJZ3JyLWVnUA=; b=m9FUKn0rPLiWDPV4DF1k5ZNmyTgBTWG+51eevSJf9OCXE4CGsh8lOCZz9q2g7oLjZ0tQRZWbwp/KQtAtUW50xSfHoWDW+XMLjHdPx2addyyhaa1mjsnp4SbnV1dmP8jDNaUuZs5zWvlbQnSjs7ANB3mKBXcPiYkUsqUrPchn3w1Rw7LAjSdfCEaAZ1ivcz42nC5A94IWvtzaGo2jDKhGWDYAMDGTsqeBz59MVj9wf++/PZmlRzAIixMNGp6uFs5RYad82Z0z5AwqP99DKHmCptIgAEoGmPVWg3MhnHo+9oEAN84x6FwvEPuH4i+5LO1M3l0InHVDTTqn2f5uW338/Q== Received: from MW4PR04CA0060.namprd04.prod.outlook.com (2603:10b6:303:6a::35) by CH2PR12MB4135.namprd12.prod.outlook.com (2603:10b6:610:7c::22) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6652.30; Thu, 10 Aug 2023 00:13:01 +0000 Received: from CO1PEPF000044EE.namprd05.prod.outlook.com (2603:10b6:303:6a:cafe::14) by MW4PR04CA0060.outlook.office365.com (2603:10b6:303:6a::35) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6652.28 via Frontend Transport; Thu, 10 Aug 2023 00:13:00 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 216.228.117.161) smtp.mailfrom=nvidia.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=nvidia.com; Received-SPF: Pass (protection.outlook.com: domain of nvidia.com designates 216.228.117.161 as permitted sender) receiver=protection.outlook.com; client-ip=216.228.117.161; helo=mail.nvidia.com; pr=C Received: from mail.nvidia.com (216.228.117.161) by CO1PEPF000044EE.mail.protection.outlook.com (10.167.241.68) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6652.19 via Frontend Transport; Thu, 10 Aug 2023 00:13:00 +0000 Received: from rnnvmail201.nvidia.com (10.129.68.8) by mail.nvidia.com (10.129.200.67) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.986.5; Wed, 9 Aug 2023 17:12:50 -0700 Received: from nvidia.com (10.126.231.37) by rnnvmail201.nvidia.com (10.129.68.8) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.986.37; Wed, 9 Aug 2023 17:12:48 -0700 From: Xueming Li To: Rahul Bhansali CC: dpdk stable Subject: patch 'common/cnxk: fix CPT backpressure disable on LBK' has been queued to stable release 22.11.3 Date: Thu, 10 Aug 2023 08:10:45 +0800 Message-ID: <20230810001045.2662-25-xuemingl@nvidia.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20230810001045.2662-1-xuemingl@nvidia.com> References: <20230625063544.11183-1-xuemingl@nvidia.com> <20230810001045.2662-1-xuemingl@nvidia.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Type: text/plain X-Originating-IP: [10.126.231.37] X-ClientProxiedBy: rnnvmail202.nvidia.com (10.129.68.7) To rnnvmail201.nvidia.com (10.129.68.8) X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: CO1PEPF000044EE:EE_|CH2PR12MB4135:EE_ X-MS-Office365-Filtering-Correlation-Id: 98648a66-65f3-4cad-83b2-08db99368edc X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: wXyKOXgbevCrCNWynY/ploFcqyeFGL9MWFCDkTrkiXrrXNe9tdEEvCO9+3sBhChWGiQD0f6C1cV2yd9mOI41rVH8MoHRJeOvcsshNmAhYSkEfpchwvFnPcjDc2boRSklmBAcI4Ppr4JFxcj2LNs9624XW0CdM4JkViKr60NGDPClnTJGhMfr42iJzs+2EpJx3NQrpzfGarsy0XaVUZHalbSRMs60mTGLaCh1oPCdLbVJlCbHbjhqcB2acpXijZmOvI1HEbtA2BqbFnA+32MfqArqCpu+Q/TUsgARyfCxXE27TlGbM+CDD4TKcw0IEm7rI+iuT7yk88gVMKjyxsfbdv3UAqsqovsGVZgeO46BfCVl1KyxbckcPvpSK+UOh2mv6j+qOI7WhnqeDFA4HRKAqiMGZXEIkYiifknzoVeaHgGfBeGQsWtzWeyUVMmeZvHTXKe47RV/LaGsz6ypR+2DYDqDZ9qnjNivk/m7kuRMIJJ7IsHPwN7vE7EseoF/fzGeIdye77A/Dkg0Ax17+hzZDg0ohJcPjLx2yWs9Ymdgr8B/cM7jfx9Mt8UsQ57XJzZt/HsocU4KEvNgDI8QeHGk2QNcD0Ff+MWph045CuyHhJjkN9Cj3x7lKanft3gdly4tfAf+qQuwsrZwOZf8iF8VxpZwbVLApCyltnEFjVH9NDOoSvXjt6uWoEUOBJyHN0xZUmJhi8iib8epItQ/ftI6g+x9SmVCeN7/l24Hv2EM8/h9oGY601+IFj9zdkyuoWxfnXE+kaWGLIdqz7ssPFlaQA== X-Forefront-Antispam-Report: CIP:216.228.117.161; CTRY:US; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:mail.nvidia.com; PTR:dc6edge2.nvidia.com; CAT:NONE; SFS:(13230028)(4636009)(136003)(39860400002)(346002)(396003)(376002)(186006)(1800799006)(451199021)(82310400008)(46966006)(40470700004)(36840700001)(2906002)(36756003)(86362001)(40460700003)(55016003)(40480700001)(83380400001)(47076005)(2616005)(6916009)(4326008)(426003)(36860700001)(53546011)(16526019)(336012)(6286002)(1076003)(26005)(478600001)(8676002)(8936002)(316002)(5660300002)(70586007)(70206006)(7636003)(356005)(6666004)(7696005)(966005)(82740400003)(41300700001); DIR:OUT; SFP:1101; X-OriginatorOrg: Nvidia.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 10 Aug 2023 00:13:00.6219 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 98648a66-65f3-4cad-83b2-08db99368edc X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=43083d15-7273-40c1-b7db-39efd9ccc17a; Ip=[216.228.117.161]; Helo=[mail.nvidia.com] X-MS-Exchange-CrossTenant-AuthSource: CO1PEPF000044EE.namprd05.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: CH2PR12MB4135 X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org Hi, FYI, your patch has been queued to stable release 22.11.3 Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet. It will be pushed if I get no objections before 08/11/23. So please shout if anyone has objections. Also note that after the patch there's a diff of the upstream commit vs the patch applied to the branch. This will indicate if there was any rebasing needed to apply to the stable branch. If there were code changes for rebasing (ie: not only metadata diffs), please double check that the rebase was correctly done. Queued patches are on a temporary branch at: https://git.dpdk.org/dpdk-stable/log/?h=22.11-staging This queued commit can be viewed at: https://git.dpdk.org/dpdk-stable/commit/?h=22.11-staging&id=da3c4ce23806030441aca6b3557dd99d7b81cb2a Thanks. Xueming Li --- >From da3c4ce23806030441aca6b3557dd99d7b81cb2a Mon Sep 17 00:00:00 2001 From: Rahul Bhansali Date: Mon, 3 Jul 2023 18:58:21 +0530 Subject: [PATCH] common/cnxk: fix CPT backpressure disable on LBK Cc: Xueming Li [ upstream commit 772e30281a1d686096b27e5926e2f369caa05cff ] For LBK interfaces, roc_nix_inl_inb_is_enabled() is false, hence backpressure on CPT is disabled and causing CQ full interrupt. NIXX_AF_RX_CHAN[0x800]_CFG is global config for all PF, VF of RPM/LBK, hence backpressure disable on CPT is not required. Fixes: 0663a84524e5 ("common/cnxk: enable backpressure on CPT with inline inbound") Signed-off-by: Rahul Bhansali --- drivers/common/cnxk/roc_nix_fc.c | 11 ----------- 1 file changed, 11 deletions(-) diff --git a/drivers/common/cnxk/roc_nix_fc.c b/drivers/common/cnxk/roc_nix_fc.c index 033e17a4bf..5e8a01c775 100644 --- a/drivers/common/cnxk/roc_nix_fc.c +++ b/drivers/common/cnxk/roc_nix_fc.c @@ -88,17 +88,6 @@ nix_fc_rxchan_bpid_set(struct roc_nix *roc_nix, bool enable) req->chan_cnt = 1; req->bpid_per_chan = 0; - rc = mbox_process_msg(mbox, (void *)&rsp); - if (rc) - goto exit; - } else { - req = mbox_alloc_msg_nix_cpt_bp_disable(mbox); - if (req == NULL) - return rc; - req->chan_base = 0; - req->chan_cnt = 1; - req->bpid_per_chan = 0; - rc = mbox_process_msg(mbox, (void *)&rsp); if (rc) goto exit; -- 2.25.1 --- Diff of the applied patch vs upstream commit (please double-check if non-empty: --- --- - 2023-08-09 21:51:21.404246600 +0800 +++ 0128-common-cnxk-fix-CPT-backpressure-disable-on-LBK.patch 2023-08-09 21:51:18.304352000 +0800 @@ -1 +1 @@ -From 772e30281a1d686096b27e5926e2f369caa05cff Mon Sep 17 00:00:00 2001 +From da3c4ce23806030441aca6b3557dd99d7b81cb2a Mon Sep 17 00:00:00 2001 @@ -3 +3 @@ -Date: Thu, 25 May 2023 15:28:35 +0530 +Date: Mon, 3 Jul 2023 18:58:21 +0530 @@ -4,0 +5,3 @@ +Cc: Xueming Li + +[ upstream commit 772e30281a1d686096b27e5926e2f369caa05cff ] @@ -13 +15,0 @@ -Cc: stable@dpdk.org @@ -17,2 +19,2 @@ - drivers/common/cnxk/roc_nix_fc.c | 18 ++---------------- - 1 file changed, 2 insertions(+), 16 deletions(-) + drivers/common/cnxk/roc_nix_fc.c | 11 ----------- + 1 file changed, 11 deletions(-) @@ -21 +23 @@ -index 8feb773e1d..6d6997ed82 100644 +index 033e17a4bf..5e8a01c775 100644 @@ -24,4 +26,7 @@ -@@ -87,25 +87,11 @@ nix_fc_rxchan_bpid_set(struct roc_nix *roc_nix, bool enable) - if (rc) - goto exit; - nix->cpt_lbpid = rsp->chan_bpid[0] & 0x1FF; +@@ -88,17 +88,6 @@ nix_fc_rxchan_bpid_set(struct roc_nix *roc_nix, bool enable) + req->chan_cnt = 1; + req->bpid_per_chan = 0; + +- rc = mbox_process_msg(mbox, (void *)&rsp); +- if (rc) +- goto exit; @@ -31 +36 @@ -- goto exit; +- return rc; @@ -33,4 +38 @@ -- if (roc_nix_is_lbk(roc_nix) || roc_nix_is_sdp(roc_nix)) -- req->chan_cnt = NIX_LBK_MAX_CHAN; -- else -- req->chan_cnt = NIX_CGX_MAX_CHAN; +- req->chan_cnt = 1; @@ -39,13 +41,3 @@ -- rc = mbox_process_msg(mbox, (void *)&rsp); -- if (rc) -- goto exit; -- nix->cpt_lbpid = 0; - } - - /* CPT to NIX BP on all channels */ -- if (!roc_feature_nix_has_rxchan_multi_bpid() || !nix->cpt_nixbpid) -+ if (!roc_feature_nix_has_rxchan_multi_bpid() || !nix->cpt_nixbpid || -+ !roc_nix_inl_inb_is_enabled(roc_nix)) - goto exit; - - mbox_put(mbox); + rc = mbox_process_msg(mbox, (void *)&rsp); + if (rc) + goto exit;