From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 5E1294301F for ; Thu, 10 Aug 2023 02:11:45 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 5482940DD8; Thu, 10 Aug 2023 02:11:45 +0200 (CEST) Received: from NAM11-CO1-obe.outbound.protection.outlook.com (mail-co1nam11on2069.outbound.protection.outlook.com [40.107.220.69]) by mails.dpdk.org (Postfix) with ESMTP id 9EFF0406B6 for ; Thu, 10 Aug 2023 02:11:44 +0200 (CEST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=b6ETg38lZdYXWeKJqBudgx/cL5A072cAySjyrX2EgwZ5CtH6cc9qCq5u5mzrVulCtjSdFNuSB8VxC9uo7qtrFBnVxctyxrP5Pk0VjCBUcibLaaEJ8X5Bnp54+NFp2d9P3h1lUJgwVQRPgIkAbGvNMJ9+AzBbcFsFX4qAnelNfYewIJITVGjsaV8VlAnRgDgRrvrLPjIz4NbpIDToV9GHD0v/hD6zVdq652B7Bkr5tL8d6LGXpmhChTtHO2ax/rW3U8yeLZUGJq0xT3YAl7zyOsBz9bf1Bq5v2U1CgwkmbYaMF6eLTXQ20ll44oU3OvbPtUMjUyvJnEPo+Yvy8YvWZw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=uF+v4TyXRRwVQI9dJp1kYmSjLiFcQ2xUkpnb8Irw1sY=; b=SmPVTUszea9ntfYc0V+25de9fcGySKB5k+GDWL216KGMwy1RxlUdDWXTUIEGfxpIaIW7KHCvlwlPtAnETJJQvYwjN1iHIMhW9j2hGiLcGGfUiw0RCv7iCObCcMVfg6EijWWkewvZmIYur1Z4nKenr4DuaTar5acQqTVh/8YfWfKmGgEQb/IeKagq+Yv1tk7IQRTbv3C+umCNIzfl9qS86KNs66ApJhELbIPQcmTEU3cfDSOnYWdinV3R+/+Fyed9V94one6ZjLQLMhwlpQviHFHp4EBz0nlnPV7OOSmakuHHartWERaLOaMv4LdN7FNvoggHiIyJ34B4EuRm0JoNvA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 216.228.117.161) smtp.rcpttodomain=redhat.com smtp.mailfrom=nvidia.com; dmarc=pass (p=reject sp=reject pct=100) action=none header.from=nvidia.com; dkim=none (message not signed); arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=uF+v4TyXRRwVQI9dJp1kYmSjLiFcQ2xUkpnb8Irw1sY=; b=N4oi5ZHjzxWTcwtsdoyd2WEzLcR/P+OvVp1cXba4L0PAV2vAc79PbbanfnY87at7W/KJ/VpzSyrsbiqgZefjGwn0ln6AIQEpiFtmWWMBa1NsP7sUXXcVXURaYVOHw0T9y8JVuDCKvT895+uI0AXndOE+YLYgGd2wjsZl1q7IsMexY09Vx8mEVVpRbxcGrOQk4QeMqMzcGDz40TbSF/luTZSAGvccTXR4MBMhX5bMMwd74X+tafzAJs/wYMkHsZNb3MKDkzjptIRgDI/2hw/og1Fj2alNQbw+vli2rSNPmdAwmXuF8kDwlgVaR2Zkoke2eFFBFAgPdQJssTRX8Rq/IQ== Received: from MW4P223CA0023.NAMP223.PROD.OUTLOOK.COM (2603:10b6:303:80::28) by SJ0PR12MB6902.namprd12.prod.outlook.com (2603:10b6:a03:484::7) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6652.27; Thu, 10 Aug 2023 00:11:42 +0000 Received: from CO1PEPF000044F2.namprd05.prod.outlook.com (2603:10b6:303:80:cafe::e2) by MW4P223CA0023.outlook.office365.com (2603:10b6:303:80::28) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6652.28 via Frontend Transport; Thu, 10 Aug 2023 00:11:41 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 216.228.117.161) smtp.mailfrom=nvidia.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=nvidia.com; Received-SPF: Pass (protection.outlook.com: domain of nvidia.com designates 216.228.117.161 as permitted sender) receiver=protection.outlook.com; client-ip=216.228.117.161; helo=mail.nvidia.com; pr=C Received: from mail.nvidia.com (216.228.117.161) by CO1PEPF000044F2.mail.protection.outlook.com (10.167.241.72) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6652.19 via Frontend Transport; Thu, 10 Aug 2023 00:11:41 +0000 Received: from rnnvmail201.nvidia.com (10.129.68.8) by mail.nvidia.com (10.129.200.67) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.986.5; Wed, 9 Aug 2023 17:11:26 -0700 Received: from nvidia.com (10.126.231.37) by rnnvmail201.nvidia.com (10.129.68.8) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.986.37; Wed, 9 Aug 2023 17:11:24 -0700 From: Xueming Li To: Bing Zhao CC: David Marchand , =?UTF-8?q?M=C3=A1rio=20Kuka?= , Viacheslav Ovsiienko , dpdk stable Subject: patch 'net/mlx5: fix drop action memory leak' has been queued to stable release 22.11.3 Date: Thu, 10 Aug 2023 08:10:29 +0800 Message-ID: <20230810001045.2662-9-xuemingl@nvidia.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20230810001045.2662-1-xuemingl@nvidia.com> References: <20230625063544.11183-1-xuemingl@nvidia.com> <20230810001045.2662-1-xuemingl@nvidia.com> MIME-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit X-Originating-IP: [10.126.231.37] X-ClientProxiedBy: rnnvmail202.nvidia.com (10.129.68.7) To rnnvmail201.nvidia.com (10.129.68.8) X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: CO1PEPF000044F2:EE_|SJ0PR12MB6902:EE_ X-MS-Office365-Filtering-Correlation-Id: dfeea177-93ac-4d49-3edc-08db99365fed X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: SiTC9GGKcGOP+4aO4PPGu31HJObJHgqKsst+pFv1g3crNdea7A/TPAZ7y9iFNAen0ELD1KkCqfMuNfPQk+rlAus70OUBWjCvP6b8Av4jq9WYRLQtwVp6s9UaVlFcqXjdyBLemtq1YyC00saXzH08UzR3YTPVeJNRbect33epGYCFL5sgjmV/W7ORxMHnpsVkinXCpr9ho+1zDvk+x2CUPStqtOCOJr+gPEfXHJCof8VGhZhohWSh6xMRtquzkOROtXUqnS7BpUKV8dfKaFeZ+CFl0AUYBWwk1IHKdp0wT+haM5xji9fT9zpI2VUT0RQkMMdj9ArefKwqP5ol0IJhQWNp49jLOyXDX0EXIEBnNaR+cRyDsMDT9M+CeGXovKr8N2LGQ7jiCsCymlffYres8eFNSuu7GsKr3RHBEjSzRx5ZtGgiB2PqOCIuYIHqE6276V6Z0lKw8UmXj/GWSHl/OOO+zjNc8U8vzd123266PNNO/3jDjW6yRGEN5nE5WoRpiaIYlq3hnBmUUfKcY9piDOCnsUU41JICoL5ixB+5fzkIKw134GUnkjuU7O2Qac1p2c09BTPxKW63aaJVqTsdkId7XIG+MRSHP0CAmDS3MTAhnCMeye8XXFzZnTyD7igjgB44SmhisYAmsIFQsytc3WymoB3RW8BJcEbQyXJI2pi1vWCsPTYFkjdVd19qXh39CyNpQS7pgDGyGdcrtw/GCjCqQPhfnXiV1VJQrPe3fPi84sFb9T2c+1rynErC0UqslZcHijaSTtd69BH8/0FJMQ== X-Forefront-Antispam-Report: CIP:216.228.117.161; CTRY:US; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:mail.nvidia.com; PTR:dc6edge2.nvidia.com; CAT:NONE; SFS:(13230028)(4636009)(376002)(346002)(136003)(396003)(39860400002)(451199021)(1800799006)(186006)(82310400008)(46966006)(40470700004)(36840700001)(7696005)(55016003)(40480700001)(2616005)(40460700003)(41300700001)(966005)(86362001)(7636003)(82740400003)(478600001)(26005)(36756003)(1076003)(53546011)(356005)(6862004)(8936002)(5660300002)(8676002)(6636002)(37006003)(4326008)(16526019)(70586007)(6286002)(70206006)(316002)(54906003)(336012)(2906002)(47076005)(36860700001)(426003)(66574015); DIR:OUT; SFP:1101; X-OriginatorOrg: Nvidia.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 10 Aug 2023 00:11:41.8630 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: dfeea177-93ac-4d49-3edc-08db99365fed X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=43083d15-7273-40c1-b7db-39efd9ccc17a; Ip=[216.228.117.161]; Helo=[mail.nvidia.com] X-MS-Exchange-CrossTenant-AuthSource: CO1PEPF000044F2.namprd05.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: SJ0PR12MB6902 X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org Hi, FYI, your patch has been queued to stable release 22.11.3 Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet. It will be pushed if I get no objections before 08/11/23. So please shout if anyone has objections. Also note that after the patch there's a diff of the upstream commit vs the patch applied to the branch. This will indicate if there was any rebasing needed to apply to the stable branch. If there were code changes for rebasing (ie: not only metadata diffs), please double check that the rebase was correctly done. Queued patches are on a temporary branch at: https://git.dpdk.org/dpdk-stable/log/?h=22.11-staging This queued commit can be viewed at: https://git.dpdk.org/dpdk-stable/commit/?h=22.11-staging&id=249a731ffd90c5af9047af48e76de58d05914620 Thanks. Xueming Li --- >From 249a731ffd90c5af9047af48e76de58d05914620 Mon Sep 17 00:00:00 2001 From: Bing Zhao Date: Thu, 13 Jul 2023 14:19:41 +0300 Subject: [PATCH] net/mlx5: fix drop action memory leak MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Cc: Xueming Li [ upstream commit 177d90ddd6e0e223966c2fb8a55e036cfb47db7a ] In DV mode, when quitting an application, the default drop action and its resources should be released. The Devx action for the TIR was not destroyed and it would cause 80B memory leak. With this commit, in DV mode, the action should be destroyed in the mlx5_devx_drop_action_destroy() explicitly. Bugzilla ID: 1192 Bugzilla ID: 1255 Fixes: bc5bee028ebc ("net/mlx5: create drop queue using DevX") Reported-by: David Marchand Reported-by: Mário Kuka Signed-off-by: Bing Zhao Acked-by: Viacheslav Ovsiienko --- drivers/net/mlx5/mlx5_devx.c | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/drivers/net/mlx5/mlx5_devx.c b/drivers/net/mlx5/mlx5_devx.c index 02deaac612..7e0ec91328 100644 --- a/drivers/net/mlx5/mlx5_devx.c +++ b/drivers/net/mlx5/mlx5_devx.c @@ -1127,6 +1127,10 @@ mlx5_devx_drop_action_destroy(struct rte_eth_dev *dev) struct mlx5_priv *priv = dev->data->dev_private; struct mlx5_hrxq *hrxq = priv->drop_queue.hrxq; +#if defined(HAVE_IBV_FLOW_DV_SUPPORT) || !defined(HAVE_INFINIBAND_VERBS_H) + if (hrxq->action != NULL) + mlx5_flow_os_destroy_flow_action(hrxq->action); +#endif if (hrxq->tir != NULL) mlx5_devx_tir_destroy(hrxq); if (hrxq->ind_table->ind_table != NULL) -- 2.25.1 --- Diff of the applied patch vs upstream commit (please double-check if non-empty: --- --- - 2023-08-09 21:51:21.021165400 +0800 +++ 0112-net-mlx5-fix-drop-action-memory-leak.patch 2023-08-09 21:51:18.274352000 +0800 @@ -1 +1 @@ -From 177d90ddd6e0e223966c2fb8a55e036cfb47db7a Mon Sep 17 00:00:00 2001 +From 249a731ffd90c5af9047af48e76de58d05914620 Mon Sep 17 00:00:00 2001 @@ -7,0 +8,3 @@ +Cc: Xueming Li + +[ upstream commit 177d90ddd6e0e223966c2fb8a55e036cfb47db7a ] @@ -20 +22,0 @@ -Cc: stable@dpdk.org @@ -31 +33 @@ -index d286cfe864..9fa400fc48 100644 +index 02deaac612..7e0ec91328 100644 @@ -34 +36 @@ -@@ -1134,6 +1134,10 @@ mlx5_devx_drop_action_destroy(struct rte_eth_dev *dev) +@@ -1127,6 +1127,10 @@ mlx5_devx_drop_action_destroy(struct rte_eth_dev *dev)