From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 943F5430B7 for ; Mon, 21 Aug 2023 04:53:15 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 6F32040EE3; Mon, 21 Aug 2023 04:53:15 +0200 (CEST) Received: from mail-pl1-f180.google.com (mail-pl1-f180.google.com [209.85.214.180]) by mails.dpdk.org (Postfix) with ESMTP id 8C64740A7D for ; Mon, 21 Aug 2023 04:53:13 +0200 (CEST) Received: by mail-pl1-f180.google.com with SMTP id d9443c01a7336-1bf3a2f44ffso19694225ad.1 for ; Sun, 20 Aug 2023 19:53:13 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20221208.gappssmtp.com; s=20221208; t=1692586392; x=1693191192; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:subject:cc:to:from:date:from:to:cc:subject:date :message-id:reply-to; bh=eUcxT9QEg7Em07PTh943EQABnl7pSsmZIbHeyCO2byA=; b=NFbM2VDlocXSJgaCYkU/nTqtcuxr08Q9pemDW+pNBGsJSYOGsSHYvziLWXMDZGBINd oqwolKSaoOZnsJ/41sQccPQC9I2RvRIhcPmTlq9bx4dUJMsWdmsH3so5BNwcthUb23Fa 8aC4rZamVKw+MAymmG8GiQSuivzcm7V0xh3XI/Gz9/5wjzbAfVN1sb348DHXU7Fwc08e ea58lw+NZTdSQfSoPVo1DroOqymO0iCkTw85epNiDPErxrhCBntx/QEDsxRkjY1necOW b/YsI7qekAOghjbIBo7yvnaj6ilK+ZgKfbieTULX756HnD1knTHSGT8J5a0GWyvzF+Rv uziQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1692586392; x=1693191192; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:subject:cc:to:from:date:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=eUcxT9QEg7Em07PTh943EQABnl7pSsmZIbHeyCO2byA=; b=CxQPE7FH3t9WchBQEL1gIjQN7vPs/za/vqiIwd8DuiagShqphRQ5bPro6XDihJ8paL 7MfWXoYPOYa7BSk/xUBOgspRj0vMZvKLUyQ909tY1UmjcsQSDD/gYt6yF9DnKZ4o8Zzm 77p1Sg+6+OxQ7PatQKvZS3Z7stB4LUqk4uBmATVq9d/3sp/ymh+DGrP/AdAfiZsh2MaP 5qoboBtC/nff9w90WmubQNirruxHXyxj9ozzAVCbok0BKbTRX4cOUrRrhLLATin13Dmt 81BcuUoW6tKSuDoJVjJV3bAp95amuP5nvTmIhdIr9oYRD6JsgkFgv6hJI/4CXkAyi0ul YR8Q== X-Gm-Message-State: AOJu0YzBCV+4IebFWa6s28jN910c2OjDNKzAgAeedIGwS8SCMhIDLmfZ 6cq5z9QX7SsWloHUjyeou/YpCg== X-Google-Smtp-Source: AGHT+IFcvPDQ6qHJPE6og4p74jQH0w33y0gM2OUCroas2Stdinza7tpdevtaX4HuKZ1TMaHobmyyZw== X-Received: by 2002:a17:902:c411:b0:1bf:73ec:b977 with SMTP id k17-20020a170902c41100b001bf73ecb977mr4621812plk.46.1692586392516; Sun, 20 Aug 2023 19:53:12 -0700 (PDT) Received: from hermes.local (204-195-127-207.wavecable.com. [204.195.127.207]) by smtp.gmail.com with ESMTPSA id i1-20020a17090332c100b001bf2dcfe352sm5759769plr.234.2023.08.20.19.53.11 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 20 Aug 2023 19:53:12 -0700 (PDT) Date: Sun, 20 Aug 2023 19:53:10 -0700 From: Stephen Hemminger To: Wenwu Ma Cc: nipun.gupta@amd.com, dev@dpdk.org, david.marchand@redhat.com, maxime.coquelin@redhat.com, chenbo.xia@intel.com, miao.li@intel.com, weix.ling@intel.com, stable@dpdk.org Subject: Re: [PATCH v2] bus/pci: fix legacy device IO port map in secondary process Message-ID: <20230820195310.086bebad@hermes.local> In-Reply-To: <20230821012707.315173-1-wenwux.ma@intel.com> References: <20230807015820.1329972-1-wenwux.ma@intel.com> <20230821012707.315173-1-wenwux.ma@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org On Mon, 21 Aug 2023 09:27:07 +0800 Wenwu Ma wrote: > + struct vfio_device_info device_info = { .argsz = sizeof(device_info) }; > + char pci_addr[PATH_MAX] = {0} Not sure if some tools will complain about initializing chars as zero. Anyway, why bother since you are using it with snprintf. Also, the new variables that are only used in the secondary case should be declared in that if() not for whole function.