patches for DPDK stable branches
 help / color / mirror / Atom feed
From: Stephen Hemminger <stephen@networkplumber.org>
To: Trevor Tao <taozj888@163.com>
Cc: dev@dpdk.org, thomas@monjalon.net, stable@dpdk.org
Subject: Re: [PATCH v1] examples/l3fwd: relax the RSS/Offload requirement
Date: Wed, 6 Sep 2023 08:11:17 -0700	[thread overview]
Message-ID: <20230906081117.32a61ec8@hermes.local> (raw)
In-Reply-To: <20230903040111.126695-1-taozj888@163.com>

On Sun,  3 Sep 2023 04:01:11 +0000
Trevor Tao <taozj888@163.com> wrote:

> Now the port Rx mq_mode had been set to RTE_ETH_MQ_RX_RSS, and offload
> mode set to RTE_ETH_RX_OFFLOAD_CHECKSUM by default, but some hardware
> and/or virtual interface does not support the RSS and offload mode
> presupposed, e.g., some virtio interfaces in the cloud don't support
> RSS and may only partly support RTE_ETH_RX_OFFLOAD_UDP_CKSUM/
> RTE_ETH_RX_OFFLOAD_TCP_CKSUM,
> but not RTE_ETH_RX_OFFLOAD_IPV4_CKSUM, and the error msg here:
> 
> virtio_dev_configure(): RSS support requested but not supported by
> the device
> Port0 dev_configure = -95
> 
> and:
> Ethdev port_id=0 requested Rx offloads 0xe does not match Rx offloads
> capabilities 0x201d in rte_eth_dev_configure()
> 
> So to enable the l3fwd running in that environment, the Rx mode requirement
> can be relaxed to reflect the hardware feature reality here, and the l3fwd
> can run smoothly then.
> A warning msg would be provided to user in case it happens here.
> 
> On the other side, enabling the software cksum check in case the
> hw support missing.
> 
> Fixes: af75078fece3 ("first public release")
> Cc: stable@dpdk.org
> 
> Signed-off-by: Trevor Tao <taozj888@163.com>

Multiple queue without RSS and rte_flow support is kind of useless.
All packets will arrive on one queue.

  reply	other threads:[~2023-09-06 15:11 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-09-03  4:01 Trevor Tao
2023-09-06 15:11 ` Stephen Hemminger [this message]
2023-09-17 18:04 ` Konstantin Ananyev
2023-09-18 12:45   ` taozj888
2023-09-20  8:04     ` Konstantin Ananyev
2023-09-20 12:13       ` taozj888
2023-09-26 13:49         ` Konstantin Ananyev
2023-10-02  9:06           ` taozj888
  -- strict thread matches above, loose matches on Subject: below --
2023-09-03  3:41 Trevor Tao
2023-07-20 10:12 Trevor Tao
2023-07-28  8:03 ` Konstantin Ananyev
2023-08-04  3:59   ` Trevor Tao
2023-08-04 13:05     ` Konstantin Ananyev

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20230906081117.32a61ec8@hermes.local \
    --to=stephen@networkplumber.org \
    --cc=dev@dpdk.org \
    --cc=stable@dpdk.org \
    --cc=taozj888@163.com \
    --cc=thomas@monjalon.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).