patches for DPDK stable branches
 help / color / mirror / Atom feed
From: Rahul Bhansali <rbhansali@marvell.com>
To: <dev@dpdk.org>, Naga Harish K S V <s.v.naga.harish.k@intel.com>,
	"Jerin Jacob" <jerinj@marvell.com>,
	Ganapati Kundapura <ganapati.kundapura@intel.com>
Cc: Rahul Bhansali <rbhansali@marvell.com>, <stable@dpdk.org>
Subject: [PATCH] eventdev/eth_rx: fix timestamp field register in mbuf
Date: Mon, 18 Sep 2023 13:55:53 +0530	[thread overview]
Message-ID: <20230918082553.704859-1-rbhansali@marvell.com> (raw)

For eventdev internal port, timestamp dynamic field registration
in mbuf is not required as that will be done from net device.
For SW eventdev, Rx timestamp field registration will be
done during Rx queue add operation as per device capabilities and
offload configuration.

Fixes: 83ab470d1259 ("eventdev/eth_rx: use timestamp as dynamic mbuf field")
Cc: stable@dpdk.org

Signed-off-by: Rahul Bhansali <rbhansali@marvell.com>
---
 lib/eventdev/rte_event_eth_rx_adapter.c | 19 ++++++++++++-------
 1 file changed, 12 insertions(+), 7 deletions(-)

diff --git a/lib/eventdev/rte_event_eth_rx_adapter.c b/lib/eventdev/rte_event_eth_rx_adapter.c
index 3ebfa5366d..5a5fade466 100644
--- a/lib/eventdev/rte_event_eth_rx_adapter.c
+++ b/lib/eventdev/rte_event_eth_rx_adapter.c
@@ -2472,13 +2472,6 @@ rxa_create(uint8_t id, uint8_t dev_id,
 	if (conf_cb == rxa_default_conf_cb)
 		rx_adapter->default_cb_arg = 1;
 
-	if (rte_mbuf_dyn_rx_timestamp_register(
-			&event_eth_rx_timestamp_dynfield_offset,
-			&event_eth_rx_timestamp_dynflag) != 0) {
-		RTE_EDEV_LOG_ERR("Error registering timestamp field in mbuf\n");
-		return -rte_errno;
-	}
-
 	rte_eventdev_trace_eth_rx_adapter_create(id, dev_id, conf_cb,
 		conf_arg);
 	return 0;
@@ -2738,6 +2731,7 @@ rte_event_eth_rx_adapter_queue_add(uint8_t id,
 					1);
 		}
 	} else {
+		uint64_t dev_offloads;
 		rte_spinlock_lock(&rx_adapter->rx_lock);
 		dev_info->internal_event_port = 0;
 		ret = rxa_init_service(rx_adapter, id);
@@ -2749,6 +2743,17 @@ rte_event_eth_rx_adapter_queue_add(uint8_t id,
 				rxa_sw_adapter_queue_count(rx_adapter));
 		}
 		rte_spinlock_unlock(&rx_adapter->rx_lock);
+
+		dev_offloads = dev_info->dev->data->dev_conf.rxmode.offloads;
+		if (dev_offloads & RTE_ETH_RX_OFFLOAD_TIMESTAMP) {
+			if (rte_mbuf_dyn_rx_timestamp_register(
+					&event_eth_rx_timestamp_dynfield_offset,
+					&event_eth_rx_timestamp_dynflag) != 0) {
+				RTE_EDEV_LOG_ERR("Error registering timestamp field in mbuf\n");
+				return -rte_errno;
+			}
+		}
+
 	}
 
 	rte_eventdev_trace_eth_rx_adapter_queue_add(id, eth_dev_id,
-- 
2.25.1


             reply	other threads:[~2023-09-18  8:26 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-09-18  8:25 Rahul Bhansali [this message]
2023-09-19 16:29 ` Jerin Jacob
2023-09-25 10:18   ` Naga Harish K, S V
2023-09-26  7:37     ` Jerin Jacob
2023-09-20 12:32 ` Naga Harish K, S V
2023-09-20 16:17   ` Rahul Bhansali
2023-09-20 16:32 ` [PATCH v2] " Rahul Bhansali
2023-09-20 16:48 ` [PATCH v3] " Rahul Bhansali
2023-09-26  7:04   ` Naga Harish K, S V
2023-09-27  4:58     ` Jerin Jacob

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20230918082553.704859-1-rbhansali@marvell.com \
    --to=rbhansali@marvell.com \
    --cc=dev@dpdk.org \
    --cc=ganapati.kundapura@intel.com \
    --cc=jerinj@marvell.com \
    --cc=s.v.naga.harish.k@intel.com \
    --cc=stable@dpdk.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).