* [PATCH v1] net/idpf: fix incorrect status calculation
@ 2023-09-28 5:05 yuying.zhang
2023-10-10 1:42 ` Xing, Beilei
2023-10-23 9:00 ` Xing, Beilei
0 siblings, 2 replies; 4+ messages in thread
From: yuying.zhang @ 2023-09-28 5:05 UTC (permalink / raw)
To: yuying.zhang, dev, qi.z.zhang, jingjing.wu, beilei.xing; +Cc: stable
From: Yuying Zhang <yuying.zhang@intel.com>
Fix the incorrect ingress packet number calculation.
Fixes: 7514d76d407b ("net/idpf: add basic statistics")
Cc: stable@dpdk.org
Signed-off-by: Yuying Zhang <yuying.zhang@intel.com>
---
drivers/net/idpf/idpf_ethdev.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/net/idpf/idpf_ethdev.c b/drivers/net/idpf/idpf_ethdev.c
index 3af7cf0bb7..6ae2ac2681 100644
--- a/drivers/net/idpf/idpf_ethdev.c
+++ b/drivers/net/idpf/idpf_ethdev.c
@@ -281,7 +281,7 @@ idpf_dev_stats_get(struct rte_eth_dev *dev, struct rte_eth_stats *stats)
idpf_vport_stats_update(&vport->eth_stats_offset, pstats);
stats->ipackets = pstats->rx_unicast + pstats->rx_multicast +
- pstats->rx_broadcast - pstats->rx_discards;
+ pstats->rx_broadcast;
stats->opackets = pstats->tx_broadcast + pstats->tx_multicast +
pstats->tx_unicast;
stats->ierrors = pstats->rx_errors;
--
2.34.1
^ permalink raw reply [flat|nested] 4+ messages in thread
* RE: [PATCH v1] net/idpf: fix incorrect status calculation
2023-09-28 5:05 [PATCH v1] net/idpf: fix incorrect status calculation yuying.zhang
@ 2023-10-10 1:42 ` Xing, Beilei
2023-10-23 9:00 ` Xing, Beilei
1 sibling, 0 replies; 4+ messages in thread
From: Xing, Beilei @ 2023-10-10 1:42 UTC (permalink / raw)
To: Zhang, Yuying, dev, Zhang, Qi Z, Wu, Jingjing; +Cc: stable
> -----Original Message-----
> From: Zhang, Yuying <yuying.zhang@intel.com>
> Sent: Thursday, September 28, 2023 1:05 PM
> To: Zhang, Yuying <yuying.zhang@intel.com>; dev@dpdk.org; Zhang, Qi Z
> <qi.z.zhang@intel.com>; Wu, Jingjing <jingjing.wu@intel.com>; Xing, Beilei
> <beilei.xing@intel.com>
> Cc: stable@dpdk.org
> Subject: [PATCH v1] net/idpf: fix incorrect status calculation
>
> From: Yuying Zhang <yuying.zhang@intel.com>
>
> Fix the incorrect ingress packet number calculation.
>
> Fixes: 7514d76d407b ("net/idpf: add basic statistics")
> Cc: stable@dpdk.org
>
> Signed-off-by: Yuying Zhang <yuying.zhang@intel.com>
> ---
> drivers/net/idpf/idpf_ethdev.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/net/idpf/idpf_ethdev.c b/drivers/net/idpf/idpf_ethdev.c
> index 3af7cf0bb7..6ae2ac2681 100644
> --- a/drivers/net/idpf/idpf_ethdev.c
> +++ b/drivers/net/idpf/idpf_ethdev.c
> @@ -281,7 +281,7 @@ idpf_dev_stats_get(struct rte_eth_dev *dev, struct
> rte_eth_stats *stats)
>
> idpf_vport_stats_update(&vport->eth_stats_offset, pstats);
> stats->ipackets = pstats->rx_unicast + pstats->rx_multicast +
> - pstats->rx_broadcast - pstats->rx_discards;
> + pstats->rx_broadcast;
Seems rx_error is also considered in ingress packets.
Same for cpfl.
> stats->opackets = pstats->tx_broadcast + pstats->tx_multicast
> +
> pstats->tx_unicast;
> stats->ierrors = pstats->rx_errors;
> --
> 2.34.1
^ permalink raw reply [flat|nested] 4+ messages in thread
* RE: [PATCH v1] net/idpf: fix incorrect status calculation
2023-09-28 5:05 [PATCH v1] net/idpf: fix incorrect status calculation yuying.zhang
2023-10-10 1:42 ` Xing, Beilei
@ 2023-10-23 9:00 ` Xing, Beilei
2023-10-24 5:26 ` Zhang, Qi Z
1 sibling, 1 reply; 4+ messages in thread
From: Xing, Beilei @ 2023-10-23 9:00 UTC (permalink / raw)
To: Zhang, Yuying, dev, Zhang, Qi Z, Wu, Jingjing; +Cc: stable
> -----Original Message-----
> From: Zhang, Yuying <yuying.zhang@intel.com>
> Sent: Thursday, September 28, 2023 1:05 PM
> To: Zhang, Yuying <yuying.zhang@intel.com>; dev@dpdk.org; Zhang, Qi Z
> <qi.z.zhang@intel.com>; Wu, Jingjing <jingjing.wu@intel.com>; Xing, Beilei
> <beilei.xing@intel.com>
> Cc: stable@dpdk.org
> Subject: [PATCH v1] net/idpf: fix incorrect status calculation
>
> From: Yuying Zhang <yuying.zhang@intel.com>
>
> Fix the incorrect ingress packet number calculation.
>
> Fixes: 7514d76d407b ("net/idpf: add basic statistics")
> Cc: stable@dpdk.org
>
> Signed-off-by: Yuying Zhang <yuying.zhang@intel.com>
> ---
> drivers/net/idpf/idpf_ethdev.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/net/idpf/idpf_ethdev.c b/drivers/net/idpf/idpf_ethdev.c
> index 3af7cf0bb7..6ae2ac2681 100644
> --- a/drivers/net/idpf/idpf_ethdev.c
> +++ b/drivers/net/idpf/idpf_ethdev.c
> @@ -281,7 +281,7 @@ idpf_dev_stats_get(struct rte_eth_dev *dev, struct
> rte_eth_stats *stats)
>
> idpf_vport_stats_update(&vport->eth_stats_offset, pstats);
> stats->ipackets = pstats->rx_unicast + pstats->rx_multicast +
> - pstats->rx_broadcast - pstats->rx_discards;
> + pstats->rx_broadcast;
> stats->opackets = pstats->tx_broadcast + pstats->tx_multicast
> +
> pstats->tx_unicast;
> stats->ierrors = pstats->rx_errors;
> --
> 2.34.1
Acked-by: Beilei Xing <beilei.xing@intel.com>
^ permalink raw reply [flat|nested] 4+ messages in thread
* RE: [PATCH v1] net/idpf: fix incorrect status calculation
2023-10-23 9:00 ` Xing, Beilei
@ 2023-10-24 5:26 ` Zhang, Qi Z
0 siblings, 0 replies; 4+ messages in thread
From: Zhang, Qi Z @ 2023-10-24 5:26 UTC (permalink / raw)
To: Xing, Beilei, Zhang, Yuying, dev, Wu, Jingjing; +Cc: stable
> -----Original Message-----
> From: Xing, Beilei <beilei.xing@intel.com>
> Sent: Monday, October 23, 2023 5:01 PM
> To: Zhang, Yuying <yuying.zhang@intel.com>; dev@dpdk.org; Zhang, Qi Z
> <qi.z.zhang@intel.com>; Wu, Jingjing <jingjing.wu@intel.com>
> Cc: stable@dpdk.org
> Subject: RE: [PATCH v1] net/idpf: fix incorrect status calculation
>
>
>
> > -----Original Message-----
> > From: Zhang, Yuying <yuying.zhang@intel.com>
> > Sent: Thursday, September 28, 2023 1:05 PM
> > To: Zhang, Yuying <yuying.zhang@intel.com>; dev@dpdk.org; Zhang, Qi Z
> > <qi.z.zhang@intel.com>; Wu, Jingjing <jingjing.wu@intel.com>; Xing,
> > Beilei <beilei.xing@intel.com>
> > Cc: stable@dpdk.org
> > Subject: [PATCH v1] net/idpf: fix incorrect status calculation
> >
> > From: Yuying Zhang <yuying.zhang@intel.com>
> >
> > Fix the incorrect ingress packet number calculation.
> >
> > Fixes: 7514d76d407b ("net/idpf: add basic statistics")
> > Cc: stable@dpdk.org
> >
> > Signed-off-by: Yuying Zhang <yuying.zhang@intel.com>
> > ---
> > drivers/net/idpf/idpf_ethdev.c | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/drivers/net/idpf/idpf_ethdev.c
> > b/drivers/net/idpf/idpf_ethdev.c index 3af7cf0bb7..6ae2ac2681 100644
> > --- a/drivers/net/idpf/idpf_ethdev.c
> > +++ b/drivers/net/idpf/idpf_ethdev.c
> > @@ -281,7 +281,7 @@ idpf_dev_stats_get(struct rte_eth_dev *dev, struct
> > rte_eth_stats *stats)
> >
> > idpf_vport_stats_update(&vport->eth_stats_offset, pstats);
> > stats->ipackets = pstats->rx_unicast + pstats->rx_multicast +
> > - pstats->rx_broadcast - pstats->rx_discards;
> > + pstats->rx_broadcast;
> > stats->opackets = pstats->tx_broadcast + pstats->tx_multicast
> > +
> > pstats->tx_unicast;
> > stats->ierrors = pstats->rx_errors;
> > --
> > 2.34.1
>
> Acked-by: Beilei Xing <beilei.xing@intel.com>
Applied to dpdk-next-net-intel.
Thanks
Qi
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2023-10-24 5:26 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2023-09-28 5:05 [PATCH v1] net/idpf: fix incorrect status calculation yuying.zhang
2023-10-10 1:42 ` Xing, Beilei
2023-10-23 9:00 ` Xing, Beilei
2023-10-24 5:26 ` Zhang, Qi Z
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).