From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id ACC29431A0 for ; Thu, 19 Oct 2023 02:00:27 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id A6A084029E; Thu, 19 Oct 2023 02:00:27 +0200 (CEST) Received: from mail-wm1-f49.google.com (mail-wm1-f49.google.com [209.85.128.49]) by mails.dpdk.org (Postfix) with ESMTP id 6961840291 for ; Thu, 19 Oct 2023 02:00:26 +0200 (CEST) Received: by mail-wm1-f49.google.com with SMTP id 5b1f17b1804b1-4081ccf69dcso1144215e9.0 for ; Wed, 18 Oct 2023 17:00:26 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1697673626; x=1698278426; darn=dpdk.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=uwS707UYdsCP/E9mf2xDav82Ao4fAfEpqwW9gehBIEY=; b=ffdsHGX0p4G/fRcFlb1PbjTE7O/Qbe9gfK4gwD0UZi2Z+zXXFH1MwsFlX/csZnChk4 SpFskQqE9+M5A0tpkwjT5LhTZa2GToDM4WjTtYT2OOSEUDfkOf6+YTHzsTangFDP0B+C oUBJGdur0Qqz2yepznSUu/w5QmPxn9m4ZS/t1RjpA/CWPYemijTbG3Eqc8wbuGDw/Ik9 maWXWsIHcE1SP9rEOMxduOsiR7ftzJSMNQx9YAS+EmpoCvF8NsxHoXK3AbVxZ3HYvoMR f8ZRxcj76qaW+FgCgLqKP/GWMZlYsL9wJoLiEMUtuIy44aRruPqPeJ6KI4OphjZmHtZm 513Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1697673626; x=1698278426; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=uwS707UYdsCP/E9mf2xDav82Ao4fAfEpqwW9gehBIEY=; b=ojtZ2teZgZpdUJPddQ9H5nYDe2VFhRik+69wV4c79nb3Kd7clL6qf0rohrieHXB+zJ wncyU1v09Td+0QMLTZaLzt4TFc2osHpVH9WbkKjXMUljq4jNDT/eDqptWe5I1JnaDAwl qZXS8lauG+6MfVmDUV2qKdo02wP9kiEHpQJ8gtcQMSOmBwL1Q60w9u4PospiX1ON16ac S0kqV/xcveqBoWIBryu2wdnIqhia67r72ILm6QXktZK4KHZ9q8zozT7FT+MPpWdEYLzp sdIhOU8aPa/tM2HGIESvUhuL5Q30MOxan1YnFZaL4mm9x1SdJcIzjHfRW62KMI7E8oR/ jXdQ== X-Gm-Message-State: AOJu0Yz9NqnNAoNOAtJBjSMNbgK++UhpItf2XJX2uU8zdI6lLDZqoPRb L+WhZPd06K7QeuwW6JUTKzbcJcyQM8UJoA== X-Google-Smtp-Source: AGHT+IEPVtcFo5KIiXE23+Glrvtu3R/AOrUoDU+lOEbgfqgMQ3qNXmanDr0ZbD/2xmGaj2HvCagILg== X-Received: by 2002:adf:9dd1:0:b0:316:fc03:3c66 with SMTP id q17-20020adf9dd1000000b00316fc033c66mr281182wre.3.1697673626114; Wed, 18 Oct 2023 17:00:26 -0700 (PDT) Received: from localhost ([137.220.119.58]) by smtp.gmail.com with ESMTPSA id bs30-20020a056000071e00b0032d9a1f2ec3sm3223264wrb.27.2023.10.18.17.00.25 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 18 Oct 2023 17:00:25 -0700 (PDT) From: luca.boccassi@gmail.com To: Jiawen Wu Cc: dpdk stable Subject: patch 'net/txgbe: check process type in close operation' has been queued to stable release 20.11.10 Date: Thu, 19 Oct 2023 00:59:05 +0100 Message-Id: <20231018235930.3144-16-luca.boccassi@gmail.com> X-Mailer: git-send-email 2.39.2 In-Reply-To: <20231018235930.3144-1-luca.boccassi@gmail.com> References: <20231018235930.3144-1-luca.boccassi@gmail.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org Hi, FYI, your patch has been queued to stable release 20.11.10 Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet. It will be pushed if I get no objections before 10/21/23. So please shout if anyone has objections. Also note that after the patch there's a diff of the upstream commit vs the patch applied to the branch. This will indicate if there was any rebasing needed to apply to the stable branch. If there were code changes for rebasing (ie: not only metadata diffs), please double check that the rebase was correctly done. Queued patches are on a temporary branch at: https://github.com/bluca/dpdk-stable This queued commit can be viewed at: https://github.com/bluca/dpdk-stable/commit/9a7af96513d007af9b22516ef0112622e695d27e Thanks. Luca Boccassi --- >From 9a7af96513d007af9b22516ef0112622e695d27e Mon Sep 17 00:00:00 2001 From: Jiawen Wu Date: Thu, 28 Sep 2023 17:47:56 +0800 Subject: [PATCH] net/txgbe: check process type in close operation [ upstream commit 21ed282505ed8f60f03a93a27ac01f4152b8ab40 ] The secondary processes are not allowed to release shared resources. Only process-private resources should be freed in a secondary process. Most of the time, there is no process-private resource, so the close operation is just forbidden in a secondary process. Fixes: e1698e383c2a ("net/txgbe: add device init and uninit") Signed-off-by: Jiawen Wu --- drivers/net/txgbe/txgbe_ethdev.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/drivers/net/txgbe/txgbe_ethdev.c b/drivers/net/txgbe/txgbe_ethdev.c index c2f2f5c323..29875bd7b9 100644 --- a/drivers/net/txgbe/txgbe_ethdev.c +++ b/drivers/net/txgbe/txgbe_ethdev.c @@ -1783,6 +1783,9 @@ txgbe_dev_close(struct rte_eth_dev *dev) PMD_INIT_FUNC_TRACE(); + if (rte_eal_process_type() != RTE_PROC_PRIMARY) + return 0; + txgbe_pf_reset_hw(hw); ret = txgbe_dev_stop(dev); -- 2.39.2 --- Diff of the applied patch vs upstream commit (please double-check if non-empty: --- --- - 2023-10-19 00:28:57.040434397 +0100 +++ 0016-net-txgbe-check-process-type-in-close-operation.patch 2023-10-19 00:28:56.225804732 +0100 @@ -1 +1 @@ -From 21ed282505ed8f60f03a93a27ac01f4152b8ab40 Mon Sep 17 00:00:00 2001 +From 9a7af96513d007af9b22516ef0112622e695d27e Mon Sep 17 00:00:00 2001 @@ -5,0 +6,2 @@ +[ upstream commit 21ed282505ed8f60f03a93a27ac01f4152b8ab40 ] + @@ -12 +13,0 @@ -Cc: stable@dpdk.org @@ -20 +21 @@ -index 2dad820cb5..6bc231a130 100644 +index c2f2f5c323..29875bd7b9 100644 @@ -23 +24 @@ -@@ -2052,6 +2052,9 @@ txgbe_dev_close(struct rte_eth_dev *dev) +@@ -1783,6 +1783,9 @@ txgbe_dev_close(struct rte_eth_dev *dev)