From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 8B12C431A0 for ; Thu, 19 Oct 2023 02:01:01 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 843BA40A8B; Thu, 19 Oct 2023 02:01:01 +0200 (CEST) Received: from mail-lj1-f180.google.com (mail-lj1-f180.google.com [209.85.208.180]) by mails.dpdk.org (Postfix) with ESMTP id DB20940A8B for ; Thu, 19 Oct 2023 02:00:59 +0200 (CEST) Received: by mail-lj1-f180.google.com with SMTP id 38308e7fff4ca-2c514cbbe7eso67026191fa.1 for ; Wed, 18 Oct 2023 17:00:59 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1697673659; x=1698278459; darn=dpdk.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=/uU0ZP+xkDZ3ofVdg9YXW80ij/aT3yFk0gcuuj06+7A=; b=jC3zo57N8wX8QqJHO5hH4+7r4psTmgW4KWCM/gZ9bNz7lus3/2us7jVVnSDJfdxoGc XVooDYFzs7Mxo1EDtXxGdzkMOehSmr/BE8NZAjBIZgAr96qRqZVto9j1kntkkvhWdAti QxIrt66uF+REJZZpfQafne5FPcSUrcWIsJgokWbss4DXBaWHyzOn2udcuIbzyaqUXh+y rku83zRbHxSGbvYd3TqlLh171+agzNwI9Sk5w634CnNzzmmAuJ1Z8ULBNgxqO+9QVK46 bDdZpGPV67X6f69mYku3rJ4X1wLV9SxQMinxPljn2Kog3QQd1FlRBv5G7lUjIFQYYse/ i1yA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1697673659; x=1698278459; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=/uU0ZP+xkDZ3ofVdg9YXW80ij/aT3yFk0gcuuj06+7A=; b=A8rN13q9pY0sVUIyJ+Ytz6aUScKItgXLxT8x3UwZYefCY0Nu1qQL+dgokjGz9HGEsa I7mOeY0VcO/L/mqHBWwpNeqC+zbQJn7d1A2VMkRTCPexyE1GpHS1mw1l8rs8c2XFnlIc w3wJAazhYv4iJsL7D7wyBTbOlQHW88RN/Ymu1kiCu9sJqfKdxOiKctJWp3176yQ1xUjG fn7yhqI/R1gG3xfJKpi+koTKR41lboUOHwtlnZ1vYrHlIxsI0Pu2n1y0rtUOQWFo322g 8xUMR4zSVfv88E+OXhWTRKRbpRWXATR0N7mEJ3sYHRJPbwSW0EsDfWLKhI6ag3ZazPCd ul/w== X-Gm-Message-State: AOJu0YzatBhpN5zOhPkUm04yYxZRdA+emMWNJsdJawYP+drtXGD22L83 aBpo576rNaj0YmEK5okoGyipviBZAgev5A== X-Google-Smtp-Source: AGHT+IF7tFS/uI4dQDGB7rFajcnku3HLm+WHPycoxADZl7KRmxhcVutUf7T3pbGEVDqTSx90Whz41Q== X-Received: by 2002:a2e:b890:0:b0:2c5:19f2:4fde with SMTP id r16-20020a2eb890000000b002c519f24fdemr304625ljp.23.1697673659331; Wed, 18 Oct 2023 17:00:59 -0700 (PDT) Received: from localhost ([137.220.119.58]) by smtp.gmail.com with ESMTPSA id h5-20020a05600c350500b003fc0505be19sm2960574wmq.37.2023.10.18.17.00.58 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 18 Oct 2023 17:00:58 -0700 (PDT) From: luca.boccassi@gmail.com To: Beilei Xing Cc: Jingjing Wu , dpdk stable Subject: patch 'net/i40e: fix FDIR queue receives broadcast packets' has been queued to stable release 20.11.10 Date: Thu, 19 Oct 2023 00:59:17 +0100 Message-Id: <20231018235930.3144-28-luca.boccassi@gmail.com> X-Mailer: git-send-email 2.39.2 In-Reply-To: <20231018235930.3144-1-luca.boccassi@gmail.com> References: <20231018235930.3144-1-luca.boccassi@gmail.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org Hi, FYI, your patch has been queued to stable release 20.11.10 Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet. It will be pushed if I get no objections before 10/21/23. So please shout if anyone has objections. Also note that after the patch there's a diff of the upstream commit vs the patch applied to the branch. This will indicate if there was any rebasing needed to apply to the stable branch. If there were code changes for rebasing (ie: not only metadata diffs), please double check that the rebase was correctly done. Queued patches are on a temporary branch at: https://github.com/bluca/dpdk-stable This queued commit can be viewed at: https://github.com/bluca/dpdk-stable/commit/297e74460e16b196560b16a26a27e2163ed8c76b Thanks. Luca Boccassi --- >From 297e74460e16b196560b16a26a27e2163ed8c76b Mon Sep 17 00:00:00 2001 From: Beilei Xing Date: Fri, 21 Jul 2023 05:35:13 +0000 Subject: [PATCH] net/i40e: fix FDIR queue receives broadcast packets [ upstream commit c07aa47b6272cc14842af06e437cda870e867fbd ] FDIR Rxq is excepted to only receive FDIR programming status, won't receive broadcast packets. Fixes: a778a1fa2e4e ("i40e: set up and initialize flow director") Signed-off-by: Beilei Xing Acked-by: Jingjing Wu --- drivers/net/i40e/i40e_ethdev.c | 16 +++++++++------- 1 file changed, 9 insertions(+), 7 deletions(-) diff --git a/drivers/net/i40e/i40e_ethdev.c b/drivers/net/i40e/i40e_ethdev.c index a0569dab25..cfcf1b690e 100644 --- a/drivers/net/i40e/i40e_ethdev.c +++ b/drivers/net/i40e/i40e_ethdev.c @@ -6080,14 +6080,16 @@ i40e_vsi_setup(struct i40e_pf *pf, } } - /* MAC/VLAN configuration */ - rte_memcpy(&filter.mac_addr, &broadcast, RTE_ETHER_ADDR_LEN); - filter.filter_type = I40E_MACVLAN_PERFECT_MATCH; + if (vsi->type != I40E_VSI_FDIR) { + /* MAC/VLAN configuration for non-FDIR VSI*/ + rte_memcpy(&filter.mac_addr, &broadcast, RTE_ETHER_ADDR_LEN); + filter.filter_type = I40E_MACVLAN_PERFECT_MATCH; - ret = i40e_vsi_add_mac(vsi, &filter); - if (ret != I40E_SUCCESS) { - PMD_DRV_LOG(ERR, "Failed to add MACVLAN filter"); - goto fail_msix_alloc; + ret = i40e_vsi_add_mac(vsi, &filter); + if (ret != I40E_SUCCESS) { + PMD_DRV_LOG(ERR, "Failed to add MACVLAN filter"); + goto fail_msix_alloc; + } } /* Get VSI BW information */ -- 2.39.2 --- Diff of the applied patch vs upstream commit (please double-check if non-empty: --- --- - 2023-10-19 00:28:57.645586403 +0100 +++ 0028-net-i40e-fix-FDIR-queue-receives-broadcast-packets.patch 2023-10-19 00:28:56.281806213 +0100 @@ -1 +1 @@ -From c07aa47b6272cc14842af06e437cda870e867fbd Mon Sep 17 00:00:00 2001 +From 297e74460e16b196560b16a26a27e2163ed8c76b Mon Sep 17 00:00:00 2001 @@ -5,0 +6,2 @@ +[ upstream commit c07aa47b6272cc14842af06e437cda870e867fbd ] + @@ -10 +11,0 @@ -Cc: stable@dpdk.org @@ -19 +20 @@ -index 50ba9aac94..0482647cc1 100644 +index a0569dab25..cfcf1b690e 100644 @@ -22 +23 @@ -@@ -6026,14 +6026,16 @@ i40e_vsi_setup(struct i40e_pf *pf, +@@ -6080,14 +6080,16 @@ i40e_vsi_setup(struct i40e_pf *pf,