From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 8BD4C431A0 for ; Thu, 19 Oct 2023 02:01:16 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 86A4940EE3; Thu, 19 Oct 2023 02:01:16 +0200 (CEST) Received: from mail-lf1-f53.google.com (mail-lf1-f53.google.com [209.85.167.53]) by mails.dpdk.org (Postfix) with ESMTP id 3E4454029E for ; Thu, 19 Oct 2023 02:01:15 +0200 (CEST) Received: by mail-lf1-f53.google.com with SMTP id 2adb3069b0e04-507a0907896so6908087e87.2 for ; Wed, 18 Oct 2023 17:01:15 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1697673675; x=1698278475; darn=dpdk.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=5NmA7Xt5on7oOiNXCcr8pv3ky81AGdTCdln6t6+clEg=; b=mqDIW99pVn1k+yJVurqgxNNe7cZb5rvVnMPJFO6ZZZcvZLrKSZKJP05s4Xfxuagzdx Mr/OAV/GZLAD+QqEKdruZ3n1T/pjRhtj11wzav/8dAdpQ+GlkH4WrNbDlNvmuY40I9iH tF4Jw4rwntJZiV89jYEfZHl1wSiKjsCfoDUhN9AJc0PpqroYMaiMl9Gl44jFfkzE9N2F +LiVmKXFFDhKE4y0zeANRxfIbYwZ5u8lBGONjfRNBgAkW4DW4ZnrUBwRnyYz2cgRZ6Wr E2RGGdxwm16FGslGCrQGmDtUzbiKkC8W5U7tOA22wlPPPsSOnTkcspMCqQGs3nQg2bLm 29LQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1697673675; x=1698278475; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=5NmA7Xt5on7oOiNXCcr8pv3ky81AGdTCdln6t6+clEg=; b=Hd3yJPIpnxILBxn9c/G1r4okw6GQ9ppNsOmp0f96SIl6memD7zq+q5eFKz2fS30Y37 iEHpW+P7//o2tAVCdaCQp3z5ij8MYo+RvTZB8INsKikMolQNX0JZlY/WCKukOjInmzHx 71I6C+bnNa6ijQV1XssDEE0O4rg0Q+MhgeKiLs1pGMYIpSWAFFcs3+n65c93VeKw6W6a ILz0ilpFnWMgRmg3Bf3IJInyXgtiwa9wD0U/jG/FeGF4c6XKKRJ+XvBlN8viedN0u/EI Tcha5dQahGMmHhQlamLtJw05XP4LCG4IWl49FmgV0NnDb0MHy78w981UcCforzOF5L3h U6WA== X-Gm-Message-State: AOJu0Yxo5iy63IvbZ78KLHj/gSJH5ct05asuSo6ORpqgmOINEWRM7CFe 0xuEJFKwqDAmnTQKTl+hzQgPJ647YINIIQ== X-Google-Smtp-Source: AGHT+IHIjC3+/bRS1JMb2VYbYxLqhuQzEGuZPfZe2YmEB2NTpv9HMJLmL/LYHZA8FrfiDmX9ACX9lA== X-Received: by 2002:a19:a418:0:b0:507:968d:a301 with SMTP id q24-20020a19a418000000b00507968da301mr260690lfc.55.1697673674700; Wed, 18 Oct 2023 17:01:14 -0700 (PDT) Received: from localhost ([137.220.119.58]) by smtp.gmail.com with ESMTPSA id l6-20020a5d4806000000b0032da75af3easm3169075wrq.80.2023.10.18.17.01.14 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 18 Oct 2023 17:01:14 -0700 (PDT) From: luca.boccassi@gmail.com To: David Marchand Cc: Qi Zhang , dpdk stable Subject: patch 'net/iavf: remove log from Tx prepare function' has been queued to stable release 20.11.10 Date: Thu, 19 Oct 2023 00:59:22 +0100 Message-Id: <20231018235930.3144-33-luca.boccassi@gmail.com> X-Mailer: git-send-email 2.39.2 In-Reply-To: <20231018235930.3144-1-luca.boccassi@gmail.com> References: <20231018235930.3144-1-luca.boccassi@gmail.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org Hi, FYI, your patch has been queued to stable release 20.11.10 Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet. It will be pushed if I get no objections before 10/21/23. So please shout if anyone has objections. Also note that after the patch there's a diff of the upstream commit vs the patch applied to the branch. This will indicate if there was any rebasing needed to apply to the stable branch. If there were code changes for rebasing (ie: not only metadata diffs), please double check that the rebase was correctly done. Queued patches are on a temporary branch at: https://github.com/bluca/dpdk-stable This queued commit can be viewed at: https://github.com/bluca/dpdk-stable/commit/5d3142ed48fd78d8a4781cb8da47e519038af3ce Thanks. Luca Boccassi --- >From 5d3142ed48fd78d8a4781cb8da47e519038af3ce Mon Sep 17 00:00:00 2001 From: David Marchand Date: Wed, 27 Sep 2023 11:41:45 +0200 Subject: [PATCH] net/iavf: remove log from Tx prepare function [ upstream commit 4015aed58aefb3cceba6766f1fcaaa483c21ede0 ] iavf_prep_pkts reports to the application that the packet is invalid (from the driver pov). Having a log message only in this branch is not consistent with all other checks in this function and it may slow down the application if such invalid packets are being sent continuously. Fixes: 19ee91c6bd9a ("net/iavf: check illegal packet sizes") Signed-off-by: David Marchand Acked-by: Qi Zhang --- drivers/net/iavf/iavf_rxtx.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/net/iavf/iavf_rxtx.c b/drivers/net/iavf/iavf_rxtx.c index 45b30363df..66a81197fd 100644 --- a/drivers/net/iavf/iavf_rxtx.c +++ b/drivers/net/iavf/iavf_rxtx.c @@ -2383,7 +2383,6 @@ iavf_prep_pkts(void *tx_queue, struct rte_mbuf **tx_pkts, if (m->data_len < IAVF_TX_MIN_PKT_LEN || m->data_len > max_frame_size) { rte_errno = EINVAL; - PMD_DRV_LOG(ERR, "INVALID mbuf: bad data_len=[%hu]", m->data_len); return i; } -- 2.39.2 --- Diff of the applied patch vs upstream commit (please double-check if non-empty: --- --- - 2023-10-19 00:28:57.906783554 +0100 +++ 0033-net-iavf-remove-log-from-Tx-prepare-function.patch 2023-10-19 00:28:56.293806530 +0100 @@ -1 +1 @@ -From 4015aed58aefb3cceba6766f1fcaaa483c21ede0 Mon Sep 17 00:00:00 2001 +From 5d3142ed48fd78d8a4781cb8da47e519038af3ce Mon Sep 17 00:00:00 2001 @@ -5,0 +6,2 @@ +[ upstream commit 4015aed58aefb3cceba6766f1fcaaa483c21ede0 ] + @@ -12 +13,0 @@ -Cc: stable@dpdk.org @@ -21 +22 @@ -index 0484988d13..21a06b8351 100644 +index 45b30363df..66a81197fd 100644 @@ -24 +25 @@ -@@ -3669,7 +3669,6 @@ iavf_prep_pkts(__rte_unused void *tx_queue, struct rte_mbuf **tx_pkts, +@@ -2383,7 +2383,6 @@ iavf_prep_pkts(void *tx_queue, struct rte_mbuf **tx_pkts,