From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id DD44E431A0 for ; Thu, 19 Oct 2023 02:01:18 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id D210540A7A; Thu, 19 Oct 2023 02:01:18 +0200 (CEST) Received: from mail-wm1-f54.google.com (mail-wm1-f54.google.com [209.85.128.54]) by mails.dpdk.org (Postfix) with ESMTP id 2B49A4029E for ; Thu, 19 Oct 2023 02:01:17 +0200 (CEST) Received: by mail-wm1-f54.google.com with SMTP id 5b1f17b1804b1-4081ccf69dcso1147035e9.0 for ; Wed, 18 Oct 2023 17:01:17 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1697673677; x=1698278477; darn=dpdk.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=BbjpX7oWWmnEryT9CHkHKBdJ6IgufHF5B5wWAe59OR0=; b=GvW6tOywTcSh1Luo1upNoUh3wxRY0e4Xnz7I67botFQrKV1Ijjjm/X6m7RwTb2cBQJ T1XFo9/aZ1qsakkd8vxdQEfmkDze+6sbQJcPOs8HIbONTBNlPNxE+NVF659k0TjOkF5P PgEBoY5/7TPhbZB7nXWVPTAt/6i0c/sObsKxuJSZ+E7erevNNUL3h1AGnOVkenGLGcDv zqB15oydsTAbDlwlSv7IOC6PNpqFAQfzJYnpAxjDII8LEHP0oSTJePmGgxyHnmcpeQv8 JI+MwlW8SHb+bTR4I88Wgk8eFUlXH0kqI7dv/Ljbh3h62npFQh+CxKV0V+hsSISRJMMa kooQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1697673677; x=1698278477; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=BbjpX7oWWmnEryT9CHkHKBdJ6IgufHF5B5wWAe59OR0=; b=hYpIhHxb9twuCOBiPlWBh3nXGCRVvCOMGFyZR6ZpY2LsvogjzvY7b56rNLWET7r7wd bdDC8ONUJB8O9xoVVmwouDRGfCmoq9Oig/SMhoiltTPzXfuN4j5HftyNTvlApmYjL3Tu 00v1nqy2K+m8WxdWAzEt24ZePcpk957PIzWeSLFTaN1ZCoi428THe2km9UHuE8231eAw xQGNVaAqIUyThyZWl+2gRta21lVx/+gRgeyQvKPCC2MWVRixakYNmc6X0t1gmFKIE4yD aEhV3qPCHCnjT5tKsdMv6feB3ggUV1hFXbudUVNcgQHJzISZRlkfnLv8PG+cIw+Ms3NY 15sw== X-Gm-Message-State: AOJu0YwE5k2APXJOooAiGyryPwPhyOpp2iFN79C6hqn1Yc/I/aj3B01t QR5GMWzoLqS/+YiLmADyOlM= X-Google-Smtp-Source: AGHT+IEZ99D/gVPbl+Hds4wnB/RT0jm4FOnRR9ruuk74NqLFHBLGpKtAR/9lwgWhVvnZUU25ji3//w== X-Received: by 2002:adf:b20a:0:b0:32d:c76f:299e with SMTP id u10-20020adfb20a000000b0032dc76f299emr210508wra.19.1697673676841; Wed, 18 Oct 2023 17:01:16 -0700 (PDT) Received: from localhost ([137.220.119.58]) by smtp.gmail.com with ESMTPSA id i6-20020adfe486000000b0032415213a6fsm3122473wrm.87.2023.10.18.17.01.16 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 18 Oct 2023 17:01:16 -0700 (PDT) From: luca.boccassi@gmail.com To: David Marchand Cc: Qi Zhang , dpdk stable Subject: patch 'net/ice: remove log from Tx prepare function' has been queued to stable release 20.11.10 Date: Thu, 19 Oct 2023 00:59:24 +0100 Message-Id: <20231018235930.3144-35-luca.boccassi@gmail.com> X-Mailer: git-send-email 2.39.2 In-Reply-To: <20231018235930.3144-1-luca.boccassi@gmail.com> References: <20231018235930.3144-1-luca.boccassi@gmail.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org Hi, FYI, your patch has been queued to stable release 20.11.10 Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet. It will be pushed if I get no objections before 10/21/23. So please shout if anyone has objections. Also note that after the patch there's a diff of the upstream commit vs the patch applied to the branch. This will indicate if there was any rebasing needed to apply to the stable branch. If there were code changes for rebasing (ie: not only metadata diffs), please double check that the rebase was correctly done. Queued patches are on a temporary branch at: https://github.com/bluca/dpdk-stable This queued commit can be viewed at: https://github.com/bluca/dpdk-stable/commit/b8822df8881feb1b833384208cb02bcd8e9744d3 Thanks. Luca Boccassi --- >From b8822df8881feb1b833384208cb02bcd8e9744d3 Mon Sep 17 00:00:00 2001 From: David Marchand Date: Wed, 27 Sep 2023 11:41:47 +0200 Subject: [PATCH] net/ice: remove log from Tx prepare function [ upstream commit 9aa546d868b60027a6723f1a772d287d44f17ef8 ] ice_prep_pkts reports to the application that the packet is invalid (from the driver pov). Having a log message in those branches is not consistent with all other checks in this function and it may slow down the application if such invalid packets are being sent continuously. Fixes: ccf33dccf7aa ("net/ice: check illegal packet sizes") Fixes: 688cb2f2c61e ("net/ice: fix scalar Tx path segment") Signed-off-by: David Marchand Acked-by: Qi Zhang --- drivers/net/ice/ice_rxtx.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/drivers/net/ice/ice_rxtx.c b/drivers/net/ice/ice_rxtx.c index bd8811649a..11b0dee9f5 100644 --- a/drivers/net/ice/ice_rxtx.c +++ b/drivers/net/ice/ice_rxtx.c @@ -3256,7 +3256,6 @@ ice_prep_pkts(__rte_unused void *tx_queue, struct rte_mbuf **tx_pkts, if (m->data_len < ICE_TX_MIN_PKT_LEN || m->data_len > max_frame_size) { rte_errno = EINVAL; - PMD_DRV_LOG(ERR, "INVALID mbuf: bad data_len=[%hu]", m->data_len); return i; } @@ -3275,7 +3274,6 @@ ice_prep_pkts(__rte_unused void *tx_queue, struct rte_mbuf **tx_pkts, if (ice_check_empty_mbuf(m) != 0) { rte_errno = EINVAL; - PMD_DRV_LOG(ERR, "INVALID mbuf: last mbuf data_len=[0]"); return i; } } -- 2.39.2 --- Diff of the applied patch vs upstream commit (please double-check if non-empty: --- --- - 2023-10-19 00:28:58.006730456 +0100 +++ 0035-net-ice-remove-log-from-Tx-prepare-function.patch 2023-10-19 00:28:56.301806741 +0100 @@ -1 +1 @@ -From 9aa546d868b60027a6723f1a772d287d44f17ef8 Mon Sep 17 00:00:00 2001 +From b8822df8881feb1b833384208cb02bcd8e9744d3 Mon Sep 17 00:00:00 2001 @@ -5,0 +6,2 @@ +[ upstream commit 9aa546d868b60027a6723f1a772d287d44f17ef8 ] + @@ -13 +14,0 @@ -Cc: stable@dpdk.org @@ -22 +23 @@ -index e07c6d1f15..d5513e9e93 100644 +index bd8811649a..11b0dee9f5 100644 @@ -25 +26 @@ -@@ -3708,7 +3708,6 @@ ice_prep_pkts(__rte_unused void *tx_queue, struct rte_mbuf **tx_pkts, +@@ -3256,7 +3256,6 @@ ice_prep_pkts(__rte_unused void *tx_queue, struct rte_mbuf **tx_pkts, @@ -33 +34 @@ -@@ -3727,7 +3726,6 @@ ice_prep_pkts(__rte_unused void *tx_queue, struct rte_mbuf **tx_pkts, +@@ -3275,7 +3274,6 @@ ice_prep_pkts(__rte_unused void *tx_queue, struct rte_mbuf **tx_pkts,