From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id C1F2D431D5 for ; Sun, 22 Oct 2023 16:35:16 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id B709642D28; Sun, 22 Oct 2023 16:35:16 +0200 (CEST) Received: from NAM10-MW2-obe.outbound.protection.outlook.com (mail-mw2nam10on2078.outbound.protection.outlook.com [40.107.94.78]) by mails.dpdk.org (Postfix) with ESMTP id 28A1E42D27 for ; Sun, 22 Oct 2023 16:35:16 +0200 (CEST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=V3dt65tIdMSaq2BZuE8CfBoswE7teMnwIZATSY6+UfAlIKKp9sWtGzv6aOqqOB9JfmGxE/Eum53IUdJ6eqqqxphpbZEJ2DYYOKPTFq9NWtTDo0pb67Zald6V8MJ7WR0E9YfbM5bKTuds0I/q2fKxI1G/s75HXd/N2qAY3iQ07LCjGkj8Mk8f2s6uzwPs1plAsT9KZwS0jRLtxRa6Mh6k6fKYzrsZk4fcPhIv8YIvsckJWTDX9PEr068OBekqG5mF1eg23f61Mt7XodgK/2H6LL2oBUOPMX25lx5cKQskN5Jrm1+chHRNZhP/13zFwjOS3Acqo8qt54mBjshQmBVg0w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=93NlseCMYlMTjvuPSGykkh0yYwnpoef6GxLV2AS028w=; b=d7H2dzEBYgbEjRt6+KMkAIcIWGbzzcrH89rikdCgsQoSbV4KGwu2HKvHu47MZlbZ+m3MpOnH9tltrS1GAYPIBMGGTnW2Kc48r8y7jDnldB2fy2C6GsE6QRsdodlnVAuqJJXRHYXuac36n08Pl6/dPTw0bGMt28B9U+XGT84/w9RuL5nnT86uKlSc4AsuP/UF7qyHUsuivksvmqPBGtqmxwhB0+uh6Cee+2ZRCVeUQtqxLtXKytSnOObpV3d6XNCkFDQChQSkE18PRioaRhU/vEinXZgb0x8ELckDspXfzM7pV57+c7f8e7ezJUjh7W+tQciWaZHpVnhuM8/3+GdfIw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 216.228.117.161) smtp.rcpttodomain=redhat.com smtp.mailfrom=nvidia.com; dmarc=pass (p=reject sp=reject pct=100) action=none header.from=nvidia.com; dkim=none (message not signed); arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=93NlseCMYlMTjvuPSGykkh0yYwnpoef6GxLV2AS028w=; b=iOZ98FmS/v3gsl2thHmqPVmf/kNYgpszny6yOl8dxloDlwuq1G51waCO0MZBYTkFHxZQdeGq+J2lq9TPpdzdqVEjk5UdW4DMZSe/veNapsb5NVvPiwbJI74nHUqCal+DRqrs4xYzRf9OZLj4AZPC114LyCaUfTR2r+n9tZOMcQsfv7yxKQWLKkzlsuUNNBQ4SI1N5AN8uRtAuVXC1bCIm2Qsc/x0d44LQxHgFDYWfFoAz7TD/ZXU4DkJJSK83TcG2rUwzK7PL7nPP5v/yf3Hazn9hn6HL5HEJ3G976GnMK1eKeSMQj2q0lZmPuG6UUdOK/KWGdxiTeE/VsWafyAs+w== Received: from DM6PR14CA0072.namprd14.prod.outlook.com (2603:10b6:5:18f::49) by SN7PR12MB7450.namprd12.prod.outlook.com (2603:10b6:806:29a::13) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6907.33; Sun, 22 Oct 2023 14:35:09 +0000 Received: from CY4PEPF0000E9DA.namprd05.prod.outlook.com (2603:10b6:5:18f:cafe::df) by DM6PR14CA0072.outlook.office365.com (2603:10b6:5:18f::49) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6907.33 via Frontend Transport; Sun, 22 Oct 2023 14:35:08 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 216.228.117.161) smtp.mailfrom=nvidia.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=nvidia.com; Received-SPF: Pass (protection.outlook.com: domain of nvidia.com designates 216.228.117.161 as permitted sender) receiver=protection.outlook.com; client-ip=216.228.117.161; helo=mail.nvidia.com; pr=C Received: from mail.nvidia.com (216.228.117.161) by CY4PEPF0000E9DA.mail.protection.outlook.com (10.167.241.79) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6933.15 via Frontend Transport; Sun, 22 Oct 2023 14:35:08 +0000 Received: from rnnvmail201.nvidia.com (10.129.68.8) by mail.nvidia.com (10.129.200.67) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.986.41; Sun, 22 Oct 2023 07:34:56 -0700 Received: from nvidia.com (10.126.231.35) by rnnvmail201.nvidia.com (10.129.68.8) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.986.41; Sun, 22 Oct 2023 07:34:54 -0700 From: Xueming Li To: David Marchand CC: Chengwen Feng , Ferruh Yigit , dpdk stable Subject: patch 'net/bonding: fix link status callback stop' has been queued to stable release 22.11.4 Date: Sun, 22 Oct 2023 22:22:48 +0800 Message-ID: <20231022142250.10324-140-xuemingl@nvidia.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20231022142250.10324-1-xuemingl@nvidia.com> References: <20231022142250.10324-1-xuemingl@nvidia.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Type: text/plain X-Originating-IP: [10.126.231.35] X-ClientProxiedBy: rnnvmail201.nvidia.com (10.129.68.8) To rnnvmail201.nvidia.com (10.129.68.8) X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: CY4PEPF0000E9DA:EE_|SN7PR12MB7450:EE_ X-MS-Office365-Filtering-Correlation-Id: 32a5e276-c9e5-490a-bd46-08dbd30c172e X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: I0cIJ8I5f10E9Quf99BVHUYfV4gVLQ4ggm9pTGB4am3tJLZq96/UN+XhYdOt+7b5FZTisgSRQvztB+ZHlKWd3bqLnFiqvTZU8R6EAzwt0fNDgskbeMvwzXW9D6tRC25rvq0A2CQHJyqih+W7GF3N1ATdKvd3TjbLuwozzti2EqJGZersQc3LdIeGT3gTLESeJ6Ehw+EVq2YhTcc3LZZWgxClFWkJnL/1A5yixU/q2iw4LDMmTv9TU0VlgAmQrXtdmGQK4iScvNPdB1DMa3pFxMu3wEu70CUtKqTQj0aXl2DWrRxa4/ZWHki1yjrsMxfvxpJAbvfDVPmV2XOiKAlF03o5J29niGBaOUTw/SI+KN/vgtndci2/FoIxpr01G6VTZsLyRaixwA74snVqtrZ81Si8mW6LwQl9rY21AnWRa31qt2xNB5sZGNnoOL155oc2YkvmbnnoWD88DbLERp33g789ip8gOgzrjV+JRPJGz8R6GRvK1qVWlGkK2ulrEu2VlPD4CtqBjExPWvDRdXqcA3PIB1urbzQ4d4BZ6FrWrijImkcC3om+IJFrxiDOx5aWR0l9WlR3u6GwYmqxSzYZ26lnqL566FBm1rDbl70cjSx82qXgl8umog+jbdoWI6VUn9CCHeFeXj28DwVVRCo2oHPpwOEhhKIbFRrGOhxNbf85qntgxxnhXcZ+funif3MNv5HR7kT10EwFALBQfgumLePpblcejYgWRDqqP1tBHUt40sLR3asp4vrfVi4662qbI/J3d8zDgdywUKS3xieFKcCJLYCJ2mo7BevA6UDK3xA= X-Forefront-Antispam-Report: CIP:216.228.117.161; CTRY:US; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:mail.nvidia.com; PTR:dc6edge2.nvidia.com; CAT:NONE; SFS:(13230031)(4636009)(396003)(39860400002)(376002)(346002)(136003)(230922051799003)(186009)(451199024)(64100799003)(1800799009)(82310400011)(46966006)(40470700004)(36840700001)(55016003)(2906002)(36860700001)(316002)(6916009)(70586007)(70206006)(54906003)(82740400003)(356005)(7636003)(2616005)(26005)(6286002)(16526019)(1076003)(478600001)(7696005)(6666004)(53546011)(966005)(40480700001)(47076005)(336012)(426003)(40460700003)(41300700001)(5660300002)(36756003)(86362001)(4326008)(8936002)(8676002)(4001150100001); DIR:OUT; SFP:1101; X-OriginatorOrg: Nvidia.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 22 Oct 2023 14:35:08.3658 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 32a5e276-c9e5-490a-bd46-08dbd30c172e X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=43083d15-7273-40c1-b7db-39efd9ccc17a; Ip=[216.228.117.161]; Helo=[mail.nvidia.com] X-MS-Exchange-CrossTenant-AuthSource: CY4PEPF0000E9DA.namprd05.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: SN7PR12MB7450 X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org Hi, FYI, your patch has been queued to stable release 22.11.4 Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet. It will be pushed if I get no objections before 11/15/23. So please shout if anyone has objections. Also note that after the patch there's a diff of the upstream commit vs the patch applied to the branch. This will indicate if there was any rebasing needed to apply to the stable branch. If there were code changes for rebasing (ie: not only metadata diffs), please double check that the rebase was correctly done. Queued patches are on a temporary branch at: https://git.dpdk.org/dpdk-stable/log/?h=22.11-staging This queued commit can be viewed at: https://git.dpdk.org/dpdk-stable/commit/?h=22.11-staging&id=b33ea9e6de82eb70a606106fc0efe2314a708164 Thanks. Xueming Li --- >From b33ea9e6de82eb70a606106fc0efe2314a708164 Mon Sep 17 00:00:00 2001 From: David Marchand Date: Mon, 16 Oct 2023 10:47:43 +0200 Subject: [PATCH] net/bonding: fix link status callback stop Cc: Xueming Li [ upstream commit 615bd385b93e89e062b4e134e9cc09a79289a0f6 ] If a bonding port gets released, a link status alarm callback still referenced the ethdev port that may be reused later. Cancel this callback when stopping the port. Bugzilla ID: 1301 Fixes: a45b288ef21a ("bond: support link status polling") Signed-off-by: David Marchand Acked-by: Chengwen Feng Acked-by: Ferruh Yigit --- drivers/net/bonding/rte_eth_bond_pmd.c | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/drivers/net/bonding/rte_eth_bond_pmd.c b/drivers/net/bonding/rte_eth_bond_pmd.c index bddc3fb8df..8df632fa6e 100644 --- a/drivers/net/bonding/rte_eth_bond_pmd.c +++ b/drivers/net/bonding/rte_eth_bond_pmd.c @@ -2160,6 +2160,10 @@ bond_ethdev_stop(struct rte_eth_dev *eth_dev) eth_dev->data->dev_link.link_status = RTE_ETH_LINK_DOWN; eth_dev->data->dev_started = 0; + if (internals->link_status_polling_enabled) { + rte_eal_alarm_cancel(bond_ethdev_slave_link_status_change_monitor, + (void *)&rte_eth_devices[internals->port_id]); + } internals->link_status_polling_enabled = 0; for (i = 0; i < internals->slave_count; i++) { uint16_t slave_id = internals->slaves[i].port_id; -- 2.25.1 --- Diff of the applied patch vs upstream commit (please double-check if non-empty: --- --- - 2023-10-22 22:17:39.317724200 +0800 +++ 0139-net-bonding-fix-link-status-callback-stop.patch 2023-10-22 22:17:34.436723700 +0800 @@ -1 +1 @@ -From 615bd385b93e89e062b4e134e9cc09a79289a0f6 Mon Sep 17 00:00:00 2001 +From b33ea9e6de82eb70a606106fc0efe2314a708164 Mon Sep 17 00:00:00 2001 @@ -4,0 +5,3 @@ +Cc: Xueming Li + +[ upstream commit 615bd385b93e89e062b4e134e9cc09a79289a0f6 ] @@ -12 +14,0 @@ -Cc: stable@dpdk.org @@ -22 +24 @@ -index aa7c911f19..c40d18d128 100644 +index bddc3fb8df..8df632fa6e 100644 @@ -25 +27 @@ -@@ -2164,6 +2164,10 @@ bond_ethdev_stop(struct rte_eth_dev *eth_dev) +@@ -2160,6 +2160,10 @@ bond_ethdev_stop(struct rte_eth_dev *eth_dev) @@ -30 +32 @@ -+ rte_eal_alarm_cancel(bond_ethdev_member_link_status_change_monitor, ++ rte_eal_alarm_cancel(bond_ethdev_slave_link_status_change_monitor, @@ -34,2 +36,2 @@ - for (i = 0; i < internals->member_count; i++) { - uint16_t member_id = internals->members[i].port_id; + for (i = 0; i < internals->slave_count; i++) { + uint16_t slave_id = internals->slaves[i].port_id;