From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 60146431D5 for ; Sun, 22 Oct 2023 16:26:29 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 56637402E6; Sun, 22 Oct 2023 16:26:29 +0200 (CEST) Received: from NAM02-SN1-obe.outbound.protection.outlook.com (mail-sn1nam02on2062.outbound.protection.outlook.com [40.107.96.62]) by mails.dpdk.org (Postfix) with ESMTP id 500F5402E4 for ; Sun, 22 Oct 2023 16:26:28 +0200 (CEST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=nffuMAuGoiXrVC3YsLykapSrJHMlQe1c7Ana2O3hEZpiCZnsSefPXmoI3ZTJR69ykFkGRGF8lEpPkDKouwRxmlU6W9VkuB2mwapvMqR5HOd9bkE9yrU+zIru856kLTw/hnPn8CTKBhmLx1+0sgqWfeUf+4xJfVVcMX9DqvttmoQpfjd0eLfH8kJ2I2vkGpDjcNoziTWu65ecAnJg0TEqnwylJnEXcVrV+JLK/ZKJl4UXVQUvDwXnRYBfTXk6zbUa3ruGCQgJmZyiFCRppziJdD6ZAVYqCw3XMr8uIrghk8q/hVJsYHT6qSA9lr43jyWSS/FeGnXdQ/XHctejN/XN2g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=LtK3E8rj2RiGoQwhyzTWWcWZWxdXpankk8Z4UD9Tx1o=; b=kRD9JcHxd+sPNNswWpK9CLeW3q61hP3KyKBNXL2UjVOQniaM7h2pxWaWi9uOYI+jLLDArym0l2d2Rgu4gSptCc46m8EJKfVabnu6JY6bms5c+I+mVllF9tmpXDlnTVXwOqCD3lMsaPJ+NCe5gN0okm9egD3FgMchZgy7XZj9BXslw88zgfNMauU2OX6MR0rLRJ03dAQAbS0vnVZka8LdKwzfU/b4H4i+3lkMjJl0Ha8tJBpBwZNS1gGS7s/feJNxEgp3L48MgmcUtOVMe70IRcF48gzpFZOTHK6qJKU4DKqka0j1qrAxT3WBI+XMvwso83wjmNEVRgjDQmterHG+bQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 216.228.117.161) smtp.rcpttodomain=linux.vnet.ibm.com smtp.mailfrom=nvidia.com; dmarc=pass (p=reject sp=reject pct=100) action=none header.from=nvidia.com; dkim=none (message not signed); arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=LtK3E8rj2RiGoQwhyzTWWcWZWxdXpankk8Z4UD9Tx1o=; b=c0TslkcO0gZ8ah8g9a0cCp8PQMz6vOMOi222NXHB+7FVmbwtbh+INmf41QdWY6plKQPj7Cndh7GKvnSctjH1epX29htFdTNruuumlhmnA2OkCyTDpNeYhyP8W0FAXAyk0GF88sRkqTOU/n8qFS32QSsPkO+HjM3iW2wK7UEg0bM6Q9zq9RGSJreyqHHP0Fnyq9670aRK9rz9zVjYwIMphqlj5TJ5iyRHSbw4y6UmYTsscjKMA7mPU0PeXVEWElN5LKdvmMYN1CZ/wfn306XRIN/WWA/lfUtEPH+exesqzrvVKfnM5fH+minrDPhbs61ofrPE2GdcvaQmm9hteGmdaQ== Received: from MW4PR03CA0050.namprd03.prod.outlook.com (2603:10b6:303:8e::25) by DS7PR12MB5958.namprd12.prod.outlook.com (2603:10b6:8:7d::20) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6907.31; Sun, 22 Oct 2023 14:26:24 +0000 Received: from CO1PEPF000044EF.namprd05.prod.outlook.com (2603:10b6:303:8e:cafe::c2) by MW4PR03CA0050.outlook.office365.com (2603:10b6:303:8e::25) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6907.31 via Frontend Transport; Sun, 22 Oct 2023 14:26:24 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 216.228.117.161) smtp.mailfrom=nvidia.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=nvidia.com; Received-SPF: Pass (protection.outlook.com: domain of nvidia.com designates 216.228.117.161 as permitted sender) receiver=protection.outlook.com; client-ip=216.228.117.161; helo=mail.nvidia.com; pr=C Received: from mail.nvidia.com (216.228.117.161) by CO1PEPF000044EF.mail.protection.outlook.com (10.167.241.69) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6933.15 via Frontend Transport; Sun, 22 Oct 2023 14:26:24 +0000 Received: from rnnvmail201.nvidia.com (10.129.68.8) by mail.nvidia.com (10.129.200.67) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.986.41; Sun, 22 Oct 2023 07:26:12 -0700 Received: from nvidia.com (10.126.231.35) by rnnvmail201.nvidia.com (10.129.68.8) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.986.41; Sun, 22 Oct 2023 07:26:11 -0700 From: Xueming Li To: David Christensen CC: Stephen Hemminger , Ferruh Yigit , dpdk stable Subject: patch 'net/tap: use MAC address parse API instead of local parser' has been queued to stable release 22.11.4 Date: Sun, 22 Oct 2023 22:21:04 +0800 Message-ID: <20231022142250.10324-36-xuemingl@nvidia.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20231022142250.10324-1-xuemingl@nvidia.com> References: <20231022142250.10324-1-xuemingl@nvidia.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Type: text/plain X-Originating-IP: [10.126.231.35] X-ClientProxiedBy: rnnvmail201.nvidia.com (10.129.68.8) To rnnvmail201.nvidia.com (10.129.68.8) X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: CO1PEPF000044EF:EE_|DS7PR12MB5958:EE_ X-MS-Office365-Filtering-Correlation-Id: 03f1ba2b-0e7d-4687-7e6a-08dbd30adea4 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: 1YdIlDkc2rt5U/ufCFJHOg5b5j7R+1ad0raMeAm6Dz3V+QQp8QSnPkYC1gharxtvkWENXN4l0GG1EpciBAbTJO6zoCGLL8bubcnYqGmFb/zMC97vExPgbbdRTVs1PDYWTt9/vxB1Ftb0gGIb1Ex0RpoN1zkzdEFvTMNeOw0fTpd7tWnl/Eb8CMi53xANW9wDIyy6rhpHChfFyeJog4SIuUOL4ey7k7+UEMoJ7Ecq7UtGUl3sXV6Qa683mqS7JAt/miWtzXXqJJcvWJ0tmLWdqCA2Nu9SzWiRAIw5B8QqOGAUdLjdxXnExe2yp/wj4kdwQrbMiUijpZMwpVzH5UEdzv3MyM+WnnQrhNEgkpvJOxSWiq5FkBYxUve4FBZEzktVhNvFjsVdtp6cQHVAzjyADp7LO/7FggHL4bvJ2KcOvoZsgkC5Zfa8h44odNU1OpAQTfve04vyDzzPMkQKLU3OHVlCa9a75cT5/jmsYxVYZ3FGFCGxNkX+MroSDfbv4DwMRX4CxSYssdtfmhQ9Go7Qba9EpHEQRgr8EYgm449D4Q/h0IGpCeYBf4Mv/Jbo1A7G4uipVfgyc3uM3IKYtq4Pt8lLeEJR1qFGNE5rwvwbaL7+SL7DQrpIzR+Gw0mgpbhcqoJkfZh5gNl88WTWpY8jObY13IADH79McQl8h92CAcI/hTB5HH1hASHSr7oost5WBjtBDV3z5VtTSCW5wqZJOdHm4/pmA+Za1F18X5SEh/56A5MDWFdn8RXKPYHxszTD7ookx1HGEm8L2AxYI0I3dWIZSSgBPhQ+dRno+BXJzuQ= X-Forefront-Antispam-Report: CIP:216.228.117.161; CTRY:US; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:mail.nvidia.com; PTR:dc6edge2.nvidia.com; CAT:NONE; SFS:(13230031)(4636009)(39860400002)(136003)(376002)(346002)(396003)(230922051799003)(64100799003)(451199024)(1800799009)(186009)(82310400011)(40470700004)(46966006)(36840700001)(40460700003)(2906002)(4001150100001)(55016003)(53546011)(7696005)(6666004)(1076003)(26005)(2616005)(70586007)(70206006)(316002)(54906003)(6916009)(966005)(86362001)(478600001)(47076005)(36860700001)(83380400001)(356005)(7636003)(426003)(82740400003)(16526019)(6286002)(336012)(5660300002)(40480700001)(41300700001)(8936002)(8676002)(4326008)(36756003); DIR:OUT; SFP:1101; X-OriginatorOrg: Nvidia.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 22 Oct 2023 14:26:24.0575 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 03f1ba2b-0e7d-4687-7e6a-08dbd30adea4 X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=43083d15-7273-40c1-b7db-39efd9ccc17a; Ip=[216.228.117.161]; Helo=[mail.nvidia.com] X-MS-Exchange-CrossTenant-AuthSource: CO1PEPF000044EF.namprd05.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: DS7PR12MB5958 X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org Hi, FYI, your patch has been queued to stable release 22.11.4 Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet. It will be pushed if I get no objections before 11/15/23. So please shout if anyone has objections. Also note that after the patch there's a diff of the upstream commit vs the patch applied to the branch. This will indicate if there was any rebasing needed to apply to the stable branch. If there were code changes for rebasing (ie: not only metadata diffs), please double check that the rebase was correctly done. Queued patches are on a temporary branch at: https://git.dpdk.org/dpdk-stable/log/?h=22.11-staging This queued commit can be viewed at: https://git.dpdk.org/dpdk-stable/commit/?h=22.11-staging&id=6754edbeb547425eea2e06eface8a6214a6621d8 Thanks. Xueming Li --- >From 6754edbeb547425eea2e06eface8a6214a6621d8 Mon Sep 17 00:00:00 2001 From: David Christensen Date: Tue, 3 Oct 2023 13:29:09 -0700 Subject: [PATCH] net/tap: use MAC address parse API instead of local parser Cc: Xueming Li [ upstream commit b79d825f32cb0012164b26428272b1ea268f839d ] Building DPDK with gcc 12 on a ppc64le system generates a stringop-overflow warning. Replace the local MAC address validation function parse_user_mac() with a call to rte_ether_unformat_addr() instead. Bugzilla ID: 1197 Signed-off-by: David Christensen Signed-off-by: Stephen Hemminger Acked-by: Ferruh Yigit --- drivers/net/tap/rte_eth_tap.c | 25 +------------------------ 1 file changed, 1 insertion(+), 24 deletions(-) diff --git a/drivers/net/tap/rte_eth_tap.c b/drivers/net/tap/rte_eth_tap.c index 66595f8312..ef8eb610f6 100644 --- a/drivers/net/tap/rte_eth_tap.c +++ b/drivers/net/tap/rte_eth_tap.c @@ -2267,29 +2267,6 @@ set_remote_iface(const char *key __rte_unused, return 0; } -static int parse_user_mac(struct rte_ether_addr *user_mac, - const char *value) -{ - unsigned int index = 0; - char mac_temp[strlen(ETH_TAP_USR_MAC_FMT) + 1], *mac_byte = NULL; - - if (user_mac == NULL || value == NULL) - return 0; - - strlcpy(mac_temp, value, sizeof(mac_temp)); - mac_byte = strtok(mac_temp, ":"); - - while ((mac_byte != NULL) && - (strlen(mac_byte) <= 2) && - (strlen(mac_byte) == strspn(mac_byte, - ETH_TAP_CMP_MAC_FMT))) { - user_mac->addr_bytes[index++] = strtoul(mac_byte, NULL, 16); - mac_byte = strtok(NULL, ":"); - } - - return index; -} - static int set_mac_type(const char *key __rte_unused, const char *value, @@ -2311,7 +2288,7 @@ set_mac_type(const char *key __rte_unused, goto success; } - if (parse_user_mac(user_mac, value) != 6) + if (rte_ether_unformat_addr(value, user_mac) < 0) goto error; success: TAP_LOG(DEBUG, "TAP user MAC param (%s)", value); -- 2.25.1 --- Diff of the applied patch vs upstream commit (please double-check if non-empty: --- --- - 2023-10-22 22:17:35.734704800 +0800 +++ 0035-net-tap-use-MAC-address-parse-API-instead-of-local-p.patch 2023-10-22 22:17:34.206723700 +0800 @@ -1 +1 @@ -From b79d825f32cb0012164b26428272b1ea268f839d Mon Sep 17 00:00:00 2001 +From 6754edbeb547425eea2e06eface8a6214a6621d8 Mon Sep 17 00:00:00 2001 @@ -4,0 +5,3 @@ +Cc: Xueming Li + +[ upstream commit b79d825f32cb0012164b26428272b1ea268f839d ] @@ -12 +14,0 @@ -Cc: stable@dpdk.org @@ -22 +24 @@ -index bf98f75559..b25a52655f 100644 +index 66595f8312..ef8eb610f6 100644