From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 71D4C431D5 for ; Sun, 22 Oct 2023 16:29:02 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 6699240DF5; Sun, 22 Oct 2023 16:29:02 +0200 (CEST) Received: from NAM11-CO1-obe.outbound.protection.outlook.com (mail-co1nam11on2086.outbound.protection.outlook.com [40.107.220.86]) by mails.dpdk.org (Postfix) with ESMTP id A048340E13 for ; Sun, 22 Oct 2023 16:29:00 +0200 (CEST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Zyeep05/2feOAEVzrxW2yaddFrzJkLHCiU/VLWzjz0nhRlfxcAbQMdR/5e8T62V042z7F4tlCIRs1OMHaB3dVfbEx5MJvi4idQA8Lcm7Qi0USC2X0iawpwRx8QjOzUn3z13AfdoZY5ufcEoK34BMEW9J2LYYfoPCGIoxoMrF1YKW9zcQxiYyDkiFsQJv4BW036r5hocz1n85ID4JBG1AGCMoLZZT5sOfe2I0xwYkEVAa9fzKYmYgPpHITQO0TI93/H+gP1cmlM5jcpbmVA8lBA3hmlbRGO6IHmrrICdzx5pU41KkQbL7xMithfSR32uEtnvxhQQI+p2JOmjnYp9aHQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=flZ9mvp9oIrHgrdUWvWdQ0NgrmtidDAJSiqEatEft9w=; b=N22Wp5nlbzg8caMnFYeH2OJFY5x5jB9CvbEAuRrjSMmccTRyIMU+KPhXd/DbZb2AWY0t2OEBNOeu8ReJZbL13SDgz7V+b9T1lOvM99KGyiKn1T49l2v1Y1QmoSG0m1TaZVcY97EeRommG1ajhEJPgH2x6abzVipKGRu9/yxcL/I/tsaTT1jr/e5o04xOgujmLuPgpQFVXbYr/A1O0/vtkRpEBhX7egmbuh9H+j9k1+UFrEitpElcW2W3CFCR5p5+eBl8ytha+0t85A/B1I/LlZ4hHr5eIHUmAyltLtLaD5YyeSx5wUZJpIP4+9eeJIG583zcmiDjSGXfdkUz68s2ow== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 216.228.117.161) smtp.rcpttodomain=marvell.com smtp.mailfrom=nvidia.com; dmarc=pass (p=reject sp=reject pct=100) action=none header.from=nvidia.com; dkim=none (message not signed); arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=flZ9mvp9oIrHgrdUWvWdQ0NgrmtidDAJSiqEatEft9w=; b=Goiu1W98x4YB/b/i5nwaWAzkcVT76FHA2/GKqijw6emWi1/N8Qhsh6lKb4erlyGzZHaLyfmrIRn/9WTEAk0OxWpFtEaj565G4NPHbqE+cifgNuJL2WTeJ3Uwy3Kpqf9ORzaLYA67pIGq6EbEoeDySZ54gNw+k7VtPpzbhcjmHEM61pn9cOzqFEwjhIG3ofirdc+ZiHL7LuRODuMUKUcfUcuDJU7gw9N0lf6xoousmv6DcxlPeZqaujKMX5XgLbOqSrhAFyntzVlqWtXr4MMv6oQJj3pTC/lrBaIYSsZNvBMRgsfQG4IEhdjUM0i/GDMkTz7Pb1k5vUN8qpFG7WcP/A== Received: from MW4PR03CA0047.namprd03.prod.outlook.com (2603:10b6:303:8e::22) by CH3PR12MB8582.namprd12.prod.outlook.com (2603:10b6:610:163::16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6907.25; Sun, 22 Oct 2023 14:28:58 +0000 Received: from CO1PEPF000044EF.namprd05.prod.outlook.com (2603:10b6:303:8e:cafe::93) by MW4PR03CA0047.outlook.office365.com (2603:10b6:303:8e::22) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6907.31 via Frontend Transport; Sun, 22 Oct 2023 14:28:58 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 216.228.117.161) smtp.mailfrom=nvidia.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=nvidia.com; Received-SPF: Pass (protection.outlook.com: domain of nvidia.com designates 216.228.117.161 as permitted sender) receiver=protection.outlook.com; client-ip=216.228.117.161; helo=mail.nvidia.com; pr=C Received: from mail.nvidia.com (216.228.117.161) by CO1PEPF000044EF.mail.protection.outlook.com (10.167.241.69) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6933.15 via Frontend Transport; Sun, 22 Oct 2023 14:28:57 +0000 Received: from rnnvmail201.nvidia.com (10.129.68.8) by mail.nvidia.com (10.129.200.67) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.986.41; Sun, 22 Oct 2023 07:28:54 -0700 Received: from nvidia.com (10.126.231.35) by rnnvmail201.nvidia.com (10.129.68.8) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.986.41; Sun, 22 Oct 2023 07:28:53 -0700 From: Xueming Li To: Amit Prakash Shukla CC: dpdk stable Subject: patch 'dma/cnxk: fix device state' has been queued to stable release 22.11.4 Date: Sun, 22 Oct 2023 22:21:38 +0800 Message-ID: <20231022142250.10324-70-xuemingl@nvidia.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20231022142250.10324-1-xuemingl@nvidia.com> References: <20231022142250.10324-1-xuemingl@nvidia.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Type: text/plain X-Originating-IP: [10.126.231.35] X-ClientProxiedBy: rnnvmail201.nvidia.com (10.129.68.8) To rnnvmail201.nvidia.com (10.129.68.8) X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: CO1PEPF000044EF:EE_|CH3PR12MB8582:EE_ X-MS-Office365-Filtering-Correlation-Id: a5fb7ced-4f03-43d7-63a5-08dbd30b3a5e X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: 8qpI1vAyYiEQauAzksuTnX3Of+XEc8ncdTXEXugvPXI6C/lyt5CbZF8OHuhpNABvKeQ6MmDmYt0wo9oj2IQhxthG/4uT+ZdVqgLLxeSFDAKMFFfYsLJCTAelaCYclQ7lx8/rEi2587GN0FAOLueXtWIgF6fJUagKRBMm8IJ5uA2685uEhQTOKVm22gm7v0scSECMWNAF+lal83ZUEQpqQ3LCW1CRYF3YfCurSNVqzWwtRoJHREuXBwB7zLlrHXkYyiXcMsBjijzY976WTt+s91Tpq9+p0Nja68ewx/gMjFRFRsLup92VqmioD/4tJ3Vld7wjq61Jd5XXeBmX7CXvWl1/geEqAOESInKYx/rp3RS6Qg0ULi6FprKfM/or70Zpj2SXORLmDz6YMzfikEUS2VLLTkLO06GkFxLN7xgXKV9sFcgOVNN3TlFlXNfK5lLasL/OqHz9TIw/8cBajOLfiWyEIqTL3sldC+q4/HbEh1Ux3szNVNCgp76FLPhhS6VJJeFsNsGUMej9w/SWYJZ9YlosOmwndXp/Bizbnj5phob8y8pfiUgEA4+2NX0ilbTLdeD3jAVNnkfAokCm6k/oiCyTzWJPUo/HR+WIZSKSeYUZpVPqCcX0ZKGaKCWxdK3mvqodBojce9E1kBuGQs+D/HB0FF9vbmxXMwixMQUAkcHoWC9vXLMNJLAsRui/OzesKH70IYfOYzLswrDofL5GbYaCD0x4a0tECoPEU8dtM6Y6oDE0r54KVEmddTW7dVuf7IQZChzH0XVzwLcCDl5cUWpDvNn14dLptHRiNv9ou54= X-Forefront-Antispam-Report: CIP:216.228.117.161; CTRY:US; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:mail.nvidia.com; PTR:dc6edge2.nvidia.com; CAT:NONE; SFS:(13230031)(4636009)(346002)(396003)(376002)(39860400002)(136003)(230922051799003)(186009)(82310400011)(451199024)(64100799003)(1800799009)(36840700001)(40470700004)(46966006)(41300700001)(40460700003)(55016003)(86362001)(4001150100001)(5660300002)(2906002)(47076005)(82740400003)(7696005)(4326008)(426003)(356005)(83380400001)(26005)(40480700001)(6286002)(36756003)(16526019)(336012)(7636003)(1076003)(36860700001)(53546011)(2616005)(478600001)(8936002)(966005)(8676002)(6916009)(70206006)(70586007)(6666004)(316002); DIR:OUT; SFP:1101; X-OriginatorOrg: Nvidia.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 22 Oct 2023 14:28:57.9328 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: a5fb7ced-4f03-43d7-63a5-08dbd30b3a5e X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=43083d15-7273-40c1-b7db-39efd9ccc17a; Ip=[216.228.117.161]; Helo=[mail.nvidia.com] X-MS-Exchange-CrossTenant-AuthSource: CO1PEPF000044EF.namprd05.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: CH3PR12MB8582 X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org Hi, FYI, your patch has been queued to stable release 22.11.4 Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet. It will be pushed if I get no objections before 11/15/23. So please shout if anyone has objections. Also note that after the patch there's a diff of the upstream commit vs the patch applied to the branch. This will indicate if there was any rebasing needed to apply to the stable branch. If there were code changes for rebasing (ie: not only metadata diffs), please double check that the rebase was correctly done. Queued patches are on a temporary branch at: https://git.dpdk.org/dpdk-stable/log/?h=22.11-staging This queued commit can be viewed at: https://git.dpdk.org/dpdk-stable/commit/?h=22.11-staging&id=915fbdb68199c5f6df9aec08de7296a0ca2bbcc6 Thanks. Xueming Li --- >From 915fbdb68199c5f6df9aec08de7296a0ca2bbcc6 Mon Sep 17 00:00:00 2001 From: Amit Prakash Shukla Date: Wed, 23 Aug 2023 16:45:16 +0530 Subject: [PATCH] dma/cnxk: fix device state Cc: Xueming Li [ upstream commit 190b2239b801d84179e5f57a1dda7ed19539281c ] When a device is not set to a ready state, on exiting the application proper cleanup is not done. This causes the application to fail on trying to run next time. Setting the device to ready state on successful probe fixes the issue. Fixes: 53f6d7328bf4 ("dma/cnxk: create and initialize device on PCI probing") Signed-off-by: Amit Prakash Shukla --- drivers/dma/cnxk/cnxk_dmadev.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/drivers/dma/cnxk/cnxk_dmadev.c b/drivers/dma/cnxk/cnxk_dmadev.c index a6f4a31e0e..b2f4b332f4 100644 --- a/drivers/dma/cnxk/cnxk_dmadev.c +++ b/drivers/dma/cnxk/cnxk_dmadev.c @@ -628,8 +628,7 @@ static const struct rte_dma_dev_ops cnxk_dmadev_ops = { }; static int -cnxk_dmadev_probe(struct rte_pci_driver *pci_drv __rte_unused, - struct rte_pci_device *pci_dev) +cnxk_dmadev_probe(struct rte_pci_driver *pci_drv __rte_unused, struct rte_pci_device *pci_dev) { struct cnxk_dpi_vf_s *dpivf = NULL; char name[RTE_DEV_NAME_MAX_LEN]; @@ -648,8 +647,7 @@ cnxk_dmadev_probe(struct rte_pci_driver *pci_drv __rte_unused, memset(name, 0, sizeof(name)); rte_pci_device_name(&pci_dev->addr, name, sizeof(name)); - dmadev = rte_dma_pmd_allocate(name, pci_dev->device.numa_node, - sizeof(*dpivf)); + dmadev = rte_dma_pmd_allocate(name, pci_dev->device.numa_node, sizeof(*dpivf)); if (dmadev == NULL) { plt_err("dma device allocation failed for %s", name); return -ENOMEM; @@ -682,6 +680,8 @@ cnxk_dmadev_probe(struct rte_pci_driver *pci_drv __rte_unused, if (rc < 0) goto err_out_free; + dmadev->state = RTE_DMA_DEV_READY; + return 0; err_out_free: -- 2.25.1 --- Diff of the applied patch vs upstream commit (please double-check if non-empty: --- --- - 2023-10-22 22:17:36.922712100 +0800 +++ 0069-dma-cnxk-fix-device-state.patch 2023-10-22 22:17:34.296723700 +0800 @@ -1 +1 @@ -From 190b2239b801d84179e5f57a1dda7ed19539281c Mon Sep 17 00:00:00 2001 +From 915fbdb68199c5f6df9aec08de7296a0ca2bbcc6 Mon Sep 17 00:00:00 2001 @@ -4,0 +5,3 @@ +Cc: Xueming Li + +[ upstream commit 190b2239b801d84179e5f57a1dda7ed19539281c ] @@ -13 +15,0 @@ -Cc: stable@dpdk.org @@ -21 +23 @@ -index f06c979b9c..d8bd61a048 100644 +index a6f4a31e0e..b2f4b332f4 100644 @@ -24 +26 @@ -@@ -668,8 +668,7 @@ static const struct rte_dma_dev_ops cnxk_dmadev_ops = { +@@ -628,8 +628,7 @@ static const struct rte_dma_dev_ops cnxk_dmadev_ops = { @@ -34 +36 @@ -@@ -688,8 +687,7 @@ cnxk_dmadev_probe(struct rte_pci_driver *pci_drv __rte_unused, +@@ -648,8 +647,7 @@ cnxk_dmadev_probe(struct rte_pci_driver *pci_drv __rte_unused, @@ -44 +46 @@ -@@ -723,6 +721,8 @@ cnxk_dmadev_probe(struct rte_pci_driver *pci_drv __rte_unused, +@@ -682,6 +680,8 @@ cnxk_dmadev_probe(struct rte_pci_driver *pci_drv __rte_unused,