From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id D0963431D5 for ; Sun, 22 Oct 2023 16:31:14 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id C958C40284; Sun, 22 Oct 2023 16:31:14 +0200 (CEST) Received: from NAM02-BN1-obe.outbound.protection.outlook.com (mail-bn1nam02on2067.outbound.protection.outlook.com [40.107.212.67]) by mails.dpdk.org (Postfix) with ESMTP id 920B84027E for ; Sun, 22 Oct 2023 16:31:13 +0200 (CEST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=IFC0ADif0cbkRfcSv/gfT6CGHk4KpeWUlhjbuO00fUee7c1HRuoWOiM+p58auBRi/bOjfpL7LNdfQiGpadBX9AlfDdPsYaVGC7xWS+JTvcP0nZMcVsOTAWS+r98S5J4BvmlolqIF+zaKc++6j9UQWbeCRTpGCcdzI8eK9yLWFibzcK+Sb+Qall6EasxSA95FWul0ZuuoUg+d+c7wO8QWcIvmrREfRfHqyfqTseZJfbesIyl0gJTJOMjF7lMSOXWbKo5wI9EMSAKkkXT6/5OaKMqd+2uPkIPtwDxsFHKky4ODSt0nDPHAcUJeubOftSQoaW5bnB/H33sTD7c4zE331w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=KTgKjYbmsrREtlkw0kUjMuZ/7u3aBQ9/Bt0C5BA2qC4=; b=H+aRwu8Ox1SgKpGFLx14z6MeclmFW1DFmupsgHdhbA/eTOtjrs2GOwZKoxSP1b0+Y5MLNKov+GEKIBubXwByrc1L0h0yxJNod2QcLoM5T2dMLvrDKYQ0+2xM3kX+1QOigHsJ6lrxUeR2VmYRPfPIJd6sYZ9TBEqjco6RX7WRMPG+q5HaILH8TthtCwiHjTC6ssQT51fyNEr4SKDCEV8CXluYsaTRWJ7qFch02BXEE3p6em+n6Hzxf+vWMk0Fr/auULBqH11oRamxwewSP2CFEmrBxt6Dkivf8UouomDPnYE2W1h8Pm3zbcDVqne3n6jIyi4dILsYlMI/qSgw2fvVXA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 216.228.117.161) smtp.rcpttodomain=redhat.com smtp.mailfrom=nvidia.com; dmarc=pass (p=reject sp=reject pct=100) action=none header.from=nvidia.com; dkim=none (message not signed); arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=KTgKjYbmsrREtlkw0kUjMuZ/7u3aBQ9/Bt0C5BA2qC4=; b=cFd55QTXhq9qbTTc4jCk4uqhEuWc6Jp9R5t7YLm/l6Z6eQY9avSk+oNvJrrWUg38ImmcFM5LZGZYaVq9+2gJ4Sqxfb9XRYxrWmIOaFS0+kOy9PMbiWvR57MSatk2fWXPGDfoSrAok7n64kkuMRtZvPbXuOXOaIs7DTpZpYJQJxXKfnHGJbwN80FT3aYCe8s802C/joqoBP3bKuSohH0/V0yMSwQzdbxYIDHItzX7KmQHeJqdrd8BRdOhBCjrlc1Gz3j9Dcsh0fGQMHTYkQnSff+SMQ2NqQ5L7HgllggeirSqyybzGTyl8XxjM0EyzsVlrJqK0GH9fp4qJbNa7LheSQ== Received: from CY5PR10CA0012.namprd10.prod.outlook.com (2603:10b6:930:1c::12) by IA1PR12MB7685.namprd12.prod.outlook.com (2603:10b6:208:423::21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6907.26; Sun, 22 Oct 2023 14:31:09 +0000 Received: from CY4PEPF0000EE30.namprd05.prod.outlook.com (2603:10b6:930:1c:cafe::90) by CY5PR10CA0012.outlook.office365.com (2603:10b6:930:1c::12) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6907.31 via Frontend Transport; Sun, 22 Oct 2023 14:31:08 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 216.228.117.161) smtp.mailfrom=nvidia.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=nvidia.com; Received-SPF: Pass (protection.outlook.com: domain of nvidia.com designates 216.228.117.161 as permitted sender) receiver=protection.outlook.com; client-ip=216.228.117.161; helo=mail.nvidia.com; pr=C Received: from mail.nvidia.com (216.228.117.161) by CY4PEPF0000EE30.mail.protection.outlook.com (10.167.242.36) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6933.15 via Frontend Transport; Sun, 22 Oct 2023 14:31:08 +0000 Received: from rnnvmail201.nvidia.com (10.129.68.8) by mail.nvidia.com (10.129.200.67) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.986.41; Sun, 22 Oct 2023 07:31:01 -0700 Received: from nvidia.com (10.126.230.35) by rnnvmail201.nvidia.com (10.129.68.8) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.986.41; Sun, 22 Oct 2023 07:30:59 -0700 From: Xueming Li To: David Marchand CC: Qi Zhang , dpdk stable Subject: patch 'net/iavf: fix TSO with big segments' has been queued to stable release 22.11.4 Date: Sun, 22 Oct 2023 22:22:02 +0800 Message-ID: <20231022142250.10324-94-xuemingl@nvidia.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20231022142250.10324-1-xuemingl@nvidia.com> References: <20231022142250.10324-1-xuemingl@nvidia.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Type: text/plain X-Originating-IP: [10.126.230.35] X-ClientProxiedBy: rnnvmail201.nvidia.com (10.129.68.8) To rnnvmail201.nvidia.com (10.129.68.8) X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: CY4PEPF0000EE30:EE_|IA1PR12MB7685:EE_ X-MS-Office365-Filtering-Correlation-Id: 24f4c8bd-b5ba-45a1-62b4-08dbd30b8858 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: TvG0vmDL46xJmCZ0oaZG7OecIASDC0TKOKIv5vmTe0vSlAZHf9GDEYCXDHXBfyUZclFZhJlM09fHB+EIRQqSoHMB2JdmPMphC1X8Bam09E2qCn95+Q143yriD0b9zLckRdzgcZnby7gC+lno41nmZTuRaw86L1wvILl9GhKw7ePyUvMR1skynNRGb2dzyK+RiuowTi7JNzscYzdlyEEx/Hi/PrrgxbLTJUH8ngpmwUdOkFqHkyPxEcwN5dCUpgdA3xlxfNW2hUDxqqcTWyfFKi7IZ5zhNhYoaaXMZCD9DcuvehfYy7cdikQmVvAfgQidlqqIg9yr8QvZbXlk3PDs4YjdLqlVhTlJ3cDswlaop1cesiVxf+FbJmmGhEIUw7tmvJll9dNveOUZvRK0v7oLzY8SyWlI4IEPIs/hPzxSZ9hHrSpYJr3J5Ve1xIjP5Y/MQBRyFHI9LIc+2+GWstpx1kwzzBSmM3pedFyCO0MEDyHQfFusv0fTDWNVEEJFt31iy9s6j6j7IolltoswYlykEo+3aF7auUwVlQVLoOcxT8uMCavYJ3zkXztbcTE51gvSTL3TuVHQeXBf8LQjyd99yYCSxEunriS+cazgYjlOy2VbctdzkSLS885Zu5g9M2hi/9nIgYQ5wLLfLvgtznzLHtsKNe6sSTxQR+1oPafvZavkGFDcqR2czfG45CdsFXi49GXHD7Ird0RUif2mt7bRCQ1HwrOfvtpaZgXQPnFHZm7xSdqPOVEBZLYqxp9emeCZGVbAvMkiI77342n6feCFoB0TM7Cgcy/ugkYg9mHvCc0= X-Forefront-Antispam-Report: CIP:216.228.117.161; CTRY:US; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:mail.nvidia.com; PTR:dc6edge2.nvidia.com; CAT:NONE; SFS:(13230031)(4636009)(346002)(376002)(39860400002)(396003)(136003)(230922051799003)(186009)(1800799009)(64100799003)(82310400011)(451199024)(36840700001)(40470700004)(46966006)(47076005)(7696005)(6666004)(53546011)(1076003)(6286002)(16526019)(478600001)(26005)(70206006)(70586007)(356005)(54906003)(36860700001)(82740400003)(7636003)(336012)(83380400001)(966005)(426003)(6916009)(316002)(2616005)(4326008)(8936002)(8676002)(5660300002)(55016003)(40460700003)(2906002)(40480700001)(41300700001)(36756003)(4001150100001)(86362001); DIR:OUT; SFP:1101; X-OriginatorOrg: Nvidia.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 22 Oct 2023 14:31:08.7089 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 24f4c8bd-b5ba-45a1-62b4-08dbd30b8858 X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=43083d15-7273-40c1-b7db-39efd9ccc17a; Ip=[216.228.117.161]; Helo=[mail.nvidia.com] X-MS-Exchange-CrossTenant-AuthSource: CY4PEPF0000EE30.namprd05.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: IA1PR12MB7685 X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org Hi, FYI, your patch has been queued to stable release 22.11.4 Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet. It will be pushed if I get no objections before 11/15/23. So please shout if anyone has objections. Also note that after the patch there's a diff of the upstream commit vs the patch applied to the branch. This will indicate if there was any rebasing needed to apply to the stable branch. If there were code changes for rebasing (ie: not only metadata diffs), please double check that the rebase was correctly done. Queued patches are on a temporary branch at: https://git.dpdk.org/dpdk-stable/log/?h=22.11-staging This queued commit can be viewed at: https://git.dpdk.org/dpdk-stable/commit/?h=22.11-staging&id=50e27677ba28f46145692b2c180c138e677d1aa2 Thanks. Xueming Li --- >From 50e27677ba28f46145692b2c180c138e677d1aa2 Mon Sep 17 00:00:00 2001 From: David Marchand Date: Wed, 27 Sep 2023 11:41:46 +0200 Subject: [PATCH] net/iavf: fix TSO with big segments Cc: Xueming Li [ upstream commit 8a1a5327ba71a19d8a6e1b9ceb5563b4af2c2029 ] Packets to be segmented with TSO are usually larger than MTU. Plus, a single segment for the whole packet may be used: in OVS case, an external rte_malloc'd buffer is used for packets received from vhost-user ports. Before this fix, TSO packets were dropped by net/iavf with the following message: 2023-09-18T14:08:52.739Z|00610|dpdk(pmd-c31/id:11)|ERR|iavf_prep_pkts(): INVALID mbuf: bad data_len=[2962] Remove the check on data_len. Fixes: 19ee91c6bd9a ("net/iavf: check illegal packet sizes") Signed-off-by: David Marchand Acked-by: Qi Zhang --- drivers/net/iavf/iavf_rxtx.c | 5 +---- 1 file changed, 1 insertion(+), 4 deletions(-) diff --git a/drivers/net/iavf/iavf_rxtx.c b/drivers/net/iavf/iavf_rxtx.c index 77c37423dd..b6bc904228 100644 --- a/drivers/net/iavf/iavf_rxtx.c +++ b/drivers/net/iavf/iavf_rxtx.c @@ -2975,7 +2975,6 @@ iavf_prep_pkts(__rte_unused void *tx_queue, struct rte_mbuf **tx_pkts, struct rte_mbuf *m; struct iavf_tx_queue *txq = tx_queue; struct rte_eth_dev *dev = &rte_eth_devices[txq->port_id]; - uint16_t max_frame_size = dev->data->mtu + IAVF_ETH_OVERHEAD; struct iavf_info *vf = IAVF_DEV_PRIVATE_TO_VF(dev->data->dev_private); struct iavf_adapter *adapter = IAVF_DEV_PRIVATE_TO_ADAPTER(dev->data->dev_private); @@ -3004,9 +3003,7 @@ iavf_prep_pkts(__rte_unused void *tx_queue, struct rte_mbuf **tx_pkts, return i; } - /* check the data_len in mbuf */ - if (m->data_len < IAVF_TX_MIN_PKT_LEN || - m->data_len > max_frame_size) { + if (m->pkt_len < IAVF_TX_MIN_PKT_LEN) { rte_errno = EINVAL; return i; } -- 2.25.1 --- Diff of the applied patch vs upstream commit (please double-check if non-empty: --- --- - 2023-10-22 22:17:37.778043300 +0800 +++ 0093-net-iavf-fix-TSO-with-big-segments.patch 2023-10-22 22:17:34.356723700 +0800 @@ -1 +1 @@ -From 8a1a5327ba71a19d8a6e1b9ceb5563b4af2c2029 Mon Sep 17 00:00:00 2001 +From 50e27677ba28f46145692b2c180c138e677d1aa2 Mon Sep 17 00:00:00 2001 @@ -4,0 +5,3 @@ +Cc: Xueming Li + +[ upstream commit 8a1a5327ba71a19d8a6e1b9ceb5563b4af2c2029 ] @@ -19 +21,0 @@ -Cc: stable@dpdk.org @@ -28 +30 @@ -index 21a06b8351..c6ef6af1d8 100644 +index 77c37423dd..b6bc904228 100644 @@ -31 +33 @@ -@@ -3636,7 +3636,6 @@ iavf_prep_pkts(__rte_unused void *tx_queue, struct rte_mbuf **tx_pkts, +@@ -2975,7 +2975,6 @@ iavf_prep_pkts(__rte_unused void *tx_queue, struct rte_mbuf **tx_pkts, @@ -39 +41 @@ -@@ -3665,9 +3664,7 @@ iavf_prep_pkts(__rte_unused void *tx_queue, struct rte_mbuf **tx_pkts, +@@ -3004,9 +3003,7 @@ iavf_prep_pkts(__rte_unused void *tx_queue, struct rte_mbuf **tx_pkts,