From: Stephen Hemminger <stephen@networkplumber.org>
To: "Morten Brørup" <mb@smartsharesystems.com>
Cc: "Thomas Monjalon" <thomas@monjalon.net>, <dev@dpdk.org>,
"David Marchand" <david.marchand@redhat.com>, <stable@dpdk.org>,
"Anatoly Burakov" <anatoly.burakov@intel.com>,
"Narcisa Vasile" <navasile@linux.microsoft.com>,
"Tyler Retzlaff" <roretzla@linux.microsoft.com>,
"Dmitry Kozlyuk" <dmitry.kozliuk@gmail.com>,
"Konstantin Ananyev" <konstantin.v.ananyev@yandex.ru>,
"Andrew Rybchenko" <andrew.rybchenko@oktetlabs.ru>
Subject: Re: [PATCH] eal/unix: allow creating thread with real-time priority
Date: Tue, 24 Oct 2023 09:04:50 -0700 [thread overview]
Message-ID: <20231024090450.519ac82b@hermes.local> (raw)
In-Reply-To: <98CBD80474FA8B44BF855DF32C47DC35E9EF75@smartserver.smartshare.dk>
On Tue, 24 Oct 2023 15:55:13 +0200
Morten Brørup <mb@smartsharesystems.com> wrote:
> >
> > 4. It MAY be used by preemptible multi-producer and/or preemptible multi-
> > consumer pthreads whose scheduling policy are all SCHED_OTHER(cfs), SCHED_IDLE
> > or SCHED_BATCH. User SHOULD be aware of the performance penalty before using
> > it.
> >
> > - 5. It MUST not be used by multi-producer/consumer pthreads, whose
> > scheduling policies are SCHED_FIFO or SCHED_RR.
> > + 5. It MUST not be used by multi-producer/consumer pthreads
> > + whose scheduling policies are ``SCHED_FIFO``
> > + or ``SCHED_RR`` (``RTE_THREAD_PRIORITY_REALTIME_CRITICAL``).
>
> Do the RTS or HTS ring modes make any difference here?
>
> Anyway, I agree that real-time priority should not be forbidden on Unix.
>
> Acked-by: Morten Brørup <mb@smartsharesystems.com>
Please add a big warning message in the rte_thread.c and the documentation
to describe the problem. Need to have the "you have been warned" action.
Use of RT priority is incompatible with 100% poll mode as is typically done
in DPDK applications. A real time thread has higher priority than other necessary
kernel threads on the same CPU. Therefore if the RT thread never sleeps, critical
system actions such as delayed writes, network packet processing and timer updates
will not happen which makes the system unstable.
Multiple DPDK users have learned this the hard way.
next prev parent reply other threads:[~2023-10-24 16:04 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-10-24 12:54 Thomas Monjalon
2023-10-24 13:55 ` Morten Brørup
2023-10-24 16:04 ` Stephen Hemminger [this message]
2023-10-25 13:15 ` Thomas Monjalon
2023-10-25 13:34 ` Bruce Richardson
2023-10-25 13:44 ` Thomas Monjalon
2023-10-25 15:08 ` Stephen Hemminger
2023-10-25 15:14 ` Bruce Richardson
2023-10-25 15:18 ` Thomas Monjalon
2023-10-25 15:32 ` Thomas Monjalon
2023-10-25 15:13 ` [PATCH v2] " Thomas Monjalon
2023-10-25 15:37 ` Stephen Hemminger
2023-10-25 16:46 ` Thomas Monjalon
2023-10-25 17:54 ` Morten Brørup
2023-10-25 21:33 ` Stephen Hemminger
2023-10-26 7:33 ` Morten Brørup
2023-10-26 16:32 ` Stephen Hemminger
2023-10-26 17:07 ` Morten Brørup
2023-10-26 0:00 ` Stephen Hemminger
[not found] ` <20231025163352.1076755-1-thomas@monjalon.net>
2023-10-25 16:31 ` [PATCH v3 2/2] " Thomas Monjalon
[not found] ` <20231026134313.1165954-1-thomas@monjalon.net>
2023-10-26 13:37 ` [PATCH v4 " Thomas Monjalon
[not found] ` <20231026142749.1174372-1-thomas@monjalon.net>
2023-10-26 14:19 ` [PATCH v5 " Thomas Monjalon
2023-10-27 8:08 ` [PATCH v6 1/1] " Thomas Monjalon
2023-10-27 8:45 ` Morten Brørup
2023-10-27 9:11 ` Thomas Monjalon
2023-10-27 18:15 ` Stephen Hemminger
2024-10-07 19:27 ` Stephen Hemminger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20231024090450.519ac82b@hermes.local \
--to=stephen@networkplumber.org \
--cc=anatoly.burakov@intel.com \
--cc=andrew.rybchenko@oktetlabs.ru \
--cc=david.marchand@redhat.com \
--cc=dev@dpdk.org \
--cc=dmitry.kozliuk@gmail.com \
--cc=konstantin.v.ananyev@yandex.ru \
--cc=mb@smartsharesystems.com \
--cc=navasile@linux.microsoft.com \
--cc=roretzla@linux.microsoft.com \
--cc=stable@dpdk.org \
--cc=thomas@monjalon.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).