From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id E95E9431A9 for ; Tue, 24 Oct 2023 14:54:58 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id E29D2406A2; Tue, 24 Oct 2023 14:54:58 +0200 (CEST) Received: from wout2-smtp.messagingengine.com (wout2-smtp.messagingengine.com [64.147.123.25]) by mails.dpdk.org (Postfix) with ESMTP id 8C85A402E3; Tue, 24 Oct 2023 14:54:57 +0200 (CEST) Received: from compute2.internal (compute2.nyi.internal [10.202.2.46]) by mailout.west.internal (Postfix) with ESMTP id 9BEA032009EF; Tue, 24 Oct 2023 08:54:53 -0400 (EDT) Received: from mailfrontend1 ([10.202.2.162]) by compute2.internal (MEProxy); Tue, 24 Oct 2023 08:54:54 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= cc:cc:content-transfer-encoding:content-type:date:date:from:from :in-reply-to:message-id:mime-version:reply-to:sender:subject :subject:to:to; s=fm3; t=1698152093; x=1698238493; bh=1o/j8r2J9M bjm/w1LM/A9jSu4DXnZDRfmwwgOC+2q1M=; b=RknSK67lpg40/L51RN54rU8kCL ZB+QPlpRkjskaIy4Wq1yhaGpGBZ1mcfz9yLPdqno3IdOnEp2+dfcS4i1ZjAWDMs6 MvYFhepx7d5+Qd3znEO//mshsPFbO0fcLM/Wso+6iM4ed1MnCubQcPXDQdGriRRd b1BaS8DeeyWDvRdw25TfuLhz3+IeQO5Md3+9jSTp/ymPU3VIniT9t/lEtfWUOZoT 3hlUk10o/6wQDh2OBrtr1rv56ZAhMIDNgXBOzl84aOiKDacvZvyGBP9Z+ceFRqRw 2IMIE+gP14dKDNwAg76GdNxFNcdA1O3wiFuXPdPge3BHkSryLWEK1seq3BDg== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-transfer-encoding :content-type:date:date:feedback-id:feedback-id:from:from :in-reply-to:message-id:mime-version:reply-to:sender:subject :subject:to:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm3; t=1698152093; x=1698238493; bh=1o/j8r2J9Mbjm /w1LM/A9jSu4DXnZDRfmwwgOC+2q1M=; b=VJuPxLQLWXNLLLwwVqeNWvqSWp3u0 4jsvMoephWajTSFW/ZXVp/Il4+Y1r8k3Bi3gzCkaqoKJWSyBLj+ZLdlOgL2PFDV9 zM4pE6TQYi1fwMa8m92jJPb7Fe+Y3W11bNG55oYP8AV+WNg3SIs2fSsWeQQUQ7dq TMyV6WBiegd7ydB4JyeHKnQUqOE8N5NxPkUBX6YQZ4stdfDgkTSQTRXpXIUApVmy JFrEusFVFFW4oghXYIhMdX09XaTU8ym2HHGQ7YV6szjF+lwfwa4ACsBQh+Rj4Z2P 9nEDLbNj4L8H7BIqKxv0WrEGFEQOe/1d4HHnz8LgFTYiWATIhYscREnEQ== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvkedrkeekgdehiecutefuodetggdotefrodftvf curfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfghnecu uegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenuc fjughrpefhvfevufffkffoggfgsedtkeertdertddtnecuhfhrohhmpefvhhhomhgrshcu ofhonhhjrghlohhnuceothhhohhmrghssehmohhnjhgrlhhonhdrnhgvtheqnecuggftrf grthhtvghrnhepveevfeevieeihfetudekgeekleeigeffueekveduteeuffeiudevteei udekfeelnecuvehluhhsthgvrhfuihiivgeptdenucfrrghrrghmpehmrghilhhfrhhomh epthhhohhmrghssehmohhnjhgrlhhonhdrnhgvth X-ME-Proxy: Feedback-ID: i47234305:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Tue, 24 Oct 2023 08:54:50 -0400 (EDT) From: Thomas Monjalon To: dev@dpdk.org Cc: David Marchand , stable@dpdk.org, Anatoly Burakov , Stephen Hemminger , Narcisa Vasile , Tyler Retzlaff , Dmitry Kozlyuk , Konstantin Ananyev , Andrew Rybchenko , =?UTF-8?q?Morten=20Br=C3=B8rup?= Subject: [PATCH] eal/unix: allow creating thread with real-time priority Date: Tue, 24 Oct 2023 14:54:16 +0200 Message-ID: <20231024125416.798897-1-thomas@monjalon.net> X-Mailer: git-send-email 2.42.0 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org When adding an API for creating threads, the real-time priority has been forbidden on Unix. There is a known issue with ring behaviour, but it should not be completely forbidden. Fixes: ca04c78b6262 ("eal: get/set thread priority per thread identifier") Fixes: ce6e911d20f6 ("eal: add thread lifetime API") Fixes: a7ba40b2b1bf ("drivers: convert to internal control threads") Cc: stable@dpdk.org Signed-off-by: Thomas Monjalon --- app/test/test_threads.c | 9 --------- doc/guides/prog_guide/env_abstraction_layer.rst | 4 +++- lib/eal/include/rte_thread.h | 2 +- lib/eal/unix/rte_thread.c | 9 --------- 4 files changed, 4 insertions(+), 20 deletions(-) diff --git a/app/test/test_threads.c b/app/test/test_threads.c index 4ac3f2671a..4f7d10e074 100644 --- a/app/test/test_threads.c +++ b/app/test/test_threads.c @@ -97,21 +97,12 @@ test_thread_priority(void) "Priority set mismatches priority get"); priority = RTE_THREAD_PRIORITY_REALTIME_CRITICAL; -#ifndef RTE_EXEC_ENV_WINDOWS - RTE_TEST_ASSERT(rte_thread_set_priority(thread_id, priority) == ENOTSUP, - "Priority set to critical should fail"); - RTE_TEST_ASSERT(rte_thread_get_priority(thread_id, &priority) == 0, - "Failed to get thread priority"); - RTE_TEST_ASSERT(priority == RTE_THREAD_PRIORITY_NORMAL, - "Failed set to critical should have retained normal"); -#else RTE_TEST_ASSERT(rte_thread_set_priority(thread_id, priority) == 0, "Priority set to critical should succeed"); RTE_TEST_ASSERT(rte_thread_get_priority(thread_id, &priority) == 0, "Failed to get thread priority"); RTE_TEST_ASSERT(priority == RTE_THREAD_PRIORITY_REALTIME_CRITICAL, "Priority set mismatches priority get"); -#endif priority = RTE_THREAD_PRIORITY_NORMAL; RTE_TEST_ASSERT(rte_thread_set_priority(thread_id, priority) == 0, diff --git a/doc/guides/prog_guide/env_abstraction_layer.rst b/doc/guides/prog_guide/env_abstraction_layer.rst index 6debf54efb..d1f7cae7cd 100644 --- a/doc/guides/prog_guide/env_abstraction_layer.rst +++ b/doc/guides/prog_guide/env_abstraction_layer.rst @@ -815,7 +815,9 @@ Known Issues 4. It MAY be used by preemptible multi-producer and/or preemptible multi-consumer pthreads whose scheduling policy are all SCHED_OTHER(cfs), SCHED_IDLE or SCHED_BATCH. User SHOULD be aware of the performance penalty before using it. - 5. It MUST not be used by multi-producer/consumer pthreads, whose scheduling policies are SCHED_FIFO or SCHED_RR. + 5. It MUST not be used by multi-producer/consumer pthreads + whose scheduling policies are ``SCHED_FIFO`` + or ``SCHED_RR`` (``RTE_THREAD_PRIORITY_REALTIME_CRITICAL``). Alternatively, applications can use the lock-free stack mempool handler. When considering this handler, note that: diff --git a/lib/eal/include/rte_thread.h b/lib/eal/include/rte_thread.h index 8da9d4d3fb..5e624015e4 100644 --- a/lib/eal/include/rte_thread.h +++ b/lib/eal/include/rte_thread.h @@ -59,7 +59,7 @@ enum rte_thread_priority { RTE_THREAD_PRIORITY_NORMAL = 0, /**< normal thread priority, the default */ RTE_THREAD_PRIORITY_REALTIME_CRITICAL = 1, - /**< highest thread priority allowed */ + /**< highest thread priority, use with caution */ }; /** diff --git a/lib/eal/unix/rte_thread.c b/lib/eal/unix/rte_thread.c index 36a21ab2f9..0ff291c6f1 100644 --- a/lib/eal/unix/rte_thread.c +++ b/lib/eal/unix/rte_thread.c @@ -153,11 +153,6 @@ rte_thread_create(rte_thread_t *thread_id, goto cleanup; } - if (thread_attr->priority == - RTE_THREAD_PRIORITY_REALTIME_CRITICAL) { - ret = ENOTSUP; - goto cleanup; - } ret = thread_map_priority_to_os_value(thread_attr->priority, ¶m.sched_priority, &policy); if (ret != 0) @@ -275,10 +270,6 @@ rte_thread_set_priority(rte_thread_t thread_id, int policy; int ret; - /* Realtime priority can cause crashes on non-Windows platforms. */ - if (priority == RTE_THREAD_PRIORITY_REALTIME_CRITICAL) - return ENOTSUP; - ret = thread_map_priority_to_os_value(priority, ¶m.sched_priority, &policy); if (ret != 0) -- 2.42.0