From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id CCC814326F for ; Thu, 2 Nov 2023 14:15:21 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 3963D42D9A; Thu, 2 Nov 2023 14:15:21 +0100 (CET) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by mails.dpdk.org (Postfix) with ESMTP id 35C4E40A76 for ; Thu, 2 Nov 2023 14:15:20 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1698930919; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=8LMzvoTRKHFcYnnUmdkC5hj/9QGshdRd1OorZ+W2lKE=; b=UMZ+G+a4F0Az8gFPpwjao6SDUSyQMQqWlQ40Gp6JfxXt/aNuiFiU1V237sGRYb6IfrQpAW 2GMMQTQuaLulNMONyeBYep0iw42CS1tsbZ5yrwjfB25XvQd4t5pVjT/0oEO/a6Sj1IuB+e Eygbo8XzAT6nR29u3mC//COYzXFmDQQ= Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-590-DMh9kDJ-Pm24IjJ1OHu2-g-1; Thu, 02 Nov 2023 09:15:16 -0400 X-MC-Unique: DMh9kDJ-Pm24IjJ1OHu2-g-1 Received: from smtp.corp.redhat.com (int-mx10.intmail.prod.int.rdu2.redhat.com [10.11.54.10]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 5BB2B88CDC8; Thu, 2 Nov 2023 13:15:16 +0000 (UTC) Received: from rh.redhat.com (unknown [10.39.192.45]) by smtp.corp.redhat.com (Postfix) with ESMTP id 85530492BFA; Thu, 2 Nov 2023 13:15:15 +0000 (UTC) From: Kevin Traynor To: David Marchand Cc: Chengwen Feng , Ferruh Yigit , dpdk stable Subject: patch 'net/bonding: fix link status callback stop' has been queued to stable release 21.11.6 Date: Thu, 2 Nov 2023 13:12:48 +0000 Message-ID: <20231102131254.315947-102-ktraynor@redhat.com> In-Reply-To: <20231102131254.315947-1-ktraynor@redhat.com> References: <20231102131254.315947-1-ktraynor@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 3.4.1 on 10.11.54.10 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: 8bit Content-Type: text/plain; charset="US-ASCII"; x-default=true X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org Hi, FYI, your patch has been queued to stable release 21.11.6 Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet. It will be pushed if I get no objections before 11/08/23. So please shout if anyone has objections. Also note that after the patch there's a diff of the upstream commit vs the patch applied to the branch. This will indicate if there was any rebasing needed to apply to the stable branch. If there were code changes for rebasing (ie: not only metadata diffs), please double check that the rebase was correctly done. Queued patches are on a temporary branch at: https://github.com/kevintraynor/dpdk-stable This queued commit can be viewed at: https://github.com/kevintraynor/dpdk-stable/commit/6b396dceec44c55e02173c5d4e4ed087ec883dc2 Thanks. Kevin --- >From 6b396dceec44c55e02173c5d4e4ed087ec883dc2 Mon Sep 17 00:00:00 2001 From: David Marchand Date: Mon, 16 Oct 2023 10:47:43 +0200 Subject: [PATCH] net/bonding: fix link status callback stop [ upstream commit 615bd385b93e89e062b4e134e9cc09a79289a0f6 ] If a bonding port gets released, a link status alarm callback still referenced the ethdev port that may be reused later. Cancel this callback when stopping the port. Bugzilla ID: 1301 Fixes: a45b288ef21a ("bond: support link status polling") Signed-off-by: David Marchand Acked-by: Chengwen Feng Acked-by: Ferruh Yigit --- drivers/net/bonding/rte_eth_bond_pmd.c | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/drivers/net/bonding/rte_eth_bond_pmd.c b/drivers/net/bonding/rte_eth_bond_pmd.c index d9fcd21d9f..7d957133e3 100644 --- a/drivers/net/bonding/rte_eth_bond_pmd.c +++ b/drivers/net/bonding/rte_eth_bond_pmd.c @@ -2135,4 +2135,8 @@ bond_ethdev_stop(struct rte_eth_dev *eth_dev) eth_dev->data->dev_started = 0; + if (internals->link_status_polling_enabled) { + rte_eal_alarm_cancel(bond_ethdev_slave_link_status_change_monitor, + (void *)&rte_eth_devices[internals->port_id]); + } internals->link_status_polling_enabled = 0; for (i = 0; i < internals->slave_count; i++) { -- 2.41.0 --- Diff of the applied patch vs upstream commit (please double-check if non-empty: --- --- - 2023-11-02 13:09:43.232413589 +0000 +++ 0102-net-bonding-fix-link-status-callback-stop.patch 2023-11-02 13:09:40.925163695 +0000 @@ -1 +1 @@ -From 615bd385b93e89e062b4e134e9cc09a79289a0f6 Mon Sep 17 00:00:00 2001 +From 6b396dceec44c55e02173c5d4e4ed087ec883dc2 Mon Sep 17 00:00:00 2001 @@ -5,0 +6,2 @@ +[ upstream commit 615bd385b93e89e062b4e134e9cc09a79289a0f6 ] + @@ -12 +13,0 @@ -Cc: stable@dpdk.org @@ -22 +23 @@ -index aa7c911f19..c40d18d128 100644 +index d9fcd21d9f..7d957133e3 100644 @@ -25 +26 @@ -@@ -2165,4 +2165,8 @@ bond_ethdev_stop(struct rte_eth_dev *eth_dev) +@@ -2135,4 +2135,8 @@ bond_ethdev_stop(struct rte_eth_dev *eth_dev) @@ -29 +30 @@ -+ rte_eal_alarm_cancel(bond_ethdev_member_link_status_change_monitor, ++ rte_eal_alarm_cancel(bond_ethdev_slave_link_status_change_monitor, @@ -33 +34 @@ - for (i = 0; i < internals->member_count; i++) { + for (i = 0; i < internals->slave_count; i++) {