From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 043A34326F for ; Thu, 2 Nov 2023 14:13:34 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id EF4D442D0B; Thu, 2 Nov 2023 14:13:33 +0100 (CET) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by mails.dpdk.org (Postfix) with ESMTP id 0B35840A76 for ; Thu, 2 Nov 2023 14:13:32 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1698930812; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=3mWsXgDtuw8KVimkf8nCLvvjrxYYsIdGIS043x55GEU=; b=Vve5NEO1m/0679KVUUBH8nYt+/TUA1b9N/mWdMo3E1mZ8Az6rzsJEFK/1MmBFzATYmAVmF b3RdIIXXdL/lskiwa4dQtGlViZCc/Nte4Z2/gu7/ma2hjVFDdJ7vxXT7dw6pwVncgBff+j BS09pMfjnFpN1/m/GUO/SKOqRz8fUjk= Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-602-Bqy9Pb0TPa-ovvaRqOL1ew-1; Thu, 02 Nov 2023 09:13:31 -0400 X-MC-Unique: Bqy9Pb0TPa-ovvaRqOL1ew-1 Received: from smtp.corp.redhat.com (int-mx10.intmail.prod.int.rdu2.redhat.com [10.11.54.10]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id D73EB85A5B5; Thu, 2 Nov 2023 13:13:30 +0000 (UTC) Received: from rh.redhat.com (unknown [10.39.192.45]) by smtp.corp.redhat.com (Postfix) with ESMTP id A4783492BFA; Thu, 2 Nov 2023 13:13:29 +0000 (UTC) From: Kevin Traynor To: Stephen Hemminger Cc: =?UTF-8?q?Morten=20Br=C3=B8rup?= , =?UTF-8?q?Mattias=20R=C3=B6nnblom?= , dpdk stable Subject: patch 'random: initialize state for unregistered non-EAL threads' has been queued to stable release 21.11.6 Date: Thu, 2 Nov 2023 13:11:18 +0000 Message-ID: <20231102131254.315947-12-ktraynor@redhat.com> In-Reply-To: <20231102131254.315947-1-ktraynor@redhat.com> References: <20231102131254.315947-1-ktraynor@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 3.4.1 on 10.11.54.10 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org Hi, FYI, your patch has been queued to stable release 21.11.6 Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet. It will be pushed if I get no objections before 11/08/23. So please shout if anyone has objections. Also note that after the patch there's a diff of the upstream commit vs the patch applied to the branch. This will indicate if there was any rebasing needed to apply to the stable branch. If there were code changes for rebasing (ie: not only metadata diffs), please double check that the rebase was correctly done. Queued patches are on a temporary branch at: https://github.com/kevintraynor/dpdk-stable This queued commit can be viewed at: https://github.com/kevintraynor/dpdk-stable/commit/81b71fcdab51c54c9f5cbaa2d99f8696c4c9a728 Thanks. Kevin --- >From 81b71fcdab51c54c9f5cbaa2d99f8696c4c9a728 Mon Sep 17 00:00:00 2001 From: Stephen Hemminger Date: Thu, 7 Sep 2023 08:24:55 -0700 Subject: [PATCH] random: initialize state for unregistered non-EAL threads MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit [ upstream commit 3a4e21301c7a8bf709ff9e74d05628f87450a11e ] The per-lcore PRNG was not initializing the rand_state of all the lcores. Any usage of rte_random by an unregistered non-EAL thread would use rand_states[RTE_MAX_LCORE] which was never initialized. Fix by using RTE_DIM() which will get all lcores. Fixes: 3f002f069612 ("eal: replace libc-based random generation with LFSR") Signed-off-by: Stephen Hemminger Reviewed-by: Morten Brørup Acked-by: Mattias Rönnblom --- lib/eal/common/rte_random.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/lib/eal/common/rte_random.c b/lib/eal/common/rte_random.c index ce21c2242a..ac5876dd1f 100644 --- a/lib/eal/common/rte_random.c +++ b/lib/eal/common/rte_random.c @@ -83,5 +83,5 @@ rte_srand(uint64_t seed) /* add lcore_id to seed to avoid having the same sequence */ - for (lcore_id = 0; lcore_id < RTE_MAX_LCORE; lcore_id++) + for (lcore_id = 0; lcore_id < RTE_DIM(rand_states); lcore_id++) __rte_srand_lfsr258(seed + lcore_id, &rand_states[lcore_id]); } -- 2.41.0 --- Diff of the applied patch vs upstream commit (please double-check if non-empty: --- --- - 2023-11-02 13:09:41.187154927 +0000 +++ 0012-random-initialize-state-for-unregistered-non-EAL-thr.patch 2023-11-02 13:09:40.781163233 +0000 @@ -1 +1 @@ -From 3a4e21301c7a8bf709ff9e74d05628f87450a11e Mon Sep 17 00:00:00 2001 +From 81b71fcdab51c54c9f5cbaa2d99f8696c4c9a728 Mon Sep 17 00:00:00 2001 @@ -8,0 +9,2 @@ +[ upstream commit 3a4e21301c7a8bf709ff9e74d05628f87450a11e ] + @@ -16 +17,0 @@ -Cc: stable@dpdk.org @@ -26 +27 @@ -index 53636331a2..812e5b4757 100644 +index ce21c2242a..ac5876dd1f 100644 @@ -29 +30 @@ -@@ -85,5 +85,5 @@ rte_srand(uint64_t seed) +@@ -83,5 +83,5 @@ rte_srand(uint64_t seed)