From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id E01104326F for ; Thu, 2 Nov 2023 14:13:48 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id DA37742D9A; Thu, 2 Nov 2023 14:13:48 +0100 (CET) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by mails.dpdk.org (Postfix) with ESMTP id 2D61040A76 for ; Thu, 2 Nov 2023 14:13:46 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1698930825; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=dkUDC1BmBgEVwLpMr9fYZkOVoH+M1NncWHZsudTB7yg=; b=TGmZK1ejDMIwsjeSR/QK0p9w3SuCAecPBdxmioBvVp5/Ej/w/prijksFILFejcGMJ9DJCx ZGPtV2O5qVvm54JhDqf5pJSq9FAyOYGjMv8I5eao4EqxlAIubqHgw3iWS3LJkh8XGYDK1H a2Gy2FZcdXcbuUgXVvl4rT7bVSmByuY= Received: from mimecast-mx02.redhat.com (mx-ext.redhat.com [66.187.233.73]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-372--vN2_yvSMUyJisFARGgJ-Q-1; Thu, 02 Nov 2023 09:13:43 -0400 X-MC-Unique: -vN2_yvSMUyJisFARGgJ-Q-1 Received: from smtp.corp.redhat.com (int-mx10.intmail.prod.int.rdu2.redhat.com [10.11.54.10]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 4252C3816D82; Thu, 2 Nov 2023 13:13:43 +0000 (UTC) Received: from rh.redhat.com (unknown [10.39.192.45]) by smtp.corp.redhat.com (Postfix) with ESMTP id 89152492BFA; Thu, 2 Nov 2023 13:13:42 +0000 (UTC) From: Kevin Traynor To: Jiawen Wu Cc: dpdk stable Subject: patch 'net/txgbe: check process type in close operation' has been queued to stable release 21.11.6 Date: Thu, 2 Nov 2023 13:11:29 +0000 Message-ID: <20231102131254.315947-23-ktraynor@redhat.com> In-Reply-To: <20231102131254.315947-1-ktraynor@redhat.com> References: <20231102131254.315947-1-ktraynor@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 3.4.1 on 10.11.54.10 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: 8bit Content-Type: text/plain; charset="US-ASCII"; x-default=true X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org Hi, FYI, your patch has been queued to stable release 21.11.6 Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet. It will be pushed if I get no objections before 11/08/23. So please shout if anyone has objections. Also note that after the patch there's a diff of the upstream commit vs the patch applied to the branch. This will indicate if there was any rebasing needed to apply to the stable branch. If there were code changes for rebasing (ie: not only metadata diffs), please double check that the rebase was correctly done. Queued patches are on a temporary branch at: https://github.com/kevintraynor/dpdk-stable This queued commit can be viewed at: https://github.com/kevintraynor/dpdk-stable/commit/4a97dac6687dd2dfba201a9a0b25a260bed8eb2a Thanks. Kevin --- >From 4a97dac6687dd2dfba201a9a0b25a260bed8eb2a Mon Sep 17 00:00:00 2001 From: Jiawen Wu Date: Thu, 28 Sep 2023 17:47:56 +0800 Subject: [PATCH] net/txgbe: check process type in close operation [ upstream commit 21ed282505ed8f60f03a93a27ac01f4152b8ab40 ] The secondary processes are not allowed to release shared resources. Only process-private resources should be freed in a secondary process. Most of the time, there is no process-private resource, so the close operation is just forbidden in a secondary process. Fixes: e1698e383c2a ("net/txgbe: add device init and uninit") Signed-off-by: Jiawen Wu --- drivers/net/txgbe/txgbe_ethdev.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/drivers/net/txgbe/txgbe_ethdev.c b/drivers/net/txgbe/txgbe_ethdev.c index 2a3d9d9d5e..bd587b4f71 100644 --- a/drivers/net/txgbe/txgbe_ethdev.c +++ b/drivers/net/txgbe/txgbe_ethdev.c @@ -2001,4 +2001,7 @@ txgbe_dev_close(struct rte_eth_dev *dev) PMD_INIT_FUNC_TRACE(); + if (rte_eal_process_type() != RTE_PROC_PRIMARY) + return 0; + txgbe_pf_reset_hw(hw); -- 2.41.0 --- Diff of the applied patch vs upstream commit (please double-check if non-empty: --- --- - 2023-11-02 13:09:41.441177176 +0000 +++ 0023-net-txgbe-check-process-type-in-close-operation.patch 2023-11-02 13:09:40.807163316 +0000 @@ -1 +1 @@ -From 21ed282505ed8f60f03a93a27ac01f4152b8ab40 Mon Sep 17 00:00:00 2001 +From 4a97dac6687dd2dfba201a9a0b25a260bed8eb2a Mon Sep 17 00:00:00 2001 @@ -5,0 +6,2 @@ +[ upstream commit 21ed282505ed8f60f03a93a27ac01f4152b8ab40 ] + @@ -12 +13,0 @@ -Cc: stable@dpdk.org @@ -20 +21 @@ -index 2dad820cb5..6bc231a130 100644 +index 2a3d9d9d5e..bd587b4f71 100644 @@ -23 +24 @@ -@@ -2053,4 +2053,7 @@ txgbe_dev_close(struct rte_eth_dev *dev) +@@ -2001,4 +2001,7 @@ txgbe_dev_close(struct rte_eth_dev *dev)