From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id BB7364326F for ; Thu, 2 Nov 2023 14:13:48 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id B688442D80; Thu, 2 Nov 2023 14:13:48 +0100 (CET) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by mails.dpdk.org (Postfix) with ESMTP id 24BC1402E3 for ; Thu, 2 Nov 2023 14:13:46 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1698930825; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=OFnmAEJ4P4lfvfeLj8pgyr91CMt75eVHUT5EYJBcxPc=; b=gtIZIfDkUVO8qhTpY67gZepHD8vEZl+2A+nMb4HZRbYiDFny+XbDJ8BEs0QtdX2rw2kbXm FO/qywpsCudrECoqSOj1RX5sJlZ26lEDoqocV1XeOuObSHuIz35xVDy7gOIi9ZgQ88RHP2 5LeEj+5K48lNode5Psoj8Eha/zc6qPg= Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-331-Yu-OC9foNX6I1M0UYw96Uw-1; Thu, 02 Nov 2023 09:13:44 -0400 X-MC-Unique: Yu-OC9foNX6I1M0UYw96Uw-1 Received: from smtp.corp.redhat.com (int-mx10.intmail.prod.int.rdu2.redhat.com [10.11.54.10]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 2F22382BA85; Thu, 2 Nov 2023 13:13:44 +0000 (UTC) Received: from rh.redhat.com (unknown [10.39.192.45]) by smtp.corp.redhat.com (Postfix) with ESMTP id 8935E492BFA; Thu, 2 Nov 2023 13:13:43 +0000 (UTC) From: Kevin Traynor To: Jiawen Wu Cc: dpdk stable Subject: patch 'net/ngbe: check process type in close operation' has been queued to stable release 21.11.6 Date: Thu, 2 Nov 2023 13:11:30 +0000 Message-ID: <20231102131254.315947-24-ktraynor@redhat.com> In-Reply-To: <20231102131254.315947-1-ktraynor@redhat.com> References: <20231102131254.315947-1-ktraynor@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 3.4.1 on 10.11.54.10 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: 8bit Content-Type: text/plain; charset="US-ASCII"; x-default=true X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org Hi, FYI, your patch has been queued to stable release 21.11.6 Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet. It will be pushed if I get no objections before 11/08/23. So please shout if anyone has objections. Also note that after the patch there's a diff of the upstream commit vs the patch applied to the branch. This will indicate if there was any rebasing needed to apply to the stable branch. If there were code changes for rebasing (ie: not only metadata diffs), please double check that the rebase was correctly done. Queued patches are on a temporary branch at: https://github.com/kevintraynor/dpdk-stable This queued commit can be viewed at: https://github.com/kevintraynor/dpdk-stable/commit/4cdc254d17bff073607d9d201531567020e388b6 Thanks. Kevin --- >From 4cdc254d17bff073607d9d201531567020e388b6 Mon Sep 17 00:00:00 2001 From: Jiawen Wu Date: Thu, 28 Sep 2023 17:47:57 +0800 Subject: [PATCH] net/ngbe: check process type in close operation [ upstream commit bf86fb0b7dd723421ea35826c0163c34b09d1c69 ] The secondary processes are not allowed to release shared resources. Only process-private resources should be freed in a secondary process. Most of the time, there is no process-private resource, so the close operation is just forbidden in a secondary process. Fixes: cc63194e89cb ("net/ngbe: support close and reset device") Signed-off-by: Jiawen Wu --- drivers/net/ngbe/ngbe_ethdev.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/drivers/net/ngbe/ngbe_ethdev.c b/drivers/net/ngbe/ngbe_ethdev.c index c6e37150e2..3038694042 100644 --- a/drivers/net/ngbe/ngbe_ethdev.c +++ b/drivers/net/ngbe/ngbe_ethdev.c @@ -1218,4 +1218,7 @@ ngbe_dev_close(struct rte_eth_dev *dev) PMD_INIT_FUNC_TRACE(); + if (rte_eal_process_type() != RTE_PROC_PRIMARY) + return 0; + ngbe_pf_reset_hw(hw); -- 2.41.0 --- Diff of the applied patch vs upstream commit (please double-check if non-empty: --- --- - 2023-11-02 13:09:41.465243946 +0000 +++ 0024-net-ngbe-check-process-type-in-close-operation.patch 2023-11-02 13:09:40.808163319 +0000 @@ -1 +1 @@ -From bf86fb0b7dd723421ea35826c0163c34b09d1c69 Mon Sep 17 00:00:00 2001 +From 4cdc254d17bff073607d9d201531567020e388b6 Mon Sep 17 00:00:00 2001 @@ -5,0 +6,2 @@ +[ upstream commit bf86fb0b7dd723421ea35826c0163c34b09d1c69 ] + @@ -12 +13,0 @@ -Cc: stable@dpdk.org @@ -20 +21 @@ -index 1cdd56497e..478da014b2 100644 +index c6e37150e2..3038694042 100644 @@ -23 +24 @@ -@@ -1263,4 +1263,7 @@ ngbe_dev_close(struct rte_eth_dev *dev) +@@ -1218,4 +1218,7 @@ ngbe_dev_close(struct rte_eth_dev *dev)